Commit graph

36786 commits

Author SHA1 Message Date
Matan Lurey 31600c829e
Forward-fix a test that will break with an engine roll. (#133619)
See https://github.com/flutter/engine/pull/44705 where it fails a framework smoke test.

Partial work towards https://github.com/flutter/flutter/issues/112498.
2023-08-30 22:29:05 +00:00
Taha Tesser d7a3a68275
Fix cancelButtonStyle & confirmButtonStyle properties from TimePickerTheme aren't working (#132843)
fixes [`TimePickerThemeData` action buttons styles aren't working](https://github.com/flutter/flutter/issues/132760)

### Code sample

<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        useMaterial3: true,
        timePickerTheme: TimePickerThemeData(
          cancelButtonStyle: TextButton.styleFrom(
            shape: const RoundedRectangleBorder(
              borderRadius: BorderRadius.all(Radius.circular(4)),
              side: BorderSide(color: Colors.red),
            ),
            backgroundColor: Colors.white,
            foregroundColor: Colors.red,
            elevation: 3,
            shadowColor: Colors.red,
          ),
          confirmButtonStyle: TextButton.styleFrom(
            shape: const RoundedRectangleBorder(
              borderRadius: BorderRadius.all(Radius.circular(4)),
            ),
            backgroundColor: Colors.green[700],
            foregroundColor: Colors.white,
            elevation: 3,
            shadowColor: Colors.green[700],
          ),
        ),
      ),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: TimePickerDialog(initialTime: TimeOfDay.now()),
      ),
    );
  }
}

``` 

</details>

### Before (action buttons don't use the style from the `TimePickerTheme`)

![Screenshot 2023-08-18 at 14 57 37](https://github.com/flutter/flutter/assets/48603081/c95160e2-76a2-4bb5-84e0-3731fce19c0b)

### After (action buttons use the style from the `TimePickerTheme`)

![Screenshot 2023-08-18 at 14 57 18](https://github.com/flutter/flutter/assets/48603081/422d348a-bee2-4696-8d9a-5fce56191aaa)
2023-08-30 22:21:29 +00:00
Hans Muller 336d60d29c
Updated DropdownMenu example and added a test (#133592) 2023-08-30 14:33:54 -07:00
Taha Tesser 1e770c3808
Add cancelButtonStyle & confirmButtonStyle to the DatePickerThemeData (#132847)
fixes [Unable to adjust the color for "Cancel" and "Ok" button in datePicker dialog](https://github.com/flutter/flutter/issues/127739)

### Code sample

<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        useMaterial3: true,
        datePickerTheme: DatePickerThemeData(
          cancelButtonStyle: TextButton.styleFrom(
            shape: const RoundedRectangleBorder(
              borderRadius: BorderRadius.all(Radius.circular(16)),
              side: BorderSide(color: Colors.red),
            ),
            backgroundColor: Colors.white,
            foregroundColor: Colors.red,
            elevation: 3,
            shadowColor: Colors.red,
          ),
          confirmButtonStyle: TextButton.styleFrom(
            shape: const RoundedRectangleBorder(
              borderRadius: BorderRadius.all(Radius.circular(16)),
            ),
            backgroundColor: Colors.green[700],
            foregroundColor: Colors.white,
            elevation: 3,
            shadowColor: Colors.green[700],
          ),
        ),
      ),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: DatePickerDialog(
          initialDate: DateTime.now(),
          firstDate: DateTime(2020),
          lastDate: DateTime(2030),
        ),
      ),
    );
  }
}
``` 

</details>

### Before 

Not possible to customize action buttons from the `DatePickerThemeData`.

### After 

![Screenshot 2023-08-18 at 16 42 00](https://github.com/flutter/flutter/assets/48603081/4ec01e93-c661-491d-9253-d687da8b76f3)
2023-08-30 21:16:13 +00:00
engine-flutter-autoroll 2f2a10d540
Roll Flutter Engine from 31d5662dcb53 to b63eee2e31cc (1 revision) (#133692)
31d5662dcb...b63eee2e31

2023-08-30 jason-simmons@users.noreply.github.com [Impeller] Reorganize the glyph atlas to improve efficiency when looking up runs of glyphs in the same font (flutter/engine#45191)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 21:06:25 +00:00
Renzo Olivares 4b89fce108
Fixing memory leak in EditableTextState (#131377) 2023-08-30 12:49:56 -07:00
engine-flutter-autoroll d1410a11b6
Roll Flutter Engine from 69f04bdfe952 to 31d5662dcb53 (14 revisions) (#133683)
69f04bdfe9...31d5662dcb

2023-08-30 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Y2xfuZM0ec5GQfHV8... to gWpPuUyuR_hmz9Xmg... (flutter/engine#45287)
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from 7a246c9eb086 to 185fbe1a264d (3 revisions) (flutter/engine#45289)
2023-08-30 30870216+gaaclarke@users.noreply.github.com Revert "Roll Dart SDK from 0cea73a8d3c3 to 96d3a79547fc" (flutter/engine#45285)
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from 3489b6d1d613 to 7a246c9eb086 (4 revisions) (flutter/engine#45286)
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from a58ccf8ae398 to 3489b6d1d613 (2 revisions) (flutter/engine#45283)
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from 6f4fd97d2f7e to a58ccf8ae398 (1 revision) (flutter/engine#45280)
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from a2728a7ad2a3 to 6f4fd97d2f7e (2 revisions) (flutter/engine#45278)
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from 7492e29ad235 to a2728a7ad2a3 (1 revision) (flutter/engine#45273)
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from 80f4d2f303d0 to 7492e29ad235 (1 revision) (flutter/engine#45272)
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from 03289b20b5d3 to 80f4d2f303d0 (1 revision) (flutter/engine#45270)
2023-08-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 96d3a79547fc to 4352efd8497d (1 revision) (flutter/engine#45267)
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from fde9fe141863 to 03289b20b5d3 (1 revision) (flutter/engine#45268)
2023-08-30 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from QKekosWnIY_ObKstn... to Y2xfuZM0ec5GQfHV8... (flutter/engine#45265)
2023-08-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 0cea73a8d3c3 to 96d3a79547fc (1 revision) (flutter/engine#45262)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from QKekosWnIY_O to gWpPuUyuR_hm

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 19:41:23 +00:00
Bruno Leroux b23105276f
Expose barrierDismissible in PageRoute constructor (#133659)
## Description

This PR exposes `barrierDismissible` in `PageRoute`, `MaterialPageRoute` and `CupertinoPageRoute` constructors.
Setting this property to true will enable the escape key binding.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/132138.

## Tests

Adds one test.
2023-08-30 19:02:06 +00:00
Ricardo Amador 15048a6b04
Update the infrastructure issue template (#133519)
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-08-30 18:51:04 +00:00
LongCatIsLooong 7f3abea35a
Reland "Remove ImageProvider.load, DecoderCallback and PaintingBinding.instantiateImageCodec (#132679) (reverted in #133482) (#133605)
Relanding the commit per
https://github.com/flutter/flutter/pull/133482#issuecomment-1698030976

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-08-30 11:28:10 -07:00
engine-flutter-autoroll d49eb4afac
Roll Packages from d7d3150e5966 to 64af59e00bb7 (4 revisions) (#133675)
d7d3150e59...64af59e00b

2023-08-30 katelovett@google.com [two_dimensional_scrollables] Fix repaint boundary override in builder delegate (flutter/packages#4814)
2023-08-29 stuartmorgan@google.com [all] Add topics to pubspecs (flutter/packages#4771)
2023-08-29 engine-flutter-autoroll@skia.org Roll Flutter from ec387a467a to 6c95737375 (24 revisions) (flutter/packages#4813)
2023-08-29 panuj330@gmail.com Fixed AlertDialog Height of example in image_picker (flutter/packages#4800)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 16:41:01 +00:00
Taha Tesser 994aab4c78
Update & improve TabBar.labelColor tests (#133668)
fixes [Improve `TabBar.labelColor` tests](https://github.com/flutter/flutter/issues/133665)

While working on a fix for https://github.com/flutter/flutter/issues/109484, I found the existing test could use some improvement first.
2023-08-30 16:40:59 +00:00
Zachary Anderson 44a9b36461
Bump gradle heap size limits in templates (#133671)
For https://github.com/flutter/flutter/issues/133639
2023-08-30 15:40:14 +00:00
Flutter GitHub Bot 7368da037a
Marks Windows module_test to be flaky (#133640)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows module_test"
}
-->
Issue link: https://github.com/flutter/flutter/issues/133639
2023-08-30 08:00:14 -07:00
Bruno Leroux 1fe24956ac
Update SelectableRegion test for M3 (#129627)
## Description

This PR  fixes one selectable region test failure when switching to M3.
The failure is somewhat tricky because it is related to the M3 typography (line height set to 1.43).

## Related Issue

fixes https://github.com/flutter/flutter/issues/129626

## Tests

Updates 1 test.
2023-08-30 13:25:35 +00:00
godofredoc 56ea352cc0
Remove cirrus tests from the flutter framework. (#133575)
The flutter framework has been running tests both in luci and cirrus. We are removing Cirrus tests on favor of the LUCI ones.
2023-08-30 04:00:10 +00:00
engine-flutter-autoroll cf4e09d025
Roll Flutter Engine from 749e67a947bc to 69f04bdfe952 (2 revisions) (#133621)
749e67a947...69f04bdfe9

2023-08-30 jonahwilliams@google.com [Impeller] transform text path offsets so color sources match expected offsets for gradients. (flutter/engine#45255)
2023-08-30 skia-flutter-autoroll@skia.org Roll Skia from e6eb56d9b074 to fde9fe141863 (1 revision) (flutter/engine#45260)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 03:00:12 +00:00
Xilai Zhang 6fd42536b7
[flutter roll] Revert "Fix Chip.shape's side is not used when provided in Material 3" (#133615)
Reverts flutter/flutter#132941
context: b/298110031

The rounded rectangle borders don't appear in some of the internal
golden image tests.
2023-08-29 19:59:02 -07:00
engine-flutter-autoroll b34955c2f4
Roll Flutter Engine from 9f2cf5c99b0f to 749e67a947bc (2 revisions) (#133618)
9f2cf5c99b...749e67a947

2023-08-29 bdero@google.com [Impeller] Document the capabilities. (flutter/engine#45253)
2023-08-29 xilaizhang@google.com [flutter roll] Revert "ios: remove shared_application and support app extension build" (flutter/engine#45250)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 02:07:09 +00:00
engine-flutter-autoroll a9c16eb135
Roll Flutter Engine from c5854a6b3658 to 9f2cf5c99b0f (4 revisions) (#133616)
c5854a6b36...9f2cf5c99b

2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from 8a2754a1ae60 to e6eb56d9b074 (3 revisions) (flutter/engine#45248)
2023-08-29 matanlurey@users.noreply.github.com Refactor `Stopwatch` into `StopwatchVisualizer` and `SkStopwatchVisualizer` (flutter/engine#45200)
2023-08-29 zanderso@users.noreply.github.com Roll buildroot (flutter/engine#45249)
2023-08-29 bdero@google.com [Impeller] Add GetDefaultDepthStencil to capabilities. (flutter/engine#45240)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 01:00:41 +00:00
Parker Lougheed 670d011b71
No longer include .packages in created .gitignore files (#133484)
The `.packages` file was deprecated in Dart 2.8 and slowly discontinued until support being fully removed in Dart 2.19. The file will no longer be created, so it can be safely dropped from the generated `.gitignore` files.
2023-08-30 00:40:01 +00:00
engine-flutter-autoroll 50b3ee26ef
Roll Flutter Engine from db3ecf8b2739 to c5854a6b3658 (1 revision) (#133610)
db3ecf8b27...c5854a6b36

2023-08-29 skia-flutter-autoroll@skia.org Roll Dart SDK from a4e0e792ef9a to 0cea73a8d3c3 (1 revision) (flutter/engine#45245)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 00:09:15 +00:00
engine-flutter-autoroll 917d4760ce
Roll Flutter Engine from 1feb9302050c to db3ecf8b2739 (4 revisions) (#133609)
1feb930205...db3ecf8b27

2023-08-29 bdero@google.com [Impeller] Remove unused HasThreadingRestrictions capability. (flutter/engine#45242)
2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from fb09020ce62d to 8a2754a1ae60 (6 revisions) (flutter/engine#45241)
2023-08-29 47866232+chunhtai@users.noreply.github.com [Impeller] Update xcode_frame_capture.md (flutter/engine#45230)
2023-08-29 109111084+yaakovschectman@users.noreply.github.com Update documentation for updater callback. (flutter/engine#45239)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 23:21:51 +00:00
Polina Cherkasova 4736cd3d37
Fix one notDisposed leak and mark another. (#133595) 2023-08-29 23:08:48 +00:00
engine-flutter-autoroll acaa97350a
Roll Flutter Engine from 01a1579808b5 to 1feb9302050c (1 revision) (#133604)
01a1579808...1feb930205

2023-08-29 109111084+yaakovschectman@users.noreply.github.com Add callback to Embedder API to respond to new channel listeners, and use for Windows lifecycle (flutter/engine#44827)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 22:36:41 +00:00
Polina Cherkasova 67f9d77177
Upgrade packages. (#133593) 2023-08-29 15:18:12 -07:00
Polina Cherkasova fb5abe45b8
Cover more tests with leak tracking. (#133596) 2023-08-29 14:23:10 -07:00
engine-flutter-autoroll fc06fe6aa9
Roll Flutter Engine from 73cc3fb451fd to 01a1579808b5 (3 revisions) (#133591)
73cc3fb451...01a1579808

2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from 15de7f9c3b3b to fb09020ce62d (3 revisions) (flutter/engine#45233)
2023-08-29 matanlurey@users.noreply.github.com Use `runIfNot: ...` to avoid running Fuchsia try-jobs for some changes. (flutter/engine#45134)
2023-08-29 zanderso@users.noreply.github.com Clean up engine repo Dart code (flutter/engine#45203)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 21:10:46 +00:00
Hans Muller 4022864c65
Added DropdownMenuEntry.labelWidget (#133491) 2023-08-29 13:01:49 -07:00
Ian Hickson 89310edaa2
Use a fake stopwatch to remove flakiness. (#133229)
Fixes https://github.com/flutter/flutter/issues/133215
2023-08-29 12:49:33 -07:00
engine-flutter-autoroll bfbfce4903
Roll Flutter Engine from d1e6eb080f08 to 73cc3fb451fd (3 revisions) (#133580)
d1e6eb080f...73cc3fb451

2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from b7e826d5324f to 15de7f9c3b3b (3 revisions) (flutter/engine#45231)
2023-08-29 jonahwilliams@google.com [Impeller] its not safe to presentWithTransaction from a background thread. (flutter/engine#45182)
2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from b0c1b2868129 to b7e826d5324f (4 revisions) (flutter/engine#45229)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 19:41:59 +00:00
Mouad Debbar 9a9c2826d1
[web] Migrate remaining web-only API usages to dart:ui_web (#132248)
This is the last batch of web-only API migration.

Depends on https://github.com/flutter/engine/pull/44516

Fixes https://github.com/flutter/flutter/issues/52899
Fixes https://github.com/flutter/flutter/issues/126831
2023-08-29 18:56:07 +00:00
Greg Spencer ff829fd8b2
Add doxygen doc generation. (#131356) 2023-08-29 11:12:02 -07:00
engine-flutter-autoroll 7ef4290a3c
Roll Flutter Engine from 50bd80773287 to d1e6eb080f08 (2 revisions) (#133570)
50bd807732...d1e6eb080f

2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from 4048262b9b21 to b0c1b2868129 (2 revisions) (flutter/engine#45227)
2023-08-29 mdebbar@google.com [web] Make devicePixelRatio ready for multi-view (flutter/engine#44783)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 17:54:24 +00:00
Polina Cherkasova ae64abc614
ShortcutManager should dispatch creation in constructor. (#133487) 2023-08-29 10:40:20 -07:00
Taha Tesser d8d7e019c1
Add FAB Additional Color Mappings example (#133453)
fixes [Additional color mappings for FAB in Material 3](https://github.com/flutter/flutter/issues/130702)

### Preview
![image](https://github.com/flutter/flutter/assets/48603081/a6f9aef6-af80-41ce-8e59-50f095db047d)
2023-08-29 17:31:02 +00:00
engine-flutter-autoroll f6c20db64b
Roll Flutter Engine from 65438c7bb46a to 50bd80773287 (1 revision) (#133565)
65438c7bb4...50bd807732

2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from 7675f886f884 to 4048262b9b21 (2 revisions) (flutter/engine#45225)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 17:00:13 +00:00
engine-flutter-autoroll dcdc4df998
Roll Packages from 383bffa3991d to d7d3150e5966 (13 revisions) (#133564)
383bffa399...d7d3150e59

2023-08-29 ian@hixie.ch [rfw] Implement /* block comments */ in the text format (flutter/packages#4769)
2023-08-29 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.4 to 2.21.5 (flutter/packages#4810)
2023-08-28 engine-flutter-autoroll@skia.org Roll Flutter from cd3aeef3a8 to ec387a467a (15 revisions) (flutter/packages#4807)
2023-08-28 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.9.0 to 1.9.10 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#4798)
2023-08-28 jhy03261997@gmail.com Fix  popping repeated pages unexpectedly (flutter/packages#4763)
2023-08-28 tarrinneal@gmail.com [pigeon] primitive enums (flutter/packages#4580)
2023-08-27 engine-flutter-autoroll@skia.org Roll Flutter from 229b74d987 to cd3aeef3a8 (4 revisions) (flutter/packages#4777)
2023-08-26 engine-flutter-autoroll@skia.org Roll Flutter from 61d9f55665 to 229b74d987 (13 revisions) (flutter/packages#4776)
2023-08-25 engine-flutter-autoroll@skia.org Roll Flutter from deeb811ef0 to 61d9f55665 (25 revisions) (flutter/packages#4774)
2023-08-25 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.3 to 3.6.0 (flutter/packages#4770)
2023-08-24 praconfi@gmail.com [css_colors] docs: Update deprecated link address (flutter/packages#4537)
2023-08-24 engine-flutter-autoroll@skia.org Roll Flutter (stable) from efbf63d9c6 to e1e47221e8 (3 revisions) (flutter/packages#4767)
2023-08-24 engine-flutter-autoroll@skia.org Roll Flutter from bd836cc63a to deeb811ef0 (17 revisions) (flutter/packages#4766)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 16:27:05 +00:00
engine-flutter-autoroll 6c95737375
Roll Flutter Engine from d84763e04496 to 65438c7bb46a (1 revision) (#133563)
d84763e044...65438c7bb4

2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from 85377eca700d to 7675f886f884 (7 revisions) (flutter/engine#45224)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 15:56:45 +00:00
engine-flutter-autoroll dbe114d8c3
Roll Flutter Engine from 0625049b5ee3 to d84763e04496 (6 revisions) (#133559)
0625049b5e...d84763e044

2023-08-29 skia-flutter-autoroll@skia.org Roll Dart SDK from 70066300aa83 to a4e0e792ef9a (1 revision) (flutter/engine#45221)
2023-08-29 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 68DESTl_q6I45UJyb... to QKekosWnIY_ObKstn... (flutter/engine#45217)
2023-08-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Ys38QMyFZToJxnXrF... to z9uQ0mXwjKFQF05Xl... (flutter/engine#45216)
2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from e9e4d0dacc9d to 85377eca700d (1 revision) (flutter/engine#45215)
2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from 5dd678aebdaf to e9e4d0dacc9d (1 revision) (flutter/engine#45214)
2023-08-29 skia-flutter-autoroll@skia.org Roll Dart SDK from f6c11801db41 to 70066300aa83 (1 revision) (flutter/engine#45212)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Ys38QMyFZToJ to z9uQ0mXwjKFQ
  fuchsia/sdk/core/mac-amd64 from 68DESTl_q6I4 to QKekosWnIY_O

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 15:13:17 +00:00
engine-flutter-autoroll c66e922aae
Roll Flutter Engine from c2ec683c4ea8 to 0625049b5ee3 (2 revisions) (#133538)
c2ec683c4e...0625049b5e

2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from 01ee493cc113 to 5dd678aebdaf (1 revision) (flutter/engine#45210)
2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from f576668bfe99 to 01ee493cc113 (1 revision) (flutter/engine#45208)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 10:25:07 +00:00
engine-flutter-autoroll d58f158a88
Roll Flutter Engine from 3d1faae1bc2f to c2ec683c4ea8 (4 revisions) (#133535)
3d1faae1bc...c2ec683c4e

2023-08-29 zhongwuzw@qq.com [iOS] Don't call App lifecycle resumed when device is locked (flutter/engine#44947)
2023-08-29 skia-flutter-autoroll@skia.org Roll Dart SDK from 60a3bb84fa6d to f6c11801db41 (1 revision) (flutter/engine#45207)
2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from b27fecd52899 to f576668bfe99 (1 revision) (flutter/engine#45206)
2023-08-29 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.3 to 3.6.0 (flutter/engine#45205)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 09:14:39 +00:00
engine-flutter-autoroll d37a8e4693
Roll Flutter Engine from c7c61ff9732c to 3d1faae1bc2f (1 revision) (#133530)
c7c61ff973...3d1faae1bc

2023-08-29 skia-flutter-autoroll@skia.org Roll Skia from 66e367b12e96 to b27fecd52899 (1 revision) (flutter/engine#45204)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 07:13:36 +00:00
Dan Field f489256fce
Fix bug in setPreferredOrientations example (#133503)
The `ui.Display` is a simple data class (like `MediaQueryData`), and does not get updated when the display size changes.  The provided sample code does not work as intended, but the update does.
2023-08-29 06:29:05 +00:00
engine-flutter-autoroll 6dae269881
Roll Flutter Engine from 9778c2cb1d51 to c7c61ff9732c (2 revisions) (#133527)
9778c2cb1d...c7c61ff973

2023-08-29 skia-flutter-autoroll@skia.org Roll Dart SDK from 2900ad211f38 to 60a3bb84fa6d (1 revision) (flutter/engine#45201)
2023-08-29 matanlurey@users.noreply.github.com A minimal `engine_tools_lib` to use for local-repo Dart tooling (flutter/engine#45154)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 04:22:24 +00:00
engine-flutter-autoroll 773287b7e4
Roll Flutter Engine from ffda7e3cfc7f to 9778c2cb1d51 (1 revision) (#133526)
ffda7e3cfc...9778c2cb1d

2023-08-29 jacksongardner@google.com Fix scene view canvas/platform view placement. (flutter/engine#45199)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 03:36:15 +00:00
engine-flutter-autoroll 8845c80aaa
Roll Flutter Engine from 1e821961e96a to ffda7e3cfc7f (2 revisions) (#133523)
1e821961e9...ffda7e3cfc

2023-08-29 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from u44zzvYd85WSDMpS3... to 68DESTl_q6I45UJyb... (flutter/engine#45197)
2023-08-29 matanlurey@users.noreply.github.com Rename `instrumentation` to `stopwatch` (flutter/engine#45196)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from u44zzvYd85WS to 68DESTl_q6I4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 02:22:07 +00:00
engine-flutter-autoroll e6c7b84920
Roll Flutter Engine from 45e2b41e5ae5 to 1e821961e96a (2 revisions) (#133520)
45e2b41e5a...1e821961e9

2023-08-29 jonahwilliams@google.com [Impeller] Sync presentation when rendering into FlutterImageView. (flutter/engine#44881)
2023-08-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from AQZddYgKiWrQL8vny... to Ys38QMyFZToJxnXrF... (flutter/engine#45195)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from AQZddYgKiWrQ to Ys38QMyFZToJ

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 01:29:15 +00:00
engine-flutter-autoroll 6cc01ced84
Roll Flutter Engine from bd2132a0814f to 45e2b41e5ae5 (2 revisions) (#133518)
bd2132a081...45e2b41e5a

2023-08-28 jacksongardner@google.com [skwasm] encode PNGs using browser APIs (flutter/engine#45187)
2023-08-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 5d3ab5db5037 to 2900ad211f38 (3 revisions) (flutter/engine#45192)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 00:36:53 +00:00
Jim Graham 88717b3c65
add missing forwards of local-engine-host in benchmark runners (#133517)
Some places where we are missing a forward of the `--local-engine-host` values in the benchmark code preventing local running of the benchmarks (does not affect CI usages which don't override local engine).
2023-08-29 00:31:14 +00:00