Commit graph

12059 commits

Author SHA1 Message Date
Michael Goderbauer 07fc9f6442
Fix mkdir call to not fail if dir exists (#22622) 2018-10-03 14:12:54 -07:00
Danny Tuppeny d43155695d
Revert "Use (processors-1) for test runs (test defaults to processors/2)" (#22628)
* Revert "Custom offset functionality for Popup Menu Button (#22534)"

This reverts commit f44b277fa6.

* Revert "Updated the ColorScheme dartdoc: a11y (#22618)"

This reverts commit aa6a27e8a2.

* Revert "Added support for the Khmer (km) language (#22617)"

This reverts commit 3a87b93fce.

* Revert "Use 'Future<void>' insted of 'Future<Null>' in SystemChrome (#22583)"

This reverts commit 37c10acb97.

* Revert "Choice Chip Fix (#22589)"

This reverts commit 8d76d37f33.

* Revert "Throw if trying to set fs.currentDirectory in tests (#22037)"

This reverts commit 2f6155bf18.

* Revert "Use (processors-1) for test runs (test defaults to processors/2) (#22085)"

This reverts commit d44f003079.
2018-10-03 21:35:36 +01:00
Danny Tuppeny 55d70506ed
Mark module_test_ios as not-flaky (#22626)
The only reds on the dashboard for this test are on rows that have many failures across the run; this does not appear to be at all flaky.
2018-10-03 21:03:25 +01:00
jslavitz f44b277fa6
Custom offset functionality for Popup Menu Button (#22534)
* Adds offset functionality to popup menu
* Adds a test
2018-10-03 11:19:19 -07:00
Hans Muller aa6a27e8a2
Updated the ColorScheme dartdoc: a11y (#22618) 2018-10-03 11:15:28 -07:00
Hans Muller 3a87b93fce
Added support for the Khmer (km) language (#22617) 2018-10-03 11:14:56 -07:00
Gary Qian 37c10acb97
Use 'Future<void>' insted of 'Future<Null>' in SystemChrome (#22583) 2018-10-03 11:14:09 -07:00
jslavitz 8d76d37f33
Choice Chip Fix (#22589)
* choice chip fix

* added test
2018-10-03 11:08:01 -07:00
Danny Tuppeny 2f6155bf18
Throw if trying to set fs.currentDirectory in tests (#22037)
* Block setting of fs.currentDirectory in tests

This isn't perfect, it only covers tests using testUsingContext, but that is the huge majority of tests.

* Tweak error message.
2018-10-03 19:07:04 +01:00
Danny Tuppeny d44f003079
Use (processors-1) for test runs (test defaults to processors/2) (#22085)
* Use (processors-1) for test runs (test defaults to processors/2)

* Add missing import 🙄
2018-10-03 19:06:48 +01:00
Rui Kowase b9f6e2c315 Remove new keyword from sample code (#22465) 2018-10-03 18:11:29 +02:00
engine-flutter-autoroll b08f36e3cc Roll engine f6af1f20ba92..74662ab69523 (13 commits) (#22599)
f6af1f20ba...74662ab695

git log f6af1f20ba92..74662ab69523 --no-merges --oneline
74662ab69 Revert &#34;Share engine layers with the framework&#34; (flutter/engine#6412)
2de87a80f Roll src/third_party/skia 6719fcc43b1e..deb512045e6a (7 commits) (flutter/engine#6411)
68a42e3f4 Add nullability annotations to MethodChannel/MethodCall. (flutter/engine#6393)
71ba20a64 Dart SDK roll for 2018-10-02 to d2c5a24fd9ead97a7f18d02786e679293cc3709e (flutter/engine#6410)
9ccc96625 Share engine layers with the framework (flutter/engine#6406)
fa719e3e7 Roll src/third_party/skia cc4dbfcfbd8a..6719fcc43b1e (17 commits) (flutter/engine#6409)
dc2634dcf Force lf-line endings for so that source offsets match across platforms. (flutter/engine#6408)
44a514943 Roll src/third_party/skia 7dae882574d2..cc4dbfcfbd8a (15 commits) (flutter/engine#6405)
de32c659b Roll src/third_party/skia 3b8b11e1f912..7dae882574d2 (15 commits) (flutter/engine#6403)
3a9c22afd Allow GetRectsForRange to provide more detailed/nuanced metrics through RectStyle enum. (flutter/engine#6335)
b59c86493 Rename the Android fragment support library JAR (flutter/engine#6400)
4213ac19c Add an Android fragment support library to third_party (flutter/engine#6384)
a785b25f4 do not count Hidden nodes at the beginning of the scrollable (flutter/engine#6381)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
2018-10-02 23:27:58 -07:00
xster 188c25fbd3
Clarify that only one nav bar should be in each route (#22584) 2018-10-02 20:09:23 -07:00
xster dd3af0e287
Cupertino picker fidelity fixes (#22537) 2018-10-02 18:35:02 -07:00
xster 08fe1d86e9
Update android fastlane bundle packages (#22532) 2018-10-02 18:34:40 -07:00
xster 9b893b1430
Set the upload key in cirrus when publishing (#22581) 2018-10-02 18:34:20 -07:00
Michael Goderbauer bfa9822134
Hide App.framework.dSYM from Spotlight (#22540) 2018-10-02 18:28:22 -07:00
Hans Muller 99a2293893
Added ColorScheme dartdoc (#22592) 2018-10-02 17:35:36 -07:00
Greg Spencer 9eca083006
Temporarily disabling Docs deplyment (#22588)
Merging on read to unbreak the build.

TBR= @Hixie
2018-10-02 16:15:04 -07:00
Hans Muller eea3465ae7
Added ColorScheme, updated ThemeData, ButtonTheme, material buttons (#22013)
Introduce an overall material "color scheme" and to make it possible to redefine how a component's visual properties bind to the color scheme and to the existing material Theme.
2018-10-02 14:50:43 -07:00
Gary Qian 46bc911b72
Add 'restoreSystemUIOverlays' to SystemChrome to allow simple UI restore after System force changes. (#22221)
* Add 'restoreSystemUIOverlays' to SystemChrome to allow simple UI restore after System force changes.
2018-10-02 14:44:39 -07:00
mockturtl 13684e4f8e use RadioListTile in expansion panels demo (#20240)
* use RadioListTile in expansion panels demo

Fixes #6048.
- expose `_Location`
- appease analyzer
2018-10-02 11:15:17 -07:00
Danny Tuppeny d89604d85c
Change file paths to URIs to fix "Could not run configuration in engine" on Windows (#22507)
* Change file paths to URIs to fix "Could not run configuration in engine" on Windows

Plus unskip test that was failing due to this.

Fixes #21348.

* Remove unused import
2018-10-02 18:31:55 +01:00
Greg Spencer 9a9ef594bc
Compare the Cirrus OS env var with the right value for macOS (darwin) (#22533) 2018-10-02 10:20:09 -07:00
Dan Field eee50963e5
Revert "Roll engine f6af1f20ba92..b59c86493159 (3 commits)" (#22559)
* Revert "unnecessary this in field initializers (#22522)"

This reverts commit 5de96bb734.

* Revert "Use unsafePackageSerialization when running tests (#22407)"

This reverts commit 4bd6ad7395.

* Revert "Roll engine f6af1f20ba92..b59c86493159 (3 commits) (#22538)"

This reverts commit 85a4591aa3.
2018-10-02 09:30:12 -07:00
Alexandre Ardhuin 5de96bb734
unnecessary this in field initializers (#22522) 2018-10-02 17:14:59 +02:00
jensjoha 4bd6ad7395
Use unsafePackageSerialization when running tests (#22407) 2018-10-02 08:36:21 +02:00
engine-flutter-autoroll 85a4591aa3
Roll engine f6af1f20ba92..b59c86493159 (3 commits) (#22538)
f6af1f20ba...b59c864931

git log f6af1f20ba92..b59c86493159 --no-merges --oneline
b59c86493 Rename the Android fragment support library JAR (flutter/engine#6400)
4213ac19c Add an Android fragment support library to third_party (flutter/engine#6384)
a785b25f4 do not count Hidden nodes at the beginning of the scrollable (flutter/engine#6381)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
2018-10-01 21:26:32 -04:00
liyuqian 22bb3e6f6c
0c2b6dc6e3...f6af1f20ba (#22528)
Manually roll the engine to the last good commit known to the
auto-roller.

git log 0c2b6dc6e339..f6af1f20ba92 --no-merges --oneline
f6af1f20b Roll src/third_party/skia e8e2bb1384ad..3b8b11e1f912 (4 commits) (flutter/engine#6395)
7f2e2ea4f Roll src/third_party/skia bba2921c1970..e8e2bb1384ad (1 commits) (flutter/engine#6394)
4f69beb27 Roll src/third_party/skia 7f3ceba5dc7f..bba2921c1970 (1 commits) (flutter/engine#6392)
a4a5449d5 Roll src/third_party/skia 22867ce6fe83..7f3ceba5dc7f (1 commits) (flutter/engine#6391)
31278f0b8 Roll src/third_party/skia ebfbf1d749c1..22867ce6fe83 (1 commits) (flutter/engine#6390)
73409c228 Roll src/third_party/skia 93d71666b2f1..ebfbf1d749c1 (1 commits) (flutter/engine#6389)
6f8c827b2 Dart SDK roll for 2018-09-28 (flutter/engine#6388)
6e96ae542 Roll src/third_party/skia cfa315390f04..93d71666b2f1 (6 commits) (flutter/engine#6386)
39dee5b61 Fix Fuchsia build. (flutter/engine#6383)
560eba1a3 Roll src/third_party/skia 87311c6e565f..cfa315390f04 (9 commits) (flutter/engine#6382)
2018-10-01 14:57:06 -07:00
Yegor d91f1608c5
upgrade packages (#22524) 2018-10-01 14:42:53 -07:00
Jason Simmons 3581b3ae85
Make font manifest descriptors consistent with the paths used for font assets (#22375)
The asset subsystem uses URIs to represent asset locations.  The font manifest
should also use URI-encoded paths instead of unencoded paths taken directly
from the manifest YAML.

Fixes https://github.com/flutter/flutter/issues/19452
2018-10-01 14:14:48 -07:00
Jonah Williams f19674853c
move doc comment back (#22525) 2018-10-01 13:29:21 -07:00
Alexandre Ardhuin f62afdcf57
add missing type parameter on methods (#22096) 2018-10-01 21:29:08 +02:00
Alexandre Ardhuin 48fb726b01
compare to null with == (#21944)
* compare to null with ==

* address review comments
2018-10-01 21:22:51 +02:00
Jonah Williams 224f91e386
Revert "Eliminate snapshot, depfile opts from bundle cmd (#22495)" (#22519)
This reverts commit b07d986f66.
2018-10-01 10:49:39 -07:00
Chris Bracken b07d986f66
Eliminate snapshot, depfile opts from bundle cmd (#22495)
Eliminates the --snapshot and --depfile parameters from the flutter
bundle command. The snapshot parameter is unused in Dart 2 -- code is
built to kernel .dill files and for profile/release builds, then AOT
compiled.

While depfiles are still used in Dart 2 (e.g. by the kernel compiler),
there are enough assumptions in the code that they lie in the default
location (e.g. in the Gradle build) and no reasons to support
user-cusomisation that it makes sense to eliminate the --depfile option
as well, and always use the default location.

This commit also renames 'depFilePath' to 'depfilePath' for consistency
across the codebase.
2018-10-01 10:19:37 -07:00
jslavitz a7303e040d
Selection controls internationalization (#22443)
* Fix internationalization issues with cupertinoTextSelectionControls
2018-10-01 10:04:08 -07:00
Tran Huy Phuc 481cb77a4c Fix flutter emaultors crash when ini file is not parsed (#22503)
Fixes #22247.
2018-10-01 18:02:43 +01:00
xster ac9dc5745e
Add support for material agnostic driver navigation (#22461) 2018-10-01 09:18:20 -07:00
Viet Do 2a8e35cc9c Cupertino Date Picker (#21251) 2018-09-28 18:29:28 -07:00
jslavitz efc5123d29
Chip press elevation (#22383)
* Make Chip press elevation customizable.
2018-09-28 16:12:55 -07:00
xster 75b24070dd
Add API docs link to each gallery demo (#22379) 2018-09-28 16:06:41 -07:00
Alexander Markov c60560fb16 Roll engine to 0c2b6dc6e3395b41ea284c505067455a4081949e (with Dart roll) 2018-09-28 15:16:36 -07:00
Alexander Markov c51aaf95a8 Roll engine to 277c895111e2c3d4cc27bb37df7540dd67c669f1 2018-09-28 15:16:36 -07:00
shrike69 c496751ae8
Change flutter tool to not require Fuchsia build args (#22382)
* Change flutter tool to not require Fuchsia build args

* Restore code that was commented out.

* Fix style nits.
2018-09-28 15:13:47 -07:00
Stanislav Baranov 54c10f44b2
Implement build flow for hot updates on Android (#22391)
This also involves switching from Core JIT to App JIT snapshot, and replacing per-isolate VM snapshot with the shared VM snapshot.

For now there is no separate update bundle file, as the generated update gets packaged directly into the APK for testing purposes.
2018-09-28 13:58:37 -07:00
liyuqian b65d3bceaa
2a22019a8d...7dc6b3a8ee (#22441)
git log 2a22019a8dd8..7dc6b3a8eeef --no-merges --oneline
7dc6b3a8e Skip non-existing libflutters for symbol check (flutter/engine#6374)
0cd9ee372 Add more debug loging to symbol verification script (flutter/engine#6372)
fcb3c519b Roll src/third_party/skia b726c89ff8a8..d004e0b55c4a (1 commits) (flutter/engine#6373)
5e3d786d0 Use nm from buildtools (flutter/engine#6371)
2018-09-28 13:19:55 -07:00
liyuqian 783c028f2c
Don't push offset to leaf layers (#21619)
For retained rendering, we don't want to push the offset down to each leaf layer. Otherwise, changing an offset layer on the very high level could cascade the change to too many leaves, which means that we can't retain them.

To not push the offset downwards, we simply push a TransformLayer when there's an offset. Skia has a fast path for concatenating scale/translation-only matrix so this operation should be fast (no performance regression is measured on Moto G4).

This is our first step towards https://github.com/flutter/flutter/issues/21756
2018-09-28 12:21:43 -07:00
Andrew Davies 1c2f478e9e
[frdp][connection] Exception checks in _getDartVm (#22386)
Through some integration testing checks, it looks like it's possible
that connecting to a new instance of the Dart VM may fail even after the
Dart VM instance has been discovered.

This means that _getDartVm should be checked in more than just one
place.  This changes the function to return a null value in the event of
a 'well-known' exception (`HttpException` or `TimeoutException`
specifically).

As a result, code now calling _getDartVm checks for null and handles it
as appropriate, and the DartVm RPC calls are all updated with
consistent timeout params.
2018-09-28 11:40:36 -07:00
shrike69 fd8a9603ac
Remove waitForViews() during hot reload (#22371) 2018-09-28 11:35:38 -07:00