development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 11:42:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change file paths to URIs to fix "Could not run configuration in engine" on Windows (#22507)

Browse source 
* Change file paths to URIs to fix "Could not run configuration in engine" on Windows

Plus unskip test that was failing due to this.

Fixes #21348.

* Remove unused import
This commit is contained in:
Danny Tuppeny 2018-10-02 18:31:55 +01:00 committed by GitHub
parent 9a9ef594bc
commit d89604d85c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
packages/flutter_tools/lib/src/vmservice.dart
View file

@ -921,13 +921,12 @@ class VM extends ServiceObjectOwner {
Uri main,
Uri packages,
Uri assetsDirectory) {
// TODO(goderbauer): Transfer Uri (instead of file path) when remote end supports it.
return invokeRpc<ServiceMap>('_flutter.runInView',
params: <String, dynamic> {
'viewId': viewId,
'mainScript': main.toFilePath(windows: false),
'packagesFile': packages.toFilePath(windows: false),
'assetDirectory': assetsDirectory.toFilePath(windows: false)
'mainScript': main.toString(),
'packagesFile': packages.toString(),
'assetDirectory': assetsDirectory.toString()
});
}

6
packages/flutter_tools/test/integration/hot_reload_test.dart
View file

@ -4,8 +4,6 @@
import 'package:file/file.dart';
import 'package:flutter_tools/src/base/file_system.dart';
import 'package:flutter_tools/src/base/platform.dart';
import 'package:vm_service_client/vm_service_client.dart';
import '../src/common.dart';
@ -37,9 +35,7 @@ void main() {
test('restart works without error', () async {
await _flutter.run();
await _flutter.hotRestart();
// TODO(dantup): Unskip after flutter-tester restart issue is fixed on Windows:
// https://github.com/flutter/flutter/issues/21348.
}, skip: platform.isWindows);
});
test('reload hits breakpoints with file:// prefixes after reload', () async {
await _flutter.run(withDebugger: true);