Reid Baker
86a9d6c660
Merge branch 'master' into reidbaker-postmortem-android-14-platform-views-background
2024-06-28 11:17:23 -04:00
Reid Baker
37f1282a58
Update Postmortem-Platform-View-android-14-regression
2024-06-28 11:17:13 -04:00
Danny Tuppeny
eb58fe16b6
[flutter_tools] Include more details in structured errors sent to a DAP client ( #150698 )
...
The debug adapter converts Flutter's structured errors into a text format to be sent to the debug client and shown in the console. When an error is not the first error since the last reload, it is shown as just a summary (since it may be caused by a prior error). In this mode, the filter was causing some important information (the erroring widget) to be omitted.
This tweaks the logic to include child nodes of a `DiagnosticBlock` in this mode.
Fixes https://github.com/Dart-Code/Dart-Code/issues/4743
## Before:
## After:
2024-06-28 06:36:03 +00:00
engine-flutter-autoroll
ed8dde8ba0
Roll Flutter Engine from 94591ffb20df to a78f5ce743ce (1 revision) ( #150972 )
...
94591ffb20...a78f5ce743skia-flutter-autoroll@skia.org Roll Dart SDK from e7022f6eb6c9 to 0820b0766ac9 (1 revision) (flutter/engine#53623 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-28 04:38:12 +00:00
engine-flutter-autoroll
15f95ce0c3
Roll Flutter Engine from ddd4814b9d40 to 94591ffb20df (5 revisions) ( #150968 )
...
ddd4814b9d...94591ffb20skia-flutter-autoroll@skia.org Roll Skia from cbd6e55139ca to 1700e3962acd (2 revisions) (flutter/engine#53619 )
2024-06-27 skia-flutter-autoroll@skia.org Roll Dart SDK from b5f079c2936e to e7022f6eb6c9 (1 revision) (flutter/engine#53616 )
2024-06-27 chinmaygarde@google.com Update DEPS to pull in 8c2d66fa4e6298894425f5bdd0591bc5b1154c53. (flutter/engine#53614 )
2024-06-27 skia-flutter-autoroll@skia.org Roll Skia from c73e514838b4 to cbd6e55139ca (4 revisions) (flutter/engine#53615 )
2024-06-27 johnoneil@users.noreply.github.com Fix #150515 Provide required headers for build with Clang-16 and GCC ⦠(flutter/engine#53479 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-28 00:22:34 +00:00
Gray Mackall
f23dbc50f0
Manual engine roll to ddd4814 ( #150952 )
...
Manual engine roll up to https://github.com/flutter/engine/pull/53592 .
Manual roll because the change requires Gradle lockfiles to be re-generated.
2024-06-27 21:57:32 +00:00
Reid Baker
69ff23b3de
local lint copy gradle task config ( #150957 )
...
- **Fix gradle lint task configuration issue on release builds**
Fixes #150955
2024-06-27 21:34:53 +00:00
engine-flutter-autoroll
2d02215080
Roll Flutter Engine from b42c80460538 to d1506c12808e (3 revisions) ( #150951 )
...
b42c804605...d1506c1280skia-flutter-autoroll@skia.org Roll Skia from 09a46ebe4c01 to dee7339d0b53 (5 revisions) (flutter/engine#53612 )
2024-06-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 65fa56a24416 to b5f079c2936e (1 revision) (flutter/engine#53611 )
2024-06-27 skia-flutter-autoroll@skia.org Roll Skia from a407ec8a29b9 to 09a46ebe4c01 (1 revision) (flutter/engine#53610 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-27 20:40:50 +00:00
Andrew Kolos
1f672c24a3
[tool] make the systemTempDirectory getter on ErrorHandlingFileSystem wrap the underlying filesystem's temp directory in aErrorHandlingDirectory ( #150876 )
...
Fixes https://github.com/flutter/flutter/issues/150730
If you can think of a more concise title, be my guest.
2024-06-27 20:39:14 +00:00
Jackson Gardner
74688cea3d
Have flutter.js load local canvaskit instead of the CDN when appropriate ( #150806 )
...
If the user specifies the `--no-web-resources-cdn` or `--local-web-sdk`, we should use the local version of CanvasKit. `flutter.js` now has a flag that can be specified in the build configuration that tells it to load locally instead.
Also, added a link to the relevant docs in the web template warnings.
This addresses https://github.com/flutter/flutter/issues/148713
Also fixes https://github.com/flutter/flutter/issues/145559
2024-06-27 18:44:04 +00:00
engine-flutter-autoroll
ab4d422213
Roll Flutter Engine from a9194f0f01f4 to b42c80460538 (10 revisions) ( #150940 )
...
a9194f0f01...b42c804605skia-flutter-autoroll@skia.org Roll Dart SDK from 7d7fbb30e0ca to 65fa56a24416 (1 revision) (flutter/engine#53609 )
2024-06-27 skia-flutter-autoroll@skia.org Roll Dart SDK from d825219c0ce1 to 7d7fbb30e0ca (1 revision) (flutter/engine#53608 )
2024-06-27 skia-flutter-autoroll@skia.org Roll Skia from fb1458ac7bfd to a407ec8a29b9 (2 revisions) (flutter/engine#53607 )
2024-06-27 skia-flutter-autoroll@skia.org Roll Skia from e2f68b30ea63 to fb1458ac7bfd (1 revision) (flutter/engine#53606 )
2024-06-27 skia-flutter-autoroll@skia.org Roll Skia from 7b55cb1afe40 to e2f68b30ea63 (1 revision) (flutter/engine#53605 )
2024-06-27 skia-flutter-autoroll@skia.org Roll Skia from 001694095f1b to 7b55cb1afe40 (1 revision) (flutter/engine#53603 )
2024-06-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 8dd486ebfab4 to d825219c0ce1 (1 revision) (flutter/engine#53602 )
2024-06-27 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from n2dgSmMCaCO7ujvmr... to gBWzGuicxu76K82lg... (flutter/engine#53601 )
2024-06-27 skia-flutter-autoroll@skia.org Roll Dart SDK from c01f907d34d8 to 8dd486ebfab4 (1 revision) (flutter/engine#53599 )
2024-06-26 skia-flutter-autoroll@skia.org Roll Skia from 55ada83438cd to 001694095f1b (3 revisions) (flutter/engine#53598 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from n2dgSmMCaCO7 to gBWzGuicxu76
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-27 18:32:23 +00:00
hangyu
5bf0192f58
[a11y] Reland [ #149375 ] Update semantics in dropdown.dart ( #150578 )
...
issue: https://github.com/flutter/flutter/issues/117997
This is a partial reland of
https://github.com/flutter/flutter/pull/149375 with updated g3fix
cl/642457545
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-06-27 10:52:48 -07:00
Michael Goderbauer
ba03c59406
Bump dartdoc to 8.0.9+1 ( #150935 )
2024-06-27 17:30:21 +00:00
Yegor
ef34436402
add onFocus to text fields ( #150648 )
...
Adds `onFocus` support to Cupertino and Material text field widgets (similar to https://github.com/flutter/flutter/pull/142942 ).
2024-06-27 14:38:32 +00:00
LouiseHsu
9a673175ab
Fixes flutter build ipa failure: Command line name "app-store" is deprecated. Use "app-store-connect" ( #150407 )
...
Fixes https://github.com/flutter/flutter/issues/149369
2024-06-27 07:42:21 +00:00
Ricardo Boss
805d79607e
Copy any previous IconThemeData instead of overwriting it in CupertinoButton ( #149777 )
...
This changes how the `IconThemeData` is passed to the child of `CupertinoButton`.
Previously, it would derive the foreground color from the current theme and create a new `IconThemeData` object.
This causes any `IconThemeData` to be overwritten.
This change uses `IconTheme.of` to get the currently applied icon theme and only overwrites the properties provided by the `CupertinoButton` instead of the whole object.
Fixes #149172 .
2024-06-27 03:53:58 +00:00
Hans Muller
e4c18b702a
Improve the behavior of scrollbar drag-scrolls triggered by the trackpad ( #150275 )
...
Corrects some problems related to trackpad scrolls introduced by https://github.com/flutter/flutter/pull/146654 .
Fixes https://github.com/flutter/flutter/issues/149999
Fixes #150342
Fixes https://github.com/flutter/flutter/issues/150236
2024-06-27 00:50:26 +00:00
FernTheDev
e706d7d0b7
feat: Add autofocus for MenuItemButton ( #139396 )
...
MenuAnchor for Material 3 is great for contextual menus but there are some minor issues related to accessibility.
This PR aims to close the gap by adding `autofocus` to the menu item button so keyboard navigation is more intuitive. Otherwise, it becomes a mess to navigate through just keyboards.
Partially resolves #139395
## Additional Notes
I should mention, I have not written tests for this due to it's trivial nature. I also lack the experience of writing Flutter tests in general, so if someone feels inclined to take over this PR and add it they're welcome to.
2024-06-27 00:46:40 +00:00
engine-flutter-autoroll
def5a38e02
Roll Flutter Engine from 1d5e3cc55a75 to a9194f0f01f4 (7 revisions) ( #150888 )
...
1d5e3cc55a...a9194f0f01skia-flutter-autoroll@skia.org Roll Skia from 173ee0af82c9 to 55ada83438cd (3 revisions) (flutter/engine#53596 )
2024-06-26 jason-simmons@users.noreply.github.com Return a null image from ImageExternalTextureGL::CreateEGLImage if an EGL display is not available (flutter/engine#53594 )
2024-06-26 30870216+gaaclarke@users.noreply.github.com [Impeller] blur - cropped the downsample pass for backdrop filters (flutter/engine#53562 )
2024-06-26 skia-flutter-autoroll@skia.org Roll Skia from 0a979d9f3606 to 173ee0af82c9 (2 revisions) (flutter/engine#53593 )
2024-06-26 matanlurey@users.noreply.github.com Remove otherwise unused third_party/web_dependencies. (flutter/engine#53588 )
2024-06-26 matanlurey@users.noreply.github.com Copy `flutter/flutter/docs/engine` to `flutter/engine/docs` as-is (no changes) (flutter/engine#53595 )
2024-06-26 skia-flutter-autoroll@skia.org Roll Dart SDK from 38bb74f63829 to c01f907d34d8 (5 revisions) (flutter/engine#53585 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-27 00:34:25 +00:00
Gray Mackall
0198afa1a4
Reland "Remove dual_screen from new_gallery integration test" ( #150873 )
...
Relands https://github.com/flutter/flutter/pull/150808
The original version of the pr [accidentally deleted the back button](https://github.com/flutter/flutter/pull/150808#discussion_r1655444210 ), which didn't block the app building but made the test hang because it couldn't back out of the demo pages.
Repro-ed the failure, and then tested that
```
new_gallery_opengles_impeller__transition_perf
new_gallery__transition_perf
new_gallery_impeller_old_zoom__transition_perf
new_gallery__crane_perf
new_gallery_impeller__transition_perf
```
All pass on my pixel 7 pro, with ` dart bin/test_runner.dart test -t <test>`, after re-adding the mistakenly deleted content.
Did not test on an iOS device (I don't have one), but those tests were failing for the same reason from what I can tell:
```
> reply@study
[2024-06-26 12:49:21.884543] [STDOUT] stdout: [ ] scrolling to demo
[2024-06-26 12:49:22.412479] [STDOUT] stdout: [ +527 ms] tapping demo
[2024-06-26 12:49:28.075978] [STDOUT] stderr: [+5663 ms] VMServiceFlutterDriver: tap message is taking a long time to complete...
```
Which is the same error, and which makes sense - they got stuck because they couldn't back out of the page.
Sorry for the churn ð
2024-06-26 23:37:55 +00:00
Parker Lougheed
c946a5a526
Switch to more reliable flutter.dev link destinations in the tool ( #150587 )
...
Contributes to https://github.com/flutter/website/issues/10363 .
2024-06-26 23:30:39 +00:00
Michael Goderbauer
776efc20d8
Adding @docImports to the animation library ( #150798 )
...
Part of https://github.com/flutter/flutter/issues/150800 .
I turned on the `comment_references` lint and looked at what needed fixing inside of the `animation` library.
There are a couple of places where for some reason adding a docImport didn't fix the `comment_references` warning:
2024-06-26 23:12:05 +00:00
Jenn Magder
a52e266b79
Remove CODEOWNERS trailing whitespace ( #150882 )
...
New analyze error in an unrelated PR
```
╔═╡ERROR #1╞════════════════════════════════════════════════════════════════════
║ /b/s/w/ir/x/w/flutter/CODEOWNERS:13: trailing U+0020 space character
╚═══════════════════════════════════════════════════════════════════════════════
```
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8744032390138579057/+/u/run_test.dart_for_analyze_shard_and_subshard_None/stdout
On this commit
2537b49e4e
2024-06-26 14:59:56 -07:00
engine-flutter-autoroll
45ead889b9
Roll Flutter Engine from e03cf86c4170 to 1d5e3cc55a75 (3 revisions) ( #150875 )
...
e03cf86c41...1d5e3cc55amatanlurey@users.noreply.github.com Replace `Log.w` with `Log.d`, and tidy the file up a bit. (flutter/engine#53586 )
2024-06-26 skia-flutter-autoroll@skia.org Roll Skia from 695d35a0559e to 0a979d9f3606 (3 revisions) (flutter/engine#53591 )
2024-06-26 matanlurey@users.noreply.github.com Move impeller-cmake-example to flutter/third_party. (flutter/engine#53589 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-26 21:31:30 +00:00
Matan Lurey
2537b49e4e
Remind folks we are moving. ( #150872 )
...
Part of https://github.com/flutter/flutter/issues/150869 .
This should mitigate accidental new files or significant changes, or at
least make me aware I suppose?
2024-06-26 14:13:53 -07:00
Jackson Gardner
7b12e69089
Remove bringup: true from web test shard. ( #150785 )
...
These two fixes seem to have stopped the flaking:
https://github.com/flutter/flutter/pull/149828
https://dart-review.googlesource.com/c/sdk/+/367821
2024-06-26 20:46:23 +00:00
engine-flutter-autoroll
086b0d709c
Roll Flutter Engine from c0017bed42c2 to e03cf86c4170 (1 revision) ( #150867 )
...
c0017bed42...e03cf86c41skia-flutter-autoroll@skia.org Roll Skia from e836fa986829 to 695d35a0559e (1 revision) (flutter/engine#53584 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-26 20:35:59 +00:00
auto-submit[bot]
43a8b6af53
Reverts "Remove dual_screen from new_gallery integration test ( #150808 )" ( #150871 )
...
Reverts: flutter/flutter#150808
Initiated by: gmackall
Reason for reverting: Causing the new_gallery tests to hang.
I can repro now though, so should be able to find a fix shortly
Original PR Author: gmackall
Reviewed By: {christopherfujino, johnmccutchan, jtmcdole, jonahwilliams}
This change reverts the following previous change:
Removes the `dual_screen` package from `new_gallery`. Unblocks the fourth attempt to land https://github.com/flutter/engine/pull/53001 .
2024-06-26 19:47:18 +00:00
Gray Mackall
1d1367678a
Remove dual_screen from new_gallery integration test ( #150808 )
...
Removes the `dual_screen` package from `new_gallery`. Unblocks the fourth attempt to land https://github.com/flutter/engine/pull/53001 .
2024-06-26 19:06:55 +00:00
engine-flutter-autoroll
35b6d4f540
Roll Flutter Engine from d4624a36712b to c0017bed42c2 (4 revisions) ( #150865 )
...
d4624a3671...c0017bed42jason-simmons@users.noreply.github.com Roll the archive package to version 3.6.1 (flutter/engine#53582 )
2024-06-26 skia-flutter-autoroll@skia.org Roll Skia from 354b30fe7ab5 to e836fa986829 (3 revisions) (flutter/engine#53583 )
2024-06-26 58529443+srujzs@users.noreply.github.com Ignore lints that will be triggered by ExternalDartReference changes (flutter/engine#53572 )
2024-06-26 skia-flutter-autoroll@skia.org Roll Skia from 79587650d153 to 354b30fe7ab5 (2 revisions) (flutter/engine#53580 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-26 19:03:09 +00:00
Samuel Wrenn
05f294c711
Fixes for Style Guide for Flutter Repo ( #150167 )
...
Fix broken links, typos, and inconsistent formatting in the Style Guide for Flutter Repo.
Fixes [150164](https://github.com/flutter/flutter/issues/150164 ).
2024-06-26 18:28:03 +00:00
engine-flutter-autoroll
00f9483036
Roll Flutter Engine from da62c629ed5c to d4624a36712b (3 revisions) ( #150852 )
...
da62c629ed...d4624a3671skia-flutter-autoroll@skia.org Roll Skia from 7e85023a57b7 to 79587650d153 (1 revision) (flutter/engine#53578 )
2024-06-26 skia-flutter-autoroll@skia.org Roll Skia from 0c9a66786ba1 to 7e85023a57b7 (3 revisions) (flutter/engine#53577 )
2024-06-26 skia-flutter-autoroll@skia.org Roll Skia from 7cbcb2f0e818 to 0c9a66786ba1 (1 revision) (flutter/engine#53576 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-26 14:35:28 +00:00
Sigurd Meldgaard
ffdeaa1995
Use `Isolate.packageConfigSync! to locate the packageconfig of flutter tools ( #150340 )
...
This is a small refactor.
Using `loadPackageConfigWithLogging` seems wrong. We should be able to
assume that the flutter_tool package_config is in place.
Warm-up for https://github.com/flutter/flutter/issues/150196
2024-06-26 09:49:44 +02:00
engine-flutter-autoroll
b2b0a751ff
Roll Flutter Engine from 25af762ffbb3 to da62c629ed5c (2 revisions) ( #150829 )
...
25af762ffb...da62c629edskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from WUN7NQK04NjF9fRmf... to n2dgSmMCaCO7ujvmr... (flutter/engine#53575 )
2024-06-25 magder@google.com Remove FlutterUndoManagerPlugin handlers from undo manager on dealloc (flutter/engine#53553 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from WUN7NQK04NjF to n2dgSmMCaCO7
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-26 06:25:08 +00:00
Polina Cherkasova
b958b8750d
Fix leaky tests. ( #150817 )
2024-06-25 21:55:34 -07:00
engine-flutter-autoroll
5030724698
Roll Flutter Engine from 94023d711db3 to 25af762ffbb3 (4 revisions) ( #150818 )
...
94023d711d...25af762ffbskia-flutter-autoroll@skia.org Roll Skia from ea8ec1a618b0 to 7cbcb2f0e818 (4 revisions) (flutter/engine#53573 )
2024-06-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 65ab2f2cf0d3 to 38bb74f63829 (1 revision) (flutter/engine#53570 )
2024-06-25 skia-flutter-autoroll@skia.org Roll Skia from 04133a5bf21f to ea8ec1a618b0 (3 revisions) (flutter/engine#53569 )
2024-06-25 skia-flutter-autoroll@skia.org Roll Skia from da1ea4eb0270 to 04133a5bf21f (2 revisions) (flutter/engine#53566 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-26 01:49:37 +00:00
flutter-pub-roller-bot
1a445b910f
Roll pub packages ( #150810 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-06-26 00:18:23 +00:00
Tong Mu
98fb56fc05
Remove reference to MaterialApp and showCupertinoModalPopup from CupertinoAlertDialog ( #150725 )
...
This PR removes the usage of Material widgets from unit tests of `CupertinoAlertDialog`. Other than it being just wrong, it also introduces bad behavior, such as the scroll view can't be overscrolled so that the overscroll behavior can't be tested.
* Since there are no longer M2 or M3 variants of tests, I straight up rewrote the unit tests for "default look" with similar tests as those of `CupertinoActionSheet` ([here](https://github.com/flutter/flutter/blob/master/packages/flutter/test/cupertino/action_sheet_test.dart#L21 ))
This PR also replaces `showCupertinoModalPopup` with `showCupertinoDialog` in `CupertinoAlertDialog`'s example code. The former should only be used by `CupertinoActionSheet`, which has a different animation from the correct `showCupertinoDialog`.
2024-06-25 22:45:05 +00:00
Matan Lurey
a6a8caaa73
Read AndroidManifest.xml and emit manifest-impeller-(enabled|disabled) analytics ( #150791 )
...
Work towards https://github.com/flutter/flutter/issues/132712 .
After this PR, after a completed `flutter build apk` command, we:
- Emit a `manifest-impeller-disabled` command if `io.flutter.embedding.android.EnableImpeller` is `'false'`.
- Emit a `manifest-impeller-disabled` command if `io.flutter.embedding.android.EnableImpeller` is _missing_.
- Emit a `manifest-impeller-enabled` command if `io.flutter.embedding.android.EnableImpeller` is `'true'`.
We will need to change the default (see `_impellerEnabledByDefault` in `project.dart`) before releasing, otherwise we will misreport `manifest-impeller-disabled` at a much higher rate than actual. If there is a way to instead compute the default instead of hard-coding, that would have been good.
See <https://docs.flutter.dev/perf/impeller#android > for details on the key-value pair.
---
I also did a tad of TLC, by removing the (now-defunct) `Usage` events for `flutter build ios`, so they are consistent.
/cc @zanderso, @chinmaygarde, @jonahwilliams
2024-06-25 22:41:23 +00:00
Jason Simmons
9afd397cd4
[flutter_tools] Shut down Chromium cleanly using a command sent through the debug protocol ( #150645 )
...
The previous approach of killing the Chromium parent process sometimes caused leaks of child processes on Windows. The Browser.close command in the debug protocol will tell Chromium to shut down all of its processes.
2024-06-25 21:43:02 +00:00
Bruno Leroux
00419bfb24
Reland fix inputDecorator hint color on M3 ( #150278 )
...
## Description
This PR is a partial reland of https://github.com/flutter/flutter/pull/148944 which was reverted in https://github.com/flutter/flutter/pull/149448 .
It makes the `InputDecoration.hintText` colors compliant with the M3 spec.
The initial PR also changed the font style, I will land the font change in another PR to better track the golden changes.
## Related Issue
Related to the color part of https://github.com/flutter/flutter/issues/148787 .
## Tests
Updates several tests.
2024-06-25 21:42:59 +00:00
engine-flutter-autoroll
a37d9e05aa
Roll Flutter Engine from 62e0b5f9c340 to 94023d711db3 (7 revisions) ( #150797 )
...
62e0b5f9c3...94023d711djacksongardner@google.com [skwasm] Fixes for getting pixels from an image. (flutter/engine#53561 )
2024-06-25 parrott.jason@gmail.com fix: web canvaskit fragment shaders were not using updated uniform values (flutter/engine#53246 )
2024-06-25 skia-flutter-autoroll@skia.org Roll Dart SDK from b5fc85cfcf1b to 65ab2f2cf0d3 (1 revision) (flutter/engine#53565 )
2024-06-25 skia-flutter-autoroll@skia.org Roll Skia from e4e4feb97a54 to da1ea4eb0270 (4 revisions) (flutter/engine#53563 )
2024-06-25 flar@google.com [DisplayList] Switch to recording DrawVertices objects by reference (flutter/engine#53548 )
2024-06-25 skia-flutter-autoroll@skia.org Roll Skia from 5f21260470cf to e4e4feb97a54 (1 revision) (flutter/engine#53559 )
2024-06-25 30870216+gaaclarke@users.noreply.github.com [impeller] Cleanup blur (flutter/engine#53543 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-25 20:58:32 +00:00
Bruno Leroux
8950c26f2b
Fix collapsed InputDecorator minimum height ( #150770 )
...
## Description
This PR sets a minimal height for collapsed `InputDecoration`.
Before this PR the minimum height was 0. On desktop, due to visual density reducing the height by 8 pixels, it leads to a collapsed text field height being too small to fit the input text vertically.
The following screenshot shows a default collapsed M3 TextField on macOS. On M3 the font style is 16px with a 1.5 height, so the input height is 24. The decoration height is 16 because of the visual density reduction (this results in the border being misplaced, some letters overflowing and the cursor overflowing).
After this PR, the minimum height is the input height.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/150763
## Tests
Adds 4 tests, updates 2.
2024-06-25 20:52:08 +00:00
Loïc Sharma
8334a3172c
Add more warm up frame docs ( #150464 )
...
Updated the wiki to call out the warm up frame. This contains details from the following pages:
1. b98d48549c/packages/flutter/lib/src/scheduler/binding.dart (L994-L1016)https://api.flutter.dev/flutter/dart-ui/PlatformDispatcher/scheduleWarmUpFrame.html
3. https://api.flutter.dev/flutter/dart-ui/FlutterView/physicalSize.html
Part of https://github.com/flutter/flutter/issues/149974
2024-06-25 20:36:05 +00:00
flutter-pub-roller-bot
65e6bde4b1
Roll pub packages ( #150739 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-06-25 19:54:07 +00:00
Victor Sanni
f89c7c7505
Add focusNode, focusColor, onFocusChange, autofocus to CupertinoButton ( #150721 )
...
Before:
https://github.com/flutter/flutter/assets/77553258/e7ed7af0-03ab-4a7d-98dd-be1ce4e9c7da
After:
https://github.com/flutter/flutter/assets/77553258/ca93fc67-1816-4e18-b0c5-130975c7f06b
Fixes #144385
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Taha Tesser <tessertaha@gmail.com>
2024-06-25 12:25:02 -07:00
Greg Price
e5a35f458f
Document RenderObject._relayoutBoundary and its invariant; small refactors ( #150527 )
...
Fixes part of #150524 .
Recently I was studying RenderObject and related code to understand
how the rendering library tracks which objects need layout, and in
particular just how the concept of "relayout boundary" works.
The [RenderObject._relayoutBoundary] property itself had no docs,
and there were some other areas that I felt could be clearer;
so here's a PR where I add those docs.
In addition to docs, this makes some small pure refactors. Mostly
those are in order to make clear docs easier to write. One rename
is to fix a lone straggler from #4425 / #4483 .
One key thing I learned, which this documents, is an invariant that
this code maintains on [_relayoutBoundary]. With that invariant in
mind, I found it's possible to simplify that bookkeeping, and to get a
measurable performance improvement as a bonus. To keep things simple,
though, I'll leave those for follow-up PRs.
For ease of review, the PR is broken into several commits each with
their own commit message.
2024-06-25 18:27:38 +00:00
engine-flutter-autoroll
a4ce9026c8
Roll Flutter Engine from 6313b1e5afd7 to 62e0b5f9c340 (1 revision) ( #150790 )
...
6313b1e5af...62e0b5f9c3skia-flutter-autoroll@skia.org Roll Skia from 3029f75db702 to 5f21260470cf (2 revisions) (flutter/engine#53557 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-06-25 18:14:00 +00:00
foxmind1
adef612ff4
fix a typo ( #150682 )
...
fix typo
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-06-25 17:51:51 +00:00
Samuel Wrenn
b8211b3d94
Fix link in RenderObjectWidget doc comment ( #150600 )
...
Fix a link in the `RenderObjectWidget` doc comment. The comment recommends subclassing `SingleChildRenderObjectElement` where it means to recommend subclassing `SingleChildRenderObjectWidget`.
Fixes #150597 .
2024-06-25 17:45:55 +00:00
