development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-02 14:34:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix leaky tests. (#150817)

Browse source
This commit is contained in:
Polina Cherkasova 2024-06-25 21:55:34 -07:00 committed by GitHub
parent 5030724698
commit b958b8750d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/flutter/test/cupertino/button_test.dart
View file

@ -492,6 +492,8 @@ void main() {
testWidgets('Button can be focused and has default colors', (WidgetTester tester) async {
final FocusNode focusNode = FocusNode(debugLabel: 'Button');
addTearDown(focusNode.dispose);
tester.binding.focusManager.highlightStrategy = FocusHighlightStrategy.alwaysTraditional;
const Border defaultFocusBorder = Border.fromBorderSide(
BorderSide(
@ -540,6 +542,8 @@ void main() {
testWidgets('Button configures focus color', (WidgetTester tester) async {
final FocusNode focusNode = FocusNode(debugLabel: 'Button');
addTearDown(focusNode.dispose);
tester.binding.focusManager.highlightStrategy = FocusHighlightStrategy.alwaysTraditional;
const Color focusColor = CupertinoColors.systemGreen;
@ -576,6 +580,8 @@ void main() {
testWidgets('CupertinoButton.onFocusChange callback', (WidgetTester tester) async {
final FocusNode focusNode = FocusNode(debugLabel: 'CupertinoButton');
addTearDown(focusNode.dispose);
bool focused = false;
await tester.pumpWidget(
CupertinoApp(

3
packages/flutter/test/widgets/undo_history_test.dart
View file

@ -32,6 +32,7 @@ void main() {
testWidgets('UndoHistory widget registers as global undo/redo client', (WidgetTester tester) async {
final FocusNode focusNode = FocusNode(debugLabel: 'UndoHistory Node');
addTearDown(focusNode.dispose);
final GlobalKey undoHistoryGlobalKey = GlobalKey();
final ValueNotifier<int> value = ValueNotifier<int>(0);
addTearDown(value.dispose);
@ -68,6 +69,7 @@ void main() {
testWidgets('UndoHistory widget deregisters as global undo/redo client when it loses focus',
(WidgetTester tester) async {
final FocusNode focusNode = FocusNode(debugLabel: 'UndoHistory Node');
addTearDown(focusNode.dispose);
final GlobalKey undoHistoryGlobalKey = GlobalKey();
final ValueNotifier<int> value = ValueNotifier<int>(0);
addTearDown(value.dispose);
@ -105,6 +107,7 @@ void main() {
testWidgets('UndoHistory widget deregisters as global undo/redo client when disposed', (WidgetTester tester) async {
final FocusNode focusNode = FocusNode(debugLabel: 'UndoHistory Node');
addTearDown(focusNode.dispose);
final GlobalKey undoHistoryGlobalKey = GlobalKey();
final ValueNotifier<int> value = ValueNotifier<int>(0);
addTearDown(value.dispose);