Commit graph

9229 commits

Author SHA1 Message Date
Piotr Caban 846d164092 wmic: Use fwprintf to output error messages. 2023-08-22 21:01:22 +02:00
Alex Henrie f339506f4f find: Use CRT allocation functions. 2023-08-18 18:31:32 +02:00
Alex Henrie c27f8f72d1 cmd: Introduce an option_equals helper for WCMD_parse_forf_options. 2023-08-17 10:40:37 +02:00
Jacek Caban a1d429dabd cscript: Build as CUI application. 2023-08-16 21:19:47 +02:00
Maxim Karasev aa3beb88b3 whoami: Refactor and add more commands.
Particularly it implements '/logonid' and '/user' options,
as well as adds stubs for '/upn' and '/fqdn'.
2023-08-14 17:53:17 +02:00
Hans Leidekker 0a880e5706 klist: Match native output for encryption type. 2023-07-31 18:23:21 +09:00
Piotr Caban 93736efa80 services: Exit early in process_send_start_message if ConnectNamedPipe fails.
HasOverlappedIoCompleted returns true after CancelIo call.
2023-07-21 21:27:44 +02:00
Maxim Karasev c29dc0064e klist: Add a program that lists Kerberos tickets.
It's a clean-room reimplementation that mimics Windows 10 program's output format.
It prints all the information that is available via KerbQueryTicketCacheMessage.

Also tested to work on Windows if dynamically linked + built with winegcc.

For further extension of the functionality, implementing
KerbQueryTicketCacheEx{,2,3}Message is required.
2023-07-21 21:27:44 +02:00
Petrichor Park 100504d2f5 notepad: Use GetDpiForWindow().
Instead of querying the registry, just calls `GetDpiForWindow`.

Winecfg's DPI slider sets `Control Panel\\Desktop\\LogPixels`.
See `programs/winecfg/x11drvdlg.c`
Notepad queries `Software\\Fonts\\LogPixels`, and so doesn't pick up
on the change.
2023-07-19 10:44:51 +02:00
Eric Pouech 10aaff9245 conhost: Fix ctrl-c handling.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55197
Signed-off-by: Eric Pouech <epouech@codeweavers.com>
2023-07-13 11:51:41 +02:00
Billy Laws b233cfb33e wineboot: Always attempt setup for all machine types.
Without this, wineboot would bail out on ARM64 in the case where x86_64 WOW is
not available but i386 is. Leaving an incomplete prefix without any clear error.
2023-07-11 20:28:35 +02:00
Eric Pouech fdd1c1c776 winedbg: Detect debuggee termination before first exception.
When a crash in a program happens, and the debugger in launched in --auto
mode, in some cases the program terminates before the debugger has gotten
proper context on debuggee.
(Could be a watchdog in programs checking if it's debugged and terminating
itself if so).

Detect debuggee termination and still provide some information on debuggee
(threads, modules, system info). The backtrace will not be available as
no exception is gotten from debuggee.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55187
Signed-off-by: Eric Pouech <epouech@codeweavers.com>
2023-07-07 12:20:23 +02:00
Eric Pouech 7ada0e2239 winedbg: Add 'info system' command.
Letting the information displayed in '--auto' mode be available
as a command.
Simplify a bit the --auto mode handling.

Note:
- the WOW64 status of the debuggee used to be printed in system
  information, which is a bit ackward as system info shouldn't be
  tied to a given process.
- replaced it with supported guest machines (for the record, a
  64-bit only setup incorrectly returns i386 as supported guest;
  I guess we shouldn't care).
- now printing the wow64 status of a process when displaying an
  exception information instead.

Signed-off-by: Eric Pouech <epouech@codeweavers.com>
2023-07-07 12:19:42 +02:00
Eric Pouech bde065746e winedbg: Cache wow64 status inside struct process.
Signed-off-by: Eric Pouech <epouech@codeweavers.com>
2023-07-07 12:19:42 +02:00
Alex Henrie eba7092f0a cmd: Allow numbered redirects at the beginning of a line.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55124
2023-07-05 21:08:33 +02:00
Kevin Schmidt 29b29eddcc taskmgr: Use macro for the color black too. 2023-07-04 21:00:12 +02:00
Mohamad Al-Jaf 95ea605b10 pnputil: Add stub program.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55178
2023-07-03 22:15:42 +02:00
Alex Henrie 3d383c468b regedit: Fix memory leak on error path in RenameKey (scan-build).
parentPath is allocated before parentKey.
2023-06-29 13:57:39 +02:00
Rémi Bernon 467201a85b explorer: Fix command-line parameter parsing.
Fixes: 5b11157ecf
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55141
2023-06-29 12:04:07 +02:00
Rémi Bernon 7255f63a65 explorer: Set virtual desktop primary adapter display settings.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55146
2023-06-28 18:58:39 +02:00
Rémi Bernon 99ef2dc4e1 explorer: Rename initialize_display_settings local variable.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55146
2023-06-28 18:58:39 +02:00
Rémi Bernon 0e5b847f85 explorer: Use debugstr_devmodew helper to trace display mode.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55146
2023-06-28 18:58:39 +02:00
Rémi Bernon 5b11157ecf explorer: Use wide string literals. 2023-06-26 16:47:11 +02:00
Rémi Bernon 43fd81b3a5 explorer: Use unprefixed debug macros. 2023-06-26 16:47:11 +02:00
Rémi Bernon 240bdd5772 explorer: Use CRT allocation functions. 2023-06-26 16:47:11 +02:00
Maarten De Braekeleer 5e2f9996ba cmd: Fix 'if exist' with a directory/ as a parameter.
'if exists' takes a parameter which can be directory, directory/,
directory/. directory\ or directory\. for example, and should equate
to true if the directory exists. The syntax directory\ is explicitly
rejected by FindFirstFile and hence was not working - look for this
specific case, and if found append a '.'.

Follow-up commit of bc9d68bcbe

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55130#add_comment
2023-06-26 16:44:17 +02:00
Liam Middlebrook 0911d462f9 cmd: Fix empty strings between PATH separators.
Previously if an empty string was encountered while parsing out PATH,
cmd.exe would ignore the rest of the PATH entirely.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55097
Signed-off-by: Liam Middlebrook <lmiddlebrook@nvidia.com>
2023-06-21 18:25:48 +02:00
Liam Middlebrook 9aee47f7f6 cmd/tests: Add tests for PATH separator.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55097
Signed-off-by: Liam Middlebrook <lmiddlebrook@nvidia.com>
2023-06-21 18:25:38 +02:00
Alexandre Julliard c938f92e4c wordpad: Use nameless unions/structs. 2023-06-20 15:58:05 +02:00
Alexandre Julliard 35299b39cb winhlp32: Use nameless unions/structs. 2023-06-20 15:58:05 +02:00
Alexandre Julliard 6c9246e022 winemenubuilder: Use nameless unions/structs. 2023-06-20 15:58:05 +02:00
Alexandre Julliard 63f94c4925 winefile: Use nameless unions/structs. 2023-06-20 15:58:05 +02:00
Alexandre Julliard f20710d9b3 winedbg: Use nameless unions/structs. 2023-06-20 15:58:05 +02:00
Alexandre Julliard 4368bd8e60 winecfg: Use nameless unions/structs. 2023-06-20 15:58:05 +02:00
Alex Henrie 2455229549 conhost: Use correct pointer type in edit_line_transpose_words (scan-build). 2023-06-19 17:42:16 +02:00
Alexandre Julliard f5784e2fd1 services: Use nameless unions/structs. 2023-06-16 17:58:37 +02:00
Alexandre Julliard c2d1c8dcd3 regedit: Use nameless unions/structs. 2023-06-16 17:58:16 +02:00
Alexandre Julliard 5d9ea809da oleview: Use nameless unions/structs. 2023-06-16 17:58:03 +02:00
Alexandre Julliard 52a868a8fe netstat: Use nameless union/structs. 2023-06-16 17:57:36 +02:00
Alexandre Julliard e3664fa8ad ipconfig: Use nameless union/structs. 2023-06-16 17:57:24 +02:00
Alexandre Julliard 14518662d6 explorer: Use nameless union/structs. 2023-06-16 17:57:11 +02:00
Alexandre Julliard 2e58c9e060 conhost: Use nameless union/structs. 2023-06-16 17:56:55 +02:00
Alex Henrie 3caa27eafb wusa: Zero out identity on error path in read_identity.
Fixes double frees in read_components and read_dependency. The double
frees could also be fixed by using free instead of free_dependency in
those functions, but zeroing out the pointers is easier to understand
because it ensures that alloc_dependency can always be paired with
free_dependency.
2023-06-16 10:30:21 +02:00
Alexandre Julliard 93630ce14e include: Remove redundant __WINE_USE_MSVCRT checks. 2023-06-12 21:21:41 +02:00
Alex Henrie 6c1157435a regedit: Fix memory leak on error path in GetItemPath (scan-build). 2023-06-08 12:04:23 +02:00
Alex Henrie 8b54c2e35d conhost: Fix memory leak on error path in edit_line_move_to_history (scan-build). 2023-06-05 14:01:07 +02:00
Alex Henrie 935626b488 wusa: Fix double free on error path in read_update_package (scan-build).
If read_identity returns FALSE, it has already called clear_identity.
2023-06-05 14:01:07 +02:00
Rémi Bernon 4b5311c7e0 explorer: Remove now unnecessary wine_create_desktop entry. 2023-05-30 13:45:47 +02:00
Rémi Bernon f7d45533d1 explorer: Call user driver through a new CreateDesktop callback. 2023-05-30 13:45:43 +02:00
Rémi Bernon 0edc848bee explorer: Don't call driver create_desktop if desktop name is "root". 2023-05-30 13:45:42 +02:00
Rémi Bernon dbb63987f0 explorer: Use root window if driver doesn't implement create_desktop. 2023-05-30 13:45:42 +02:00
Rémi Bernon f9c1b6af12 explorer: Load graphics driver before calling CreateDesktopW. 2023-05-30 13:45:42 +02:00
Alexandre Julliard 0b23d22bd6 start: Implement the /machine option. 2023-05-24 15:43:54 +02:00
Alexandre Julliard 850e3bcc5d start: Use CRT allocation functions. 2023-05-24 15:43:54 +02:00
Alexandre Julliard df0483aa9b start: Add a separate helper to parse command line options. 2023-05-24 15:43:54 +02:00
Alexandre Julliard 4ae7de5bf7 start: Move memory allocation into parse_title(). 2023-05-24 15:43:54 +02:00
Davide Beatrici f266dc094a explorer: Fix uninitialized variable warning.
programs/explorer/desktop.c:104:16: warning: ‘hres’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  104 |         return hres;
      |                ^~~~
2023-05-23 22:36:50 +02:00
Jactry Zeng 996271fc2f wordpad: Resize buttons of toolbar to make them align with height of the font list combox.
The current size set to these buttons is too small when in HiDPI.
2023-05-12 17:50:49 +02:00
Olivier F. R. Dierick 60ef0f8677 dxdiag: Ignore option /64bit on the commandline.
The builtin dxdiag doesn't know about option /64bit and display an
error dialog. Some games use that option internally on startup and the
dialog is annoying.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49964
2023-05-08 20:01:42 +02:00
Alex Henrie 9d80b367ce winemenubuilder: Skip desktop integration for certain associations.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=41275
2023-05-02 20:02:20 +02:00
Zhiyi Zhang f88affa2a1 findstr: Add basic functionality.
Company of Heroes: Battle of Crete needs a functioning findstr.exe to exit properly.
Freemake Video Converter 4.1 installer also needs this.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=35254
2023-05-02 13:33:07 +02:00
Zhiyi Zhang db0ccc440a tasklist: Partially support '/fi' option.
Some filters such as STATUS and CPUTIME are not implemented.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48596
2023-05-02 13:33:07 +02:00
Zhiyi Zhang 397ce0dbf2 tasklist: Support '/fo' option. 2023-05-02 13:33:06 +02:00
Zhiyi Zhang 8238c1d48f tasklist: Support '/nh' option. 2023-05-02 13:33:06 +02:00
Zhiyi Zhang 62af0b5f84 tasklist: Add basic functionality.
Company of Heroes: Battle of Crete needs a functioning tasklist.exe to exit properly.
2023-05-02 13:33:03 +02:00
Eric Pouech f01ce56a49 winedbg: Improve size management in watch command.
- support 8 byte targets
- default to CPU pointer size if size isn't present nor supported.
- detect unaligned requests

Signed-off-by: Eric Pouech <eric.pouech@codeweavers.com>
2023-04-18 18:18:19 +02:00
Eric Pouech adde76fabd winedbg: Simplify watch command implementation.
This also correctly initialize some lvalue.
Context of the bug has changed, but the underlying issue remained the same.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=39495
Signed-off-by: Eric Pouech <eric.pouech@codeweavers.com>
2023-04-18 18:18:16 +02:00
Eric Pouech 812b4b1ca3 dbghelp: Use source file path as stored in debug info format.
Currently, dbghelp returns the source file either:
- in DOS format when native module option isn't enabled
- as stored in debug info format otherwise

This used to work for PE modules inside ELF shared libraries but is broken
since evolution to REAL modules. This generates several issues:
- winedbg does not always set the native module option when calling dbghelp
  for source file related functions, leading to heterogenous output to user
- some dbghelp function rely on matching source paths, hence leading to
  errors in winedbg when mixing the two formats for the same source file.

Introduce a new Wine only dbghelp option to return the source paths as they
are stored inside debug information format, and activate it unconditionaly
inside winedbg.

This fixes some failure cases of command 'break <NN>' in winedbg.

Signed-off-by: Eric Pouech <epouech@codeweavers.com>
2023-04-18 18:17:44 +02:00
Eric Pouech fd87ddfae7 winedbg: Let 'break symbol : line' command work again.
Signed-off-by: Eric Pouech <epouech@codeweavers.com>
2023-04-18 18:17:44 +02:00
Francois Gouget 8d2146934c iphlpapi: Fix the GAA_FLAG_INCLUDE_GATEWAYS constant name. 2023-04-10 14:18:00 +02:00
Eric Pouech 24069aad30 winedbg: Don't crash when no search path has been set.
Note: it's anyway wrong to search source files inside modules' path
(a proper fix will require revisiting source file handling).
This fix will actually be sufficient when running wine from within
its build tree.

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2023-04-05 15:24:41 +02:00
Hugh McMaster 887aa70e08 kernelbase: Implement GetConsoleOriginalTitleW(). 2023-04-03 16:52:01 +02:00
Hugh McMaster 6891faf454 conhost: Save original console title on initialization. 2023-04-03 16:52:01 +02:00
Zebediah Figura 3cb0b6c3f3 winedevice: Use the ntoskrnl channel. 2023-03-31 19:10:38 +02:00
Paul Gofman c0c68ee83a services: Change running service state once its process dies. 2023-03-30 18:49:16 +02:00
Paul Gofman 3580d466cc services: Factor out notify_service_state() function. 2023-03-30 18:49:16 +02:00
Paul Gofman 466a86bc54 services: Create service processes in a job. 2023-03-30 18:49:16 +02:00
Mohamad Al-Jaf 3503ab4e94 winecfg: Add an option to set WinRT app dark theme. 2023-03-29 22:29:38 +02:00
Paul Gofman fb6b1c91bb taskkill: Support terminating child processes. 2023-03-29 22:29:32 +02:00
Paul Gofman 5c85145189 taskkill: Mark processes for termination in main(). 2023-03-29 11:50:58 +02:00
Paul Gofman 6cca1f5099 taskkill: Use toolhelp snapshot to get process information. 2023-03-29 11:50:58 +02:00
Paul Gofman 62ef3c5be1 taskkill: Factor out get_task_pid(). 2023-03-29 11:50:58 +02:00
Paul Gofman cf4a0b7392 taskkill: Enumerate processes in main(). 2023-03-29 11:50:58 +02:00
Paul Gofman 20ab5f06d0 taskkill: Remove unneeded free() before process exit. 2023-03-29 11:50:58 +02:00
Paul Gofman dd3f3f381f taskkill: Use CRT allocation functions. 2023-03-29 11:50:58 +02:00
Francois Gouget a2d5644797 schtasks/tests: Verify that the task folders are correctly deleted. 2023-03-27 17:43:41 +02:00
Francois Gouget 739c5c547c schtasks/tests: Deleting folders requires elevated privileges on Windows 7 & 8.
This means skipping any test that requires creating a task as the test
would be unable to clean up after itself.

Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=52193
Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54634
2023-03-27 17:43:37 +02:00
Alexandre Julliard 9e8fbdab72 wineboot: Add processor features for supported WoW64 architectures on ARM64. 2023-03-15 14:57:51 +01:00
Alexandre Julliard e3e0c3a91a wineboot: Use the SystemProcessorBrandString query instead of cpuid. 2023-03-14 17:38:51 +01:00
Hugh McMaster 1a61a4e1a6 regedit: Append '.reg' file extension if necessary. 2023-03-09 18:12:49 +01:00
Hugh McMaster f5fe9a6cf9 regedit: Allow export_key() to return TRUE.
We don't handle errors in export_registry_data() anyway.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54491
2023-03-09 18:12:47 +01:00
Rémi Bernon 992d60e122 explorer: Use GUID_NULL display device GUID for nulldrv. 2023-03-03 18:29:54 +01:00
Alexandre Julliard 1774db388b winedbg: Use the Zydis library for disassembly. 2023-02-27 16:36:22 +01:00
Alexandre Julliard 297f7cb37e winefile: Use standard va_list instead of __ms_va_list. 2023-02-20 08:40:27 +01:00
Alexandre Julliard dbfeb4b7f4 taskmgr: Use standard va_list instead of __ms_va_list. 2023-02-20 08:40:14 +01:00
Alexandre Julliard b19d3e779b start: Use standard va_list instead of __ms_va_list. 2023-02-20 08:40:02 +01:00
Alexandre Julliard d244f902b3 oleview: Use standard va_list instead of __ms_va_list. 2023-02-20 08:39:42 +01:00
Alexandre Julliard e1f1846611 notepad: Use standard va_list instead of __ms_va_list. 2023-02-20 08:39:31 +01:00
Alexandre Julliard 9efe1a32a2 conhost: Use standard va_list instead of __ms_va_list. 2023-02-20 08:39:18 +01:00
Francois Gouget dfcc45cc17 winetest: Trace the keyboard layout.
It is important for the input tests so add it to the global locale
information.
2023-02-17 18:59:29 +01:00
Francois Gouget cac02872c6 winetest: Avoid an infinite loop in vstrfmtmake() when the format is NULL.
When the format is NULL vsnprintf() always returns -1 so we keep
doubling the allocated memory until running out of memory.
2023-02-14 09:57:07 +01:00
Francois Gouget b07129bad4 winetest: Don't use plain strings as format specifiers.
When they contain a percent character they would, at best, not be
printed correctly, and at worst cause a crash.
2023-02-14 09:57:07 +01:00
Alex Henrie fae940df23 wineboot: Avoid calling RtlInitUnicodeString on a static constant. 2023-02-13 15:54:40 +01:00
Alex Henrie dccc6a60b6 services: Avoid calling RtlInitUnicodeString on a static constant. 2023-02-10 19:09:16 +01:00
Alex Henrie a6f3e4ad22 winhlp32: Fix memory leak on realloc failure in HLPFILE_RtfAddBitmap (cppcheck). 2023-02-07 17:46:55 +01:00
Eric Pouech 234943344f winedbg: Don't expose module whose machine isn't the process' one to gdb.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2023-02-06 22:34:44 +01:00
Eric Pouech 71dbcbce26 winedbg: Handle multi-machine process in command 'info share'.
- filter out native machine on wow64 configuration.
- add option to info share to print all modules.

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2023-02-06 22:34:44 +01:00
Eric Pouech 7077c5bcab conhost: Only update font when running with a window.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54449
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2023-02-06 22:34:44 +01:00
Brendan Shanks fe6294c743 taskkill: Use exit code 1 when terminating processes. 2023-02-02 10:56:34 +01:00
Brendan Shanks 2da1126021 taskmgr: Use exit code 1 when terminating processes. 2023-02-02 10:56:32 +01:00
Hans Leidekker 3a819255f5 winecfg: Fix CurrentVersion registry string for Windows 10 and up.
It no longer reflects the real OS major and minor version numbers.
2023-02-01 17:11:47 +01:00
Hans Leidekker 69154f0329 ntdll: Default to Windows 10. 2023-02-01 17:11:47 +01:00
Hans Leidekker 2ccc2a42d7 ntdll: Add Windows 11 version. 2023-02-01 17:11:47 +01:00
Eric Pouech 433bc12709 winedbg: Fix read access to variables with thread local storage.
No longer relying on loaded module info (getting index address out of
PE image, and caching it in struct dbg_module).

Co-authored-by: Evan Tang <etang@codeweavers.com>
2023-01-26 22:05:13 +01:00
Eric Pouech 224b33c2be winedbg: Track loaded modules.
Co-authored-by: Evan Tang <etang@codeweavers.com>
2023-01-26 22:05:13 +01:00
Eric Pouech e8c7920919 conhost.exe: Handle ctrl-\ in Wine.
Let conhost handle ctrl-\ instead of Unix tty, and pretend it's a
ctrl-pause/break key stroke.  This allows CUI application in processed
input mode not to close upon ctrl-\.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54141
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2023-01-25 10:04:02 +01:00
Eric Pouech fda954dfd4 conhost.exe: Handle ctrl-pause/break key strokes.
Note: this patch should be extended by adding insertion
of the CTRL_BREAK_EVENT into processes' crtl handler
(as it's done for CTRL_C_EVENT).

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2023-01-25 10:04:00 +01:00
Eric Pouech 5fc54e3219 winedbg: Use debuggee's bitness for 'examine /a' command.
Also fixes stack dump in crash summary and 'info stack' command.
(We were using debugger's bitness instead).

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2023-01-24 20:14:52 +01:00
Eric Pouech a89975f731 dbghelp: Expose the real path to the module in SymGetModuleInfo*().
Expose the real path of a loaded module (potentially read from
WINEDLLDIR or WINEBUILDDIR or overriden load order or ...).  This
improves gdb integration by passing the real path to the loaded
modules (instead of the paths in c:\windows\ system subdirectories).
Introduce new Wine only dbghelp's extended option to enable the
feature.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54250
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2023-01-24 18:25:58 +01:00
Eric Pouech 3055653c1e winedbg: Pass loaded image's file handle to dbghelp.
In some cases (running from build tree, overriding load order...), the
path to the module from the load DLL debug event isn't the real path
to the loaded module. So pass the handle to loaded module's image from
winedbg to dbghelp (to avoid image lookup).

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54250
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2023-01-24 18:24:13 +01:00
Rémi Bernon 03aa9e13e7 services: Use a separate allocation for NotifyParamsArray[0].params.
The pointer might be freed by RPC NdrPointerFree, which will try to use
a dedicated free call for the array elements, and fail.
2023-01-24 18:15:41 +01:00
Gabriel Ivăncescu 929fdbbf55 notepad: Fix uninitialized upper 64-bits of pos in DoFind.
And get rid of the hacky casts.

Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
2023-01-18 22:55:19 +01:00
Eric Pouech ec05c03463 conhost: Initialize color_map when creating an alternate screen buffer.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54287
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2023-01-11 14:27:58 +01:00
Eric Pouech 8993f5720a conhost: Reset console attribute upon exit in unix mode.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2023-01-11 14:27:54 +01:00
Hugh McMaster 0e6b21ef1d conhost: Migrate from FontPitchFamily to FontFamily.
To ensure a seamless transition between value names, we try loading the
registry value from FontFamily first and FontPitchFamily second.

Any changes to the console font family are saved to the new value name.
2023-01-11 11:54:16 +01:00
Jinoh Kang 36ca172e85 regedit: Clip siblings when drawing list and tree views. 2023-01-06 10:41:21 +01:00
Jinoh Kang 8242b65172 regedit: Use the default WM_PAINT implementation for REGEDIT window. 2023-01-06 10:41:21 +01:00
Eric Pouech af215210f0 kernel32/tests: Skip some console tests on w1064v1909.
We get conhost.exe:tty failures on testbot:
- not for version prior to w1064v1909 (these tests require
  pseudo-consoles, which are not implemented in these Windows
  version).
- for w1064v1909
- not for W10 versions after w1064v1909.

So, we assume that pseudo-console support is immature in this
Windows version: skip all the remaining test at the first
discrepancy point.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53465
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-12-21 18:24:39 +01:00
Eric Pouech 0a7c04816f conhost: Don't print control characters for Unix tty.
They will be reinterpreted by Unix tty, leading to wrong display.

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-12-20 22:37:02 +01:00
Eric Pouech a922577986 winedbg: Avoid passing a non allocated buffer to HeapFree.
Latest changes to heap management can lead to a crash in this situation.

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-12-09 17:52:25 +01:00
Alex Henrie 5792785879 cmd: Use standard C functions for memory allocation. 2022-12-09 17:52:25 +01:00
Alexandre Julliard 57c58be77d winedbg: Fix printf format warnings on ARM platforms. 2022-12-08 18:11:23 +01:00
Alex Henrie 33ae61d79b winhlp32: Use standard C functions for memory allocation. 2022-12-07 20:27:26 +01:00
Eric Pouech cd0e949519 wineconsole: Set launched process name as created console title.
wineconsole was setting created console's title to '????\wineconsole.exe'.
This was preventing conhost to load its configuration according to
first running command path.

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-12-05 20:04:54 +01:00
Alex Henrie b8b55de629 winecfg: Annotate allocation functions with __WINE_(DEALLOC|MALLOC). 2022-12-05 20:04:54 +01:00
Alex Henrie 1f4532d5c6 winecfg: Use standard C functions for memory allocation. 2022-12-05 20:04:54 +01:00
Alex Henrie 6136b54757 services: Use standard C functions for memory allocation. 2022-12-01 10:24:10 +01:00
Eric Pouech f2ca35bd80 cmd: Use OEM code page when reading a file.
Calling GetConsoleCP() when ReadConsoleW() fails (potentially indicating
that cmd.exe's instance isn't attached to a console) makes no sense.

In details, since GetConsoleCP() returns 0 when not attached to a console
to indicate error, we're in fact using CP_ACP.

So fallback explicitely to OEM CP (which is the default for CUI programs).

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-11-25 18:09:57 +01:00
Rémi Bernon 1c30f7803c winepath: Free wine_get_(dos|unix)_file_name memory with HeapFree. 2022-11-25 18:09:57 +01:00
Paul Gofman eec6aea10a wmic: Support array of BSTRs in convert_to_bstr(). 2022-11-24 22:20:20 +01:00
Paul Gofman e3d7a3e3f6 wmic: Add nicconfig alias. 2022-11-24 22:20:20 +01:00
Paul Gofman 97b9d8ddbe wmic: Handle VariantChangeType() failures.
wmic currently crashes on, e. g., VT_EMPTY or VT_ARRAY types returned.
2022-11-24 22:20:20 +01:00
Paul Gofman 85b84a949c wmic: Call _BeginEnumeration() before iterating class object.
Otherwise enumeration fails on Windows.
2022-11-24 22:20:20 +01:00
Paul Gofman 6412b3dc3a wmic: Don't set WBEM_FLAG_FORWARD_ONLY flag on query.
The result access is not forward only.
2022-11-24 22:20:20 +01:00
Rémi Bernon f810a57590 rpcss: Use I_Rpc(Free|Allocate) in MIDL_user_(allocate|free).
In ept_map, rpcss uses TowerConstruct to allocate tower array elements.

The array is later released by the generated stub code, and each element
is ultimately freed using MIDL_user_free.

TowerConstruct always allocate memory using I_RpcAllocate, we must use
I_RpcFree to free it.
2022-11-23 17:59:47 +01:00
Alex Henrie dab61cdcd1 explorer: Put the calling convention inside the function pointer parentheses.
As required by MSVC.
2022-11-22 18:27:30 +01:00
Zhiyi Zhang 8459a5272a explorer: Use a valid taskbar position when the taskbar is hidden.
Some applications use FindWindowA() with class Shell_TrayWnd to find the taskbar window on Windows.
Then GetWindowRect() is called to get the taskbar window rectangle. Finally, the taskbar window
rectangle is subtracted from the primary screen rectangle to calculate the work area. Without a
valid taskbar window position, these applications end up getting an incorrect work area and going
down the wrong path. So use the same position and size as the host system panel for explorer taskbar
when it's hidden.
2022-11-17 10:00:24 +01:00
Zhiyi Zhang b6818e2c20 explorer/tests: Add taskbar tests. 2022-11-17 10:00:24 +01:00
Eric Pouech 8f1febc430 cmd: Don't write outside of variable array.
GCC 12.2 rightfully complains about an out-of-founds array access.
This can possibly happen for unsupported variable names.

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-11-14 13:13:02 +01:00
Eric Pouech 41221452c8 winedbg: Don't use invalid address mode in exception prolog.
Removes a GCC 12.2 warning about printing NULL string.

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-11-14 13:13:02 +01:00