system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-09-30 04:48:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

winhlp32: Fix memory leak on realloc failure in HLPFILE_RtfAddBitmap (cppcheck).

Browse source
This commit is contained in:
Alex Henrie 2023-02-06 22:26:56 -07:00 committed by Alexandre Julliard
parent e1f45229db
commit a6f3e4ad22
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
programs/winhlp32/hlpfile.c
View file

@ -966,6 +966,7 @@ static BOOL HLPFILE_RtfAddBitmap(struct RtfData* rd, HLPFILE* file, const BYTE*
const BYTE* pict_beg;
BYTE* alloc = NULL;
BITMAPINFO* bi;
BITMAPINFO* new_bi;
ULONG off, csz;
unsigned nc = 0;
BOOL clrImportant = FALSE;
@ -1013,8 +1014,13 @@ static BOOL HLPFILE_RtfAddBitmap(struct RtfData* rd, HLPFILE* file, const BYTE*
if (!nc && bi->bmiHeader.biBitCount <= 8)
nc = 1 << bi->bmiHeader.biBitCount;
bi = realloc(bi, sizeof(*bi) + nc * sizeof(RGBQUAD));
if (!bi) return FALSE;
new_bi = realloc(bi, sizeof(*bi) + nc * sizeof(RGBQUAD));
if (!new_bi)
{
free(bi);
return FALSE;
}
bi = new_bi;
for (i = 0; i < nc; i++)
{
bi->bmiColors[i].rgbBlue = ptr[0];