system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-10-04 19:48:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

server: Enforce a mapping size limit instead of relying on the Unix file system.

Browse source 
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55667
This commit is contained in:
Alexandre Julliard 2023-12-15 10:11:22 +01:00
parent 3504f138ec
commit 24f7869e93
2 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
dlls/kernel32/tests/file.c
View file

@ -3105,6 +3105,7 @@ static void test_MapFile(void)
{
HANDLE handle;
HANDLE hmap;
UINT err;
ok(test_Mapfile_createtemp(&handle), "Couldn't create test file.\n");
@ -3123,15 +3124,17 @@ static void test_MapFile(void)
ok(test_Mapfile_createtemp(&handle), "Couldn't create test file.\n");
SetLastError( 0xdeadbeef );
hmap = CreateFileMappingA( handle, NULL, PAGE_READWRITE, 0, 0, NULL );
err = GetLastError();
ok( hmap == NULL, "mapped zero size file\n");
ok( GetLastError() == ERROR_FILE_INVALID, "not ERROR_FILE_INVALID\n");
ok( err == ERROR_FILE_INVALID, "got %u\n", err );
hmap = CreateFileMappingA( handle, NULL, PAGE_READWRITE, 0x80000, 0, NULL );
ok( hmap == NULL, "mapping should fail\n");
hmap = CreateFileMappingA( handle, NULL, PAGE_READWRITE, 0x80000, 0x10000, NULL );
SetLastError( 0xdeadbeef );
hmap = CreateFileMappingA( handle, NULL, PAGE_READWRITE, 0x8000000, 0x10000, NULL );
err = GetLastError();
ok( hmap == NULL, "mapping should fail\n");
ok( err == ERROR_NOT_ENOUGH_MEMORY || err == ERROR_INVALID_PARAMETER, "got %u\n", err );
/* On XP you can now map again, on Win 95 you cannot. */

2
server/mapping.c
View file

@ -993,7 +993,7 @@ static struct mapping *create_mapping( struct object *root, const struct unicode
}
else if (st.st_size < mapping->size)
{
if (!(file_access & FILE_WRITE_DATA))
if (!(file_access & FILE_WRITE_DATA) || mapping->size >> 54 /* ntfs limit */)
{
set_error( STATUS_SECTION_TOO_BIG );
goto error;