system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-07-19 03:45:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

kerberos: Fix memory leaks in (wow64_)query_ticket_cache (scan-build).

Browse source
This commit is contained in:
Alex Henrie 2023-06-05 23:26:24 -06:00 committed by Alexandre Julliard
parent 9e3f1a1506
commit 025e9a0183
1 changed files with 15 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
dlls/kerberos/unixlib.c
View file

@ -339,22 +339,30 @@ done:
return status;
}
static void free_tickets_in_list( struct ticket_list *list )
{
ULONG i;
for (i = 0; i < list->count; i++)
{
free( list->tickets[i].RealmName.Buffer );
free( list->tickets[i].ServerName.Buffer );
}
free( list->tickets );
}
static NTSTATUS query_ticket_cache( void *args )
{
struct query_ticket_cache_params *params = args;
struct ticket_list list = { 0 };
NTSTATUS status;
ULONG i;
status = kerberos_fill_ticket_list( &list );
if (status == STATUS_SUCCESS) status = copy_tickets_to_client( &list, params->resp, params->out_size );
for (i = 0; i < list.count; i++)
{
free( list.tickets[i].RealmName.Buffer );
free( list.tickets[i].ServerName.Buffer );
}
free_tickets_in_list( &list );
return status;
}
@ -1237,17 +1245,12 @@ static NTSTATUS wow64_query_ticket_cache( void *args )
} const *params32 = args;
struct ticket_list list = { 0 };
NTSTATUS status;
ULONG i;
status = kerberos_fill_ticket_list( &list );
if (status == STATUS_SUCCESS)
status = copy_tickets_to_client32( &list, ULongToPtr(params32->resp), ULongToPtr(params32->out_size) );
for (i = 0; i < list.count; i++)
{
free( list.tickets[i].RealmName.Buffer );
free( list.tickets[i].ServerName.Buffer );
}
free_tickets_in_list( &list );
return status;
}