system/wine
system/wine
1
0
Fork 0
mirror of https://github.com/wine-mirror/wine synced 2024-07-08 03:45:57 +00:00
Code Issues Projects Releases Wiki Activity

wineusb: Fix memory leaks on error paths in usb_submit_urb (scan-build).

Browse Source
This commit is contained in:
Alex Henrie 2023-06-06 00:02:12 -06:00 committed by Alexandre Julliard
parent dcb123fac8
commit 9e3f1a1506
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
dlls/wineusb.sys/unixlib.c
View File

@ -449,7 +449,10 @@ static NTSTATUS usb_submit_urb(void *args)
transfer_ctx->transfer_buffer = params->transfer_buffer;
if (!(transfer = libusb_alloc_transfer(0)))
{
free(transfer_ctx);
return STATUS_NO_MEMORY;
}
irp->Tail.Overlay.DriverContext[0] = transfer;
if (pipe.type == UsbdPipeTypeBulk)
@ -465,6 +468,7 @@ static NTSTATUS usb_submit_urb(void *args)
else
{
WARN("Invalid pipe type %#x.\n", pipe.type);
free(transfer_ctx);
libusb_free_transfer(transfer);
return USBD_STATUS_INVALID_PIPE_HANDLE;
}
@ -489,11 +493,15 @@ static NTSTATUS usb_submit_urb(void *args)
transfer_ctx->transfer_buffer = params->transfer_buffer;
if (!(transfer = libusb_alloc_transfer(0)))
{
free(transfer_ctx);
return STATUS_NO_MEMORY;
}
irp->Tail.Overlay.DriverContext[0] = transfer;
if (!(buffer = malloc(sizeof(struct libusb_control_setup) + req->TransferBufferLength)))
{
free(transfer_ctx);
libusb_free_transfer(transfer);
return STATUS_NO_MEMORY;
}
@ -549,11 +557,15 @@ static NTSTATUS usb_submit_urb(void *args)
FIXME("Unhandled flags %#x.\n", (int)req->TransferFlags);
if (!(transfer = libusb_alloc_transfer(0)))
{
free(transfer_ctx);
return STATUS_NO_MEMORY;
}
irp->Tail.Overlay.DriverContext[0] = transfer;
if (!(buffer = malloc(sizeof(struct libusb_control_setup) + req->TransferBufferLength)))
{
free(transfer_ctx);
libusb_free_transfer(transfer);
return STATUS_NO_MEMORY;
}