Mike Yuan
3760416ee8
shared/async: use safe_close where appropriate
2023-12-28 18:26:52 +08:00
Mike Yuan
1cbd441b09
fdset: use FOREACH_ARRAY at one more place
2023-12-28 18:26:52 +08:00
Mike Yuan
1276e63370
fd-util: modernization
2023-12-28 18:26:52 +08:00
Chris Simons
9ef362bf3d
machinectl: add restart
convenience alias ( #30625 )
2023-12-28 07:09:42 +09:00
Yu Watanabe
1a4b0459f6
network/address: unconditionally check if address is ready
...
Previously, we checked if the address is ready only when it is an IPv6
address. But, IPv4 address never enter tentative state, hence the check
for an IPv4 address is effectively equivalent to the one for IPv6.
So, let's unify the check. This does not change any effective behavior.
2023-12-28 07:08:37 +09:00
Yu Watanabe
3a30d81238
Merge pull request #30643 from bluca/completion
...
bash completion additions for systemctl/systemd-analyze
2023-12-28 04:10:20 +09:00
Yu Watanabe
9e7cd6bed1
Merge pull request #30641 from YHNdnzj/hibernation-device
...
Follow-ups for hibernate-util
2023-12-28 04:09:55 +09:00
Yu Watanabe
f1f494f3f8
Merge pull request #30634 from dtardon/docbook-valid-3
...
DocBook validation fixes (part 3)
2023-12-28 04:06:57 +09:00
Luca Boccassi
cfb912abaf
bash completion: add systemd-analyze architectures
...
Follow-up for fb8cc599ed
2023-12-27 17:52:06 +01:00
Luca Boccassi
5df839e99f
analyze: allow --no-legend with architectures verb
...
It prints a table with a header, allow omitting it
Follow-up for fb8cc599ed
2023-12-27 17:50:07 +01:00
Luca Boccassi
c24c63e946
bash completion: make systemctl mount-image/bind autocomplete on active services
...
The verb works only on running service units, so complete on that as the first
parameter, and a local file as the second. The other parameters are inside the
service namespace so we can't autocomplete from the outside, return early.
2023-12-27 17:48:05 +01:00
Luca Boccassi
79272d3098
bash completion: add systemctl service-log-level/target
2023-12-27 16:59:03 +01:00
Mike Yuan
fe33920c2a
sleep: don't log duplicate error
...
write_resume_config() logs error on its own.
2023-12-27 22:38:43 +08:00
Mike Yuan
6e819bd2bd
hibernate-util: remove unused code
...
All callers of write_resume_config() pass non-NULL device.
2023-12-27 22:38:42 +08:00
Mike Yuan
66b9956082
hibernate-util: make sure we use blockdev path for HibernationDevice.path
...
Before this commit, this field could spuriously contain the path of the
swapfile.
2023-12-27 22:38:42 +08:00
Yu Watanabe
51dfa75c6e
Merge pull request #30639 from mrc0mmand/more-cocci-shenanigans
...
Another batch of Coccinelle tweaks
2023-12-27 20:33:46 +09:00
Frantisek Sumsal
321e64dc67
tpm2-util: declare the cleanup attribute first
...
As we do everywhere else (apart from it being incosistent, the switched
order also makes Coccinelle unhappy).
2023-12-27 11:15:48 +01:00
Frantisek Sumsal
8f07111aa8
bootctl: add a missing space
2023-12-27 11:15:48 +01:00
Frantisek Sumsal
b8e0dd3939
test: use timestamp_is_set()
2023-12-27 11:15:48 +01:00
Frantisek Sumsal
cfae9ec203
test: use set_isempty() in one more place
2023-12-27 11:15:48 +01:00
Frantisek Sumsal
6f8b3838c9
test: use IN_SET()/ERRNO_IS_NEG_*() more
2023-12-27 11:15:48 +01:00
Frantisek Sumsal
c83f4220a1
tree-wide: use IN_SET() more
2023-12-27 11:15:48 +01:00
Frantisek Sumsal
c633361f06
coccinelle: dial back warnings about performance
...
Turns out I _really_ underestimated the impact of
--include-headers-for-types, as it significantly reduces both runtime
and storage penalties. For example, on my machine the runtime of
uncached run goes down from ~15 minutes to ~2 minutes, and similarly the
total storage needed by the cache goes from ~15 GiB down to ~3 GiB.
2023-12-27 11:15:48 +01:00
Frantisek Sumsal
b25d3b36a2
coccinelle: help Coccinelle with some more complex macros
...
Drop the original macro file, since it's not needed anymore thanks to
resolving includes properly, but introduce a similar file -
parsing_hacks.h - that helps Coccinelle in some specific corner cases.
This eliminates most of the outstanding parsing errors in source files.
The remaining ones are limitations of the parsing engine (see the FIXMEs
in pasing_hacks.h) and need further investigation.
2023-12-27 11:15:48 +01:00
Frantisek Sumsal
11959eb201
coccinelle: search the system include path for header files as well
...
Since Coccinelle is originally a kernel tool, it doesn't search the
system include path by default for header files. Without this we're
missing a lot of types provides by stdlib (and other libraries we make
use of).
2023-12-27 11:15:44 +01:00
Luca Boccassi
74ce6bbdee
Merge pull request #30631 from yuwata/network-address-free
...
network/address: tiny cleanups for address_free()
2023-12-26 19:21:15 +01:00
Mike Yuan
e14348c616
sleep: connect to correct bus when locking homed-managed homes
...
Partially reverts 122f6f1eaa
Fixes https://github.com/systemd/systemd/issues/29938#issuecomment-1869508708
2023-12-26 18:53:03 +01:00
David Tardon
af29d0b179
man: rewrite as <group>
2023-12-26 13:10:36 +01:00
David Tardon
0fd5f9fb50
man: fix markup
...
<arg> is not allowed inside <title>.
2023-12-26 13:10:36 +01:00
David Tardon
7f9d96d4c5
man: move </variablelist> to the right place
2023-12-26 13:10:35 +01:00
David Tardon
b239fc7250
man: fix <cmdsynopsis> content
...
Inline text is not allowed.
2023-12-26 13:10:35 +01:00
David Tardon
20dcd73a28
man: fix markup
...
<option> is not allowed in <cmdsynopsis>.
2023-12-26 13:10:35 +01:00
David Tardon
dfa6c32ad9
man: restrict <command> to the actual command
2023-12-26 13:10:35 +01:00
David Tardon
996de3397b
man: move macro decls. out of <funcsynopsis>
...
<funcsynopsis> doesn't allow block content.
2023-12-26 13:10:35 +01:00
David Tardon
932abebf4d
man: fix markup
...
<arg> is not allowed inside <term>.
2023-12-26 13:10:35 +01:00
Frantisek Sumsal
4d3510d00f
coccinelle: explicitly undefine SD_BOOT
...
So Coccinelle doesn't pull in includes guarded by #if SD_BOOT.
For example:
$ head -n5 main.c
#if FOO
#include "foo.h"
#else
#include "bar.h"
#endif
$ spatch --verbose-includes --recursive-includes --sp-file zz-drop-braces.cocci main.c
init_defs_builtins: /usr/lib64/coccinelle/standard.h
HANDLING: main.c
including ./foo.h
including ./bar.h
$ spatch --verbose-includes --recursive-includes --sp-file zz-drop-braces.cocci main.c --undefined FOO
init_defs_builtins: /usr/lib64/coccinelle/standard.h
HANDLING: main.c
including ./bar.h
2023-12-26 11:23:19 +01:00
David Tardon
b3579feb59
man: fix indentation
2023-12-26 08:59:53 +01:00
Yu Watanabe
5a4631bd8f
coccinelle: fix typo
2023-12-26 09:43:21 +09:00
Stuart Hayhurst
5fd55b2c26
hwdb: Add override for headset form-factor for the Corsair Void Elite
...
Earlier versions of the headset had 'Headset' in the product name.
This version uses 'Dongle' instead, so it doesn't get given a form-factor.
2023-12-26 06:04:47 +09:00
Yu Watanabe
fe3fcb9492
Merge pull request #30633 from mrc0mmand/cocci-shenanigans
...
coccinelle: rework how we run the Coccinelle transformations
2023-12-26 05:45:58 +09:00
Frantisek Sumsal
8451e720d8
systemctl: use SYNTHETIC_ERRNO()
2023-12-25 19:51:43 +01:00
Frantisek Sumsal
0b3c270896
modules-load: simplify OOM check
2023-12-25 18:26:59 +01:00
Frantisek Sumsal
f2d0e2e5f5
sd-bus: drop unnecessary braces
2023-12-25 18:26:59 +01:00
Frantisek Sumsal
50f605bfe6
network: use timestamp_is_set() in one more place
2023-12-25 18:26:59 +01:00
Frantisek Sumsal
78bc04cf12
tree-wide: use strndupa_safe() in a couple more cases
2023-12-25 18:26:59 +01:00
Frantisek Sumsal
34e2897f51
nspawn: log & return in a single statement
2023-12-25 18:26:59 +01:00
Frantisek Sumsal
c490b6ddc2
tree-wide: use IOVEC_MAKE() in a couple more places
2023-12-25 18:26:59 +01:00
Frantisek Sumsal
dd1b1dae7e
test: use FLAGS_SET() in one more place
2023-12-25 18:26:59 +01:00
Frantisek Sumsal
cd1c510f0c
test: use ERRNO_IS_NEG_NOT_SUPPORTED() in one more place
2023-12-25 18:26:59 +01:00
Frantisek Sumsal
6f7936cf57
killall: fix errno check
2023-12-25 18:26:59 +01:00