system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-22 02:26:11 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

DevTools: Use default constructors/destructors

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-02-15 13:28:01 -07:00 committed by Tim Flynn
parent 84f87a9f76
commit 7070713ec8
50 changed files with 75 additions and 122 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Userland/DevTools/HackStudio/CodeDocument.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2020, Itamar S. <itamar8910@gmail.com>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -32,8 +33,4 @@ CodeDocument::CodeDocument(Client* client)
{
}
CodeDocument::~CodeDocument()
{
}
}

3
Userland/DevTools/HackStudio/CodeDocument.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2020, Itamar S. <itamar8910@gmail.com>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -14,7 +15,7 @@ namespace HackStudio {
class CodeDocument final : public GUI::TextDocument {
public:
virtual ~CodeDocument() override;
virtual ~CodeDocument() override = default;
static NonnullRefPtr<CodeDocument> create(const String& file_path, Client* client = nullptr);
static NonnullRefPtr<CodeDocument> create(Client* client = nullptr);

5
Userland/DevTools/HackStudio/Debugger/DebuggerVariableJSObject.cpp
View file

@ -1,6 +1,7 @@
/*
* Copyright (c) 2021, Matthew Olsson <matthewcolsson@gmail.com>
* Copyright (c) 2021, Hunter Salyer <thefalsehonesty@gmail.com>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -25,10 +26,6 @@ DebuggerVariableJSObject::DebuggerVariableJSObject(const Debug::DebugInfo::Varia
{
}
DebuggerVariableJSObject::~DebuggerVariableJSObject()
{
}
JS::ThrowCompletionOr<bool> DebuggerVariableJSObject::internal_set(const JS::PropertyKey& property_key, JS::Value value, JS::Value)
{
auto& vm = this->vm();

3
Userland/DevTools/HackStudio/Debugger/DebuggerVariableJSObject.h
View file

@ -1,6 +1,7 @@
/*
* Copyright (c) 2021, Matthew Olsson <matthewcolsson@gmail.com>
* Copyright (c) 2021, Hunter Salyer <thefalsehonesty@gmail.com>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -21,7 +22,7 @@ public:
static DebuggerVariableJSObject* create(DebuggerGlobalJSObject&, const Debug::DebugInfo::VariableInfo& variable_info);
DebuggerVariableJSObject(const Debug::DebugInfo::VariableInfo& variable_info, JS::Object& prototype);
virtual ~DebuggerVariableJSObject() override;
virtual ~DebuggerVariableJSObject() override = default;
virtual const char* class_name() const override { return m_variable_info.type_name.characters(); }

5
Userland/DevTools/HackStudio/Debugger/DisassemblyModel.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2020, Luke Wilde <lukew@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -67,10 +68,6 @@ DisassemblyModel::DisassemblyModel(const Debug::DebugSession& debug_session, con
}
}
DisassemblyModel::~DisassemblyModel()
{
}
int DisassemblyModel::row_count(const GUI::ModelIndex&) const
{
return m_instructions.size();

3
Userland/DevTools/HackStudio/Debugger/DisassemblyModel.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2020, Luke Wilde <lukew@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -40,7 +41,7 @@ public:
__Count
};
virtual ~DisassemblyModel() override;
virtual ~DisassemblyModel() override = default;
virtual int row_count(const GUI::ModelIndex& = GUI::ModelIndex()) const override;
virtual int column_count(const GUI::ModelIndex& = GUI::ModelIndex()) const override { return Column::__Count; }

5
Userland/DevTools/HackStudio/Debugger/RegistersModel.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2020, Luke Wilde <lukew@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -93,10 +94,6 @@ RegistersModel::RegistersModel(const PtraceRegisters& current_regs, const Ptrace
m_registers.append({ "gs", current_regs.gs, current_regs.gs != previous_regs.gs });
}
RegistersModel::~RegistersModel()
{
}
int RegistersModel::row_count(const GUI::ModelIndex&) const
{
return m_registers.size();

3
Userland/DevTools/HackStudio/Debugger/RegistersModel.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2020, Luke Wilde <lukew@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -36,7 +37,7 @@ public:
__Count
};
virtual ~RegistersModel() override;
virtual ~RegistersModel() override = default;
virtual int row_count(const GUI::ModelIndex& = GUI::ModelIndex()) const override;
virtual int column_count(const GUI::ModelIndex& = GUI::ModelIndex()) const override { return Column::__Count; }

5
Userland/DevTools/HackStudio/Dialogs/NewProjectDialog.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2021, Nick Vella <nick@nxk.io>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -101,10 +102,6 @@ NewProjectDialog::NewProjectDialog(GUI::Window* parent)
};
}
NewProjectDialog::~NewProjectDialog()
{
}
RefPtr<ProjectTemplate> NewProjectDialog::selected_template()
{
if (m_icon_view->selection().is_empty()) {

3
Userland/DevTools/HackStudio/Dialogs/NewProjectDialog.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2021, Nick Vella <nick@nxk.io>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -27,7 +28,7 @@ public:
private:
NewProjectDialog(GUI::Window* parent);
virtual ~NewProjectDialog() override;
virtual ~NewProjectDialog() override = default;
void update_dialog();
Optional<String> get_available_project_name();

5
Userland/DevTools/HackStudio/Dialogs/ProjectTemplatesModel.cpp
View file

@ -1,6 +1,7 @@
/*
* Copyright (c) 2021, Nick Vella <nick@nxk.io>
* Copyright (c) 2021, sin-ack <sin-ack@protonmail.com>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -42,10 +43,6 @@ ProjectTemplatesModel::ProjectTemplatesModel()
rescan_templates();
}
ProjectTemplatesModel::~ProjectTemplatesModel()
{
}
int ProjectTemplatesModel::row_count(const GUI::ModelIndex&) const
{
return m_mapping.size();

3
Userland/DevTools/HackStudio/Dialogs/ProjectTemplatesModel.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2021, Nick Vella <nick@nxk.io>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -29,7 +30,7 @@ public:
__Count
};
virtual ~ProjectTemplatesModel() override;
virtual ~ProjectTemplatesModel() override = default;
RefPtr<ProjectTemplate> template_for_index(const GUI::ModelIndex& index);

6
Userland/DevTools/HackStudio/Editor.cpp
View file

@ -1,6 +1,6 @@
/*
* Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2018-2021, the SerenityOS developers.
* Copyright (c) 2018-2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -79,10 +79,6 @@ Editor::Editor()
set_gutter_visible(true);
}
Editor::~Editor()
{
}
ErrorOr<void> Editor::initialize_documentation_tooltip()
{
m_documentation_tooltip_window = GUI::Window::construct();

4
Userland/DevTools/HackStudio/Editor.h
View file

@ -1,7 +1,7 @@
/*
* Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2020-2022, Itamar S. <itamar8910@gmail.com>
* Copyright (c) 2018-2021, the SerenityOS developers.
* Copyright (c) 2018-2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -26,7 +26,7 @@ class Editor final : public GUI::TextEditor {
public:
static ErrorOr<NonnullRefPtr<Editor>> try_create();
virtual ~Editor() override;
virtual ~Editor() override = default;
Function<void()> on_focus;
Function<void(String)> on_open;

5
Userland/DevTools/HackStudio/EditorWrapper.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -48,10 +49,6 @@ EditorWrapper::EditorWrapper()
};
}
EditorWrapper::~EditorWrapper()
{
}
void EditorWrapper::set_editor_has_focus(Badge<Editor>, bool focus)
{
auto& font = Gfx::FontDatabase::default_font();

3
Userland/DevTools/HackStudio/EditorWrapper.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -24,7 +25,7 @@ class EditorWrapper : public GUI::Widget {
C_OBJECT(EditorWrapper)
public:
virtual ~EditorWrapper() override;
virtual ~EditorWrapper() override = default;
Editor& editor() { return *m_editor; }
const Editor& editor() const { return *m_editor; }

5
Userland/DevTools/HackStudio/Git/DiffViewer.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2020, Itamar S. <itamar8910@gmail.com>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -16,10 +17,6 @@
namespace HackStudio {
DiffViewer::~DiffViewer()
{
}
void DiffViewer::paint_event(GUI::PaintEvent& event)
{
GUI::Painter painter(*this);

3
Userland/DevTools/HackStudio/Git/DiffViewer.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2020, Itamar S. <itamar8910@gmail.com>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -15,7 +16,7 @@ namespace HackStudio {
class DiffViewer final : public GUI::AbstractScrollableWidget {
C_OBJECT(DiffViewer)
public:
virtual ~DiffViewer() override;
virtual ~DiffViewer() override = default;
void set_content(const String& original, const String& diff);

4
Userland/DevTools/HackStudio/Git/GitFilesView.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2020, Itamar S. <itamar8910@gmail.com>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -11,9 +12,6 @@
#include <LibGfx/Palette.h>
namespace HackStudio {
GitFilesView::~GitFilesView()
{
}
void GitFilesView::paint_list_item(GUI::Painter& painter, int row_index, int painted_item_index)
{

3
Userland/DevTools/HackStudio/Git/GitFilesView.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2020, Itamar S. <itamar8910@gmail.com>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -17,7 +18,7 @@ using GitFileActionCallback = Function<void(String const& file)>;
class GitFilesView : public GUI::ListView {
C_OBJECT(GitFilesView)
public:
virtual ~GitFilesView() override;
virtual ~GitFilesView() override = default;
protected:
GitFilesView(GitFileActionCallback, NonnullRefPtr<Gfx::Bitmap> action_icon);

2
Userland/DevTools/HackStudio/HackStudioWidget.cpp
View file

@ -1,7 +1,7 @@
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2020, Itamar S. <itamar8910@gmail.com>
* Copyright (c) 2020-2021, the SerenityOS developers.
* Copyright (c) 2020-2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/

5
Userland/DevTools/HackStudio/LanguageServers/ClientConnection.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2020, Itamar S. <itamar8910@gmail.com>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -20,10 +21,6 @@ ClientConnection::ClientConnection(NonnullOwnPtr<Core::Stream::LocalSocket> sock
s_connections.set(1, *this);
}
ClientConnection::~ClientConnection()
{
}
void ClientConnection::die()
{
s_connections.remove(client_id());

3
Userland/DevTools/HackStudio/LanguageServers/ClientConnection.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2020, Itamar S. <itamar8910@gmail.com>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -21,7 +22,7 @@ namespace LanguageServers {
class ClientConnection : public IPC::ClientConnection<LanguageClientEndpoint, LanguageServerEndpoint> {
public:
explicit ClientConnection(NonnullOwnPtr<Core::Stream::LocalSocket>);
~ClientConnection() override;
~ClientConnection() override = default;
virtual void die() override;

4
Userland/DevTools/HackStudio/LanguageServers/CodeComprehensionEngine.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2021, Itamar S. <itamar8910@gmail.com>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -14,9 +15,6 @@ CodeComprehensionEngine::CodeComprehensionEngine(const FileDB& filedb, bool shou
{
}
CodeComprehensionEngine::~CodeComprehensionEngine()
{
}
void CodeComprehensionEngine::set_declarations_of_document(const String& filename, Vector<GUI::AutocompleteProvider::Declaration>&& declarations)
{
// Callback may not be configured if we're running tests

3
Userland/DevTools/HackStudio/LanguageServers/CodeComprehensionEngine.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2021, Itamar S. <itamar8910@gmail.com>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -18,7 +19,7 @@ class ClientConnection;
class CodeComprehensionEngine {
public:
CodeComprehensionEngine(const FileDB& filedb, bool store_all_declarations = false);
virtual ~CodeComprehensionEngine();
virtual ~CodeComprehensionEngine() = default;
virtual Vector<GUI::AutocompleteProvider::Entry> get_suggestions(const String& file, const GUI::TextPosition& autocomplete_position) = 0;

5
Userland/DevTools/HackStudio/Locator.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -157,10 +158,6 @@ Locator::Locator(Core::Object* parent)
};
}
Locator::~Locator()
{
}
void Locator::open_suggestion(const GUI::ModelIndex& index)
{
auto& model = reinterpret_cast<LocatorSuggestionModel&>(*m_suggestion_view->model());

3
Userland/DevTools/HackStudio/Locator.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -14,7 +15,7 @@ namespace HackStudio {
class Locator final : public GUI::Widget {
C_OBJECT(Locator)
public:
virtual ~Locator() override;
virtual ~Locator() override = default;
void open();
void close();

5
Userland/DevTools/HackStudio/TerminalWrapper.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -203,10 +204,6 @@ TerminalWrapper::TerminalWrapper(bool user_spawned)
run_command("Shell");
}
TerminalWrapper::~TerminalWrapper()
{
}
int TerminalWrapper::child_exit_status() const
{
VERIFY(m_child_exit_status.has_value());

3
Userland/DevTools/HackStudio/TerminalWrapper.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -15,7 +16,7 @@ namespace HackStudio {
class TerminalWrapper final : public GUI::Widget {
C_OBJECT(TerminalWrapper)
public:
virtual ~TerminalWrapper() override;
virtual ~TerminalWrapper() override = default;
enum class WaitForExit {
No,
Yes

5
Userland/DevTools/Inspector/RemoteObjectGraphModel.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -22,10 +23,6 @@ RemoteObjectGraphModel::RemoteObjectGraphModel(RemoteProcess& process)
m_timer_icon.set_bitmap_for_size(16, Gfx::Bitmap::try_load_from_file("/res/icons/16x16/timer.png").release_value_but_fixme_should_propagate_errors());
}
RemoteObjectGraphModel::~RemoteObjectGraphModel()
{
}
GUI::ModelIndex RemoteObjectGraphModel::index(int row, int column, const GUI::ModelIndex& parent) const
{
if (!parent.is_valid()) {

3
Userland/DevTools/Inspector/RemoteObjectGraphModel.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -22,7 +23,7 @@ public:
return adopt_ref(*new RemoteObjectGraphModel(process));
}
virtual ~RemoteObjectGraphModel() override;
virtual ~RemoteObjectGraphModel() override = default;
virtual int row_count(const GUI::ModelIndex& = GUI::ModelIndex()) const override;
virtual int column_count(const GUI::ModelIndex& = GUI::ModelIndex()) const override;

5
Userland/DevTools/Profiler/DisassemblyModel.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -122,10 +123,6 @@ DisassemblyModel::DisassemblyModel(Profile& profile, ProfileNode& node)
}
}
DisassemblyModel::~DisassemblyModel()
{
}
int DisassemblyModel::row_count(GUI::ModelIndex const&) const
{
return m_instructions.size();

3
Userland/DevTools/Profiler/DisassemblyModel.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -41,7 +42,7 @@ public:
__Count
};
virtual ~DisassemblyModel() override;
virtual ~DisassemblyModel() override = default;
virtual int row_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override;
virtual int column_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override { return Column::__Count; }

5
Userland/DevTools/Profiler/IndividualSampleModel.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -17,10 +18,6 @@ IndividualSampleModel::IndividualSampleModel(Profile& profile, size_t event_inde
{
}
IndividualSampleModel::~IndividualSampleModel()
{
}
int IndividualSampleModel::row_count(GUI::ModelIndex const&) const
{
auto const& event = m_profile.events().at(m_event_index);

3
Userland/DevTools/Profiler/IndividualSampleModel.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -26,7 +27,7 @@ public:
__Count
};
virtual ~IndividualSampleModel() override;
virtual ~IndividualSampleModel() override = default;
virtual int row_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override;
virtual int column_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override;

5
Userland/DevTools/Profiler/ProfileModel.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -19,10 +20,6 @@ ProfileModel::ProfileModel(Profile& profile)
m_kernel_frame_icon.set_bitmap_for_size(16, Gfx::Bitmap::try_load_from_file("/res/icons/16x16/inspector-object-red.png").release_value_but_fixme_should_propagate_errors());
}
ProfileModel::~ProfileModel()
{
}
GUI::ModelIndex ProfileModel::index(int row, int column, GUI::ModelIndex const& parent) const
{
if (!parent.is_valid()) {

3
Userland/DevTools/Profiler/ProfileModel.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -28,7 +29,7 @@ public:
__Count
};
virtual ~ProfileModel() override;
virtual ~ProfileModel() override = default;
virtual int row_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override;
virtual int column_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override;

5
Userland/DevTools/Profiler/SamplesModel.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -17,10 +18,6 @@ SamplesModel::SamplesModel(Profile& profile)
m_kernel_frame_icon.set_bitmap_for_size(16, Gfx::Bitmap::try_load_from_file("/res/icons/16x16/inspector-object-red.png").release_value_but_fixme_should_propagate_errors());
}
SamplesModel::~SamplesModel()
{
}
int SamplesModel::row_count(GUI::ModelIndex const&) const
{
return m_profile.filtered_event_indices().size();

3
Userland/DevTools/Profiler/SamplesModel.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -31,7 +32,7 @@ public:
__Count
};
virtual ~SamplesModel() override;
virtual ~SamplesModel() override = default;
virtual int row_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override;
virtual int column_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override;

5
Userland/DevTools/Profiler/SignpostsModel.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -15,10 +16,6 @@ SignpostsModel::SignpostsModel(Profile& profile)
{
}
SignpostsModel::~SignpostsModel()
{
}
int SignpostsModel::row_count(GUI::ModelIndex const&) const
{
return m_profile.filtered_signpost_indices().size();

3
Userland/DevTools/Profiler/SignpostsModel.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -30,7 +31,7 @@ public:
__Count
};
virtual ~SignpostsModel() override;
virtual ~SignpostsModel() override = default;
virtual int row_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override;
virtual int column_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override;

5
Userland/DevTools/Profiler/TimelineContainer.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -31,10 +32,6 @@ TimelineContainer::TimelineContainer(GUI::Widget& header_container, TimelineView
};
}
TimelineContainer::~TimelineContainer()
{
}
void TimelineContainer::did_scroll()
{
AbstractScrollableWidget::did_scroll();

3
Userland/DevTools/Profiler/TimelineContainer.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -16,7 +17,7 @@ class TimelineContainer : public GUI::AbstractScrollableWidget {
C_OBJECT(TimelineContainer);
public:
virtual ~TimelineContainer();
virtual ~TimelineContainer() override = default;
protected:
virtual void did_scroll() override;

5
Userland/DevTools/Profiler/TimelineHeader.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -27,10 +28,6 @@ TimelineHeader::TimelineHeader(Profile& profile, Process const& process)
m_text = String::formatted("{} ({})", LexicalPath::basename(m_process.executable), m_process.pid);
}
TimelineHeader::~TimelineHeader()
{
}
void TimelineHeader::paint_event(GUI::PaintEvent& event)
{
GUI::Frame::paint_event(event);

3
Userland/DevTools/Profiler/TimelineHeader.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -17,7 +18,7 @@ class TimelineHeader final : public GUI::Frame {
C_OBJECT(TimelineHeader);
public:
virtual ~TimelineHeader();
virtual ~TimelineHeader() override = default;
Function<void(bool)> on_selection_change;

5
Userland/DevTools/Profiler/TimelineTrack.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -25,10 +26,6 @@ TimelineTrack::TimelineTrack(TimelineView const& view, Profile const& profile, P
set_frame_thickness(1);
}
TimelineTrack::~TimelineTrack()
{
}
void TimelineTrack::set_scale(float scale)
{
set_fixed_width(m_profile.length_in_ms() / scale);

3
Userland/DevTools/Profiler/TimelineTrack.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -19,7 +20,7 @@ class TimelineTrack final : public GUI::Frame {
C_OBJECT(TimelineTrack);
public:
virtual ~TimelineTrack() override;
virtual ~TimelineTrack() override = default;
void set_scale(float);

5
Userland/DevTools/Profiler/TimelineView.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -18,10 +19,6 @@ TimelineView::TimelineView(Profile& profile)
set_shrink_to_fit(true);
}
TimelineView::~TimelineView()
{
}
u64 TimelineView::timestamp_at_x(int x) const
{
float column_width = (float)width() / (float)m_profile.length_in_ms();

3
Userland/DevTools/Profiler/TimelineView.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -17,7 +18,7 @@ class TimelineView final : public GUI::Widget {
C_OBJECT(TimelineView);
public:
virtual ~TimelineView() override;
virtual ~TimelineView() override = default;
Function<void()> on_selection_change;
Function<void()> on_scale_change;

3
Userland/DevTools/UserspaceEmulator/Region.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -18,7 +19,7 @@ class Emulator;
class Region {
public:
virtual ~Region() { }
virtual ~Region() = default;
const Range& range() const { return m_range; }