From 7070713ec82675cd8ac0c6a86e6259d3543f60c4 Mon Sep 17 00:00:00 2001 From: Lenny Maiorani Date: Tue, 15 Feb 2022 13:28:01 -0700 Subject: [PATCH] DevTools: Use default constructors/destructors https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules "The compiler is more likely to get the default semantics right and you cannot implement these functions better than the compiler." --- Userland/DevTools/HackStudio/CodeDocument.cpp | 5 +---- Userland/DevTools/HackStudio/CodeDocument.h | 3 ++- .../HackStudio/Debugger/DebuggerVariableJSObject.cpp | 5 +---- .../DevTools/HackStudio/Debugger/DebuggerVariableJSObject.h | 3 ++- Userland/DevTools/HackStudio/Debugger/DisassemblyModel.cpp | 5 +---- Userland/DevTools/HackStudio/Debugger/DisassemblyModel.h | 3 ++- Userland/DevTools/HackStudio/Debugger/RegistersModel.cpp | 5 +---- Userland/DevTools/HackStudio/Debugger/RegistersModel.h | 3 ++- Userland/DevTools/HackStudio/Dialogs/NewProjectDialog.cpp | 5 +---- Userland/DevTools/HackStudio/Dialogs/NewProjectDialog.h | 3 ++- .../DevTools/HackStudio/Dialogs/ProjectTemplatesModel.cpp | 5 +---- .../DevTools/HackStudio/Dialogs/ProjectTemplatesModel.h | 3 ++- Userland/DevTools/HackStudio/Editor.cpp | 6 +----- Userland/DevTools/HackStudio/Editor.h | 4 ++-- Userland/DevTools/HackStudio/EditorWrapper.cpp | 5 +---- Userland/DevTools/HackStudio/EditorWrapper.h | 3 ++- Userland/DevTools/HackStudio/Git/DiffViewer.cpp | 5 +---- Userland/DevTools/HackStudio/Git/DiffViewer.h | 3 ++- Userland/DevTools/HackStudio/Git/GitFilesView.cpp | 4 +--- Userland/DevTools/HackStudio/Git/GitFilesView.h | 3 ++- Userland/DevTools/HackStudio/HackStudioWidget.cpp | 2 +- .../HackStudio/LanguageServers/ClientConnection.cpp | 5 +---- .../DevTools/HackStudio/LanguageServers/ClientConnection.h | 3 ++- .../HackStudio/LanguageServers/CodeComprehensionEngine.cpp | 4 +--- .../HackStudio/LanguageServers/CodeComprehensionEngine.h | 3 ++- Userland/DevTools/HackStudio/Locator.cpp | 5 +---- Userland/DevTools/HackStudio/Locator.h | 3 ++- Userland/DevTools/HackStudio/TerminalWrapper.cpp | 5 +---- Userland/DevTools/HackStudio/TerminalWrapper.h | 3 ++- Userland/DevTools/Inspector/RemoteObjectGraphModel.cpp | 5 +---- Userland/DevTools/Inspector/RemoteObjectGraphModel.h | 3 ++- Userland/DevTools/Profiler/DisassemblyModel.cpp | 5 +---- Userland/DevTools/Profiler/DisassemblyModel.h | 3 ++- Userland/DevTools/Profiler/IndividualSampleModel.cpp | 5 +---- Userland/DevTools/Profiler/IndividualSampleModel.h | 3 ++- Userland/DevTools/Profiler/ProfileModel.cpp | 5 +---- Userland/DevTools/Profiler/ProfileModel.h | 3 ++- Userland/DevTools/Profiler/SamplesModel.cpp | 5 +---- Userland/DevTools/Profiler/SamplesModel.h | 3 ++- Userland/DevTools/Profiler/SignpostsModel.cpp | 5 +---- Userland/DevTools/Profiler/SignpostsModel.h | 3 ++- Userland/DevTools/Profiler/TimelineContainer.cpp | 5 +---- Userland/DevTools/Profiler/TimelineContainer.h | 3 ++- Userland/DevTools/Profiler/TimelineHeader.cpp | 5 +---- Userland/DevTools/Profiler/TimelineHeader.h | 3 ++- Userland/DevTools/Profiler/TimelineTrack.cpp | 5 +---- Userland/DevTools/Profiler/TimelineTrack.h | 3 ++- Userland/DevTools/Profiler/TimelineView.cpp | 5 +---- Userland/DevTools/Profiler/TimelineView.h | 3 ++- Userland/DevTools/UserspaceEmulator/Region.h | 3 ++- 50 files changed, 75 insertions(+), 122 deletions(-) diff --git a/Userland/DevTools/HackStudio/CodeDocument.cpp b/Userland/DevTools/HackStudio/CodeDocument.cpp index c0f747ebf2..a8605c24a0 100644 --- a/Userland/DevTools/HackStudio/CodeDocument.cpp +++ b/Userland/DevTools/HackStudio/CodeDocument.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Itamar S. + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -32,8 +33,4 @@ CodeDocument::CodeDocument(Client* client) { } -CodeDocument::~CodeDocument() -{ -} - } diff --git a/Userland/DevTools/HackStudio/CodeDocument.h b/Userland/DevTools/HackStudio/CodeDocument.h index 37167cd8e9..70a066f4b4 100644 --- a/Userland/DevTools/HackStudio/CodeDocument.h +++ b/Userland/DevTools/HackStudio/CodeDocument.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Itamar S. + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -14,7 +15,7 @@ namespace HackStudio { class CodeDocument final : public GUI::TextDocument { public: - virtual ~CodeDocument() override; + virtual ~CodeDocument() override = default; static NonnullRefPtr create(const String& file_path, Client* client = nullptr); static NonnullRefPtr create(Client* client = nullptr); diff --git a/Userland/DevTools/HackStudio/Debugger/DebuggerVariableJSObject.cpp b/Userland/DevTools/HackStudio/Debugger/DebuggerVariableJSObject.cpp index 49c8b86896..063f1fd4cb 100644 --- a/Userland/DevTools/HackStudio/Debugger/DebuggerVariableJSObject.cpp +++ b/Userland/DevTools/HackStudio/Debugger/DebuggerVariableJSObject.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2021, Matthew Olsson * Copyright (c) 2021, Hunter Salyer + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -25,10 +26,6 @@ DebuggerVariableJSObject::DebuggerVariableJSObject(const Debug::DebugInfo::Varia { } -DebuggerVariableJSObject::~DebuggerVariableJSObject() -{ -} - JS::ThrowCompletionOr DebuggerVariableJSObject::internal_set(const JS::PropertyKey& property_key, JS::Value value, JS::Value) { auto& vm = this->vm(); diff --git a/Userland/DevTools/HackStudio/Debugger/DebuggerVariableJSObject.h b/Userland/DevTools/HackStudio/Debugger/DebuggerVariableJSObject.h index 2d88074313..817d014c0d 100644 --- a/Userland/DevTools/HackStudio/Debugger/DebuggerVariableJSObject.h +++ b/Userland/DevTools/HackStudio/Debugger/DebuggerVariableJSObject.h @@ -1,6 +1,7 @@ /* * Copyright (c) 2021, Matthew Olsson * Copyright (c) 2021, Hunter Salyer + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -21,7 +22,7 @@ public: static DebuggerVariableJSObject* create(DebuggerGlobalJSObject&, const Debug::DebugInfo::VariableInfo& variable_info); DebuggerVariableJSObject(const Debug::DebugInfo::VariableInfo& variable_info, JS::Object& prototype); - virtual ~DebuggerVariableJSObject() override; + virtual ~DebuggerVariableJSObject() override = default; virtual const char* class_name() const override { return m_variable_info.type_name.characters(); } diff --git a/Userland/DevTools/HackStudio/Debugger/DisassemblyModel.cpp b/Userland/DevTools/HackStudio/Debugger/DisassemblyModel.cpp index e98c7f5d71..22d99180fd 100644 --- a/Userland/DevTools/HackStudio/Debugger/DisassemblyModel.cpp +++ b/Userland/DevTools/HackStudio/Debugger/DisassemblyModel.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Luke Wilde + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -67,10 +68,6 @@ DisassemblyModel::DisassemblyModel(const Debug::DebugSession& debug_session, con } } -DisassemblyModel::~DisassemblyModel() -{ -} - int DisassemblyModel::row_count(const GUI::ModelIndex&) const { return m_instructions.size(); diff --git a/Userland/DevTools/HackStudio/Debugger/DisassemblyModel.h b/Userland/DevTools/HackStudio/Debugger/DisassemblyModel.h index a188951c17..6daaea3cc2 100644 --- a/Userland/DevTools/HackStudio/Debugger/DisassemblyModel.h +++ b/Userland/DevTools/HackStudio/Debugger/DisassemblyModel.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Luke Wilde + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -40,7 +41,7 @@ public: __Count }; - virtual ~DisassemblyModel() override; + virtual ~DisassemblyModel() override = default; virtual int row_count(const GUI::ModelIndex& = GUI::ModelIndex()) const override; virtual int column_count(const GUI::ModelIndex& = GUI::ModelIndex()) const override { return Column::__Count; } diff --git a/Userland/DevTools/HackStudio/Debugger/RegistersModel.cpp b/Userland/DevTools/HackStudio/Debugger/RegistersModel.cpp index ef00f1eba6..3bac9fce93 100644 --- a/Userland/DevTools/HackStudio/Debugger/RegistersModel.cpp +++ b/Userland/DevTools/HackStudio/Debugger/RegistersModel.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Luke Wilde + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -93,10 +94,6 @@ RegistersModel::RegistersModel(const PtraceRegisters& current_regs, const Ptrace m_registers.append({ "gs", current_regs.gs, current_regs.gs != previous_regs.gs }); } -RegistersModel::~RegistersModel() -{ -} - int RegistersModel::row_count(const GUI::ModelIndex&) const { return m_registers.size(); diff --git a/Userland/DevTools/HackStudio/Debugger/RegistersModel.h b/Userland/DevTools/HackStudio/Debugger/RegistersModel.h index 86cd07a9f0..91651e798a 100644 --- a/Userland/DevTools/HackStudio/Debugger/RegistersModel.h +++ b/Userland/DevTools/HackStudio/Debugger/RegistersModel.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Luke Wilde + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -36,7 +37,7 @@ public: __Count }; - virtual ~RegistersModel() override; + virtual ~RegistersModel() override = default; virtual int row_count(const GUI::ModelIndex& = GUI::ModelIndex()) const override; virtual int column_count(const GUI::ModelIndex& = GUI::ModelIndex()) const override { return Column::__Count; } diff --git a/Userland/DevTools/HackStudio/Dialogs/NewProjectDialog.cpp b/Userland/DevTools/HackStudio/Dialogs/NewProjectDialog.cpp index 24af69e911..36d67f5e8f 100644 --- a/Userland/DevTools/HackStudio/Dialogs/NewProjectDialog.cpp +++ b/Userland/DevTools/HackStudio/Dialogs/NewProjectDialog.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Nick Vella + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -101,10 +102,6 @@ NewProjectDialog::NewProjectDialog(GUI::Window* parent) }; } -NewProjectDialog::~NewProjectDialog() -{ -} - RefPtr NewProjectDialog::selected_template() { if (m_icon_view->selection().is_empty()) { diff --git a/Userland/DevTools/HackStudio/Dialogs/NewProjectDialog.h b/Userland/DevTools/HackStudio/Dialogs/NewProjectDialog.h index a4edd3459a..1503e36186 100644 --- a/Userland/DevTools/HackStudio/Dialogs/NewProjectDialog.h +++ b/Userland/DevTools/HackStudio/Dialogs/NewProjectDialog.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Nick Vella + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -27,7 +28,7 @@ public: private: NewProjectDialog(GUI::Window* parent); - virtual ~NewProjectDialog() override; + virtual ~NewProjectDialog() override = default; void update_dialog(); Optional get_available_project_name(); diff --git a/Userland/DevTools/HackStudio/Dialogs/ProjectTemplatesModel.cpp b/Userland/DevTools/HackStudio/Dialogs/ProjectTemplatesModel.cpp index f9f7a4481e..5f9c61608d 100644 --- a/Userland/DevTools/HackStudio/Dialogs/ProjectTemplatesModel.cpp +++ b/Userland/DevTools/HackStudio/Dialogs/ProjectTemplatesModel.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2021, Nick Vella * Copyright (c) 2021, sin-ack + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -42,10 +43,6 @@ ProjectTemplatesModel::ProjectTemplatesModel() rescan_templates(); } -ProjectTemplatesModel::~ProjectTemplatesModel() -{ -} - int ProjectTemplatesModel::row_count(const GUI::ModelIndex&) const { return m_mapping.size(); diff --git a/Userland/DevTools/HackStudio/Dialogs/ProjectTemplatesModel.h b/Userland/DevTools/HackStudio/Dialogs/ProjectTemplatesModel.h index 4d0359f28c..80f83817cc 100644 --- a/Userland/DevTools/HackStudio/Dialogs/ProjectTemplatesModel.h +++ b/Userland/DevTools/HackStudio/Dialogs/ProjectTemplatesModel.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Nick Vella + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -29,7 +30,7 @@ public: __Count }; - virtual ~ProjectTemplatesModel() override; + virtual ~ProjectTemplatesModel() override = default; RefPtr template_for_index(const GUI::ModelIndex& index); diff --git a/Userland/DevTools/HackStudio/Editor.cpp b/Userland/DevTools/HackStudio/Editor.cpp index 724f3c3554..a8b2b2f190 100644 --- a/Userland/DevTools/HackStudio/Editor.cpp +++ b/Userland/DevTools/HackStudio/Editor.cpp @@ -1,6 +1,6 @@ /* * Copyright (c) 2018-2021, Andreas Kling - * Copyright (c) 2018-2021, the SerenityOS developers. + * Copyright (c) 2018-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -79,10 +79,6 @@ Editor::Editor() set_gutter_visible(true); } -Editor::~Editor() -{ -} - ErrorOr Editor::initialize_documentation_tooltip() { m_documentation_tooltip_window = GUI::Window::construct(); diff --git a/Userland/DevTools/HackStudio/Editor.h b/Userland/DevTools/HackStudio/Editor.h index 705fe5b811..75755e0f8e 100644 --- a/Userland/DevTools/HackStudio/Editor.h +++ b/Userland/DevTools/HackStudio/Editor.h @@ -1,7 +1,7 @@ /* * Copyright (c) 2018-2021, Andreas Kling * Copyright (c) 2020-2022, Itamar S. - * Copyright (c) 2018-2021, the SerenityOS developers. + * Copyright (c) 2018-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -26,7 +26,7 @@ class Editor final : public GUI::TextEditor { public: static ErrorOr> try_create(); - virtual ~Editor() override; + virtual ~Editor() override = default; Function on_focus; Function on_open; diff --git a/Userland/DevTools/HackStudio/EditorWrapper.cpp b/Userland/DevTools/HackStudio/EditorWrapper.cpp index 0f8430aa20..b245f7e380 100644 --- a/Userland/DevTools/HackStudio/EditorWrapper.cpp +++ b/Userland/DevTools/HackStudio/EditorWrapper.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -48,10 +49,6 @@ EditorWrapper::EditorWrapper() }; } -EditorWrapper::~EditorWrapper() -{ -} - void EditorWrapper::set_editor_has_focus(Badge, bool focus) { auto& font = Gfx::FontDatabase::default_font(); diff --git a/Userland/DevTools/HackStudio/EditorWrapper.h b/Userland/DevTools/HackStudio/EditorWrapper.h index df9dfd59aa..4713e8828a 100644 --- a/Userland/DevTools/HackStudio/EditorWrapper.h +++ b/Userland/DevTools/HackStudio/EditorWrapper.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -24,7 +25,7 @@ class EditorWrapper : public GUI::Widget { C_OBJECT(EditorWrapper) public: - virtual ~EditorWrapper() override; + virtual ~EditorWrapper() override = default; Editor& editor() { return *m_editor; } const Editor& editor() const { return *m_editor; } diff --git a/Userland/DevTools/HackStudio/Git/DiffViewer.cpp b/Userland/DevTools/HackStudio/Git/DiffViewer.cpp index 49ea5478ea..e28f681298 100644 --- a/Userland/DevTools/HackStudio/Git/DiffViewer.cpp +++ b/Userland/DevTools/HackStudio/Git/DiffViewer.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Itamar S. + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -16,10 +17,6 @@ namespace HackStudio { -DiffViewer::~DiffViewer() -{ -} - void DiffViewer::paint_event(GUI::PaintEvent& event) { GUI::Painter painter(*this); diff --git a/Userland/DevTools/HackStudio/Git/DiffViewer.h b/Userland/DevTools/HackStudio/Git/DiffViewer.h index eaaba2670d..38b27bf0df 100644 --- a/Userland/DevTools/HackStudio/Git/DiffViewer.h +++ b/Userland/DevTools/HackStudio/Git/DiffViewer.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Itamar S. + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -15,7 +16,7 @@ namespace HackStudio { class DiffViewer final : public GUI::AbstractScrollableWidget { C_OBJECT(DiffViewer) public: - virtual ~DiffViewer() override; + virtual ~DiffViewer() override = default; void set_content(const String& original, const String& diff); diff --git a/Userland/DevTools/HackStudio/Git/GitFilesView.cpp b/Userland/DevTools/HackStudio/Git/GitFilesView.cpp index 6fd455902c..917ed783d2 100644 --- a/Userland/DevTools/HackStudio/Git/GitFilesView.cpp +++ b/Userland/DevTools/HackStudio/Git/GitFilesView.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Itamar S. + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -11,9 +12,6 @@ #include namespace HackStudio { -GitFilesView::~GitFilesView() -{ -} void GitFilesView::paint_list_item(GUI::Painter& painter, int row_index, int painted_item_index) { diff --git a/Userland/DevTools/HackStudio/Git/GitFilesView.h b/Userland/DevTools/HackStudio/Git/GitFilesView.h index ddd0437020..ae9f9a34f1 100644 --- a/Userland/DevTools/HackStudio/Git/GitFilesView.h +++ b/Userland/DevTools/HackStudio/Git/GitFilesView.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Itamar S. + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -17,7 +18,7 @@ using GitFileActionCallback = Function; class GitFilesView : public GUI::ListView { C_OBJECT(GitFilesView) public: - virtual ~GitFilesView() override; + virtual ~GitFilesView() override = default; protected: GitFilesView(GitFileActionCallback, NonnullRefPtr action_icon); diff --git a/Userland/DevTools/HackStudio/HackStudioWidget.cpp b/Userland/DevTools/HackStudio/HackStudioWidget.cpp index 73009fc783..e3e658c1d9 100644 --- a/Userland/DevTools/HackStudio/HackStudioWidget.cpp +++ b/Userland/DevTools/HackStudio/HackStudioWidget.cpp @@ -1,7 +1,7 @@ /* * Copyright (c) 2018-2020, Andreas Kling * Copyright (c) 2020, Itamar S. - * Copyright (c) 2020-2021, the SerenityOS developers. + * Copyright (c) 2020-2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ diff --git a/Userland/DevTools/HackStudio/LanguageServers/ClientConnection.cpp b/Userland/DevTools/HackStudio/LanguageServers/ClientConnection.cpp index 30cd662e89..03edcb14ee 100644 --- a/Userland/DevTools/HackStudio/LanguageServers/ClientConnection.cpp +++ b/Userland/DevTools/HackStudio/LanguageServers/ClientConnection.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Itamar S. + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -20,10 +21,6 @@ ClientConnection::ClientConnection(NonnullOwnPtr sock s_connections.set(1, *this); } -ClientConnection::~ClientConnection() -{ -} - void ClientConnection::die() { s_connections.remove(client_id()); diff --git a/Userland/DevTools/HackStudio/LanguageServers/ClientConnection.h b/Userland/DevTools/HackStudio/LanguageServers/ClientConnection.h index 8ec97fbfb7..fc848b2fbb 100644 --- a/Userland/DevTools/HackStudio/LanguageServers/ClientConnection.h +++ b/Userland/DevTools/HackStudio/LanguageServers/ClientConnection.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Itamar S. + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -21,7 +22,7 @@ namespace LanguageServers { class ClientConnection : public IPC::ClientConnection { public: explicit ClientConnection(NonnullOwnPtr); - ~ClientConnection() override; + ~ClientConnection() override = default; virtual void die() override; diff --git a/Userland/DevTools/HackStudio/LanguageServers/CodeComprehensionEngine.cpp b/Userland/DevTools/HackStudio/LanguageServers/CodeComprehensionEngine.cpp index 361ffd392d..044aae97ab 100644 --- a/Userland/DevTools/HackStudio/LanguageServers/CodeComprehensionEngine.cpp +++ b/Userland/DevTools/HackStudio/LanguageServers/CodeComprehensionEngine.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Itamar S. + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -14,9 +15,6 @@ CodeComprehensionEngine::CodeComprehensionEngine(const FileDB& filedb, bool shou { } -CodeComprehensionEngine::~CodeComprehensionEngine() -{ -} void CodeComprehensionEngine::set_declarations_of_document(const String& filename, Vector&& declarations) { // Callback may not be configured if we're running tests diff --git a/Userland/DevTools/HackStudio/LanguageServers/CodeComprehensionEngine.h b/Userland/DevTools/HackStudio/LanguageServers/CodeComprehensionEngine.h index 13a19c3d85..da410b4638 100644 --- a/Userland/DevTools/HackStudio/LanguageServers/CodeComprehensionEngine.h +++ b/Userland/DevTools/HackStudio/LanguageServers/CodeComprehensionEngine.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Itamar S. + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -18,7 +19,7 @@ class ClientConnection; class CodeComprehensionEngine { public: CodeComprehensionEngine(const FileDB& filedb, bool store_all_declarations = false); - virtual ~CodeComprehensionEngine(); + virtual ~CodeComprehensionEngine() = default; virtual Vector get_suggestions(const String& file, const GUI::TextPosition& autocomplete_position) = 0; diff --git a/Userland/DevTools/HackStudio/Locator.cpp b/Userland/DevTools/HackStudio/Locator.cpp index 516449331b..c4dedfdb52 100644 --- a/Userland/DevTools/HackStudio/Locator.cpp +++ b/Userland/DevTools/HackStudio/Locator.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -157,10 +158,6 @@ Locator::Locator(Core::Object* parent) }; } -Locator::~Locator() -{ -} - void Locator::open_suggestion(const GUI::ModelIndex& index) { auto& model = reinterpret_cast(*m_suggestion_view->model()); diff --git a/Userland/DevTools/HackStudio/Locator.h b/Userland/DevTools/HackStudio/Locator.h index ba7249d97b..8f38db45e8 100644 --- a/Userland/DevTools/HackStudio/Locator.h +++ b/Userland/DevTools/HackStudio/Locator.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -14,7 +15,7 @@ namespace HackStudio { class Locator final : public GUI::Widget { C_OBJECT(Locator) public: - virtual ~Locator() override; + virtual ~Locator() override = default; void open(); void close(); diff --git a/Userland/DevTools/HackStudio/TerminalWrapper.cpp b/Userland/DevTools/HackStudio/TerminalWrapper.cpp index e820c359c5..e45d087b35 100644 --- a/Userland/DevTools/HackStudio/TerminalWrapper.cpp +++ b/Userland/DevTools/HackStudio/TerminalWrapper.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -203,10 +204,6 @@ TerminalWrapper::TerminalWrapper(bool user_spawned) run_command("Shell"); } -TerminalWrapper::~TerminalWrapper() -{ -} - int TerminalWrapper::child_exit_status() const { VERIFY(m_child_exit_status.has_value()); diff --git a/Userland/DevTools/HackStudio/TerminalWrapper.h b/Userland/DevTools/HackStudio/TerminalWrapper.h index a2636fb844..d06e213175 100644 --- a/Userland/DevTools/HackStudio/TerminalWrapper.h +++ b/Userland/DevTools/HackStudio/TerminalWrapper.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -15,7 +16,7 @@ namespace HackStudio { class TerminalWrapper final : public GUI::Widget { C_OBJECT(TerminalWrapper) public: - virtual ~TerminalWrapper() override; + virtual ~TerminalWrapper() override = default; enum class WaitForExit { No, Yes diff --git a/Userland/DevTools/Inspector/RemoteObjectGraphModel.cpp b/Userland/DevTools/Inspector/RemoteObjectGraphModel.cpp index f951ab3b3b..33b1c445c5 100644 --- a/Userland/DevTools/Inspector/RemoteObjectGraphModel.cpp +++ b/Userland/DevTools/Inspector/RemoteObjectGraphModel.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -22,10 +23,6 @@ RemoteObjectGraphModel::RemoteObjectGraphModel(RemoteProcess& process) m_timer_icon.set_bitmap_for_size(16, Gfx::Bitmap::try_load_from_file("/res/icons/16x16/timer.png").release_value_but_fixme_should_propagate_errors()); } -RemoteObjectGraphModel::~RemoteObjectGraphModel() -{ -} - GUI::ModelIndex RemoteObjectGraphModel::index(int row, int column, const GUI::ModelIndex& parent) const { if (!parent.is_valid()) { diff --git a/Userland/DevTools/Inspector/RemoteObjectGraphModel.h b/Userland/DevTools/Inspector/RemoteObjectGraphModel.h index 4a2b0462c2..a9fb2df3f3 100644 --- a/Userland/DevTools/Inspector/RemoteObjectGraphModel.h +++ b/Userland/DevTools/Inspector/RemoteObjectGraphModel.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -22,7 +23,7 @@ public: return adopt_ref(*new RemoteObjectGraphModel(process)); } - virtual ~RemoteObjectGraphModel() override; + virtual ~RemoteObjectGraphModel() override = default; virtual int row_count(const GUI::ModelIndex& = GUI::ModelIndex()) const override; virtual int column_count(const GUI::ModelIndex& = GUI::ModelIndex()) const override; diff --git a/Userland/DevTools/Profiler/DisassemblyModel.cpp b/Userland/DevTools/Profiler/DisassemblyModel.cpp index 7677957911..3411a31069 100644 --- a/Userland/DevTools/Profiler/DisassemblyModel.cpp +++ b/Userland/DevTools/Profiler/DisassemblyModel.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -122,10 +123,6 @@ DisassemblyModel::DisassemblyModel(Profile& profile, ProfileNode& node) } } -DisassemblyModel::~DisassemblyModel() -{ -} - int DisassemblyModel::row_count(GUI::ModelIndex const&) const { return m_instructions.size(); diff --git a/Userland/DevTools/Profiler/DisassemblyModel.h b/Userland/DevTools/Profiler/DisassemblyModel.h index 4dae093fd8..e1f419ec29 100644 --- a/Userland/DevTools/Profiler/DisassemblyModel.h +++ b/Userland/DevTools/Profiler/DisassemblyModel.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -41,7 +42,7 @@ public: __Count }; - virtual ~DisassemblyModel() override; + virtual ~DisassemblyModel() override = default; virtual int row_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override; virtual int column_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override { return Column::__Count; } diff --git a/Userland/DevTools/Profiler/IndividualSampleModel.cpp b/Userland/DevTools/Profiler/IndividualSampleModel.cpp index a4961c01c1..ba27683f58 100644 --- a/Userland/DevTools/Profiler/IndividualSampleModel.cpp +++ b/Userland/DevTools/Profiler/IndividualSampleModel.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2021, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -17,10 +18,6 @@ IndividualSampleModel::IndividualSampleModel(Profile& profile, size_t event_inde { } -IndividualSampleModel::~IndividualSampleModel() -{ -} - int IndividualSampleModel::row_count(GUI::ModelIndex const&) const { auto const& event = m_profile.events().at(m_event_index); diff --git a/Userland/DevTools/Profiler/IndividualSampleModel.h b/Userland/DevTools/Profiler/IndividualSampleModel.h index 1f1f2435cb..d499f62338 100644 --- a/Userland/DevTools/Profiler/IndividualSampleModel.h +++ b/Userland/DevTools/Profiler/IndividualSampleModel.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2021, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -26,7 +27,7 @@ public: __Count }; - virtual ~IndividualSampleModel() override; + virtual ~IndividualSampleModel() override = default; virtual int row_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override; virtual int column_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override; diff --git a/Userland/DevTools/Profiler/ProfileModel.cpp b/Userland/DevTools/Profiler/ProfileModel.cpp index c3ffa609db..9adf82e1cf 100644 --- a/Userland/DevTools/Profiler/ProfileModel.cpp +++ b/Userland/DevTools/Profiler/ProfileModel.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -19,10 +20,6 @@ ProfileModel::ProfileModel(Profile& profile) m_kernel_frame_icon.set_bitmap_for_size(16, Gfx::Bitmap::try_load_from_file("/res/icons/16x16/inspector-object-red.png").release_value_but_fixme_should_propagate_errors()); } -ProfileModel::~ProfileModel() -{ -} - GUI::ModelIndex ProfileModel::index(int row, int column, GUI::ModelIndex const& parent) const { if (!parent.is_valid()) { diff --git a/Userland/DevTools/Profiler/ProfileModel.h b/Userland/DevTools/Profiler/ProfileModel.h index 5f938f09b1..11108bdead 100644 --- a/Userland/DevTools/Profiler/ProfileModel.h +++ b/Userland/DevTools/Profiler/ProfileModel.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2020, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -28,7 +29,7 @@ public: __Count }; - virtual ~ProfileModel() override; + virtual ~ProfileModel() override = default; virtual int row_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override; virtual int column_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override; diff --git a/Userland/DevTools/Profiler/SamplesModel.cpp b/Userland/DevTools/Profiler/SamplesModel.cpp index e9123af0a6..a37aec04d9 100644 --- a/Userland/DevTools/Profiler/SamplesModel.cpp +++ b/Userland/DevTools/Profiler/SamplesModel.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2021, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -17,10 +18,6 @@ SamplesModel::SamplesModel(Profile& profile) m_kernel_frame_icon.set_bitmap_for_size(16, Gfx::Bitmap::try_load_from_file("/res/icons/16x16/inspector-object-red.png").release_value_but_fixme_should_propagate_errors()); } -SamplesModel::~SamplesModel() -{ -} - int SamplesModel::row_count(GUI::ModelIndex const&) const { return m_profile.filtered_event_indices().size(); diff --git a/Userland/DevTools/Profiler/SamplesModel.h b/Userland/DevTools/Profiler/SamplesModel.h index 06079a9088..144307b5bf 100644 --- a/Userland/DevTools/Profiler/SamplesModel.h +++ b/Userland/DevTools/Profiler/SamplesModel.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2021, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -31,7 +32,7 @@ public: __Count }; - virtual ~SamplesModel() override; + virtual ~SamplesModel() override = default; virtual int row_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override; virtual int column_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override; diff --git a/Userland/DevTools/Profiler/SignpostsModel.cpp b/Userland/DevTools/Profiler/SignpostsModel.cpp index 3afcc0339a..237be28fb8 100644 --- a/Userland/DevTools/Profiler/SignpostsModel.cpp +++ b/Userland/DevTools/Profiler/SignpostsModel.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -15,10 +16,6 @@ SignpostsModel::SignpostsModel(Profile& profile) { } -SignpostsModel::~SignpostsModel() -{ -} - int SignpostsModel::row_count(GUI::ModelIndex const&) const { return m_profile.filtered_signpost_indices().size(); diff --git a/Userland/DevTools/Profiler/SignpostsModel.h b/Userland/DevTools/Profiler/SignpostsModel.h index b9660ea76b..f227f3a952 100644 --- a/Userland/DevTools/Profiler/SignpostsModel.h +++ b/Userland/DevTools/Profiler/SignpostsModel.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -30,7 +31,7 @@ public: __Count }; - virtual ~SignpostsModel() override; + virtual ~SignpostsModel() override = default; virtual int row_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override; virtual int column_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override; diff --git a/Userland/DevTools/Profiler/TimelineContainer.cpp b/Userland/DevTools/Profiler/TimelineContainer.cpp index 2e2ed380a5..5d54f4e114 100644 --- a/Userland/DevTools/Profiler/TimelineContainer.cpp +++ b/Userland/DevTools/Profiler/TimelineContainer.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -31,10 +32,6 @@ TimelineContainer::TimelineContainer(GUI::Widget& header_container, TimelineView }; } -TimelineContainer::~TimelineContainer() -{ -} - void TimelineContainer::did_scroll() { AbstractScrollableWidget::did_scroll(); diff --git a/Userland/DevTools/Profiler/TimelineContainer.h b/Userland/DevTools/Profiler/TimelineContainer.h index 9760e25ef3..c096d8d45d 100644 --- a/Userland/DevTools/Profiler/TimelineContainer.h +++ b/Userland/DevTools/Profiler/TimelineContainer.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -16,7 +17,7 @@ class TimelineContainer : public GUI::AbstractScrollableWidget { C_OBJECT(TimelineContainer); public: - virtual ~TimelineContainer(); + virtual ~TimelineContainer() override = default; protected: virtual void did_scroll() override; diff --git a/Userland/DevTools/Profiler/TimelineHeader.cpp b/Userland/DevTools/Profiler/TimelineHeader.cpp index 9d1606f2bf..9bdc51a511 100644 --- a/Userland/DevTools/Profiler/TimelineHeader.cpp +++ b/Userland/DevTools/Profiler/TimelineHeader.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -27,10 +28,6 @@ TimelineHeader::TimelineHeader(Profile& profile, Process const& process) m_text = String::formatted("{} ({})", LexicalPath::basename(m_process.executable), m_process.pid); } -TimelineHeader::~TimelineHeader() -{ -} - void TimelineHeader::paint_event(GUI::PaintEvent& event) { GUI::Frame::paint_event(event); diff --git a/Userland/DevTools/Profiler/TimelineHeader.h b/Userland/DevTools/Profiler/TimelineHeader.h index f429cbb0cb..6040b6d0aa 100644 --- a/Userland/DevTools/Profiler/TimelineHeader.h +++ b/Userland/DevTools/Profiler/TimelineHeader.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -17,7 +18,7 @@ class TimelineHeader final : public GUI::Frame { C_OBJECT(TimelineHeader); public: - virtual ~TimelineHeader(); + virtual ~TimelineHeader() override = default; Function on_selection_change; diff --git a/Userland/DevTools/Profiler/TimelineTrack.cpp b/Userland/DevTools/Profiler/TimelineTrack.cpp index cf63bb81f2..0028b8e4e3 100644 --- a/Userland/DevTools/Profiler/TimelineTrack.cpp +++ b/Userland/DevTools/Profiler/TimelineTrack.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2021, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -25,10 +26,6 @@ TimelineTrack::TimelineTrack(TimelineView const& view, Profile const& profile, P set_frame_thickness(1); } -TimelineTrack::~TimelineTrack() -{ -} - void TimelineTrack::set_scale(float scale) { set_fixed_width(m_profile.length_in_ms() / scale); diff --git a/Userland/DevTools/Profiler/TimelineTrack.h b/Userland/DevTools/Profiler/TimelineTrack.h index fb74dde0b6..4a9591477d 100644 --- a/Userland/DevTools/Profiler/TimelineTrack.h +++ b/Userland/DevTools/Profiler/TimelineTrack.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2018-2021, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -19,7 +20,7 @@ class TimelineTrack final : public GUI::Frame { C_OBJECT(TimelineTrack); public: - virtual ~TimelineTrack() override; + virtual ~TimelineTrack() override = default; void set_scale(float); diff --git a/Userland/DevTools/Profiler/TimelineView.cpp b/Userland/DevTools/Profiler/TimelineView.cpp index bc34d0fb25..f43e76bab2 100644 --- a/Userland/DevTools/Profiler/TimelineView.cpp +++ b/Userland/DevTools/Profiler/TimelineView.cpp @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -18,10 +19,6 @@ TimelineView::TimelineView(Profile& profile) set_shrink_to_fit(true); } -TimelineView::~TimelineView() -{ -} - u64 TimelineView::timestamp_at_x(int x) const { float column_width = (float)width() / (float)m_profile.length_in_ms(); diff --git a/Userland/DevTools/Profiler/TimelineView.h b/Userland/DevTools/Profiler/TimelineView.h index 97b0943c23..8be0694cee 100644 --- a/Userland/DevTools/Profiler/TimelineView.h +++ b/Userland/DevTools/Profiler/TimelineView.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2021, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -17,7 +18,7 @@ class TimelineView final : public GUI::Widget { C_OBJECT(TimelineView); public: - virtual ~TimelineView() override; + virtual ~TimelineView() override = default; Function on_selection_change; Function on_scale_change; diff --git a/Userland/DevTools/UserspaceEmulator/Region.h b/Userland/DevTools/UserspaceEmulator/Region.h index 1701e16ffd..3efea3ad1a 100644 --- a/Userland/DevTools/UserspaceEmulator/Region.h +++ b/Userland/DevTools/UserspaceEmulator/Region.h @@ -1,5 +1,6 @@ /* * Copyright (c) 2020, Andreas Kling + * Copyright (c) 2022, the SerenityOS developers. * * SPDX-License-Identifier: BSD-2-Clause */ @@ -18,7 +19,7 @@ class Emulator; class Region { public: - virtual ~Region() { } + virtual ~Region() = default; const Range& range() const { return m_range; }