system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-09-23 12:56:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

arm64: traps: address fallout from printk -> pr_* conversion

Browse source 
Commit ac7b406c1a ("arm64: Use pr_* instead of printk") was a fairly
mindless s/printk/pr_*/ change driven by a complaint from checkpatch.

As is usual with such changes, this has led to some odd behaviour on
arm64:

  * syslog now picks up the "pr_emerg" line from dump_backtrace, but not
    the actual trace, which leads to a bunch of "kernel:Call trace:"
    lines in the log

  * __{pte,pmd,pgd}_error print at KERN_CRIT, as opposed to KERN_ERR
    which is used by other architectures.

This patch restores the original printk behaviour for dump_backtrace
and downgrade the pgtable error macros to KERN_ERR.

Signed-off-by: Will Deacon <will.deacon@arm.com>
This commit is contained in:
Will Deacon 2015-12-21 16:44:27 +00:00
parent 20380bb390
commit c9cd0ed925
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
arch/arm64/kernel/traps.c
View file

@ -171,7 +171,7 @@ static void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk)
#endif #endif
skip = !!regs; skip = !!regs;
pr_emerg("Call trace:\n"); printk("Call trace:\n");
while (1) { while (1) {
unsigned long where = frame.pc; unsigned long where = frame.pc;
unsigned long stack; unsigned long stack;
@ -482,22 +482,22 @@ asmlinkage void bad_mode(struct pt_regs *regs, int reason, unsigned int esr)
void __pte_error(const char *file, int line, unsigned long val) void __pte_error(const char *file, int line, unsigned long val)
{ {
pr_crit("%s:%d: bad pte %016lx.\n", file, line, val); pr_err("%s:%d: bad pte %016lx.\n", file, line, val);
} }
void __pmd_error(const char *file, int line, unsigned long val) void __pmd_error(const char *file, int line, unsigned long val)
{ {
pr_crit("%s:%d: bad pmd %016lx.\n", file, line, val); pr_err("%s:%d: bad pmd %016lx.\n", file, line, val);
} }
void __pud_error(const char *file, int line, unsigned long val) void __pud_error(const char *file, int line, unsigned long val)
{ {
pr_crit("%s:%d: bad pud %016lx.\n", file, line, val); pr_err("%s:%d: bad pud %016lx.\n", file, line, val);
} }
void __pgd_error(const char *file, int line, unsigned long val) void __pgd_error(const char *file, int line, unsigned long val)
{ {
pr_crit("%s:%d: bad pgd %016lx.\n", file, line, val); pr_err("%s:%d: bad pgd %016lx.\n", file, line, val);
} }
/* GENERIC_BUG traps */ /* GENERIC_BUG traps */