Commit graph

1987 commits

Author SHA1 Message Date
Sune Vuorela 56a2a8d3bd cleanups: Sprinkle in a bit unique_ptr
Document memory ownership with unique_ptr's and do a bit of code
cleanups.
2024-03-06 21:57:08 +00:00
Sune Vuorela 8bcafd80bb Clean up TextSelection and remove unused parts 2024-03-05 00:11:27 +00:00
Sune Vuorela 6cc2a08d6b Use std::swap 2024-03-04 23:56:46 +00:00
Sune Vuorela 1d93a42263 Newer clazy: More potential detaching temporary 2024-03-04 16:49:25 +01:00
l10n daemon script df3bfa005d SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2024-02-18 01:13:47 +00:00
Sune Vuorela 2e008d437c Simplify textentity memory management
After trying to measure the effect of switching TinyTextEntity from a
custom SBO string type to just QString and getting a barely measurable
gain, TinyTextEntity kind of looked like TextEntity, so merge those two.

Also reduce the amount of new/deletes around TextEntities

Implement a string pool for some tiny strings, and various memory optimizations
2024-02-07 14:07:08 +00:00
Sune Vuorela 12e40e0d36 Button groups can span multiple pages
The code needs to be aware of that.

BUG: 479942
2024-01-25 22:14:54 +00:00
Alexis Murzeau 2609f4001a Add support for app.popUpMenu and submenus in popUpMenuEx
These functions from `app` are JS functions that can be used by PDF
files.

Based on popUpMenuEx, the implementation of popUpMenu converts arguments
to app.popUpMenuEx format and then call it.

The popMenuEx function is improved to handle submenus as well using
`oSubMenu`.

app.popUpMenu is used in Altium Designer and EasyEDA exported PDFs.
See an example here:
https://www.st.com/en/evaluation-tools/32f723ediscovery.html#cad-resources
https://www.st.com/resource/en/schematic_pack/mb1260-f723e-d03_schematic.pdf

BUGS: 479777
2024-01-17 19:01:08 +00:00
Sune Vuorela dc88b5873a Don't put slashes in plugin prefix
It complicates stuff further down the line and we don't gain much for
it, so work with the rest of the stack rather than work around it.

One of the complications is that if bindir contains both plugins and executable, we will have okular and okular/ in the same folder and that doesn't really work.
2024-01-09 14:12:45 +00:00
l10n daemon script 651098cf5a SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2024-01-08 02:08:32 +00:00
Nicolas Fella f7b1b3b032 Remove unused caller arg from KBookmarkManager::changed 2024-01-03 21:02:38 +01:00
Sune Vuorela 2fad5243ab Remove setUpdate call; it doesn't do anything
And it defaults to true
2024-01-03 19:49:53 +00:00
Sune Vuorela 611dea4c0d Remove deprecated functions. Porting is needed anyways 2023-12-22 23:25:44 +00:00
Sune Vuorela 0cb6dace0c Fix qHash(NormalizedRect) 2023-12-21 23:24:58 +00:00
Sune Vuorela 7e07b41e06 document diff; port from deprecated
Use std::u32string for ucs4 representation. That can non-deprecated be
fed back into QString. Unfortunately the data from toUcs4 can't.
2023-12-21 13:38:58 +00:00
Sune Vuorela db728684e1 Port deprecated QLocale country 2023-12-19 12:18:28 +00:00
Sune Vuorela 792425fc77 s/qAsConst/std::as_const/
We now definitely has std::as_const available and Qt has started nagging
about converting to std::as_const.

Implementation is the same for both functions, and qAsConst was a
stop-gap measure until std::as_const was sufficiently available.
2023-12-19 11:46:24 +00:00
Sune Vuorela a72ad046f7 Remove ifdef'ed out code 2023-12-18 22:56:22 +00:00
Sune Vuorela 18200c87f7 Clazy: small and trivial things should be taken by copy 2023-12-18 22:56:22 +00:00
Sune Vuorela be29ae5eec Make some RegularExpressions static 2023-12-18 22:56:22 +00:00
Carl Schwan 946a8aa386 Port away from QTextStream::setCodec 2023-12-18 22:56:22 +00:00
Carl Schwan 514640923b Port to newer KBookmark API 2023-12-18 22:56:22 +00:00
Carl Schwan c02926d213 Port away from KRun::isExcecutableFile
This method moved to KIO::OpenUrlJob
2023-12-18 22:56:22 +00:00
Sune Vuorela a9717a8e5f Use CI environment for clang/clazy
In order to be able to also do this with Qt6 we can't currently rely on
'random distro' to be able to give us an environment sufficient for
running clang and clazy, so use the CI system setup instead

A side effect is that we get a newer clazy and clang-tidy and thus is a
few more issues to either ignore or fix.

Also, ask ninja to continue as long as possible rather than stop at
first error to be able to get succes in as few runs as possible
2023-12-15 09:39:03 +00:00
l10n daemon script 20a5bb2b5c SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2023-12-14 01:15:39 +00:00
Sune Vuorela b4a95259e2 Remove some unused parts of FilePrinter 2023-12-13 10:27:13 +00:00
Sune Vuorela ffe522af8c Include QFlags in global.h. It references the macros from there 2023-12-13 10:03:51 +00:00
Sune Vuorela ddbbe12c84 Fix since notation in signatureutils keylocation 2023-12-07 15:01:57 +00:00
Sune Vuorela 3e1842a923 Show an icon depending on the storage location of the signature 2023-12-07 12:15:03 +00:00
Sune Vuorela c94d47b07f Fix a qprinter deprecation warning
Co-Authored-By: Carl Schwan <carl@carlschwan.eu>
2023-12-07 11:46:59 +00:00
Sune Vuorela 32c804296a Get rid of QStringRef 2023-12-06 19:12:43 +00:00
Sune Vuorela 69943b5819 Fix deprecated warning QMap::unite
It looks like we mostly come with new values, and if we actually end up
with duplication we want the newest found and not do multi inserts.
2023-12-06 17:28:23 +00:00
Nicolas Fella 1b479dfb7b Port away from deprecated KRun 2023-12-06 09:22:16 +00:00
l10n daemon script 1641c47234 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2023-11-07 02:06:23 +00:00
l10n daemon script c16357bebf SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2023-11-04 11:46:37 +00:00
l10n daemon script e11183bfb9 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2023-10-20 01:19:41 +00:00
Nicolas Fella d4a344a189 Port away from deprecated KPluginLoader 2023-09-11 19:29:44 +00:00
Nicolas Fella 4addfcc4ec Remove kdelibs4 migration code when using Qt6
Upgrading 4->6 is not supported by KF6
2023-09-11 17:46:07 +00:00
Volker Krause e41f682b3d Fix creation of new JS objects
A default constructed QJSValue is undefined, not an object.

BUG: 474256
FIXED-IN: 23.08.1
2023-09-11 17:36:01 +00:00
Volker Krause c31696be6a Guard against setting invalid button icons
Fixes a crash by the test case in bug 474256.
2023-09-11 17:36:01 +00:00
Volker Krause bb102528ee The nFace argument in PDF JS button icon methods is optional
CCBUG: 474256
2023-09-11 17:36:01 +00:00
Nicolas Fella b5303248f0 Add missing includes 2023-09-11 16:47:17 +02:00
Jeremy Whiting 4ae7d68857 Fix more Qt deprecations.
Mostly QPrinter::Orientation -> QPageLayout::Orientation and
a few things about sizes.
2023-08-10 23:12:39 +00:00
Sune Vuorela 3eee43ffd8 Don't use private Qt api
Add some more unit testing to expose some bugs in previous implementation and fix those as well.
2023-08-10 23:06:18 +00:00
Sune Vuorela 88fc4032ac Random collection of cppcheck fixes
- missing consts
 - shadowing of variable names
 - superflous code
 - tighter scoping of some variables
 and other such bits
2023-08-10 22:47:57 +00:00
Sune Vuorela 0018d4fd11 No need to lookup paths for images without a dot.
if there is no suffix, the image reader in Qt cycles thru all of the
possible values that it might be able to load to see if such a thing
exists relative to current workdir. If one has configured an annotation
with path from a image, it is very unlikely that such a image does not
have a suffix.

While this is not a problem for most users, on certain so-called
enterprise systems with encrypted file systems and virus scanners and so
on, it makes a slight difference.
2023-08-07 23:20:25 +00:00
l10n daemon script 54a72d01ad SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2023-08-07 01:48:35 +00:00
Albert Astals Cid 532cb0cdcd Initial implementation of app.popUpMenuEx
It is defenitely not a full implementation but it's enough for the one
file we have that needs it for now

BUGS: 472764
2023-08-05 18:20:54 +00:00
Albert Astals Cid 0a3f4a78a3 Fix playing of external audio files
QUrl::fromUserInput().isRelative() returns false for things like "sound.ogg"
because it converts it to http://sound.ogg

So we use the variant where we give it the document folder, this way if
the file exists returns the local file.

For full urls we get the full url with this second variant so all should
be good
2023-08-05 08:33:35 +00:00
Albert Astals Cid 74fad426f2 Fix phonon not being correctly detected 2023-08-03 23:57:04 +02:00