Clazy: small and trivial things should be taken by copy

This commit is contained in:
Sune Vuorela 2023-12-14 12:54:15 +01:00 committed by Carl Schwan
parent be29ae5eec
commit 18200c87f7
2 changed files with 7 additions and 5 deletions

View file

@ -671,7 +671,7 @@ RegularAreaRect *TextPage::findText(int searchID, const QString &query, SearchDi
// we have a '-' just followed by a '\n' character
// check if the string contains a '-' character
// if the '-' is the last entry
static int stringLengthAdaptedWithHyphen(const QString &str, const TextList::ConstIterator &it, const TextList::ConstIterator &textListEnd)
static int stringLengthAdaptedWithHyphen(const QString &str, TextList::ConstIterator it, TextList::ConstIterator textListEnd)
{
const int len = str.length();
@ -725,7 +725,7 @@ RegularAreaRect *TextPagePrivate::searchPointToArea(const SearchPoint *sp)
return ret;
}
RegularAreaRect *TextPagePrivate::findTextInternalForward(int searchID, const QString &_query, TextComparisonFunction comparer, const TextList::ConstIterator &start, int start_offset, const TextList::ConstIterator &end)
RegularAreaRect *TextPagePrivate::findTextInternalForward(int searchID, const QString &_query, TextComparisonFunction comparer, TextList::ConstIterator start, int start_offset, TextList::ConstIterator end)
{
// normalize query search all unicode (including glyphs)
const QString query = _query.normalized(QString::NormalizationForm_KC);
@ -825,7 +825,7 @@ RegularAreaRect *TextPagePrivate::findTextInternalForward(int searchID, const QS
return nullptr;
}
RegularAreaRect *TextPagePrivate::findTextInternalBackward(int searchID, const QString &_query, TextComparisonFunction comparer, const TextList::ConstIterator &start, int start_offset, const TextList::ConstIterator &end)
RegularAreaRect *TextPagePrivate::findTextInternalBackward(int searchID, const QString &_query, TextComparisonFunction comparer, TextList::ConstIterator start, int start_offset, TextList::ConstIterator end)
{
// normalize query to search all unicode (including glyphs)
const QString query = _query.normalized(QString::NormalizationForm_KC);

View file

@ -29,6 +29,8 @@ class RegionText;
namespace Okular
{
class PagePrivate;
class RegularAreaRect;
class Page;
typedef QList<TinyTextEntity *> TextList;
/**
@ -48,8 +50,8 @@ public:
TextPagePrivate();
~TextPagePrivate();
RegularAreaRect *findTextInternalForward(int searchID, const QString &query, TextComparisonFunction comparer, const TextList::ConstIterator &start, int start_offset, const TextList::ConstIterator &end);
RegularAreaRect *findTextInternalBackward(int searchID, const QString &query, TextComparisonFunction comparer, const TextList::ConstIterator &start, int start_offset, const TextList::ConstIterator &end);
RegularAreaRect *findTextInternalForward(int searchID, const QString &query, TextComparisonFunction comparer, const TextList::ConstIterator start, int start_offset, const TextList::ConstIterator end);
RegularAreaRect *findTextInternalBackward(int searchID, const QString &query, TextComparisonFunction comparer, const TextList::ConstIterator start, int start_offset, const TextList::ConstIterator end);
/**
* Copy a TextList to m_words, the pointers of list are adopted