9b89c38020
The "simplify" feature used go/ast's object tracking in only one place - to replace s[a:len(s)] with s[a:]. Using go/ast.Object did allow us to not simplify code like: len := func(s []int) int { ... } s = s[a:len(s)] The existing code already noted the limitation with that approach, such as "len" being redeclared in a different file in the same package. Since go/ast's object tracking is file-based and very basic, it wouldn't work with edge cases like those. The reasoning is that redeclaring len and abusing it that way is extremely unlikely, and hasn't been a problem in about a decade now. I reason that the same applies to len being redeclared in the same file, so we should be able to safely remove the use of go/ast.Object here. Per https://go.dev/cl/401454, this makes "gofmt -s" about 5% faster. If we ever wanted to truly get rid of false positive simplifications, I imagine we'd want to reimplement the feature under go/analysis, which is able to fully typecheck packages and suggest edits. That seems unnecessary at this point, but we can always course correct in the presumably unlikely scenario that users start reporting bugs. See #46485. For #52463. Change-Id: I77fc97adceafde8f0fe6887ace83ae325bfa7416 Reviewed-on: https://go-review.googlesource.com/c/go/+/401875 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Daniel Martí <mvdan@mvdan.cc> Reviewed-by: Robert Griesemer <gri@google.com> Reviewed-by: Michael Knyszek <mknyszek@google.com> |
||
---|---|---|
.github | ||
api | ||
doc | ||
lib/time | ||
misc | ||
src | ||
test | ||
.gitattributes | ||
.gitignore | ||
AUTHORS | ||
codereview.cfg | ||
CONTRIBUTING.md | ||
CONTRIBUTORS | ||
LICENSE | ||
PATENTS | ||
README.md | ||
SECURITY.md |
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.