languages/go
languages/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-02 09:28:34 +00:00
Code Issues Projects Releases Packages Wiki Activity

reflect: deprecate (Slice|String)Header

Browse source 
As discussed in CL 401434 there are substantial misuses of these in the
wild, and they are a potential source of unsafety even for code that
does not use them directly.

We should either keep them as-is and document when/how they can be used
safely, or deprecate them so that uses will eventually die out.

After some discussion, it was decided to deprecate them outright.
Since the docs already mentioned that they may be unstable across
releases, it should be possible to get rid of them completely later on.

Change-Id: I3b75819409177b5a286c1e9861a2edb6fd1301b8
Reviewed-on: https://go-review.googlesource.com/c/go/+/401434
Auto-Submit: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
This commit is contained in:
Carlo Alberto Ferraris 2022-04-21 17:49:12 +09:00 committed by Gopher Robot
parent 5f2fdbe7ed
commit bc2e961cf4
2 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
doc/go1.19.html
View file

@ -166,6 +166,16 @@ Do not send CLs removing the interior tags from such phrases.
</dd>
</dl> <!-- os/exec -->
<dl id="reflect"><dt><a href="/pkg/reflect/">reflect</a></dt>
<dd>
<p><!-- CL 401434 -->
<a href="/pkg/strconv/#reflect.SliceHeader"></a><code>reflect.SliceHeader</code>
and <a href="/pkg/strconv/#reflect.StringHeader"></a><code>reflect.StringHeader</code>
are now deprecated, and their use should be avoided.
</p>
</dd>
</dl><!-- reflect -->
<dl id="runtime"><dt><a href="/pkg/runtime/">runtime</a></dt>
<dd>
<p><!-- https://go.dev/issue/51461 -->

6
src/reflect/value.go
View file

@ -2660,6 +2660,9 @@ func (v Value) UnsafePointer() unsafe.Pointer {
// Moreover, the Data field is not sufficient to guarantee the data
// it references will not be garbage collected, so programs must keep
// a separate, correctly typed pointer to the underlying data.
//
// Deprecated: this type should not be used, it exists only for
// backward compatibility.
type StringHeader struct {
Data uintptr
Len int
@ -2671,6 +2674,9 @@ type StringHeader struct {
// Moreover, the Data field is not sufficient to guarantee the data
// it references will not be garbage collected, so programs must keep
// a separate, correctly typed pointer to the underlying data.
//
// Deprecated: this type should not be used, it exists only for
// backward compatibility.
type SliceHeader struct {
Data uintptr
Len int