Go to file
Regis Crelier f8d1d003c9 Reland "[VM/runtime] Fix computation of the hash of recursive types."
This is a reland of a528b19d2c

Updating the hash of the empty type argument vector in write-protected memory caused a crash in precomp mode.
The fix is to correctly initialize the hash so it does not need an update.

Original change's description:
> [VM/runtime] Fix computation of the hash of recursive types.
>
> When computing the hash of a type, only include the hashes of the type arguments corresponding to the type parameters of the type's class and not of the whole type argument vector, otherwise, the variable location of TypeRefs in the base class type arguments may result in different hashes.
>
> Add a regression test (this test was not failing in all configurations, since the issue becomes visible depending on the order in which types are loaded and finalized).
>
> This fixes issue https://github.com/dart-lang/sdk/issues/42954
>
> Small improvement: pick hash value 1 for a vector of dynamic types, so it can be cached and not recomputed repeatedly, which was the case with value 0.
>
> Change-Id: I3468952cbf61944a82cf8e00efbf4952bd831fbe
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157563
> Reviewed-by: Alexander Markov <alexmarkov@google.com>
> Commit-Queue: Régis Crelier <regis@google.com>

Change-Id: I538b4538c69472e09b7bd745c6bd41023e1f154f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157781
Commit-Queue: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
2020-08-07 21:13:35 +00:00
.dart_tool Update to package:convert with null safety 2020-08-06 21:20:39 +00:00
.github Update new issue template. 2019-04-30 18:14:21 +00:00
benchmarks [benchmark] Fix lint in IsolateSpawn hello world. 2020-08-06 11:15:20 +00:00
build Reland "[vm] Fix some Fuchsia tests" 2020-08-06 21:29:29 +00:00
client Remove old annotated_steps buildbot scripts and dispatcher 2017-05-23 16:17:02 +02:00
docs process docs: Add link to experimental flags yaml file 2020-05-30 02:28:22 +00:00
pkg Remove unused code from PackageBuildWorkspacePackageTest. 2020-08-07 18:57:51 +00:00
runtime Reland "[VM/runtime] Fix computation of the hash of recursive types." 2020-08-07 21:13:35 +00:00
samples [vm] Native API: Introduce Dart_FinalizableHandle 2020-07-23 11:30:39 +00:00
samples-dev/swarm [cfe] Check overrides on operators 2020-07-08 08:45:34 +00:00
sdk [vm] Delete ABI infrastructure 2020-08-06 19:55:12 +00:00
tests Reland "[VM/runtime] Fix computation of the hash of recursive types." 2020-08-07 21:13:35 +00:00
third_party Add README.google and change browser-compat-data DEPS 2020-05-29 18:59:34 +00:00
tools [vm] Delete ABI infrastructure 2020-08-06 19:55:12 +00:00
utils [Compiler] Version Fix for Window Builds 2020-08-06 18:17:12 +00:00
.clang-format VM: Re-format to use at most one newline between functions 2017-07-13 08:08:37 -07:00
.gitattributes Migrate language_2/string to null safety. 2020-06-17 21:14:43 +00:00
.gitconfig [infra] Add documentation to .gitconfig 2018-06-11 18:24:16 +00:00
.gitignore Add internal benchmarks to .gitignore. 2020-06-26 11:57:22 +00:00
.gn
.mailmap fix my name in .mailmap 2018-09-11 01:45:52 +00:00
.packages [ package:dds ] Add server-sent event (SSE) support to DDS 2020-07-15 21:30:09 +00:00
.style.yapf Mass format python with yapf 2019-08-05 20:34:31 +00:00
.vpython [infra] Add .vpython spec to fix gsutil on the bots (#31065) 2018-10-11 15:11:35 +00:00
AUTHORS [runtime/vm] ARM64: Support unaligned memory accesses for regex. 2019-10-15 20:11:40 +00:00
BUILD.gn Reland "[vm] Fix some Fuchsia tests" 2020-08-06 21:29:29 +00:00
CHANGELOG.md bump linter to 0.1.118 2020-08-06 23:11:09 +00:00
codereview.settings Update codereview.settings to Gerrit (dart-review.googlesource.com) 2017-09-04 12:52:09 +00:00
CONTRIBUTING.md Fix a number of outdated URLs across a number of markdown files 2020-05-29 09:23:45 +00:00
DEPS Roll benchmarks-internal 1682e8c568cf..991d4cb32af0 2020-08-07 20:48:42 +00:00
LICENSE Remove third_party licenses from LICENSE 2019-08-21 07:43:34 +00:00
PATENT_GRANT Rename patent file 2019-08-16 12:03:17 +00:00
PRESUBMIT.py [Core Libraries] Eliminate the fork in the core libraries. 2020-06-16 23:37:36 +00:00
README.dart-sdk Add dart2native to sdk README 2020-01-20 09:32:58 +00:00
README.md Fix a number of outdated URLs across a number of markdown files 2020-05-29 09:23:45 +00:00
sdk_args.gni [build] Automatically rebuild sdk_hash when the Git commit changes. 2020-07-09 21:12:15 +00:00
WATCHLISTS [dart2js] 20 dart2js tests ported to nnbd #1. 2020-06-26 15:21:42 +00:00

Dart

A client-optimized language for fast apps on any platform

Dart is:

  • Optimized for UI: Develop with a programming language specialized around the needs of user interface creation

  • Productive: Make changes iteratively: use hot reload to see the result instantly in your running app

  • Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web

Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:

  • Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.

  • Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).

Dart platforms illustration

License & patents

Dart is free and open source.

See LICENSE and PATENT_GRANT.

Using Dart

Visit the dart.dev to learn more about the language, tools, getting started, and more.

Browse pub.dev for more packages and libraries contributed by the community and the Dart team.

Building Dart

If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.

There are more documents on our wiki.

Contributing to Dart

The easiest way to contribute to Dart is to file issues.

You can also contribute patches, as described in Contributing.