languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 16:41:07 +00:00
Code Issues Packages Projects Releases Wiki Activity
dart-sdk/tests
History
Regis Crelier f8d1d003c9 Reland "[VM/runtime] Fix computation of the hash of recursive types." 
This is a reland of a528b19d2c

Updating the hash of the empty type argument vector in write-protected memory caused a crash in precomp mode.
The fix is to correctly initialize the hash so it does not need an update.

Original change's description:
> [VM/runtime] Fix computation of the hash of recursive types.
>
> When computing the hash of a type, only include the hashes of the type arguments corresponding to the type parameters of the type's class and not of the whole type argument vector, otherwise, the variable location of TypeRefs in the base class type arguments may result in different hashes.
>
> Add a regression test (this test was not failing in all configurations, since the issue becomes visible depending on the order in which types are loaded and finalized).
>
> This fixes issue https://github.com/dart-lang/sdk/issues/42954
>
> Small improvement: pick hash value 1 for a vector of dynamic types, so it can be cached and not recomputed repeatedly, which was the case with value 0.
>
> Change-Id: I3468952cbf61944a82cf8e00efbf4952bd831fbe
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157563
> Reviewed-by: Alexander Markov <alexmarkov@google.com>
> Commit-Queue: Régis Crelier <regis@google.com>

Change-Id: I538b4538c69472e09b7bd745c6bd41023e1f154f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157781
Commit-Queue: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
2020-08-07 21:13:35 +00:00
..
co19 [co19] LibTest/core tests enabled 2020-08-05 11:10:33 +00:00
co19_2
corelib
corelib_2
dart2js [package:js] Add errors for missing @JS on class 2020-08-07 17:09:23 +00:00
dart2js_2 [package:js] Add errors for missing @JS on class 2020-08-07 17:09:23 +00:00
dartdevc
dartdevc_2
ffi
ffi_2
kernel
language Reland "[VM/runtime] Fix computation of the hash of recursive types." 2020-08-07 21:13:35 +00:00
language_2 Reland "[VM/runtime] Fix computation of the hash of recursive types." 2020-08-07 21:13:35 +00:00
lib [package:js] Add errors for missing @JS on class 2020-08-07 17:09:23 +00:00
lib_2 [dart2js] Skip js interop test on csp config 2020-07-31 19:29:03 +00:00
modular
standalone [dart:io] Disable isInsecureConnectionAllowed check as it broken 2020-07-31 16:45:00 +00:00
standalone_2 Reland "[vm] Fix some Fuchsia tests" 2020-08-06 21:29:29 +00:00
legacy_status_dart2js.csv
README.md

README.md

This directory contains tests of the language and core library implementations. For more information, see https://github.com/dart-lang/sdk/wiki/Testing.