dart-sdk/runtime
Daco Harkes d3ea8bff5c [vm/ffi] Fix constant Finalizables
The kernel builder relied on only seeing expressions emitted by the
finalizable transform (variable get and this) as arguments to the fence.

However, other transforms can run later. In this case the expression
was turned into a constant.

This CL changes the implementation to accept any expression rather than
accepting a subset of expressions.

TEST=tests/ffi/regress_49402_test.dart

Closes: https://github.com/dart-lang/sdk/issues/49402
Change-Id: I1a962a5b7a38099eb5c3bbf5a5a8145b16727d97
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-debug-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250744
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Slava Egorov <vegorov@google.com>
2022-07-07 08:39:21 +00:00
..
bin [standalone] Remove RISC-V linker hack. 2022-06-30 21:16:04 +00:00
docs Fix typos 2022-06-15 11:08:28 +00:00
include [vm/heap/metrics] Remove deprecated isolate-based vm heap statistic messages. 2022-06-16 15:27:49 +00:00
lib Revert "[vm] Generate event ids for synchronous begin and end events." 2022-07-01 16:08:40 +00:00
observatory Revert "Reland "[ VM / Service ] Add abstract flag to Function"" 2022-07-07 02:39:11 +00:00
observatory_2 Revert "Reland "[ VM / Service ] Add abstract flag to Function"" 2022-07-07 02:39:11 +00:00
platform [vm] Update bit algorithms in utils.cc 2022-05-16 07:30:40 +00:00
tests [vm] Bug fix in dedup optimization when build deferred components. 2022-07-06 11:04:10 +00:00
third_party [vm] More pieces of Windows ARM support. 2022-04-07 23:15:48 +00:00
tools [misc] Cleanup stale todos 2022-06-28 16:02:53 +00:00
vm [vm/ffi] Fix constant Finalizables 2022-07-07 08:39:21 +00:00
.clang-tidy
.gitignore
BUILD.gn [build] -fno-strict-vtable-pointers is a Clang-only flag. 2022-03-30 17:34:20 +00:00
codereview.settings
configs.gni
CPPLINT.cfg
OWNERS [infra] Add OWNERS to the Dart SDK 2022-02-14 14:06:34 +00:00
PRESUBMIT.py [python3] Migrate PRESUBMIT.py files 2021-08-16 08:29:54 +00:00
runtime_args.gni [VM] error: ‘mallinfo mallinfo()’ is deprecated 2021-12-08 00:25:10 +00:00