[misc] Cleanup stale todos

TEST=tests/ffi

Change-Id: Iae97f62b1adb8dbe99ad075dfe750604db0de62c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249301
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Tess Strickland <sstrickl@google.com>

pkg/front_end/test/ffi_test.dart

@@ -5,6 +5,6 @@
 import 'package:expect/expect.dart';
 
 void main() {
-  // TODO(dacoharkes): implement dart:ffi tests
+  // TODO(http://dartbug.com/49304): implement dart:ffi tests
   Expect.isTrue(true);
 }

runtime/bin/ffi_test/ffi_test_functions.cc

@@ -574,7 +574,6 @@ typedef intptr_t (*IntptrBinOp)(intptr_t a, intptr_t b);
 // Returns a closure.
 // Note this closure is not properly marked as DART_EXPORT or extern "C".
 // Used for testing passing a pointer to a closure to Dart.
-// TODO(dacoharkes): is this a supported use case?
 DART_EXPORT IntptrBinOp IntptrAdditionClosure() {
   std::cout << "IntptrAdditionClosure()\n";
   IntptrBinOp retval = [](intptr_t a, intptr_t b) { return a + b; };

runtime/tools/ffi/sdk_lib_ffi_generator.dart

@@ -319,9 +319,7 @@ ArgParser argParser() {
 }
 
 Uri dartPath() {
-  // TODO(dacoharkes): Use "../../../tools/sdks/dart-sdk/bin/dart" when the
-  // pinned fully supports extension methods.
-  return Uri.parse("dart");
+  return Platform.script.resolve("../../../tools/sdks/dart-sdk/bin/dart");
 }
 
 class Config {

runtime/vm/object_service.cc

@@ -1578,16 +1578,10 @@ void ExternalTypedData::PrintJSONImpl(JSONStream* stream, bool ref) const {
 }
 
 void Pointer::PrintJSONImpl(JSONStream* stream, bool ref) const {
-  // TODO(dacoharkes): what is the JSONStream used for?
-  // should it fail because it's not supported?
-  // or should it print something reasonable as default?
   Instance::PrintJSONImpl(stream, ref);
 }
 
 void DynamicLibrary::PrintJSONImpl(JSONStream* stream, bool ref) const {
-  // TODO(dacoharkes): what is the JSONStream used for?
-  // should it fail because it's not supported?
-  // or should it print something reasonable as default?
   Instance::PrintJSONImpl(stream, ref);
 }
 

sdk/lib/_internal/vm/lib/ffi_dynamic_library_patch.dart

@@ -37,8 +37,6 @@ class DynamicLibrary {
   @pragma("vm:external-name", "Ffi_dl_providesSymbol")
   external bool providesSymbol(String symbolName);
 
-  // TODO(dacoharkes): Expose this to users, or extend Pointer?
-  // https://github.com/dart-lang/sdk/issues/35881
   @pragma("vm:external-name", "Ffi_dl_getHandle")
   external int getHandle();
 

tests/ffi/vmspecific_static_checks_test.dart

@@ -43,10 +43,6 @@ void main() {
   testLookupFunctionTypeMismatch();
   testLookupFunctionPointervoid();
   testLookupFunctionPointerNFdyn();
-  testNativeFunctionSignatureInvalidReturn();
-  testNativeFunctionSignatureInvalidParam();
-  testNativeFunctionSignatureInvalidOptionalNamed();
-  testNativeFunctionSignatureInvalidOptionalPositional();
   testHandleVariance();
   testEmptyStructLookupFunctionArgument();
   testEmptyStructLookupFunctionReturn();
@@ -332,28 +328,6 @@ void testLookupFunctionPointerNFdyn() {
   // l.lookupFunction<PointerNFdynN, PointerNFdynD>("cos");
 }
 
-// TODO(dacoharkes): make the next 4 test compile errors
-typedef Invalid1 = int Function(Int8);
-typedef Invalid2 = Int8 Function(int);
-typedef Invalid3 = Int8 Function({Int8 named});
-typedef Invalid4 = Int8 Function([Int8 positional]);
-
-void testNativeFunctionSignatureInvalidReturn() {
-  // Pointer<NativeFunction<Invalid1>> p = fromAddress(999);
-}
-
-void testNativeFunctionSignatureInvalidParam() {
-  // Pointer<NativeFunction<Invalid2>> p = fromAddress(999);
-}
-
-void testNativeFunctionSignatureInvalidOptionalNamed() {
-  // Pointer<NativeFunction<Invalid3>> p = fromAddress(999);
-}
-
-void testNativeFunctionSignatureInvalidOptionalPositional() {
-  // Pointer<NativeFunction<Invalid4>> p = fromAddress(999);
-}
-
 // error on missing field annotation
 class TestStruct extends Struct {
   @Double()

tests/ffi_2/prepare_flutter_bundle.dart

@@ -9,9 +9,6 @@ import 'dart:io';
 
 import 'package:path/path.dart' as path;
 
-// TODO(dacoharkes): Migrate script to be nullsafe and generate nullsafe
-// Flutter app.
-
 main(List<String> args) async {
   if (args.length != 1) {
     print('Usage ${Platform.executable} ${Platform.script} <output-dir>');
@@ -82,7 +79,6 @@ After copying modify the test application:
     * Add the cpp files to Pods/Development Pods/<deep nesting>/ios/Classes
       to ensure they are statically linked to the app.
 ''');
-  // TODO(dacoharkes): Automate these steps. How to automate the XCode step?
 }
 
 void dumpTestList(List<String> testFiles, String message) {

tests/ffi_2/vmspecific_static_checks_test.dart

@@ -45,10 +45,6 @@ void main() {
   testLookupFunctionTypeMismatch();
   testLookupFunctionPointervoid();
   testLookupFunctionPointerNFdyn();
-  testNativeFunctionSignatureInvalidReturn();
-  testNativeFunctionSignatureInvalidParam();
-  testNativeFunctionSignatureInvalidOptionalNamed();
-  testNativeFunctionSignatureInvalidOptionalPositional();
   testHandleVariance();
   testEmptyStructLookupFunctionArgument();
   testEmptyStructLookupFunctionReturn();
@@ -334,28 +330,6 @@ void testLookupFunctionPointerNFdyn() {
   // l.lookupFunction<PointerNFdynN, PointerNFdynD>("cos");
 }
 
-// TODO(dacoharkes): make the next 4 test compile errors
-typedef Invalid1 = int Function(Int8);
-typedef Invalid2 = Int8 Function(int);
-typedef Invalid3 = Int8 Function({Int8 named});
-typedef Invalid4 = Int8 Function([Int8 positional]);
-
-void testNativeFunctionSignatureInvalidReturn() {
-  // Pointer<NativeFunction<Invalid1>> p = fromAddress(999);
-}
-
-void testNativeFunctionSignatureInvalidParam() {
-  // Pointer<NativeFunction<Invalid2>> p = fromAddress(999);
-}
-
-void testNativeFunctionSignatureInvalidOptionalNamed() {
-  // Pointer<NativeFunction<Invalid3>> p = fromAddress(999);
-}
-
-void testNativeFunctionSignatureInvalidOptionalPositional() {
-  // Pointer<NativeFunction<Invalid4>> p = fromAddress(999);
-}
-
 // error on missing field annotation
 class TestStruct extends Struct {
   @Double()