languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 00:29:48 +00:00
Code Issues Packages Projects Releases Wiki Activity
dart-sdk/pkg
History
Oleh Prypin c0b40136e5 Revert "[ddc] Add non-null assertions when setting fields" 
This reverts commit c590001ef0.

Reason for revert: Breaks google3 (b/247639927)

Original change's description:
> [ddc] Add non-null assertions when setting fields
>
> Re-land previously reverted change:
> https://dart-review.googlesource.com/c/sdk/+/258780
>
> Adds additional tests and more checks to ensure assertions are only
> added in libraries that have been migrated to null safety.
>
> Issue: https://github.com/dart-lang/sdk/issues/49918
> Change-Id: If0b9bca9fe0d7db5e15023fe03ccac891af568e8
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259120
> Reviewed-by: Sigmund Cherem <sigmund@google.com>
> Commit-Queue: Nicholas Shahan <nshahan@google.com>

TBR=sigmund@google.com,nshahan@google.com,annagrin@google.com

Change-Id: Iee2d33005cbabfacab7fc5c45046c6eeb8e31b01
Issue: https://github.com/dart-lang/sdk/issues/49918
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260106
Reviewed-by: Oleh Prypin <oprypin@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2022-09-20 17:19:38 +00:00
..
_fe_analyzer_shared Shared type analysis: add more pattern types. 2022-09-20 17:15:15 +00:00
_js_interop_checks [pkg:js] Add proto argument to createStaticInteropMock 2022-09-16 20:13:30 +00:00
analysis_server [analysis_server] FlutterRemoveWidget to handle Builder 2022-09-20 17:04:35 +00:00
analysis_server_client Fix typos 2022-09-16 19:35:00 +00:00
analyzer [analyzer] fix diagnostics for lints map 2022-09-20 17:11:35 +00:00
analyzer_cli Replace more Bazel with Blaze, some simplifications. 2022-08-15 19:50:46 +00:00
analyzer_plugin Fix typos 2022-09-16 19:35:00 +00:00
analyzer_utilities Fix typos 2022-09-16 19:35:00 +00:00
async_helper Fixed various typos in a lot of files 2022-07-25 12:21:59 +00:00
build_integration [pkg/build_integration] analyze using package:lints 2022-07-07 20:59:08 +00:00
compiler [dart2js] improve nullsafe API for a few _find* methods 2022-09-20 16:34:45 +00:00
dart2js_info [dart2js] Avoid double-counting used class sizes 2022-08-30 22:43:59 +00:00
dart2js_runtime_metrics [dart2js] Updating runtime allocations to store a JSON-decoded map instead of a JSON string 2022-08-06 00:02:37 +00:00
dart2js_tools
dart2native [pkg/dart2native] Refactor MachO parsing. 2022-09-07 11:32:37 +00:00
dart2wasm [pkg:js] Add type/conformance checking for createStaticInteropMock 2022-09-16 20:13:30 +00:00
dart_internal [dart_internal] Support 2.19 2022-07-19 09:00:36 +00:00
dartdev Remove emoji from null safety terminal messages. They are not rendering correctly on Windows. 2022-09-15 16:41:29 +00:00
dds [ DDS ] Fix IsolateManager.initialize() not correctly handling Sentinel responses 2022-09-15 13:56:43 +00:00
dds_service_extensions [pkg] use package:lints when analying pkg/ 2022-07-07 14:29:22 +00:00
dev_compiler Revert "[ddc] Add non-null assertions when setting fields" 2022-09-20 17:19:38 +00:00
expect [pkg] use package:lints when analyzing pkg/smith, pkg/expect 2022-07-06 22:29:24 +00:00
front_end Revert "Reland "[cfe,corelib] Add class 'Record' to the core library"" 2022-09-19 13:52:01 +00:00
frontend_server [frontend_server] Migrate frontend_server_starter 2022-09-16 08:06:49 +00:00
js Fixed various typos in a lot of files 2022-07-25 12:21:59 +00:00
js_ast
js_runtime [pkg] use package:lints for pkg/_js_interop_checks, pkg/js_runtime 2022-07-18 17:27:53 +00:00
js_shared [pkg/js_shared] address a few analysis issues 2022-06-23 23:34:18 +00:00
kernel Revert "Reland "[cfe,corelib] Add class 'Record' to the core library"" 2022-09-19 13:52:01 +00:00
language_versioning_2_7_test [pkg] ignore some intentional analysis issues 2022-07-01 20:04:10 +00:00
meta Report invalid mustCallSuper annotation targets 2022-07-28 17:48:15 +00:00
modular_test Fixed various typos in a lot of files 2022-07-25 12:21:59 +00:00
native_stack_traces [pkg/native_stack_traces] Add support for MacOS universal binaries. 2022-08-25 13:27:24 +00:00
nnbd_migration Migration: properly handle a field overriding a field in a mixin. 2022-09-19 17:11:51 +00:00
scrape Deprecate 'name' in AST, use 'name2' token instead. 2022-08-02 16:25:34 +00:00
smith [vm] Add a stub simx64. 2022-07-29 18:11:01 +00:00
sourcemap_testing [ddc] Migrate sourcemap and stacktrace tests 2022-06-22 22:05:25 +00:00
status_file [pkg/status_file] analyze using package:lints 2022-07-06 22:48:35 +00:00
telemetry [pkg] use package:lints when analying pkg/ 2022-07-07 14:29:22 +00:00
test_runner [analyzer] fix diagnostics for lints map 2022-09-20 17:11:35 +00:00
testing [testing] Remove language version from generated library 2022-07-12 10:51:17 +00:00
vm [vm/aot] Initial support for records in TFA 2022-09-16 18:43:50 +00:00
vm_service [pkg/vm_service] turn on a few more lints for this package 2022-09-19 17:02:14 +00:00
vm_snapshot_analysis [CFE] Remove support for .packages file 2022-06-24 08:20:39 +00:00
wasm_builder [dart2wasm] Fix memory definition. 2022-09-06 18:25:36 +00:00
.gitignore
BUILD.gn
OWNERS
pkg.status [gardening] Mark pkg/vm/test/kernel_front_end_test as Slow 2022-07-18 17:07:43 +00:00
README.md

README.md

Package validation

The packages in pkg/ are automatically validated on the LUCI CI bots. The validation is largely done by the tools/package_deps package; it can be tested locally via:

dart tools/package_deps/bin/package_deps.dart

Packages which are published

There are several packages developed in pkg/ which are published to pub. Validation of these packages is particularly important because the pub tools are not used for these packages during development; we get our dependency versions from the DEPS file. Its very easy for the dependencies specified in a package's pubspec file to get out of date wrt the packages and versions actually used.

In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:

  • that the dependencies listed in the pubspec are used in the package
  • that all the packages used by the source are listed in the pubspec
  • that we don't use relative path deps to pkg/ or third_party/ packages

Packages which are not published

For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:

# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none

These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.

We validate:

  • that the dependencies listed in the pubspec are used in the package
  • that all the packages used by the source are listed in the pubspec
  • that a reference to a pkg/ package is done via a relative path dependency