languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-07-19 20:17:27 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Remove emoji from null safety terminal messages. They are not rendering correctly on Windows.

Browse source 
Followup to https://dart-review.googlesource.com/c/sdk/+/257642

Change-Id: Id0193dea51e164f20ccb7a3087cd2995a742f348
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259300
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
This commit is contained in:
Michael Thomsen 2022-09-15 16:41:29 +00:00 committed by Commit Bot
parent a74d3fc01d
commit eb2504dea3
4 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart
View file

@ -1074,7 +1074,7 @@ const Code<Null> codeCompilingWithSoundNullSafety =
const MessageCode messageCompilingWithSoundNullSafety = const MessageCode(
"CompilingWithSoundNullSafety",
severity: Severity.info,
problemMessage: r"""Compiling with sound null safety 💪""");
problemMessage: r"""Compiling with sound null safety.""");
// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
const Code<Null> codeCompilingWithoutSoundNullSafety =
@ -1084,7 +1084,7 @@ const Code<Null> codeCompilingWithoutSoundNullSafety =
const MessageCode messageCompilingWithoutSoundNullSafety = const MessageCode(
"CompilingWithoutSoundNullSafety",
severity: Severity.info,
problemMessage: r"""Compiling without sound null safety ⚠️
problemMessage: r"""Compiling without sound null safety!
Dart 3 will only support sound null safety, see https://dart.dev/null-safety""");
// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.

3
pkg/dartdev/test/commands/run_test.dart
View file

@ -13,8 +13,7 @@ import 'package:test/test.dart';
import '../utils.dart';
const String soundNullSafetyMessage =
'Info: Compiling with sound null safety 💪';
const String soundNullSafetyMessage = 'Info: Compiling with sound null safety.';
const devToolsMessagePrefix =
'The Dart DevTools debugger and profiler is available at: http://127.0.0.1:';
const dartVMServiceMessagePrefix =

2
pkg/dartdev/test/no_such_file_test.dart
View file

@ -34,7 +34,7 @@ void main() {
expect(result.stderr, contains("Error when reading 'foo.dart':"));
expect(result.stdout, isNotEmpty);
expect(
result.stdout, contains('Info: Compiling with sound null safety 💪\n'));
result.stdout, contains('Info: Compiling with sound null safety.\n'));
expect(result.exitCode, 254);
});
}

4
pkg/front_end/messages.yaml
View file

@ -5517,14 +5517,14 @@ UnexpectedModifierInNonNnbd:
late int x;
CompilingWithSoundNullSafety:
problemMessage: "Compiling with sound null safety 💪"
problemMessage: "Compiling with sound null safety."
configuration: nnbd-strong,compile
severity: INFO
script: |
main() {}
CompilingWithoutSoundNullSafety:
problemMessage: "Compiling without sound null safety ⚠️\nDart 3 will only support sound null safety, see https://dart.dev/null-safety"
problemMessage: "Compiling without sound null safety!\nDart 3 will only support sound null safety, see https://dart.dev/null-safety"
configuration: nnbd-weak,compile
severity: INFO
script: |