mirror of
https://github.com/dart-lang/sdk
synced 2024-09-06 00:59:09 +00:00
f98a2138b7
When uploading CLs, the presubmit checks verify that the lines in the diff are formatted correctly according to `git cl format runtime`. However, when `buildtools/<os>-<arch>/clang/bin/clang-format` is updated, it does not force reformatting of files that would be reformatted. This leads to two issues: * Inconsistent style within the code base and within a single file. * Spurious reformatting in CLs when (1) clang-format is used on the whole file, or (2) the diff lines overlap. `clang-format` doesn't change that frequently, so in general this is not a large issue, but I've seen a bit too many "spurious formatting, please revert" comments on CLs recently. This CL formats the runtime to be in line with the current pinned `clang-format`: ``` $ find runtime/ -iname *.h -o -iname *.cc | xargs buildtools/mac-arm64/clang/bin/clang-format -i ``` `git cl format` (which only formats changed lines, and does so with `clang-format`) seems to not agree with itself, or clang-format, or cpplint in a handful of places. This CL adds `// clang-format off` for these. (See previous patchsets for the specific instances.) TEST=A variety of bots including GCC, MacOS and Windows. Change-Id: I470892e898971899fda14bb3b8f2c8efefd67686 Cq-Include-Trybots: luci.dart.try:vm-gcc-linux-try,vm-ffi-qemu-linux-release-riscv64-try,vm-ffi-qemu-linux-release-arm-try,vm-aot-win-debug-x64-try,vm-win-debug-x64c-try,vm-mac-debug-x64-try,vm-mac-debug-arm64-try,vm-aot-linux-debug-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362780 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
111 lines
3.6 KiB
C++
111 lines
3.6 KiB
C++
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
|
|
#if defined(TARGET_ARCH_X64)
|
|
|
|
#include "platform/unaligned.h"
|
|
|
|
#include "vm/code_patcher.h"
|
|
#include "vm/instructions.h"
|
|
#include "vm/instructions_x64.h"
|
|
|
|
#include "vm/constants.h"
|
|
#include "vm/cpu.h"
|
|
#include "vm/object.h"
|
|
#include "vm/object_store.h"
|
|
|
|
namespace dart {
|
|
|
|
// [start] is the address of a displacement inside a load instruction
|
|
intptr_t IndexFromPPLoadDisp8(uword start) {
|
|
int8_t offset = *reinterpret_cast<int8_t*>(start);
|
|
return ObjectPool::IndexFromOffset(offset);
|
|
}
|
|
|
|
intptr_t IndexFromPPLoadDisp32(uword start) {
|
|
int32_t offset = LoadUnaligned(reinterpret_cast<int32_t*>(start));
|
|
return ObjectPool::IndexFromOffset(offset);
|
|
}
|
|
|
|
bool DecodeLoadObjectFromPoolOrThread(uword pc, const Code& code, Object* obj) {
|
|
ASSERT(code.ContainsInstructionAt(pc));
|
|
|
|
uint8_t* bytes = reinterpret_cast<uint8_t*>(pc);
|
|
|
|
COMPILE_ASSERT(THR == R14);
|
|
if ((bytes[0] == 0x49) || (bytes[0] == 0x4d)) {
|
|
if ((bytes[1] == 0x8b) || (bytes[1] == 0x3b)) { // movq, cmpq
|
|
if ((bytes[2] & 0xc7) == (0x80 | (THR & 7))) { // [r14+disp32]
|
|
int32_t offset = LoadUnaligned(reinterpret_cast<int32_t*>(pc + 3));
|
|
return Thread::ObjectAtOffset(offset, obj);
|
|
}
|
|
if ((bytes[2] & 0xc7) == (0x40 | (THR & 7))) { // [r14+disp8]
|
|
uint8_t offset = *reinterpret_cast<uint8_t*>(pc + 3);
|
|
return Thread::ObjectAtOffset(offset, obj);
|
|
}
|
|
}
|
|
}
|
|
|
|
if (((bytes[0] == 0x41) && (bytes[1] == 0xff) && (bytes[2] == 0x76))) {
|
|
// push [r14+disp8]
|
|
uint8_t offset = *reinterpret_cast<uint8_t*>(pc + 3);
|
|
return Thread::ObjectAtOffset(offset, obj);
|
|
}
|
|
|
|
COMPILE_ASSERT(PP == R15);
|
|
if ((bytes[0] == 0x49) || (bytes[0] == 0x4d)) {
|
|
if ((bytes[1] == 0x8b) || (bytes[1] == 0x3b)) { // movq, cmpq
|
|
if ((bytes[2] & 0xc7) == (0x80 | (PP & 7))) { // [r15+disp32]
|
|
intptr_t index = IndexFromPPLoadDisp32(pc + 3);
|
|
return ObjectAtPoolIndex(code, index, obj);
|
|
}
|
|
if ((bytes[2] & 0xc7) == (0x40 | (PP & 7))) { // [r15+disp8]
|
|
intptr_t index = IndexFromPPLoadDisp8(pc + 3);
|
|
return ObjectAtPoolIndex(code, index, obj);
|
|
}
|
|
}
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
intptr_t TypeTestingStubCallPattern::GetSubtypeTestCachePoolIndex() {
|
|
static int16_t indirect_call_pattern[] = {
|
|
0xff, -1 /* 0x53 or 0x56 */, 0x07, // callq [RBX/RSI + 0x7]
|
|
};
|
|
static int16_t direct_call_pattern[] = {
|
|
0xe8, -1, -1, -1, -1, // callq [PC + <offset>]
|
|
};
|
|
static int16_t pattern_disp8[] = {
|
|
0x4d, 0x8b, 0x4f, -1, // movq R9, [PP + offset]
|
|
};
|
|
static int16_t pattern_disp32[] = {
|
|
0x4d, 0x8b, 0x8f, -1, -1, -1, -1, // movq R9, [PP + offset]
|
|
};
|
|
|
|
uword pc = pc_;
|
|
if (MatchesPattern(pc, direct_call_pattern,
|
|
ARRAY_SIZE(direct_call_pattern))) {
|
|
pc -= ARRAY_SIZE(direct_call_pattern);
|
|
} else if (MatchesPattern(pc, indirect_call_pattern,
|
|
ARRAY_SIZE(indirect_call_pattern))) {
|
|
pc -= ARRAY_SIZE(indirect_call_pattern);
|
|
} else {
|
|
FATAL("Failed to decode at %" Px, pc_);
|
|
}
|
|
|
|
if (MatchesPattern(pc, pattern_disp8, ARRAY_SIZE(pattern_disp8))) {
|
|
return IndexFromPPLoadDisp8(pc - 1);
|
|
} else if (MatchesPattern(pc, pattern_disp32, ARRAY_SIZE(pattern_disp32))) {
|
|
return IndexFromPPLoadDisp32(pc - 4);
|
|
} else {
|
|
FATAL("Failed to decode at %" Px, pc);
|
|
}
|
|
}
|
|
|
|
} // namespace dart
|
|
|
|
#endif // defined TARGET_ARCH_X64
|