mirror of
https://github.com/dart-lang/sdk
synced 2024-09-19 14:32:49 +00:00
5c9d67edcd
The source files were linked in filesystem order rather than sorted order, which meant the binaryen programs were not built reproducibly. The binaryen config.h contains the version of the binaryen based on the git tag, however gclient sync does not pull down additional git tags when the checkout is updated. Effectively the git tags are frozen and the wrong version may be reported, leading to divergent builds and lack of remote build cache sharing. Use the git commit instead. Fix the gitignore rules to not ignore the files actually checked into the Dart SDK. Fixes: b/333761738 Change-Id: Ib2d812a04e629e5ce3da7185869051e30457d7e2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362187 Commit-Queue: Jonas Termansen <sortie@google.com> Commit-Queue: William Hesse <whesse@google.com> Auto-Submit: Jonas Termansen <sortie@google.com> Reviewed-by: William Hesse <whesse@google.com> |
||
|---|---|---|
| .. | ||
| babel | ||
| binary_size | ||
| binaryen | ||
| cpu_features | ||
| d3 | ||
| d8 | ||
| devtools | ||
| double-conversion | ||
| fallback_root_certificates | ||
| firefox_jsshell | ||
| jsc | ||
| mdn/browser-compat-data | ||
| pkg | ||
| requirejs | ||
| .gitignore | ||
| clang.tar.gz.sha1 | ||
| OWNERS | ||