[build] Move runtime/third_party into third_party proper

* Add a chromium LICENSE file for binary_size.
* Update BUILD.gn files to still work.

Tested: CQ+flutter-linux-try
Cq-Include-Trybots: luci.dart.try:flutter-linux-try
Bug: b/286184681
Change-Id: Ia52839bc3edd9e42c2df27d0cb7d290851712249
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332963
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>

pkg/vm_snapshot_analysis/lib/src/commands/treemap.dart

@@ -7,7 +7,7 @@
 /// flag.
 ///
 /// It used the same visualization framework as Chromium's binary_size tool
-/// located in runtime/third_party/binary_size.
+/// located in third_party/binary_size.
 library vm_snapshot_analysis.commands.treemap;
 
 import 'dart:async';

runtime/BUILD.gn

@@ -303,7 +303,7 @@ library_for_all_configs("libdart") {
   extra_nonproduct_deps = [ "vm:libprotozero" ]
   extra_deps = [
     ":generate_version_cc_file",
-    "third_party/double-conversion/src:libdouble_conversion",
+    "../third_party/double-conversion/src:libdouble_conversion",
   ]
   if (is_fuchsia) {
     if (using_fuchsia_gn_sdk) {

runtime/third_party/double-conversion/src/BUILD.gn

@@ -2,39 +2,8 @@
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
-source_set("libdouble_conversion") {
-  # We are only interested in exposing the exported symbols (for size reasons).
-  cflags = []
-  if (is_posix) {
-    cflags += [ "-fvisibility=hidden" ]
-  }
-
-  configs += [
-    "../../..:dart_arch_config",
-    "../../..:dart_config",
-    "../../..:dart_os_config",
-  ]
-  sources = [
-    "bignum-dtoa.cc",
-    "bignum-dtoa.h",
-    "bignum.cc",
-    "bignum.h",
-    "cached-powers.cc",
-    "cached-powers.h",
-    "diy-fp.h",
-    "double-conversion.h",
-    "double-to-string.cc",
-    "double-to-string.h",
-    "fast-dtoa.cc",
-    "fast-dtoa.h",
-    "fixed-dtoa.cc",
-    "fixed-dtoa.h",
-    "ieee.h",
-    "string-to-double.cc",
-    "string-to-double.h",
-    "strtod.cc",
-    "strtod.h",
-    "utils.h",
-  ]
-  include_dirs = [ "." ]
+# TODO(athom): Remove this when Flutter uses the target from the new location.
+group("libdouble_conversion") {
+  deps =
+      [ "../../../../third_party/double-conversion/src:libdouble_conversion" ]
 }

runtime/vm/double_conversion.cc

@@ -4,7 +4,7 @@
 
 #include "vm/double_conversion.h"
 
-#include "third_party/double-conversion/src/double-conversion.h"
+#include "../../third_party/double-conversion/src/double-conversion.h"
 
 #include "vm/exceptions.h"
 #include "vm/globals.h"

third_party/binary_size/LICENSE

@@ -0,0 +1,27 @@
+// Copyright 2015 The Chromium Authors
+//
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+//    * Redistributions of source code must retain the above copyright
+// notice, this list of conditions and the following disclaimer.
+//    * Redistributions in binary form must reproduce the above
+// copyright notice, this list of conditions and the following disclaimer
+// in the documentation and/or other materials provided with the
+// distribution.
+//    * Neither the name of Google LLC nor the names of its
+// contributors may be used to endorse or promote products derived from
+// this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

third_party/double-conversion/src/BUILD.gn

@@ -0,0 +1,40 @@
+# Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
+# for details. All rights reserved. Use of this source code is governed by a
+# BSD-style license that can be found in the LICENSE file.
+
+source_set("libdouble_conversion") {
+  # We are only interested in exposing the exported symbols (for size reasons).
+  cflags = []
+  if (is_posix) {
+    cflags += [ "-fvisibility=hidden" ]
+  }
+
+  configs += [
+    "../../../runtime:dart_arch_config",
+    "../../../runtime:dart_config",
+    "../../../runtime:dart_os_config",
+  ]
+  sources = [
+    "bignum-dtoa.cc",
+    "bignum-dtoa.h",
+    "bignum.cc",
+    "bignum.h",
+    "cached-powers.cc",
+    "cached-powers.h",
+    "diy-fp.h",
+    "double-conversion.h",
+    "double-to-string.cc",
+    "double-to-string.h",
+    "fast-dtoa.cc",
+    "fast-dtoa.h",
+    "fixed-dtoa.cc",
+    "fixed-dtoa.h",
+    "ieee.h",
+    "string-to-double.cc",
+    "string-to-double.h",
+    "strtod.cc",
+    "strtod.h",
+    "utils.h",
+  ]
+  include_dirs = [ "." ]
+}