Find a file
Ben Konyi 8fd83cb222 [ dart:developer ] Remove optional 'parent' parameter from TimelineTask.withTaskId to avoid ID collisions
If parent is a param in the TimelineTask.withTaskId() constructor, we have the possibility of running into this situation:

TimelineTaskA - id 0

TimelineTaskB - id 1
TimelineTaskC - id 2 - parentId 1
TimelineTaskD - id 0 - parentId 2 (this task created with TimelineTask.withTaskId(0, parent: C))
TimelineTaskE - id 3 - parentId 0 (now who is the parent of E? D or A?)

If we do not allow the user to specify parent in the withTaskId() constructor, we remove the possibility of this clash. This clash happens because the user was able to inject an event with id 0 into an async tree defined by the parent parameter.

By removing the parent parameter from the withTaskId() constructor, we can rely on different sources of truth for the different TimelineTask constructors.
  - If taskId is specified via TimelineTask.withTaskId(), then that is the source of truth for inferring the async event tree (events with the same async id are in the same async tree).
  - If parent is specified via TimelineTask(parent: parent), then that is the source of truth for inferring the async event tree.
  - If neither taskId nor parent are specified (e.g. TimelineTask()), we default to timestamp inference.

Change-Id: I491a20cf1d1aaea744ab92e56602269390e73fb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121680
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Kenzie Schmoll <kenzieschmoll@google.com>
2019-10-14 23:37:48 +00:00
.github Update new issue template. 2019-04-30 18:14:21 +00:00
benchmarks [vm/benchmarks] Add IsolateSpawn spawn latency and memory benchmarks. 2019-10-11 19:52:12 +00:00
build [vm] Fix one MSAN failure; add UBSAN configuration. 2019-10-09 23:38:30 +00:00
client
docs Updated spec_parser such that it runs with ANTLR v4 2019-03-19 14:06:26 +00:00
pkg Change experiment flag name in test runner and test config. 2019-10-14 23:24:58 +00:00
runtime Fix AOT build breakage (new extension method names were failing as demangling is not done in AOT builds). 2019-10-14 22:49:22 +00:00
samples [vm/ffi] Use Pointer<Null> as the type of nullptr. 2019-10-11 14:39:47 +00:00
samples-dev Mass format python with yapf 2019-08-05 20:34:31 +00:00
sdk [ dart:developer ] Remove optional 'parent' parameter from TimelineTask.withTaskId to avoid ID collisions 2019-10-14 23:37:48 +00:00
sdk_nnbd [ dart:developer ] Remove optional 'parent' parameter from TimelineTask.withTaskId to avoid ID collisions 2019-10-14 23:37:48 +00:00
tests [VM] Implement name demangling of extension methods. 2019-10-14 20:40:09 +00:00
third_party [vm] Update wasmer and resolve a TODO. 2019-09-19 22:49:44 +00:00
tools [vm,aot,bytecode] Support obfuscation 2019-10-14 18:12:29 +00:00
utils Add a script and target to run dartfix 2019-10-14 15:50:21 +00:00
.clang-format
.gitattributes
.gitconfig
.gitignore Reland "[llvm] Add initial scaffolding" 2019-07-30 20:34:31 +00:00
.gn
.mailmap
.packages [vm/ffi] Deprecate Pointer.allocate/free. 2019-10-10 13:17:43 +00:00
.style.yapf Mass format python with yapf 2019-08-05 20:34:31 +00:00
.vpython
AUTHORS [ VM ] Updated splay-tree licenses, added V8 project authors to AUTHORS 2019-04-30 19:50:46 +00:00
BUILD.gn Add a script and target to run dartfix 2019-10-14 15:50:21 +00:00
CHANGELOG.md [ dart:developer ] Remove optional 'parent' parameter from TimelineTask.withTaskId to avoid ID collisions 2019-10-14 23:37:48 +00:00
codereview.settings
CONTRIBUTING.md
DEPS Update dartdoc to v0.28.8. 2019-10-14 21:42:39 +00:00
LICENSE Remove third_party licenses from LICENSE 2019-08-21 07:43:34 +00:00
PATENT_GRANT Rename patent file 2019-08-16 12:03:17 +00:00
PRESUBMIT.py Add embedder/vm layer checks to presubmits. 2019-09-30 16:28:07 +00:00
README.dart-sdk
README.md Update README.md 2019-08-16 12:24:02 +00:00
sdk_args.gni Build DDC targets with forked SDK sources when building with --nnbd flag 2019-10-09 23:24:21 +00:00
WATCHLISTS Auto-CC dart2js on changes to the js_runtime sdk. 2019-09-12 18:17:38 +00:00

Dart

A client-optimized language for fast apps on any platform

Dart is:

  • Optimized for UI: Develop with a programming language specialized around the needs of user interface creation

  • Productive: Make changes iteratively: use hot reload to see the result instantly in your running app

  • Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web

Dart has flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:

  • Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.

  • Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).

Dart platforms illustration

License & patents

Dart is free and open source.

See LICENSE and PATENT_GRANT.

Using Dart

Visit the dart.dev to learn more about the language, tools, getting started, and more.

Browse pub.dev for more packages and libraries contributed by the community and the Dart team.

Building Dart

If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.

There are more documents on our wiki.

Contributing to Dart

The easiest way to contribute to Dart is to file issues.

You can also contribute patches, as described in Contributing.