languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-15 23:19:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change experiment flag name in test runner and test config.

Browse source 
Use "enable-experiment" to be consistent with other tools.

Change-Id: If9598f667517443a4f61ef91955ff57a477f0a5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121681
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
This commit is contained in:
Robert Nystrom 2019-10-14 23:24:58 +00:00 committed by commit-bot@chromium.org
parent 4a2adf5734
commit aab88791b8
3 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pkg/smith/lib/configuration.dart
View file

@ -246,7 +246,7 @@ class Configuration {
builderTag: stringOption("builder-tag"),
vmOptions: stringListOption("vm-options"),
dart2jsOptions: stringListOption("dart2js-options"),
experiments: stringListOption("experiments"),
experiments: stringListOption("enable-experiment"),
timeout: intOption("timeout"),
enableAsserts: boolOption("enable-asserts"),
isChecked: boolOption("checked"),
@ -471,7 +471,7 @@ class Configuration {
if (builderTag.isNotEmpty) fields.add("builder-tag: $builderTag");
stringListField("vm-options", vmOptions);
stringListField("dart2js-options", dart2jsOptions);
stringListField("experiments", experiments);
stringListField("enable-experiment", experiments);
if (timeout > 0) fields.add("timeout: $timeout");
if (enableAsserts) fields.add("enable-asserts");
if (isChecked) fields.add("checked");

2
pkg/smith/test/configuration_test.dart
View file

@ -202,7 +202,7 @@ void main() {
"builder-tag": "the tag",
"vm-options": ["vm stuff", "more vm stuff"],
"dart2js-options": ["dart2js stuff", "more dart2js stuff"],
"experiments": ["semicolons", "interrobangs"],
"enable-experiment": ["semicolons", "interrobangs"],
"enable-asserts": true,
"checked": true,
"csp": true,

4
pkg/test_runner/lib/src/options.dart
View file

@ -311,7 +311,7 @@ options. Used to be able to make sane updates to the status files.''',
_Option('dart2js_options', 'Extra options for dart2js compilation step.',
hide: true),
_Option('shared_options', 'Extra shared options.', hide: true),
_Option('experiments', 'Experiment flags to enable.'),
_Option('enable-experiment', 'Experiment flags to enable.'),
_Option(
'babel',
'''Transforms dart2js output with Babel. The value must be
@ -637,7 +637,7 @@ compiler.''',
var dart2jsOptions = listOption("dart2js_options");
var vmOptions = listOption("vm_options");
var sharedOptions = listOption("shared_options");
var experiments = listOption("experiments");
var experiments = listOption("enable-experiment");
// JSON reporting implies listing and reporting.
if (data['report_in_json'] as bool) {