dart-sdk/pkg
Ilya Yanok 8f1a15daca Revert "Replace CiderByteStore methods with variants without signature."
This reverts commit 3a1a08106e.

Reason for revert: breaks dartd, can you maybe add instead of replace?

Original change's description:
> Replace CiderByteStore methods with variants without signature.
>
> Change-Id: I42c3aa456554974c1f44b95833e14487542539a5
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246986
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Keerti Parthasarathy <keertip@google.com>

TBR=keertip@google.com,scheglov@google.com

Change-Id: Ia05a618cde2f87b9c3162e28709de31baed18796
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247081
Reviewed-by: Ilya Yanok <yanok@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Ilya Yanok <yanok@google.com>
2022-06-03 07:14:06 +00:00
..
_fe_analyzer_shared [cfe] Handle extensions in Extension?.member check 2022-05-31 13:11:03 +00:00
_js_interop_checks [pkg] prefer 'any' deps for package dev dependencies 2022-05-27 01:34:59 +00:00
analysis_server allow rename on extension via fix_data.yaml 2022-06-03 00:39:55 +00:00
analysis_server_client [pkg] normalize the headers of the pkg/ readmes 2022-05-31 21:00:13 +00:00
analyzer Revert "Replace CiderByteStore methods with variants without signature." 2022-06-03 07:14:06 +00:00
analyzer_cli Use LibraryFileStateKind where a library is expected. 2022-06-01 20:43:54 +00:00
analyzer_plugin [pkg] normalize the headers of the pkg/ readmes 2022-05-31 21:00:13 +00:00
analyzer_utilities Make Cache.get() just return the value. 2022-06-02 15:45:45 +00:00
async_helper [pkg] prefer 'any' deps for package dev dependencies 2022-05-27 01:34:59 +00:00
build_integration [pkg] prefer 'any' deps for package dev dependencies 2022-05-27 01:34:59 +00:00
compiler [dart2js] Remove references to global growable list checks. 2022-06-02 22:08:45 +00:00
dart2js_info [dart2js] Fix tests for dart2js_info. 2022-06-01 19:56:14 +00:00
dart2js_runtime_metrics [pkg] prefer 'any' deps for package dev dependencies 2022-05-27 01:34:59 +00:00
dart2js_tools [pkg] prefer 'any' deps for package dev dependencies 2022-05-27 01:34:59 +00:00
dart2native [pkg] prefer 'any' deps for package dev dependencies 2022-05-27 01:34:59 +00:00
dart2wasm [pkg] prefer 'any' deps for package dev dependencies 2022-05-27 01:34:59 +00:00
dart_internal
dartdev Revert "Modify dartdev language-server to call the server snapshot" 2022-06-02 05:13:26 +00:00
dds Reland "[ Service / DDS ] Add method that can return local paths" 2022-06-01 21:22:34 +00:00
dds_service_extensions [pkg] normalize the headers of the pkg/ readmes 2022-05-31 21:00:13 +00:00
dev_compiler [ddc] Migrate property_model to null safety 2022-05-27 20:56:00 +00:00
expect [pkg] prefer 'any' deps for package dev dependencies 2022-05-27 01:34:59 +00:00
front_end [cfe] Update test expectations after new async/async* implementation in the VM 2022-06-02 23:47:49 +00:00
frontend_server [vm] Enable new implementation of async/async* in JIT mode 2022-06-02 23:40:15 +00:00
js [pkg] normalize the headers of the pkg/ readmes 2022-05-31 21:00:13 +00:00
js_ast [pkg] prefer 'any' deps for package dev dependencies 2022-05-27 01:34:59 +00:00
js_runtime [pkg] prefer 'any' deps for package dev dependencies 2022-05-27 01:34:59 +00:00
js_shared [pkg] prefer 'any' deps for package dev dependencies 2022-05-27 01:34:59 +00:00
kernel [cfe] Update test expectations after new async/async* implementation in the VM 2022-06-02 23:47:49 +00:00
language_versioning_2.7_test [pkg] prefer 'any' deps for package dev dependencies 2022-05-27 01:34:59 +00:00
meta [pkg/meta] prep for publishing package:meta 1.8.0 2022-05-16 21:56:05 +00:00
modular_test [pkg] prefer 'any' deps for package dev dependencies 2022-05-27 01:34:59 +00:00
native_stack_traces [pkg] prep to publish package:native_stack_traces 2022-05-31 16:39:16 +00:00
nnbd_migration [pkg] prefer 'any' deps for package dev dependencies 2022-05-27 01:34:59 +00:00
scrape [pkg] prefer 'any' deps for package dev dependencies 2022-05-27 01:34:59 +00:00
smith [pkg] prefer 'any' deps for package dev dependencies 2022-05-27 01:34:59 +00:00
sourcemap_testing [pkg] prefer 'any' deps for package dev dependencies 2022-05-27 01:34:59 +00:00
status_file [pkg] prefer 'any' deps for package dev dependencies 2022-05-27 01:34:59 +00:00
telemetry [pkg] prefer 'any' deps for package dev dependencies 2022-05-27 01:34:59 +00:00
test_runner [pkg] prefer 'any' deps for package dev dependencies 2022-05-27 01:34:59 +00:00
testing Read package_config.json in more tests 2022-05-11 18:58:44 +00:00
vm [vm] Enable new implementation of async/async* in JIT mode 2022-06-02 23:40:15 +00:00
vm_service [vm] Enable new implementation of async/async* in JIT mode 2022-06-02 23:40:15 +00:00
vm_snapshot_analysis [pkg] prep to publish package:vm_snapshot_analysis 2022-05-31 16:39:14 +00:00
wasm_builder [pkg] prefer 'any' deps for package dev dependencies 2022-05-27 01:34:59 +00:00
.gitignore [cleanup] Remove remaining references to analysis_server language model 2022-05-30 11:27:42 +00:00
BUILD.gn
OWNERS
pkg.status [web] Move libraries to a shared location 2022-05-18 19:59:33 +00:00
README.md

Package validation

The packages in pkg/ are automatically validated on the LUCI CI bots. The validation is largely done by the tools/package_deps package; it can be tested locally via:

dart tools/package_deps/bin/package_deps.dart

Packages which are published

There are several packages developed in pkg/ which are published to pub. Validation of these packages is particularly important because the pub tools are not used for these packages during development; we get our dependency versions from the DEPS file. Its very easy for the dependencies specified in a package's pubspec file to get out of date wrt the packages and versions actually used.

In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:

  • that the dependencies listed in the pubspec are used in the package
  • that all the packages used by the source are listed in the pubspec
  • that we don't use relative path deps to pkg/ or third_party/ packages

Packages which are not published

For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:

# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none

These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.

We validate:

  • that the dependencies listed in the pubspec are used in the package
  • that all the packages used by the source are listed in the pubspec
  • that a reference to a pkg/ package is done via a relative path dependency