languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-15 22:19:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Modify dartdev language-server to call the server snapshot"

Browse source 
This reverts commit 1598182907.

Reason for revert: The snapshot for the DAS needs to have the default set before this change can land.  Will work with Analyzer folks in the morning to put together a new PR.

Original change's description:
> Modify dartdev language-server to call the server snapshot
>
> Change-Id: I6fc7b2c1e55089fa0bf88633733c51ff768e699b
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246059
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Jaime Wren <jwren@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I848f4ad08405fee5aeb0d2eb166f95390e81bb3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246840
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
This commit is contained in:
Jaime Wren 2022-06-02 05:13:26 +00:00 committed by Commit Bot
parent 31dc8e3cef
commit 6c210bbc57
1 changed files with 5 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
pkg/dartdev/lib/src/commands/language_server.dart
View file

@ -8,9 +8,7 @@ import 'package:analysis_server/src/server/driver.dart' as server_driver;
import 'package:args/args.dart';
import '../core.dart';
import '../sdk.dart';
import '../utils.dart';
import '../vm_interop_handler.dart';
class LanguageServerCommand extends DartdevCommand {
static const String commandName = 'language-server';
@ -40,14 +38,11 @@ For more information about the server's capabilities and configuration, see:
@override
Future<int> run() async {
if (!Sdk.checkArtifactExists(sdk.analysisServerSnapshot)) return 255;
VmInteropHandler.run(
sdk.analysisServerSnapshot,
[
...argResults!.arguments,
],
packageConfigOverride: null);
final driver = server_driver.Driver();
driver.start(
argResults!.arguments,
defaultToLsp: true,
);
// The server will continue to run past the return from this method.
//