mirror of
https://github.com/dart-lang/sdk
synced 2024-10-14 19:40:29 +00:00
9588927faf
This CL moves native assets resolution to the embedder. The Dart VM looks up the asset path (for example `['relative', 'foo.so']`) with the asset id. The embedder defines callbacks for asset loading, and returns a handle to the dylib. Then the VM calls the embedder again with `dlsym` to lookup the symbol. The Dart VM & kernel compiler are responsible for the asset id to asset path mapping. The kernel compiler compiles it into the snapshot and the VM looks it up in the snapshot. Relative paths are resolved relative to the isolate script uri (kernel snapshot, jit snapshot, aot snapshot, or `dart compile exe` result). The embedder is responsible for remembering the script uri it set when spawning the isolate group. This CL does not add `dlclose` or `dladdr` embedder callbacks yet. Bug: https://github.com/dart-lang/sdk/issues/55521 Bug: https://github.com/dart-lang/sdk/issues/55966 TEST=pkg/dartdev/test/native_assets/build_test.dart TEST=tests/ffi/native_assets/asset_relative_test.dart Bug: https://github.com/dart-lang/sdk/issues/55410 Bug: https://github.com/dart-lang/sdk/issues/55523 Bug: https://github.com/dart-lang/sdk/issues/55207 Change-Id: I75ec4a368c5fb3d2f76b03771e796ff56bcac941 Cq-Include-Trybots: dart/try:vm-aot-linux-debug-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-mac-release-arm64-try,vm-aot-mac-release-x64-try,vm-aot-obfuscate-linux-release-x64-try,vm-aot-optimization-level-linux-release-x64-try,vm-aot-win-debug-arm64-try,vm-aot-win-debug-x64-try,vm-aot-win-debug-x64c-try,pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-mac-release-try,pkg-mac-release-arm64-try,pkg-win-release-try,pkg-win-release-arm64-try,vm-aot-asan-linux-release-x64-try,vm-asan-linux-release-x64-try,vm-aot-msan-linux-release-x64-try,vm-msan-linux-release-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/361881 Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com> |
||
|---|---|---|
| .. | ||
| generator | ||
| native_assets | ||
| static_checks | ||
| abi_specific_int_incomplete_aot_test.dart | ||
| abi_specific_int_incomplete_jit_test.dart | ||
| abi_specific_int_test.dart | ||
| abi_test.dart | ||
| address_of_array_generated_test.dart | ||
| address_of_generated_shared.dart | ||
| address_of_shared.dart | ||
| address_of_struct_generated_test.dart | ||
| address_of_test.dart | ||
| address_of_typeddata_generated_test.dart | ||
| aliasing_test.dart | ||
| all_positive.dart | ||
| allocator_test.dart | ||
| analysis_options.yaml | ||
| async_callback_tests_utils.dart | ||
| async_void_function_callbacks_test.dart | ||
| bool_test.dart | ||
| c_types_test.dart | ||
| callback_tests_utils.dart | ||
| callback_unwind_error_test.dart | ||
| calloc_test.dart | ||
| coordinate.dart | ||
| coordinate_nnbd_workaround.dart | ||
| data_not_asan_test.dart | ||
| data_test.dart | ||
| deeply_immutable_c_api_finalizer_test.dart | ||
| dl_api_exit_enter_isolate_test.dart | ||
| dylib_close_test.dart | ||
| dylib_isolates_test.dart | ||
| dylib_open_test.dart | ||
| dylib_utils.dart | ||
| expando_test.dart | ||
| extension_methods_test.dart | ||
| external_typed_data_finalizer_test.dart | ||
| external_typed_data_test.dart | ||
| ffi.status | ||
| ffi_callback_unique_test.dart | ||
| ffi_induce_a_crash_test.dart | ||
| ffi_native_test.dart | ||
| ffi_test_helpers.dart | ||
| finalizer_external_size_accounting_test.dart | ||
| function_callbacks_many_test.dart | ||
| function_callbacks_structs_by_value_generated_test.dart | ||
| function_callbacks_structs_by_value_native_callable_generated_test.dart | ||
| function_callbacks_structs_by_value_test.dart | ||
| function_callbacks_subtype_test.dart | ||
| function_callbacks_test.dart | ||
| function_callbacks_varargs_generated_test.dart | ||
| function_callbacks_varargs_native_callable_generated_test.dart | ||
| function_callbacks_very_many_test.dart | ||
| function_struct_by_value_out_of_bounds_test.dart | ||
| function_structs_by_value_generated_args_leaf_test.dart | ||
| function_structs_by_value_generated_args_native_leaf_test.dart | ||
| function_structs_by_value_generated_args_native_test.dart | ||
| function_structs_by_value_generated_args_test.dart | ||
| function_structs_by_value_generated_compounds.dart | ||
| function_structs_by_value_generated_ret_arg_leaf_test.dart | ||
| function_structs_by_value_generated_ret_arg_native_leaf_test.dart | ||
| function_structs_by_value_generated_ret_arg_native_test.dart | ||
| function_structs_by_value_generated_ret_arg_test.dart | ||
| function_structs_by_value_generated_ret_leaf_test.dart | ||
| function_structs_by_value_generated_ret_native_leaf_test.dart | ||
| function_structs_by_value_generated_ret_native_test.dart | ||
| function_structs_by_value_generated_ret_test.dart | ||
| function_structs_test.dart | ||
| function_test.dart | ||
| function_varargs_generated_leaf_test.dart | ||
| function_varargs_generated_native_leaf_test.dart | ||
| function_varargs_generated_native_test.dart | ||
| function_varargs_generated_test.dart | ||
| function_varargs_name_test.dart | ||
| function_varargs_test.dart | ||
| function_very_many_test.dart | ||
| hardfp_test.dart | ||
| has_symbol_test.dart | ||
| inline_array_multi_dimensional_test.dart | ||
| inline_array_test.dart | ||
| invoke_callback_after_suspension_test.dart | ||
| isolate_local_function_callbacks_test.dart | ||
| msan_test.dart | ||
| native_callables_async_structs_by_value_generated_test.dart | ||
| native_callables_sync_structs_by_value_generated_test.dart | ||
| native_effect_test.dart | ||
| negative_function_test.dart | ||
| pointer_arithmetic_operators_test.dart | ||
| regress_37254_test.dart | ||
| regress_39044_test.dart | ||
| regress_39063_test.dart | ||
| regress_39885_test.dart | ||
| regress_40537_test.dart | ||
| regress_43016_test.dart | ||
| regress_43693_test.dart | ||
| regress_45189_test.dart | ||
| regress_45198_test.dart | ||
| regress_45507_test.dart | ||
| regress_45988_test.dart | ||
| regress_46004_test.dart | ||
| regress_46127_test.dart | ||
| regress_47594_test.dart | ||
| regress_47673_test.dart | ||
| regress_49402_test.dart | ||
| regress_49684_test.dart | ||
| regress_51315_test.dart | ||
| regress_51321_test.dart | ||
| regress_51504_test.dart | ||
| regress_51538_2_test.dart | ||
| regress_51538_3_test.dart | ||
| regress_51538_test.dart | ||
| regress_52298_test.dart | ||
| regress_52399_test.dart | ||
| regress_b_261224444_test.dart | ||
| regress_flutter79441_test.dart | ||
| regress_flutter97301_test.dart | ||
| regress_jump_to_frame_test.dart | ||
| sizeof_test.dart | ||
| snapshot_test.dart | ||
| stacktrace_regress_37910_test.dart | ||
| structs_nested_test.dart | ||
| structs_nnbd_workaround_test.dart | ||
| structs_packed_test.dart | ||
| structs_test.dart | ||
| structs_typed_data_test.dart | ||
| unaligned_test.dart | ||
| variance_function_test.dart | ||
| very_large_struct.dart | ||
| vmspecific_deprecated_funcs_test.dart | ||
| vmspecific_dynamic_library_test.dart | ||
| vmspecific_enable_ffi_test.dart | ||
| vmspecific_ffi_native_handles_test.dart | ||
| vmspecific_ffi_native_test.dart | ||
| vmspecific_function_callbacks_exit_test.dart | ||
| vmspecific_function_callbacks_test.dart | ||
| vmspecific_function_gc_test.dart | ||
| vmspecific_function_test.dart | ||
| vmspecific_handle_dynamically_linked_test.dart | ||
| vmspecific_handle_test.dart | ||
| vmspecific_highmem_32bit_test.dart | ||
| vmspecific_leaf_call_test.dart | ||
| vmspecific_native_finalizer_2_test.dart | ||
| vmspecific_native_finalizer_deeply_immutable_test.dart | ||
| vmspecific_native_finalizer_isolate_groups_test.dart | ||
| vmspecific_native_finalizer_isolates_test.dart | ||
| vmspecific_native_finalizer_test.dart | ||
| vmspecific_object_gc_test.dart | ||
| vmspecific_pointer_load_il_test.dart | ||
| vmspecific_regress_37100_test.dart | ||
| vmspecific_regress_37511_callbacks_test.dart | ||
| vmspecific_regress_37511_test.dart | ||
| vmspecific_regress_37780_test.dart | ||
| vmspecific_regress_51794_test.dart | ||
| vmspecific_send_port_id_test.dart | ||