[tests] Remove obsolete Dart 3.0 experiments from FFI tests

Change-Id: I6909ccbbdd3e2a7e9ef403155f3ce0a41d5c173f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/309680
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>

tests/ffi/analysis_options.yaml

@@ -2,9 +2,6 @@ analyzer:
   exclude:
     # Do analyze this subfolder in the tests/ even if tests/ is fully excluded.
 
-  enable-experiment:
-    - records # TODO(http://dartbug.com/50586): Remove this when records are no longer an experiment.
-
 linter:
   rules:
     - unawaited_futures

tests/ffi/function_callbacks_varargs_generated_test.dart

@@ -6,10 +6,9 @@
 // Generated by tests/ffi/generator/structs_by_value_tests_generator.dart.
 //
 // SharedObjects=ffi_test_functions
-// VMOptions=--enable-experiment=records
-// VMOptions=--enable-experiment=records --deterministic --optimization-counter-threshold=20
-// VMOptions=--enable-experiment=records --use-slow-path
-// VMOptions=--enable-experiment=records --use-slow-path --stacktrace-every=100
+// VMOptions=--deterministic --optimization-counter-threshold=20
+// VMOptions=--use-slow-path
+// VMOptions=--use-slow-path --stacktrace-every=100
 
 import 'dart:ffi';
 

tests/ffi/function_varargs_generated_leaf_test.dart

@@ -6,10 +6,9 @@
 // Generated by tests/ffi/generator/structs_by_value_tests_generator.dart.
 //
 // SharedObjects=ffi_test_functions
-// VMOptions=--enable-experiment=records
-// VMOptions=--enable-experiment=records --deterministic --optimization-counter-threshold=90
-// VMOptions=--enable-experiment=records --use-slow-path
-// VMOptions=--enable-experiment=records --use-slow-path --stacktrace-every=100
+// VMOptions=--deterministic --optimization-counter-threshold=90
+// VMOptions=--use-slow-path
+// VMOptions=--use-slow-path --stacktrace-every=100
 
 import 'dart:ffi';
 

tests/ffi/function_varargs_generated_native_leaf_test.dart

@@ -6,10 +6,9 @@
 // Generated by tests/ffi/generator/structs_by_value_tests_generator.dart.
 //
 // SharedObjects=ffi_test_functions
-// VMOptions=--enable-experiment=records
-// VMOptions=--enable-experiment=records --deterministic --optimization-counter-threshold=90
-// VMOptions=--enable-experiment=records --use-slow-path
-// VMOptions=--enable-experiment=records --use-slow-path --stacktrace-every=100
+// VMOptions=--deterministic --optimization-counter-threshold=90
+// VMOptions=--use-slow-path
+// VMOptions=--use-slow-path --stacktrace-every=100
 
 import 'dart:ffi';
 

tests/ffi/function_varargs_generated_native_test.dart

@@ -6,10 +6,9 @@
 // Generated by tests/ffi/generator/structs_by_value_tests_generator.dart.
 //
 // SharedObjects=ffi_test_functions
-// VMOptions=--enable-experiment=records
-// VMOptions=--enable-experiment=records --deterministic --optimization-counter-threshold=90
-// VMOptions=--enable-experiment=records --use-slow-path
-// VMOptions=--enable-experiment=records --use-slow-path --stacktrace-every=100
+// VMOptions=--deterministic --optimization-counter-threshold=90
+// VMOptions=--use-slow-path
+// VMOptions=--use-slow-path --stacktrace-every=100
 
 import 'dart:ffi';
 

tests/ffi/function_varargs_generated_test.dart

@@ -6,10 +6,9 @@
 // Generated by tests/ffi/generator/structs_by_value_tests_generator.dart.
 //
 // SharedObjects=ffi_test_functions
-// VMOptions=--enable-experiment=records
-// VMOptions=--enable-experiment=records --deterministic --optimization-counter-threshold=90
-// VMOptions=--enable-experiment=records --use-slow-path
-// VMOptions=--enable-experiment=records --use-slow-path --stacktrace-every=100
+// VMOptions=--deterministic --optimization-counter-threshold=90
+// VMOptions=--use-slow-path
+// VMOptions=--use-slow-path --stacktrace-every=100
 
 import 'dart:ffi';
 

tests/ffi/function_varargs_name_test.dart

@@ -2,8 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// VMOptions=--enable-experiment=records
-
 // SharedObjects=ffi_test_functions
 
 import 'dylib_utils.dart';

tests/ffi/function_varargs_test.dart

@@ -2,8 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// VMOptions=--enable-experiment=records
-
 import 'dart:ffi';
 import 'dart:io';
 

tests/ffi/generator/structs_by_value_tests_generator.dart

@@ -1035,7 +1035,6 @@ Future<void> writeDartCallTest(
           : isLeaf
               ? 2021
               : 2020,
-      vmFlags: isVarArgs ? '--enable-experiment=records' : '',
     ));
     var suffix = isNative ? 'Native' : '';
     suffix += isLeaf ? 'Leaf' : '';
@@ -1144,7 +1143,6 @@ Future<void> writeDartCallbackTest(
     buffer.write(headerDartCallbackTest(
       isNnbd: isNnbd,
       copyrightYear: isVarArgs ? 2023 : 2020,
-      vmFlags: isVarArgs ? '--enable-experiment=records' : '',
     ));
 
     buffer.write("""

tests/ffi/regress_51504_test.dart

@@ -4,8 +4,6 @@
 
 // SharedObjects=ffi_test_functions
 
-// VMOptions=--enable-experiment=records
-
 import 'dart:ffi';
 import 'dart:io';