mirror of
https://github.com/dart-lang/sdk
synced 2024-09-16 03:27:43 +00:00
f20b0ddcc2
Closes https://github.com/dart-lang/sdk/issues/43022 Real static errors were added in a previous CL. This simply removes TODOs to address that and removes a TODO to handle contexts. Static error testing doesn't support testing for contexts. Change-Id: Id27fadeb77484a3556fdfdf4c50c8cd67ce2d9a0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159381 Auto-Submit: Srujan Gaddam <srujzs@google.com> Commit-Queue: Srujan Gaddam <srujzs@google.com> Commit-Queue: Nate Bosch <nbosch@google.com> Reviewed-by: Nate Bosch <nbosch@google.com>
60 lines
2.5 KiB
Dart
60 lines
2.5 KiB
Dart
// Copyright (c) 2020, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
// Checks for static errors related to parameters for constructors and
|
|
// factories.
|
|
|
|
@JS()
|
|
library js_constructor_parameters_static_test;
|
|
|
|
import 'package:js/js.dart';
|
|
import 'package:expect/expect.dart';
|
|
|
|
@JS()
|
|
class Foo {
|
|
external Foo({int? a});
|
|
// ^
|
|
// [web] Named parameters for JS interop functions are only allowed in a factory constructor of an @anonymous JS class.
|
|
external factory Foo.fooFactory({int? a});
|
|
// ^
|
|
// [web] Named parameters for JS interop functions are only allowed in a factory constructor of an @anonymous JS class.
|
|
}
|
|
|
|
@JS()
|
|
@anonymous
|
|
class Bar {
|
|
external Bar({int? a});
|
|
// ^
|
|
// [web] Named parameters for JS interop functions are only allowed in a factory constructor of an @anonymous JS class.
|
|
|
|
// Factories of an anonymous class can only contain named parameters.
|
|
external factory Bar.barFactoryPositional(int? a);
|
|
// ^
|
|
// [web] Factory constructors for @anonymous JS interop classes should not contain any positional parameters.
|
|
external factory Bar.barFactoryOptional([int? a]);
|
|
// ^
|
|
// [web] Factory constructors for @anonymous JS interop classes should not contain any positional parameters.
|
|
external factory Bar.barFactoryMixedOptional(int? a, [int? b]);
|
|
// ^
|
|
// [web] Factory constructors for @anonymous JS interop classes should not contain any positional parameters.
|
|
external factory Bar.barFactoryMixedNamed(int? a, {int? b});
|
|
// ^
|
|
// [web] Factory constructors for @anonymous JS interop classes should not contain any positional parameters.
|
|
|
|
// Named parameters are okay only for factories of an anonymous class.
|
|
external factory Bar.barFactoryNamed({int? a});
|
|
}
|
|
|
|
@JS()
|
|
abstract class Baz {
|
|
external Baz({int? a});
|
|
// ^
|
|
// [web] Named parameters for JS interop functions are only allowed in a factory constructor of an @anonymous JS class.
|
|
external factory Baz.bazFactory({int? a});
|
|
// ^
|
|
// [web] Named parameters for JS interop functions are only allowed in a factory constructor of an @anonymous JS class.
|
|
}
|
|
|
|
main() {}
|