languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 12:24:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

[package:js] Remove stale TODOs from static error tests

Browse source 
Closes https://github.com/dart-lang/sdk/issues/43022

Real static errors were added in a previous CL. This simply removes
TODOs to address that and removes a TODO to handle contexts. Static
error testing doesn't support testing for contexts.

Change-Id: Id27fadeb77484a3556fdfdf4c50c8cd67ce2d9a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159381
Auto-Submit: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
This commit is contained in:
Srujan Gaddam 2020-08-19 22:04:58 +00:00 committed by commit-bot@chromium.org
parent 32ae7d9efc
commit f20b0ddcc2
3 changed files with 0 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tests/lib/js/constructor_parameters_static_test.dart
View file

@ -2,8 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
// TODO(srujzs): Fix this test once web static error testing is supported.
// Checks for static errors related to parameters for constructors and
// factories.

4
tests/lib/js/js_annotation_static_test.dart
View file

@ -2,8 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
// TODO(srujzs): Fix this test once web static error testing is supported.
// Tests static errors for incorrect JS annotations.
@JS()
@ -12,8 +10,6 @@ library js_annotation_static_test;
import 'package:js/js.dart';
class Foo {
// ^^^
// [web] TODO(srujzs): Test context once supported.
@JS()
external Foo(int bar);
// ^

2
tests/lib/js/parameters_static_test.dart
View file

@ -2,8 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
// TODO(srujzs): Fix this test once web static error testing is supported.
// Checks for static errors related to parameters for methods.
@JS()