dart-sdk/runtime/observatory_2/lib
Vyacheslav Egorov 54be4bc80e [vm/service] Remove Stack.awaiterFrames
This field was supposed[1] to replace Stack.asyncCausalFrames but IDEs
and other service protocol users never adopted it.

The mechanism for collecting awaiterFrames and asyncCausalFrames
was originally considerably different, but we have since unified
both[2] after we switched to lazy async stack traces[3].

Today the only differences between the two are:

- asyncCausalFrames represens async gaps explicitly, while
  awaiterFrames does not;
- when asynchronous function is running its synchronous part
  before the first suspension awaiterFrames will still represent
  the corresponding frame as an asynchronous activation, while
  asyncCausalFrames will treat the same frame as regular frame.

Consequently having this field does not add any value.

This CL removes it from the response and updates all tests to
test against asyncCausalFrames.

[1]: https://codereview.chromium.org/2692803006/
[2]: https://dart-review.googlesource.com/c/sdk/+/167561
[3]: https://github.com/dart-lang/sdk/issues/37668

Tested: pkg/vm_service, service, service_2
Bug: https://github.com/dart-lang/sdk/issues/51763
Change-Id: If2b035a8840047423b8ed8ce3b5d81155e9f38d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/301062
Commit-Queue: Slava Egorov <vegorov@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2023-05-09 13:46:56 +00:00
..
src [vm/service] Remove Stack.awaiterFrames 2023-05-09 13:46:56 +00:00
allocation_profile.dart Copy Dart 2 version of Observatory and service tests. 2020-10-07 22:20:25 +00:00
app.dart [observatory] remove unused_imports and some unused variables 2023-02-15 16:49:58 +00:00
cli.dart Copy Dart 2 version of Observatory and service tests. 2020-10-07 22:20:25 +00:00
debugger.dart Copy Dart 2 version of Observatory and service tests. 2020-10-07 22:20:25 +00:00
elements.dart [ Observatory ] Remove footer with dead / irrelevant links 2021-10-11 23:30:24 +00:00
event.dart Copy Dart 2 version of Observatory and service tests. 2020-10-07 22:20:25 +00:00
models.dart [observatory] remove unused_imports and some unused variables 2023-02-15 16:49:58 +00:00
object_graph.dart [observatory] remove unused_imports and some unused variables 2023-02-15 16:49:58 +00:00
repositories.dart [observatory] remove unused_imports and some unused variables 2023-02-15 16:49:58 +00:00
sample_profile.dart Copy Dart 2 version of Observatory and service tests. 2020-10-07 22:20:25 +00:00
service.dart Copy Dart 2 version of Observatory and service tests. 2020-10-07 22:20:25 +00:00
service_common.dart Change : to = for default values in runtime/. 2022-08-23 13:53:42 +00:00
service_html.dart [observatory] remove unused_imports and some unused variables 2023-02-15 16:49:58 +00:00
service_io.dart Copy Dart 2 version of Observatory and service tests. 2020-10-07 22:20:25 +00:00
tracer.dart Change : to = for default values in runtime/. 2022-08-23 13:53:42 +00:00
utils.dart Copy Dart 2 version of Observatory and service tests. 2020-10-07 22:20:25 +00:00