languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 08:24:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ Observatory ] Remove footer with dead / irrelevant links

Browse source 
Fixes https://github.com/dart-lang/sdk/issues/47391

TEST=N/A

Change-Id: Idfe6b43e23fa8b8ee3beb64c59e916e342a323e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216240
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
This commit is contained in:
Ben Konyi 2021-10-11 23:30:24 +00:00 committed by commit-bot@chromium.org
parent 669073094d
commit 1e8b4683f0
56 changed files with 0 additions and 233 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
runtime/observatory/lib/elements.dart
View file

@ -92,7 +92,6 @@ export 'package:observatory/src/elements/type_arguments_ref.dart';
export 'package:observatory/src/elements/unknown_ref.dart';
export 'package:observatory/src/elements/unlinkedcall_ref.dart';
export 'package:observatory/src/elements/unlinkedcall_view.dart';
export 'package:observatory/src/elements/view_footer.dart';
export 'package:observatory/src/elements/vm_connect.dart';
export 'package:observatory/src/elements/vm_connect_target.dart';
export 'package:observatory/src/elements/vm_view.dart';

3
runtime/observatory/lib/src/elements/class_view.dart
View file

@ -30,7 +30,6 @@ import 'package:observatory/src/elements/nav/vm_menu.dart';
import 'package:observatory/src/elements/object_common.dart';
import 'package:observatory/src/elements/source_inset.dart';
import 'package:observatory/src/elements/source_link.dart';
import 'package:observatory/src/elements/view_footer.dart';
class ClassViewElement extends CustomElement implements Renderable {
late RenderingScheduler<ClassViewElement> _r;
@ -257,8 +256,6 @@ class ClassViewElement extends CustomElement implements Renderable {
.element
]
: const [],
new HRElement(),
new ViewFooterElement(queue: _r.queue).element
]
];
}

4
runtime/observatory/lib/src/elements/context_view.dart
View file

@ -19,7 +19,6 @@ import 'package:observatory/src/elements/nav/refresh.dart';
import 'package:observatory/src/elements/nav/top_menu.dart';
import 'package:observatory/src/elements/nav/vm_menu.dart';
import 'package:observatory/src/elements/object_common.dart';
import 'package:observatory/src/elements/view_footer.dart';
class ContextViewElement extends CustomElement implements Renderable {
late RenderingScheduler<ContextViewElement> _r;
@ -187,9 +186,6 @@ class ContextViewElement extends CustomElement implements Renderable {
]
]);
}
content.add(new DivElement()
..classes = ['content-centered-big']
..children = <Element>[new ViewFooterElement(queue: _r.queue).element]);
children = content;
}
}

2
runtime/observatory/lib/src/elements/error_view.dart
View file

@ -12,7 +12,6 @@ import 'package:observatory/src/elements/helpers/rendering_scheduler.dart';
import 'package:observatory/src/elements/helpers/custom_element.dart';
import 'package:observatory/src/elements/nav/notify.dart';
import 'package:observatory/src/elements/nav/top_menu.dart';
import 'package:observatory/src/elements/view_footer.dart';
class ErrorViewElement extends CustomElement implements Renderable {
late RenderingScheduler<ErrorViewElement> _r;
@ -67,7 +66,6 @@ class ErrorViewElement extends CustomElement implements Renderable {
..classes = ['well']
..children = <Element>[new PreElement()..text = error.message]
],
new ViewFooterElement(queue: _r.queue).element
];
}

2
runtime/observatory/lib/src/elements/field_view.dart
View file

@ -24,7 +24,6 @@ import 'package:observatory/src/elements/nav/vm_menu.dart';
import 'package:observatory/src/elements/object_common.dart';
import 'package:observatory/src/elements/script_inset.dart';
import 'package:observatory/src/elements/source_link.dart';
import 'package:observatory/src/elements/view_footer.dart';
class FieldViewElement extends CustomElement implements Renderable {
late RenderingScheduler<FieldViewElement> _r;
@ -162,7 +161,6 @@ class FieldViewElement extends CustomElement implements Renderable {
queue: _r.queue)
.element
],
new ViewFooterElement(queue: _r.queue).element
]
];
}

2
runtime/observatory/lib/src/elements/flag_list.dart
View file

@ -16,7 +16,6 @@ import 'package:observatory/src/elements/nav/notify.dart';
import 'package:observatory/src/elements/nav/refresh.dart';
import 'package:observatory/src/elements/nav/top_menu.dart';
import 'package:observatory/src/elements/nav/vm_menu.dart';
import 'package:observatory/src/elements/view_footer.dart';
class FlagListElement extends CustomElement implements Renderable {
late RenderingScheduler<FlagListElement> _r;
@ -108,7 +107,6 @@ class FlagListElement extends CustomElement implements Renderable {
new DivElement()
..classes = ['content-centered']
..children = content,
new ViewFooterElement(queue: _r.queue).element
];
}

2
runtime/observatory/lib/src/elements/function_view.dart
View file

@ -27,7 +27,6 @@ import 'package:observatory/src/elements/nav/vm_menu.dart';
import 'package:observatory/src/elements/object_common.dart';
import 'package:observatory/src/elements/source_inset.dart';
import 'package:observatory/src/elements/source_link.dart';
import 'package:observatory/src/elements/view_footer.dart';
class FunctionViewElement extends CustomElement implements Renderable {
late RenderingScheduler<FunctionViewElement> _r;
@ -145,7 +144,6 @@ class FunctionViewElement extends CustomElement implements Renderable {
queue: _r.queue)
.element
],
new ViewFooterElement(queue: _r.queue).element
]
];
}

2
runtime/observatory/lib/src/elements/icdata_view.dart
View file

@ -17,7 +17,6 @@ import 'package:observatory/src/elements/nav/refresh.dart';
import 'package:observatory/src/elements/nav/top_menu.dart';
import 'package:observatory/src/elements/nav/vm_menu.dart';
import 'package:observatory/src/elements/object_common.dart';
import 'package:observatory/src/elements/view_footer.dart';
class ICDataViewElement extends CustomElement implements Renderable {
late RenderingScheduler<ICDataViewElement> _r;
@ -182,7 +181,6 @@ class ICDataViewElement extends CustomElement implements Renderable {
]
],
new HRElement(),
new ViewFooterElement(queue: _r.queue).element
]
];
}

3
runtime/observatory/lib/src/elements/instance_view.dart
View file

@ -29,7 +29,6 @@ import 'package:observatory/src/elements/nav/vm_menu.dart';
import 'package:observatory/src/elements/object_common.dart';
import 'package:observatory/src/elements/source_inset.dart';
import 'package:observatory/src/elements/source_link.dart';
import 'package:observatory/src/elements/view_footer.dart';
import 'package:observatory/utils.dart';
class InstanceViewElement extends CustomElement implements Renderable {
@ -163,8 +162,6 @@ class InstanceViewElement extends CustomElement implements Renderable {
.element
]);
}
content.addAll(
[new HRElement(), new ViewFooterElement(queue: _r.queue).element]);
children = <Element>[
navBar(_createMenu()),
new DivElement()

2
runtime/observatory/lib/src/elements/isolate_reconnect.dart
View file

@ -13,7 +13,6 @@ import 'package:observatory/src/elements/helpers/custom_element.dart';
import 'package:observatory/src/elements/helpers/uris.dart';
import 'package:observatory/src/elements/nav/notify.dart';
import 'package:observatory/src/elements/nav/top_menu.dart';
import 'package:observatory/src/elements/view_footer.dart';
class IsolateReconnectElement extends CustomElement implements Renderable {
late RenderingScheduler<IsolateReconnectElement> _r;
@ -104,7 +103,6 @@ class IsolateReconnectElement extends CustomElement implements Renderable {
new AnchorElement(href: Uris.vm())..text = 'isolates summary',
]))
],
new ViewFooterElement(queue: _r.queue).element
];
}
}

3
runtime/observatory/lib/src/elements/isolate_view.dart
View file

@ -27,7 +27,6 @@ import 'package:observatory/src/elements/nav/top_menu.dart';
import 'package:observatory/src/elements/nav/vm_menu.dart';
import 'package:observatory/src/elements/script_inset.dart';
import 'package:observatory/src/elements/source_inset.dart';
import 'package:observatory/src/elements/view_footer.dart';
import 'package:observatory/utils.dart';
class IsolateViewElement extends CustomElement implements Renderable {
@ -305,8 +304,6 @@ class IsolateViewElement extends CustomElement implements Renderable {
.element
]
: const [],
new HRElement(),
new ViewFooterElement(queue: _r.queue).element
]
];
}

3
runtime/observatory/lib/src/elements/json_view.dart
View file

@ -12,7 +12,6 @@ import 'package:observatory/src/elements/helpers/rendering_scheduler.dart';
import 'package:observatory/src/elements/helpers/custom_element.dart';
import 'package:observatory/src/elements/nav/notify.dart';
import 'package:observatory/src/elements/nav/top_menu.dart';
import 'package:observatory/src/elements/view_footer.dart';
class JSONViewElement extends CustomElement implements Renderable {
late RenderingScheduler<JSONViewElement> _r;
@ -63,8 +62,6 @@ class JSONViewElement extends CustomElement implements Renderable {
new HeadingElement.h2()..text = 'Object',
new HRElement(),
new PreElement()..text = JSONPretty.stringify(_map),
new HRElement(),
new ViewFooterElement(queue: _r.queue).element
]
];
}

3
runtime/observatory/lib/src/elements/library_view.dart
View file

@ -26,7 +26,6 @@ import 'package:observatory/src/elements/nav/vm_menu.dart';
import 'package:observatory/src/elements/object_common.dart';
import 'package:observatory/src/elements/script_ref.dart';
import 'package:observatory/src/elements/script_inset.dart';
import 'package:observatory/src/elements/view_footer.dart';
class LibraryViewElement extends CustomElement implements Renderable {
late RenderingScheduler<LibraryViewElement> _r;
@ -190,8 +189,6 @@ class LibraryViewElement extends CustomElement implements Renderable {
queue: _r.queue)
.element
],
new HRElement(),
new ViewFooterElement(queue: _r.queue).element
]
];
}

1
runtime/observatory/lib/src/elements/logging.dart
View file

@ -19,7 +19,6 @@ import 'package:observatory/src/elements/nav/notify.dart';
import 'package:observatory/src/elements/nav/refresh.dart';
import 'package:observatory/src/elements/nav/top_menu.dart';
import 'package:observatory/src/elements/nav/vm_menu.dart';
import 'package:observatory/src/elements/view_footer.dart';
class LoggingPageElement extends CustomElement implements Renderable {
late RenderingScheduler<LoggingPageElement> _r;

3
runtime/observatory/lib/src/elements/megamorphiccache_view.dart
View file

@ -20,7 +20,6 @@ import 'package:observatory/src/elements/nav/refresh.dart';
import 'package:observatory/src/elements/nav/top_menu.dart';
import 'package:observatory/src/elements/nav/vm_menu.dart';
import 'package:observatory/src/elements/object_common.dart';
import 'package:observatory/src/elements/view_footer.dart';
class MegamorphicCacheViewElement extends CustomElement implements Renderable {
late RenderingScheduler<MegamorphicCacheViewElement> _r;
@ -177,8 +176,6 @@ class MegamorphicCacheViewElement extends CustomElement implements Renderable {
]
]
],
new HRElement(),
new ViewFooterElement(queue: _r.queue).element
]
];
}

3
runtime/observatory/lib/src/elements/object_view.dart
View file

@ -17,7 +17,6 @@ import 'package:observatory/src/elements/nav/refresh.dart';
import 'package:observatory/src/elements/nav/top_menu.dart';
import 'package:observatory/src/elements/nav/vm_menu.dart';
import 'package:observatory/src/elements/object_common.dart';
import 'package:observatory/src/elements/view_footer.dart';
class ObjectViewElement extends CustomElement implements Renderable {
late RenderingScheduler<ObjectViewElement> _r;
@ -116,8 +115,6 @@ class ObjectViewElement extends CustomElement implements Renderable {
_reachableSizes, _references, _retainingPaths, _objects,
queue: _r.queue)
.element,
new HRElement(),
new ViewFooterElement(queue: _r.queue).element
]
];
}

3
runtime/observatory/lib/src/elements/objectpool_view.dart
View file

@ -20,7 +20,6 @@ import 'package:observatory/src/elements/nav/refresh.dart';
import 'package:observatory/src/elements/nav/top_menu.dart';
import 'package:observatory/src/elements/nav/vm_menu.dart';
import 'package:observatory/src/elements/object_common.dart';
import 'package:observatory/src/elements/view_footer.dart';
class ObjectPoolViewElement extends CustomElement implements Renderable {
late RenderingScheduler<ObjectPoolViewElement> _r;
@ -140,8 +139,6 @@ class ObjectPoolViewElement extends CustomElement implements Renderable {
..children = _createEntry(entry)
])
.toList(),
new HRElement(),
new ViewFooterElement(queue: _r.queue).element
]
];
}

2
runtime/observatory/lib/src/elements/objectstore_view.dart
View file

@ -17,7 +17,6 @@ import 'package:observatory/src/elements/nav/notify.dart';
import 'package:observatory/src/elements/nav/refresh.dart';
import 'package:observatory/src/elements/nav/top_menu.dart';
import 'package:observatory/src/elements/nav/vm_menu.dart';
import 'package:observatory/src/elements/view_footer.dart';
class ObjectStoreViewElement extends CustomElement implements Renderable {
late RenderingScheduler<ObjectStoreViewElement> _r;
@ -116,7 +115,6 @@ class ObjectStoreViewElement extends CustomElement implements Renderable {
]
])
.toList()),
new ViewFooterElement(queue: _r.queue).element
]
];
}

2
runtime/observatory/lib/src/elements/ports.dart
View file

@ -16,7 +16,6 @@ import 'package:observatory/src/elements/nav/notify.dart';
import 'package:observatory/src/elements/nav/refresh.dart';
import 'package:observatory/src/elements/nav/top_menu.dart';
import 'package:observatory/src/elements/nav/vm_menu.dart';
import 'package:observatory/src/elements/view_footer.dart';
class PortsElement extends CustomElement implements Renderable {
late RenderingScheduler<PortsElement> _r;
@ -101,7 +100,6 @@ class PortsElement extends CustomElement implements Renderable {
new BRElement(),
new DivElement()..children = _createList(),
],
new ViewFooterElement(queue: _r.queue).element
];
}

2
runtime/observatory/lib/src/elements/script_view.dart
View file

@ -21,7 +21,6 @@ import 'package:observatory/src/elements/nav/top_menu.dart';
import 'package:observatory/src/elements/nav/vm_menu.dart';
import 'package:observatory/src/elements/object_common.dart';
import 'package:observatory/src/elements/script_inset.dart';
import 'package:observatory/src/elements/view_footer.dart';
class ScriptViewElement extends CustomElement implements Renderable {
late RenderingScheduler<ScriptViewElement> _r;
@ -149,7 +148,6 @@ class ScriptViewElement extends CustomElement implements Renderable {
new ScriptInsetElement(_isolate, _script, _scripts, _objects, _events,
currentPos: _pos, queue: _r.queue)
.element,
new ViewFooterElement(queue: _r.queue).element
]
];
}

3
runtime/observatory/lib/src/elements/sentinel_view.dart
View file

@ -13,7 +13,6 @@ import 'package:observatory/src/elements/nav/isolate_menu.dart';
import 'package:observatory/src/elements/nav/notify.dart';
import 'package:observatory/src/elements/nav/top_menu.dart';
import 'package:observatory/src/elements/nav/vm_menu.dart';
import 'package:observatory/src/elements/view_footer.dart';
class SentinelViewElement extends CustomElement implements Renderable {
late RenderingScheduler<SentinelViewElement> _r;
@ -82,8 +81,6 @@ class SentinelViewElement extends CustomElement implements Renderable {
..text = 'Sentinel: #{_sentinel.valueAsString}',
new HRElement(),
new DivElement()..text = _sentinelKindToDescription(_sentinel.kind),
new HRElement(),
new ViewFooterElement(queue: _r.queue).element
]
];
}

3
runtime/observatory/lib/src/elements/singletargetcache_view.dart
View file

@ -17,7 +17,6 @@ import 'package:observatory/src/elements/nav/refresh.dart';
import 'package:observatory/src/elements/nav/top_menu.dart';
import 'package:observatory/src/elements/nav/vm_menu.dart';
import 'package:observatory/src/elements/object_common.dart';
import 'package:observatory/src/elements/view_footer.dart';
class SingleTargetCacheViewElement extends CustomElement implements Renderable {
late RenderingScheduler<SingleTargetCacheViewElement> _r;
@ -170,8 +169,6 @@ class SingleTargetCacheViewElement extends CustomElement implements Renderable {
]
]
],
new HRElement(),
new ViewFooterElement(queue: _r.queue).element
]
];
}

3
runtime/observatory/lib/src/elements/subtypetestcache_view.dart
View file

@ -17,7 +17,6 @@ import 'package:observatory/src/elements/nav/refresh.dart';
import 'package:observatory/src/elements/nav/top_menu.dart';
import 'package:observatory/src/elements/nav/vm_menu.dart';
import 'package:observatory/src/elements/object_common.dart';
import 'package:observatory/src/elements/view_footer.dart';
class SubtypeTestCacheViewElement extends CustomElement implements Renderable {
late RenderingScheduler<SubtypeTestCacheViewElement> _r;
@ -141,8 +140,6 @@ class SubtypeTestCacheViewElement extends CustomElement implements Renderable {
]
]
],
new HRElement(),
new ViewFooterElement(queue: _r.queue).element
]
];
}

3
runtime/observatory/lib/src/elements/unlinkedcall_view.dart
View file

@ -17,7 +17,6 @@ import 'package:observatory/src/elements/nav/refresh.dart';
import 'package:observatory/src/elements/nav/top_menu.dart';
import 'package:observatory/src/elements/nav/vm_menu.dart';
import 'package:observatory/src/elements/object_common.dart';
import 'package:observatory/src/elements/view_footer.dart';
class UnlinkedCallViewElement extends CustomElement implements Renderable {
late RenderingScheduler<UnlinkedCallViewElement> _r;
@ -153,8 +152,6 @@ class UnlinkedCallViewElement extends CustomElement implements Renderable {
]
]
],
new HRElement(),
new ViewFooterElement(queue: _r.queue).element
]
];
}

51
runtime/observatory/lib/src/elements/view_footer.dart
View file

@ -1,51 +0,0 @@
// Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
library view_footer_element;
import 'dart:html';
import 'dart:async';
import 'package:observatory/src/elements/helpers/custom_element.dart';
import 'package:observatory/src/elements/helpers/rendering_scheduler.dart';
class ViewFooterElement extends CustomElement implements Renderable {
late RenderingScheduler<ViewFooterElement> _r;
Stream<RenderedEvent<ViewFooterElement>> get onRendered => _r.onRendered;
factory ViewFooterElement({RenderingQueue? queue}) {
ViewFooterElement e = new ViewFooterElement.created();
e._r = new RenderingScheduler<ViewFooterElement>(e, queue: queue);
return e;
}
ViewFooterElement.created() : super.created('view-footer');
@override
void attached() {
super.attached();
_r.enable();
}
@override
void detached() {
super.detached();
children = <Element>[];
_r.disable(notify: true);
}
void render() {
children = <Element>[
new AnchorElement()
// ignore: unsafe_html
..href = 'https://dart-lang.github.io/observatory/'
..text = 'View documentation',
new AnchorElement()
// ignore: unsafe_html
..href =
'https://github.com/dart-lang/sdk/issues/new?title=Observatory:&amp;body=Observatory%20Feedback'
..text = 'File a bug report'
];
}
}

2
runtime/observatory/lib/src/elements/vm_connect.dart
View file

@ -13,7 +13,6 @@ import 'package:observatory/src/elements/helpers/rendering_scheduler.dart';
import 'package:observatory/src/elements/helpers/custom_element.dart';
import 'package:observatory/src/elements/nav/notify.dart';
import 'package:observatory/src/elements/nav/top_menu.dart';
import 'package:observatory/src/elements/view_footer.dart';
import 'package:observatory/src/elements/vm_connect_target.dart';
class VMConnectElement extends CustomElement implements Renderable {
@ -114,7 +113,6 @@ class VMConnectElement extends CustomElement implements Renderable {
new DivElement()..classes = ['flex-item-20-percent'],
],
],
new ViewFooterElement(queue: _r.queue).element
];
}

2
runtime/observatory/lib/src/elements/vm_view.dart
View file

@ -16,7 +16,6 @@ import 'package:observatory/src/elements/nav/notify.dart';
import 'package:observatory/src/elements/nav/refresh.dart';
import 'package:observatory/src/elements/nav/top_menu.dart';
import 'package:observatory/src/elements/nav/vm_menu.dart';
import 'package:observatory/src/elements/view_footer.dart';
import 'package:observatory/utils.dart';
class VMViewElement extends CustomElement implements Renderable {
@ -119,7 +118,6 @@ class VMViewElement extends CustomElement implements Renderable {
describeVM(),
describeIsolateGroups(),
describeSystemIsolateGroups(),
new ViewFooterElement(queue: _r.queue).element
];
}

1
runtime/observatory/observatory_sources.gni
View file

@ -137,7 +137,6 @@ observatory_sources = [
"lib/src/elements/unknown_ref.dart",
"lib/src/elements/unlinkedcall_ref.dart",
"lib/src/elements/unlinkedcall_view.dart",
"lib/src/elements/view_footer.dart",
"lib/src/elements/vm_connect.dart",
"lib/src/elements/vm_connect_target.dart",
"lib/src/elements/vm_view.dart",

1
runtime/observatory_2/lib/elements.dart
View file

@ -93,7 +93,6 @@ export 'package:observatory_2/src/elements/type_arguments_ref.dart';
export 'package:observatory_2/src/elements/unknown_ref.dart';
export 'package:observatory_2/src/elements/unlinkedcall_ref.dart';
export 'package:observatory_2/src/elements/unlinkedcall_view.dart';
export 'package:observatory_2/src/elements/view_footer.dart';
export 'package:observatory_2/src/elements/vm_connect.dart';
export 'package:observatory_2/src/elements/vm_connect_target.dart';
export 'package:observatory_2/src/elements/vm_view.dart';

3
runtime/observatory_2/lib/src/elements/class_view.dart
View file

@ -30,7 +30,6 @@ import 'package:observatory_2/src/elements/nav/vm_menu.dart';
import 'package:observatory_2/src/elements/object_common.dart';
import 'package:observatory_2/src/elements/source_inset.dart';
import 'package:observatory_2/src/elements/source_link.dart';
import 'package:observatory_2/src/elements/view_footer.dart';
class ClassViewElement extends CustomElement implements Renderable {
RenderingScheduler<ClassViewElement> _r;
@ -257,8 +256,6 @@ class ClassViewElement extends CustomElement implements Renderable {
.element
]
: const [],
new HRElement(),
new ViewFooterElement(queue: _r.queue).element
]
];
}

4
runtime/observatory_2/lib/src/elements/context_view.dart
View file

@ -19,7 +19,6 @@ import 'package:observatory_2/src/elements/nav/refresh.dart';
import 'package:observatory_2/src/elements/nav/top_menu.dart';
import 'package:observatory_2/src/elements/nav/vm_menu.dart';
import 'package:observatory_2/src/elements/object_common.dart';
import 'package:observatory_2/src/elements/view_footer.dart';
class ContextViewElement extends CustomElement implements Renderable {
RenderingScheduler<ContextViewElement> _r;
@ -187,9 +186,6 @@ class ContextViewElement extends CustomElement implements Renderable {
]
]);
}
content.add(new DivElement()
..classes = ['content-centered-big']
..children = <Element>[new ViewFooterElement(queue: _r.queue).element]);
children = content;
}
}

2
runtime/observatory_2/lib/src/elements/error_view.dart
View file

@ -12,7 +12,6 @@ import 'package:observatory_2/src/elements/helpers/rendering_scheduler.dart';
import 'package:observatory_2/src/elements/helpers/custom_element.dart';
import 'package:observatory_2/src/elements/nav/notify.dart';
import 'package:observatory_2/src/elements/nav/top_menu.dart';
import 'package:observatory_2/src/elements/view_footer.dart';
class ErrorViewElement extends CustomElement implements Renderable {
RenderingScheduler<ErrorViewElement> _r;
@ -67,7 +66,6 @@ class ErrorViewElement extends CustomElement implements Renderable {
..classes = ['well']
..children = <Element>[new PreElement()..text = error.message]
],
new ViewFooterElement(queue: _r.queue).element
];
}

2
runtime/observatory_2/lib/src/elements/field_view.dart
View file

@ -24,7 +24,6 @@ import 'package:observatory_2/src/elements/nav/vm_menu.dart';
import 'package:observatory_2/src/elements/object_common.dart';
import 'package:observatory_2/src/elements/script_inset.dart';
import 'package:observatory_2/src/elements/source_link.dart';
import 'package:observatory_2/src/elements/view_footer.dart';
class FieldViewElement extends CustomElement implements Renderable {
RenderingScheduler<FieldViewElement> _r;
@ -162,7 +161,6 @@ class FieldViewElement extends CustomElement implements Renderable {
queue: _r.queue)
.element
],
new ViewFooterElement(queue: _r.queue).element
]
];
}

2
runtime/observatory_2/lib/src/elements/flag_list.dart
View file

@ -16,7 +16,6 @@ import 'package:observatory_2/src/elements/nav/notify.dart';
import 'package:observatory_2/src/elements/nav/refresh.dart';
import 'package:observatory_2/src/elements/nav/top_menu.dart';
import 'package:observatory_2/src/elements/nav/vm_menu.dart';
import 'package:observatory_2/src/elements/view_footer.dart';
class FlagListElement extends CustomElement implements Renderable {
RenderingScheduler<FlagListElement> _r;
@ -108,7 +107,6 @@ class FlagListElement extends CustomElement implements Renderable {
new DivElement()
..classes = ['content-centered']
..children = content,
new ViewFooterElement(queue: _r.queue).element
];
}

2
runtime/observatory_2/lib/src/elements/function_view.dart
View file

@ -27,7 +27,6 @@ import 'package:observatory_2/src/elements/nav/vm_menu.dart';
import 'package:observatory_2/src/elements/object_common.dart';
import 'package:observatory_2/src/elements/source_inset.dart';
import 'package:observatory_2/src/elements/source_link.dart';
import 'package:observatory_2/src/elements/view_footer.dart';
class FunctionViewElement extends CustomElement implements Renderable {
RenderingScheduler<FunctionViewElement> _r;
@ -145,7 +144,6 @@ class FunctionViewElement extends CustomElement implements Renderable {
queue: _r.queue)
.element
],
new ViewFooterElement(queue: _r.queue).element
]
];
}

3
runtime/observatory_2/lib/src/elements/icdata_view.dart
View file

@ -17,7 +17,6 @@ import 'package:observatory_2/src/elements/nav/refresh.dart';
import 'package:observatory_2/src/elements/nav/top_menu.dart';
import 'package:observatory_2/src/elements/nav/vm_menu.dart';
import 'package:observatory_2/src/elements/object_common.dart';
import 'package:observatory_2/src/elements/view_footer.dart';
class ICDataViewElement extends CustomElement implements Renderable {
RenderingScheduler<ICDataViewElement> _r;
@ -181,8 +180,6 @@ class ICDataViewElement extends CustomElement implements Renderable {
]
]
],
new HRElement(),
new ViewFooterElement(queue: _r.queue).element
]
];
}

3
runtime/observatory_2/lib/src/elements/instance_view.dart
View file

@ -29,7 +29,6 @@ import 'package:observatory_2/src/elements/nav/vm_menu.dart';
import 'package:observatory_2/src/elements/object_common.dart';
import 'package:observatory_2/src/elements/source_inset.dart';
import 'package:observatory_2/src/elements/source_link.dart';
import 'package:observatory_2/src/elements/view_footer.dart';
import 'package:observatory_2/utils.dart';
class InstanceViewElement extends CustomElement implements Renderable {
@ -162,8 +161,6 @@ class InstanceViewElement extends CustomElement implements Renderable {
.element
]);
}
content.addAll(
[new HRElement(), new ViewFooterElement(queue: _r.queue).element]);
children = <Element>[
navBar(_createMenu()),
new DivElement()

2
runtime/observatory_2/lib/src/elements/isolate_reconnect.dart
View file

@ -13,7 +13,6 @@ import 'package:observatory_2/src/elements/helpers/custom_element.dart';
import 'package:observatory_2/src/elements/helpers/uris.dart';
import 'package:observatory_2/src/elements/nav/notify.dart';
import 'package:observatory_2/src/elements/nav/top_menu.dart';
import 'package:observatory_2/src/elements/view_footer.dart';
class IsolateReconnectElement extends CustomElement implements Renderable {
RenderingScheduler<IsolateReconnectElement> _r;
@ -104,7 +103,6 @@ class IsolateReconnectElement extends CustomElement implements Renderable {
new AnchorElement(href: Uris.vm())..text = 'isolates summary',
]))
],
new ViewFooterElement(queue: _r.queue).element
];
}
}

3
runtime/observatory_2/lib/src/elements/isolate_view.dart
View file

@ -27,7 +27,6 @@ import 'package:observatory_2/src/elements/nav/top_menu.dart';
import 'package:observatory_2/src/elements/nav/vm_menu.dart';
import 'package:observatory_2/src/elements/script_inset.dart';
import 'package:observatory_2/src/elements/source_inset.dart';
import 'package:observatory_2/src/elements/view_footer.dart';
import 'package:observatory_2/utils.dart';
class IsolateViewElement extends CustomElement implements Renderable {
@ -305,8 +304,6 @@ class IsolateViewElement extends CustomElement implements Renderable {
.element
]
: const [],
new HRElement(),
new ViewFooterElement(queue: _r.queue).element
]
];
}

3
runtime/observatory_2/lib/src/elements/json_view.dart
View file

@ -12,7 +12,6 @@ import 'package:observatory_2/src/elements/helpers/rendering_scheduler.dart';
import 'package:observatory_2/src/elements/helpers/custom_element.dart';
import 'package:observatory_2/src/elements/nav/notify.dart';
import 'package:observatory_2/src/elements/nav/top_menu.dart';
import 'package:observatory_2/src/elements/view_footer.dart';
class JSONViewElement extends CustomElement implements Renderable {
RenderingScheduler<JSONViewElement> _r;
@ -63,8 +62,6 @@ class JSONViewElement extends CustomElement implements Renderable {
new HeadingElement.h2()..text = 'Object',
new HRElement(),
new PreElement()..text = JSONPretty.stringify(_map),
new HRElement(),
new ViewFooterElement(queue: _r.queue).element
]
];
}

3
runtime/observatory_2/lib/src/elements/library_view.dart
View file

@ -26,7 +26,6 @@ import 'package:observatory_2/src/elements/nav/vm_menu.dart';
import 'package:observatory_2/src/elements/object_common.dart';
import 'package:observatory_2/src/elements/script_ref.dart';
import 'package:observatory_2/src/elements/script_inset.dart';
import 'package:observatory_2/src/elements/view_footer.dart';
class LibraryViewElement extends CustomElement implements Renderable {
RenderingScheduler<LibraryViewElement> _r;
@ -190,8 +189,6 @@ class LibraryViewElement extends CustomElement implements Renderable {
queue: _r.queue)
.element
],
new HRElement(),
new ViewFooterElement(queue: _r.queue).element
]
];
}

1
runtime/observatory_2/lib/src/elements/logging.dart
View file

@ -19,7 +19,6 @@ import 'package:observatory_2/src/elements/nav/notify.dart';
import 'package:observatory_2/src/elements/nav/refresh.dart';
import 'package:observatory_2/src/elements/nav/top_menu.dart';
import 'package:observatory_2/src/elements/nav/vm_menu.dart';
import 'package:observatory_2/src/elements/view_footer.dart';
class LoggingPageElement extends CustomElement implements Renderable {
RenderingScheduler<LoggingPageElement> _r;

3
runtime/observatory_2/lib/src/elements/megamorphiccache_view.dart
View file

@ -20,7 +20,6 @@ import 'package:observatory_2/src/elements/nav/refresh.dart';
import 'package:observatory_2/src/elements/nav/top_menu.dart';
import 'package:observatory_2/src/elements/nav/vm_menu.dart';
import 'package:observatory_2/src/elements/object_common.dart';
import 'package:observatory_2/src/elements/view_footer.dart';
class MegamorphicCacheViewElement extends CustomElement implements Renderable {
RenderingScheduler<MegamorphicCacheViewElement> _r;
@ -177,8 +176,6 @@ class MegamorphicCacheViewElement extends CustomElement implements Renderable {
]
]
],
new HRElement(),
new ViewFooterElement(queue: _r.queue).element
]
];
}

3
runtime/observatory_2/lib/src/elements/object_view.dart
View file

@ -17,7 +17,6 @@ import 'package:observatory_2/src/elements/nav/refresh.dart';
import 'package:observatory_2/src/elements/nav/top_menu.dart';
import 'package:observatory_2/src/elements/nav/vm_menu.dart';
import 'package:observatory_2/src/elements/object_common.dart';
import 'package:observatory_2/src/elements/view_footer.dart';
class ObjectViewElement extends CustomElement implements Renderable {
RenderingScheduler<ObjectViewElement> _r;
@ -117,8 +116,6 @@ class ObjectViewElement extends CustomElement implements Renderable {
_reachableSizes, _references, _retainingPaths, _objects,
queue: _r.queue)
.element,
new HRElement(),
new ViewFooterElement(queue: _r.queue).element
]
];
}

3
runtime/observatory_2/lib/src/elements/objectpool_view.dart
View file

@ -20,7 +20,6 @@ import 'package:observatory_2/src/elements/nav/refresh.dart';
import 'package:observatory_2/src/elements/nav/top_menu.dart';
import 'package:observatory_2/src/elements/nav/vm_menu.dart';
import 'package:observatory_2/src/elements/object_common.dart';
import 'package:observatory_2/src/elements/view_footer.dart';
class ObjectPoolViewElement extends CustomElement implements Renderable {
RenderingScheduler<ObjectPoolViewElement> _r;
@ -140,8 +139,6 @@ class ObjectPoolViewElement extends CustomElement implements Renderable {
..children = _createEntry(entry)
])
.toList(),
new HRElement(),
new ViewFooterElement(queue: _r.queue).element
]
];
}

2
runtime/observatory_2/lib/src/elements/objectstore_view.dart
View file

@ -17,7 +17,6 @@ import 'package:observatory_2/src/elements/nav/notify.dart';
import 'package:observatory_2/src/elements/nav/refresh.dart';
import 'package:observatory_2/src/elements/nav/top_menu.dart';
import 'package:observatory_2/src/elements/nav/vm_menu.dart';
import 'package:observatory_2/src/elements/view_footer.dart';
class ObjectStoreViewElement extends CustomElement implements Renderable {
RenderingScheduler<ObjectStoreViewElement> _r;
@ -116,7 +115,6 @@ class ObjectStoreViewElement extends CustomElement implements Renderable {
]
])
.toList()),
new ViewFooterElement(queue: _r.queue).element
]
];
}

2
runtime/observatory_2/lib/src/elements/ports.dart
View file

@ -16,7 +16,6 @@ import 'package:observatory_2/src/elements/nav/notify.dart';
import 'package:observatory_2/src/elements/nav/refresh.dart';
import 'package:observatory_2/src/elements/nav/top_menu.dart';
import 'package:observatory_2/src/elements/nav/vm_menu.dart';
import 'package:observatory_2/src/elements/view_footer.dart';
class PortsElement extends CustomElement implements Renderable {
RenderingScheduler<PortsElement> _r;
@ -101,7 +100,6 @@ class PortsElement extends CustomElement implements Renderable {
new BRElement(),
new DivElement()..children = _createList(),
],
new ViewFooterElement(queue: _r.queue).element
];
}

2
runtime/observatory_2/lib/src/elements/script_view.dart
View file

@ -21,7 +21,6 @@ import 'package:observatory_2/src/elements/nav/top_menu.dart';
import 'package:observatory_2/src/elements/nav/vm_menu.dart';
import 'package:observatory_2/src/elements/object_common.dart';
import 'package:observatory_2/src/elements/script_inset.dart';
import 'package:observatory_2/src/elements/view_footer.dart';
class ScriptViewElement extends CustomElement implements Renderable {
RenderingScheduler<ScriptViewElement> _r;
@ -149,7 +148,6 @@ class ScriptViewElement extends CustomElement implements Renderable {
new ScriptInsetElement(_isolate, _script, _scripts, _objects, _events,
currentPos: _pos, queue: _r.queue)
.element,
new ViewFooterElement(queue: _r.queue).element
]
];
}

3
runtime/observatory_2/lib/src/elements/sentinel_view.dart
View file

@ -13,7 +13,6 @@ import 'package:observatory_2/src/elements/nav/isolate_menu.dart';
import 'package:observatory_2/src/elements/nav/notify.dart';
import 'package:observatory_2/src/elements/nav/top_menu.dart';
import 'package:observatory_2/src/elements/nav/vm_menu.dart';
import 'package:observatory_2/src/elements/view_footer.dart';
class SentinelViewElement extends CustomElement implements Renderable {
RenderingScheduler<SentinelViewElement> _r;
@ -82,8 +81,6 @@ class SentinelViewElement extends CustomElement implements Renderable {
..text = 'Sentinel: #{_sentinel.valueAsString}',
new HRElement(),
new DivElement()..text = _sentinelKindToDescription(_sentinel.kind),
new HRElement(),
new ViewFooterElement(queue: _r.queue).element
]
];
}

3
runtime/observatory_2/lib/src/elements/singletargetcache_view.dart
View file

@ -17,7 +17,6 @@ import 'package:observatory_2/src/elements/nav/refresh.dart';
import 'package:observatory_2/src/elements/nav/top_menu.dart';
import 'package:observatory_2/src/elements/nav/vm_menu.dart';
import 'package:observatory_2/src/elements/object_common.dart';
import 'package:observatory_2/src/elements/view_footer.dart';
class SingleTargetCacheViewElement extends CustomElement implements Renderable {
RenderingScheduler<SingleTargetCacheViewElement> _r;
@ -170,8 +169,6 @@ class SingleTargetCacheViewElement extends CustomElement implements Renderable {
]
]
],
new HRElement(),
new ViewFooterElement(queue: _r.queue).element
]
];
}

3
runtime/observatory_2/lib/src/elements/subtypetestcache_view.dart
View file

@ -17,7 +17,6 @@ import 'package:observatory_2/src/elements/nav/refresh.dart';
import 'package:observatory_2/src/elements/nav/top_menu.dart';
import 'package:observatory_2/src/elements/nav/vm_menu.dart';
import 'package:observatory_2/src/elements/object_common.dart';
import 'package:observatory_2/src/elements/view_footer.dart';
class SubtypeTestCacheViewElement extends CustomElement implements Renderable {
RenderingScheduler<SubtypeTestCacheViewElement> _r;
@ -141,8 +140,6 @@ class SubtypeTestCacheViewElement extends CustomElement implements Renderable {
]
]
],
new HRElement(),
new ViewFooterElement(queue: _r.queue).element
]
];
}

3
runtime/observatory_2/lib/src/elements/unlinkedcall_view.dart
View file

@ -17,7 +17,6 @@ import 'package:observatory_2/src/elements/nav/refresh.dart';
import 'package:observatory_2/src/elements/nav/top_menu.dart';
import 'package:observatory_2/src/elements/nav/vm_menu.dart';
import 'package:observatory_2/src/elements/object_common.dart';
import 'package:observatory_2/src/elements/view_footer.dart';
class UnlinkedCallViewElement extends CustomElement implements Renderable {
RenderingScheduler<UnlinkedCallViewElement> _r;
@ -153,8 +152,6 @@ class UnlinkedCallViewElement extends CustomElement implements Renderable {
]
]
],
new HRElement(),
new ViewFooterElement(queue: _r.queue).element
]
];
}

51
runtime/observatory_2/lib/src/elements/view_footer.dart
View file

@ -1,51 +0,0 @@
// Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
library view_footer_element;
import 'dart:html';
import 'dart:async';
import 'package:observatory_2/src/elements/helpers/custom_element.dart';
import 'package:observatory_2/src/elements/helpers/rendering_scheduler.dart';
class ViewFooterElement extends CustomElement implements Renderable {
RenderingScheduler<ViewFooterElement> _r;
Stream<RenderedEvent<ViewFooterElement>> get onRendered => _r.onRendered;
factory ViewFooterElement({RenderingQueue queue}) {
ViewFooterElement e = new ViewFooterElement.created();
e._r = new RenderingScheduler<ViewFooterElement>(e, queue: queue);
return e;
}
ViewFooterElement.created() : super.created('view-footer');
@override
void attached() {
super.attached();
_r.enable();
}
@override
void detached() {
super.detached();
children = <Element>[];
_r.disable(notify: true);
}
void render() {
children = <Element>[
new AnchorElement()
// ignore: unsafe_html
..href = 'https://dart-lang.github.io/observatory/'
..text = 'View documentation',
new AnchorElement()
// ignore: unsafe_html
..href =
'https://github.com/dart-lang/sdk/issues/new?title=Observatory:&amp;body=Observatory%20Feedback'
..text = 'File a bug report'
];
}
}

2
runtime/observatory_2/lib/src/elements/vm_connect.dart
View file

@ -13,7 +13,6 @@ import 'package:observatory_2/src/elements/helpers/rendering_scheduler.dart';
import 'package:observatory_2/src/elements/helpers/custom_element.dart';
import 'package:observatory_2/src/elements/nav/notify.dart';
import 'package:observatory_2/src/elements/nav/top_menu.dart';
import 'package:observatory_2/src/elements/view_footer.dart';
import 'package:observatory_2/src/elements/vm_connect_target.dart';
class VMConnectElement extends CustomElement implements Renderable {
@ -114,7 +113,6 @@ class VMConnectElement extends CustomElement implements Renderable {
new DivElement()..classes = ['flex-item-20-percent'],
],
],
new ViewFooterElement(queue: _r.queue).element
];
}

2
runtime/observatory_2/lib/src/elements/vm_view.dart
View file

@ -16,7 +16,6 @@ import 'package:observatory_2/src/elements/nav/notify.dart';
import 'package:observatory_2/src/elements/nav/refresh.dart';
import 'package:observatory_2/src/elements/nav/top_menu.dart';
import 'package:observatory_2/src/elements/nav/vm_menu.dart';
import 'package:observatory_2/src/elements/view_footer.dart';
import 'package:observatory_2/utils.dart';
class VMViewElement extends CustomElement implements Renderable {
@ -119,7 +118,6 @@ class VMViewElement extends CustomElement implements Renderable {
describeVM(),
describeIsolateGroups(),
describeSystemIsolateGroups(),
new ViewFooterElement(queue: _r.queue).element
];
}

1
runtime/observatory_2/observatory_sources.gni
View file

@ -139,7 +139,6 @@ observatory_sources = [
"lib/src/elements/unknown_ref.dart",
"lib/src/elements/unlinkedcall_ref.dart",
"lib/src/elements/unlinkedcall_view.dart",
"lib/src/elements/view_footer.dart",
"lib/src/elements/vm_connect.dart",
"lib/src/elements/vm_connect_target.dart",
"lib/src/elements/vm_view.dart",