mirror of
https://github.com/dart-lang/sdk
synced 2024-10-01 16:44:02 +00:00
53eabe4824
This change migrates the Dart linux builders from Goma to RBE via reclient. Goma is being shut down by the end of the year and we must migrate to the new replacement, which is much more powerful and can do things we could never do with Goma. We should already see some mild build time improvements from simply switching. This change can be safely reverted if there are any problems: - If you must revert this change, please reach out with what you observed, but please first read and try the below instructions. - Cross-compilation with RBE is not implemented at this time and certain special builders running on Linux intel may not support RBE. The existing configuration support to disable Goma remains in place. The existence of configuration file makes the recipe switch all Linux x64 bots use RBE rather than Goma. Try disabling Goma on any builders that are failing, whether using `--no-goma` in the test matrix or using `goma = False` on infra/config. Goma is going away soon and we will soon bring RBE up to feature parity and Goma isn't really working on the special cross builds anyway. - Rare flakes in the remote builds have previously been observed, but I haven't seen them reappear yet after upgrading reclient. Look for build log messages mentioning the remote execution failed, or that an upload blob size digest mysteriously changed. Please alert me if you see this and I will talk to the Foundry team. If this happens, please try if you can fix this using `exec_strategy=remote_local_fallback` in the configuration file. Right now reclient only does remote executions to catch cases where RBE doesn't work, but if it fails, it can be configured to silently fall back on a slow local build. - If RBE is used on a configuration that doesn't support RBE builds, the default -j 1000 may overload the bot if it falls back on a local build. If this happens, the bot may explode and fail with BOT_DIED. If this happens, disable Goma (RBE) on the builder as above and let me know about the problem. - We haven't tried sending a full production load to the RBE pool yet. Flutter is already using the RBE pool partially. It's unclear what will happen once we turn this on for everyone. Keep an eye out for anything unusual and let me know. - If it turns out RBE doesn't cache invalidate properly, it is possible outdated object files will be linked. If anything really weird happens, this may the case. As far as I tested, the caching is working correctly. RBE is yet to be officially rolled out to our developers. Stay tuned. Bug: b/296994239 Change-Id: I77e0025197ab98a672efbc0cb04c8ece528c3e29 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/335826 Reviewed-by: Alexander Thomas <athom@google.com> Commit-Queue: Jonas Termansen <sortie@google.com> |
||
|---|---|---|
| .. | ||
| config | ||
| dart | ||
| fuchsia | ||
| linux | ||
| mac | ||
| rbe | ||
| rust | ||
| sanitizers | ||
| secondary | ||
| toolchain | ||
| .gitignore | ||
| detect_host_arch.py | ||
| executable_suffix.gni | ||
| find_depot_tools.py | ||
| gn_helpers.py | ||
| gn_run_binary.py | ||
| OWNERS | ||
| README.dart.md | ||
| shim_headers.gni | ||
| vs_toolchain.py | ||
This directory was taken from a snapshot of flutter/engine/src/build/.
The snapshot was taken with a recursive copy cp -R of the directory from
the flutter repository.
The contents has now diverged significantly from Flutter, and is maintained independently by the Dart team. It is used to support the GN build system.