mirror of
https://github.com/dart-lang/sdk
synced 2024-09-30 03:48:30 +00:00
Spelling build
Closes https://github.com/dart-lang/sdk/pull/50859 GitOrigin-RevId: 7b056018c2925745701bdecdd7da325d9458204d Change-Id: Iff037d773713bf73efde6951599becfd7297b921 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277740 Reviewed-by: Alexander Thomas <athom@google.com>
This commit is contained in:
parent
f19d6c17fc
commit
ba15a61271
|
@ -190,7 +190,7 @@ config("compiler") {
|
|||
ldflags += common_mac_flags
|
||||
} else if (is_posix) {
|
||||
# CPU architecture. We may or may not be doing a cross compile now, so for
|
||||
# simplicitly we always explicitly set the architecture.
|
||||
# simplicity we always explicitly set the architecture.
|
||||
if (current_cpu == "x64") {
|
||||
cflags += [
|
||||
"-m64",
|
||||
|
|
|
@ -5,7 +5,7 @@
|
|||
# This config causes functions not to be automatically exported from shared
|
||||
# libraries. By default, all symbols are exported but this means there are
|
||||
# lots of exports that slow everything down. In general we explicitly mark
|
||||
# which functiosn we want to export from components.
|
||||
# which function we want to export from components.
|
||||
#
|
||||
# Some third_party code assumes all functions are exported so this is separated
|
||||
# into its own config so such libraries can remove this config to make symbols
|
||||
|
|
|
@ -41,7 +41,7 @@ config("sdk") {
|
|||
}
|
||||
|
||||
# When using the pulled Debian sysroot with gcc, we have to specify these
|
||||
# excplicitly.
|
||||
# explicitly.
|
||||
if (dart_sysroot == "debian" && !is_clang) {
|
||||
cflags += [
|
||||
"-I=/usr/include/c++/4.8",
|
||||
|
|
|
@ -61,7 +61,7 @@ This script sets or clears the MH_PIE bit in an executable's Mach-O header,
|
|||
enabling or disabling position independence on Mac OS X 10.5 and later.
|
||||
Processes running position-independent executables have varying levels of
|
||||
ASLR protection depending on the OS release. The main executable's load
|
||||
address, shared library load addresess, and the heap and stack base
|
||||
address, shared library load addresses, and the heap and stack base
|
||||
addresses may be randomized. Position-independent executables are produced
|
||||
by supplying the -pie flag to the linker (or defeated by supplying -no_pie).
|
||||
Executables linked with a deployment target of 10.7 or higher have PIE on
|
||||
|
|
|
@ -77,7 +77,7 @@ def main():
|
|||
action="store_true",
|
||||
dest="print_sdk_path",
|
||||
default=False,
|
||||
help="Additionaly print the path the SDK (appears first).")
|
||||
help="Additionally print the path the SDK (appears first).")
|
||||
parser.add_option(
|
||||
"--create_symlink_at",
|
||||
action="store",
|
||||
|
|
|
@ -80,7 +80,7 @@ char kLSanDefaultSuppressions[] =
|
|||
// Instead, commits that introduce memory leaks should be reverted. Suppressing
|
||||
// the leak is acceptable in some cases when reverting is impossible, i.e. when
|
||||
// enabling leak detection for the first time for a test target with
|
||||
// pre-existing leaks.
|
||||
// preexisting leaks.
|
||||
|
||||
// Small test-only leak in ppapi_unittests. http://crbug.com/258113
|
||||
"leak:ppapi::proxy::PPP_Instance_Private_ProxyTest_PPPInstancePrivate_Test\n"
|
||||
|
|
|
@ -130,7 +130,7 @@ template("mac_toolchain") {
|
|||
# These variables are not build into GN but are helpers that implement
|
||||
# (1) linking to produce a .so, (2) extracting the symbols from that file
|
||||
# to a temporary file, (3) if the temporary file has differences from the
|
||||
# existing .TOC file, overwrite it, oterwise, don't change it.
|
||||
# existing .TOC file, overwrite it, otherwise, don't change it.
|
||||
#
|
||||
# As a special case, if the library reexports symbols from other dynamic
|
||||
# libraries, we always update the .TOC and skip the temporary file and
|
||||
|
|
|
@ -25,7 +25,7 @@ class Fix {
|
|||
return 'Fix(kind=$kind, change=$change)';
|
||||
}
|
||||
|
||||
/// A finction that can be used to sort fixes by their relevance.
|
||||
/// A function that can be used to sort fixes by their relevance.
|
||||
///
|
||||
/// The most relevant fixes will be sorted before fixes with a lower
|
||||
/// relevance. Fixes with the same relevance are sorted alphabetically.
|
||||
|
|
|
@ -36,7 +36,7 @@ class AddNotNullAssert extends CorrectionProducer {
|
|||
}
|
||||
|
||||
if (body is BlockFunctionBody) {
|
||||
// Check for an obvious pre-existing assertion.
|
||||
// Check for an obvious preexisting assertion.
|
||||
for (var statement in body.block.statements) {
|
||||
if (statement is AssertStatement) {
|
||||
final condition = statement.condition;
|
||||
|
|
|
@ -30,7 +30,7 @@ class AddParameter extends ParameterModification {
|
|||
/// invocations of the function, or `null` if the parameter is optional and no
|
||||
/// argument needs to be added. The only time an argument needs to be added
|
||||
/// for an optional parameter is if the parameter is positional and there are
|
||||
/// pre-existing optional positional parameters after the ones being added.
|
||||
/// preexisting optional positional parameters after the ones being added.
|
||||
final CodeTemplate? argumentValue;
|
||||
|
||||
/// Initialize a newly created parameter modification to represent the
|
||||
|
|
|
@ -52,7 +52,7 @@ main() {
|
|||
parseCompilationUnit('D? foo(X? x) { X? x1; X? x2 = x; }');
|
||||
}
|
||||
|
||||
void test_bangBeforeFuctionCall1() {
|
||||
void test_bangBeforeFunctionCall1() {
|
||||
// https://github.com/dart-lang/sdk/issues/39776
|
||||
var unit = parseCompilationUnit('f() { Function? f1; f1!(42); }');
|
||||
var funct = unit.declarations[0] as FunctionDeclaration;
|
||||
|
@ -77,7 +77,7 @@ main() {
|
|||
expect(argument.value, 42);
|
||||
}
|
||||
|
||||
void test_bangBeforeFuctionCall2() {
|
||||
void test_bangBeforeFunctionCall2() {
|
||||
// https://github.com/dart-lang/sdk/issues/39776
|
||||
var unit = parseCompilationUnit('f() { Function f2; f2!<int>(42); }');
|
||||
var funct = unit.declarations[0] as FunctionDeclaration;
|
||||
|
|
|
@ -130,7 +130,7 @@ abstract class FileEditBuilder {
|
|||
|
||||
/// Add the region of text specified by the given [range] to the linked edit
|
||||
/// group with the given [groupName]. The [range] is relative to the original
|
||||
/// source. This is typically used to include pre-existing regions of text in
|
||||
/// source. This is typically used to include preexisting regions of text in
|
||||
/// a group. If the region to be included is part of newly generated text,
|
||||
/// then the method [EditBuilder.addLinkedEdit] should be used instead.
|
||||
void addLinkedPosition(SourceRange range, String groupName);
|
||||
|
|
|
@ -61,8 +61,8 @@ class KernelAnnotationProcessor {
|
|||
|
||||
ir.Library libraryNode = elementMap.getLibraryNode(library);
|
||||
String? libraryName = annotationData.getJsInteropLibraryName(libraryNode);
|
||||
final bool isExplicitlylyJsLibrary = libraryName != null;
|
||||
bool isJsLibrary = isExplicitlylyJsLibrary;
|
||||
final bool isExplicitlyJsLibrary = libraryName != null;
|
||||
bool isJsLibrary = isExplicitlyJsLibrary;
|
||||
|
||||
elementEnvironment.forEachLibraryMember(library, (MemberEntity member) {
|
||||
ir.Member memberNode = elementMap.getMemberNode(member);
|
||||
|
@ -75,7 +75,7 @@ class KernelAnnotationProcessor {
|
|||
}
|
||||
} else {
|
||||
FunctionEntity function = member as FunctionEntity;
|
||||
if (function.isExternal && isExplicitlylyJsLibrary) {
|
||||
if (function.isExternal && isExplicitlyJsLibrary) {
|
||||
// External members of explicit js-interop library are implicitly
|
||||
// js-interop members.
|
||||
memberName ??= function.name;
|
||||
|
|
|
@ -224,7 +224,7 @@ class NativeBehavior {
|
|||
/// created by the call to JS. 'var' (and '') are like 'dynamic' or
|
||||
/// 'Object' except that 'dynamic' would indicate that objects of any type
|
||||
/// are created, which defeats tree-shaking. Think of 'var' (and '') as
|
||||
/// meaning 'any pre-existing type'.
|
||||
/// meaning 'any preexisting type'.
|
||||
///
|
||||
/// The types Ti are non-nullable, so add class `Null` to specify a
|
||||
/// nullable type, e.g `'String|Null'`.
|
||||
|
|
|
@ -887,7 +887,7 @@ abstract class NodeProducingEditPlan extends EditPlan {
|
|||
/// Modifies [changes] to insert parentheses enclosing the [sourceNode]. This
|
||||
/// works even if [changes] already includes modifications at the beginning or
|
||||
/// end of [sourceNode]--the parentheses are inserted outside of any
|
||||
/// pre-existing changes.
|
||||
/// preexisting changes.
|
||||
Map<int?, List<AtomicEdit>>? _createAddParenChanges(
|
||||
Map<int?, List<AtomicEdit>>? changes) {
|
||||
changes ??= {};
|
||||
|
|
|
@ -1452,9 +1452,9 @@ extension E on C/*?*/ {
|
|||
}
|
||||
f(C/*?*/ c) => c();
|
||||
''');
|
||||
var functoinExpressionInvocation =
|
||||
var functionExpressionInvocation =
|
||||
findNode.functionExpressionInvocation('c()');
|
||||
visitSubexpression(functoinExpressionInvocation, 'void');
|
||||
visitSubexpression(functionExpressionInvocation, 'void');
|
||||
}
|
||||
|
||||
Future<void>
|
||||
|
@ -1466,9 +1466,9 @@ extension E on C/*?*/ {
|
|||
}
|
||||
f(C/*?*/ c) => E(c)();
|
||||
''');
|
||||
var functoinExpressionInvocation =
|
||||
var functionExpressionInvocation =
|
||||
findNode.functionExpressionInvocation('E(c)()');
|
||||
visitSubexpression(functoinExpressionInvocation, 'void');
|
||||
visitSubexpression(functionExpressionInvocation, 'void');
|
||||
}
|
||||
|
||||
Future<void>
|
||||
|
|
|
@ -96,7 +96,7 @@ class DFE {
|
|||
// If 'kernel_blob_ptr' is not nullptr, then this function can also
|
||||
// read kernel blobs. In such case it sets 'kernel_blob_ptr'
|
||||
// to a shared pointer which owns the kernel buffer.
|
||||
// Othwerise, the caller is responsible for free()ing 'kernel_buffer'.
|
||||
// Otherwise, the caller is responsible for free()ing 'kernel_buffer'.
|
||||
void ReadScript(const char* script_uri,
|
||||
uint8_t** kernel_buffer,
|
||||
intptr_t* kernel_buffer_size,
|
||||
|
@ -112,7 +112,7 @@ class DFE {
|
|||
// If 'kernel_blob_ptr' is not nullptr, then this function can also
|
||||
// read kernel blobs. In such case it sets 'kernel_blob_ptr'
|
||||
// to a shared pointer which owns the kernel buffer.
|
||||
// Othwerise, the caller is responsible for free()ing 'kernel_buffer'
|
||||
// Otherwise, the caller is responsible for free()ing 'kernel_buffer'
|
||||
// if `true` was returned.
|
||||
bool TryReadKernelFile(const char* script_uri,
|
||||
uint8_t** kernel_buffer,
|
||||
|
|
|
@ -1376,7 +1376,7 @@ DART_EXPORT void Dart_StartProfiling(void);
|
|||
/**
|
||||
* Stops the CPU sampling profiler.
|
||||
*
|
||||
* Note that some profile samples might still be taken after this fucntion
|
||||
* Note that some profile samples might still be taken after this function
|
||||
* returns due to the asynchronous nature of the implementation on some
|
||||
* platforms.
|
||||
*/
|
||||
|
|
|
@ -155,7 +155,7 @@ def MakeCompactTree(symbols, symbol_path_origin_dir):
|
|||
|
||||
path_parts = file_path.split('/')
|
||||
|
||||
# Find pre-existing node in tree, or update if it already exists
|
||||
# Find preexisting node in tree, or update if it already exists
|
||||
node = result
|
||||
depth = 0
|
||||
while len(path_parts) > 0:
|
||||
|
|
|
@ -405,7 +405,7 @@ void Dart_DumpSnapshotInformationAsJson(
|
|||
// Open empty object so output is valid/parsable JSON.
|
||||
js.OpenObject();
|
||||
js.OpenObject("snapshot_data");
|
||||
// Base addreses of the snapshot data, useful to calculate relative offsets.
|
||||
// Base addresses of the snapshot data, useful to calculate relative offsets.
|
||||
js.PrintfProperty("vm_data", "%p", info->vm_snapshot_data);
|
||||
js.PrintfProperty("vm_instructions", "%p", info->vm_snapshot_instructions);
|
||||
js.PrintfProperty("isolate_data", "%p", info->vm_isolate_data);
|
||||
|
|
|
@ -495,7 +495,7 @@ class ClassDeserializationCluster : public DeserializationCluster {
|
|||
// explicitly as Array objects into the snapshot and instead utilize a different
|
||||
// encoding: objects in a cluster representing a canonical set are sorted
|
||||
// to appear in the same order they appear in the Array representing the set,
|
||||
// and we additionaly write out array of values describing gaps between objects.
|
||||
// and we additionally write out array of values describing gaps between objects.
|
||||
//
|
||||
// In some situations not all canonical objects of the some type need to
|
||||
// be added to the resulting canonical set because they are cached in some
|
||||
|
|
|
@ -146,7 +146,7 @@ struct RetainReasons : public AllStatic {
|
|||
// The object is a function and symbolic stack traces are enabled.
|
||||
static constexpr const char* kSymbolicStackTraces =
|
||||
"needed for symbolic stack traces";
|
||||
// The object is a parent function function of a non-inlined local function.
|
||||
// The object is a parent function of a non-inlined local function.
|
||||
static constexpr const char* kLocalParent = "parent of a local function";
|
||||
// The object is a main function of the root library.
|
||||
static constexpr const char* kMainFunction =
|
||||
|
|
|
@ -1633,7 +1633,7 @@ bool FlowGraphCompiler::NeedsEdgeCounter(BlockEntryInstr* block) {
|
|||
(!block->last_instruction()->IsGoto() || block->IsFunctionEntry());
|
||||
}
|
||||
|
||||
// Allocate a register that is not explictly blocked.
|
||||
// Allocate a register that is not explicitly blocked.
|
||||
static Register AllocateFreeRegister(bool* blocked_registers) {
|
||||
for (intptr_t i = 0; i < kNumberOfCpuRegisters; i++) {
|
||||
intptr_t regno = (i + kRegisterAllocationBias) % kNumberOfCpuRegisters;
|
||||
|
@ -1646,7 +1646,7 @@ static Register AllocateFreeRegister(bool* blocked_registers) {
|
|||
return kNoRegister;
|
||||
}
|
||||
|
||||
// Allocate a FPU register that is not explictly blocked.
|
||||
// Allocate a FPU register that is not explicitly blocked.
|
||||
static FpuRegister AllocateFreeFpuRegister(bool* blocked_registers) {
|
||||
for (intptr_t regno = 0; regno < kNumberOfFpuRegisters; regno++) {
|
||||
if (!blocked_registers[regno]) {
|
||||
|
|
|
@ -11551,7 +11551,7 @@ bool Field::NeedsSetter() const {
|
|||
}
|
||||
}
|
||||
|
||||
// Othwerwise, setters for static fields can be omitted
|
||||
// Otherwise, setters for static fields can be omitted
|
||||
// and fields can be accessed directly.
|
||||
return false;
|
||||
}
|
||||
|
|
|
@ -3226,7 +3226,7 @@ class Function : public Object {
|
|||
bool HasOptionalParameters() const;
|
||||
// Returns whether the function has optional named parameters.
|
||||
bool HasOptionalNamedParameters() const;
|
||||
// Returns whether the fuction has required named parameters.
|
||||
// Returns whether the function has required named parameters.
|
||||
bool HasRequiredNamedParameters() const;
|
||||
// Returns whether the function has optional positional parameters.
|
||||
bool HasOptionalPositionalParameters() const;
|
||||
|
|
|
@ -18,7 +18,7 @@ class JSValue {
|
|||
|
||||
JSValue(this._ref);
|
||||
|
||||
// Currently we always explictly box JS ref's in [JSValue] objects. In the
|
||||
// Currently we always explicitly box JS ref's in [JSValue] objects. In the
|
||||
// future, we will want to leave these values unboxed when possible, even when
|
||||
// they are nullable.
|
||||
static JSValue? box(WasmExternRef? ref) =>
|
||||
|
|
|
@ -248,7 +248,7 @@ window.ExampleJSClass = function ExampleJSClass(x) {
|
|||
|
||||
addEventListener(String name, bool callback(Event e)) => null;
|
||||
|
||||
addFormatterGoldens('Function with functon arguments', addEventListener);
|
||||
addFormatterGoldens('Function with function arguments', addEventListener);
|
||||
|
||||
// Closure
|
||||
addGolden('dart:html method', window.addEventListener);
|
||||
|
|
|
@ -4294,7 +4294,7 @@ Value:
|
|||
]
|
||||
]
|
||||
-----------------------------------
|
||||
Test: Function with functon arguments formatting header
|
||||
Test: Function with function arguments formatting header
|
||||
Value:
|
||||
[
|
||||
"span",
|
||||
|
@ -4304,7 +4304,7 @@ Value:
|
|||
"(String, (Event$) => bool) => Null"
|
||||
]
|
||||
-----------------------------------
|
||||
Test: Function with functon arguments formatting body
|
||||
Test: Function with function arguments formatting body
|
||||
Value:
|
||||
[
|
||||
"ol",
|
||||
|
|
|
@ -49,7 +49,7 @@ void main() {
|
|||
expectStringContains("too few arguments", message);
|
||||
}
|
||||
|
||||
// Dynamic call of a top level funciton with too many arguments.
|
||||
// Dynamic call of a top level function with too many arguments.
|
||||
try {
|
||||
dynamicFunction(1, 2);
|
||||
} on NoSuchMethodError catch (error) {
|
||||
|
@ -58,7 +58,7 @@ void main() {
|
|||
expectStringContains("too many arguments", message);
|
||||
}
|
||||
|
||||
// Dynamic call of a top level funciton with too few arguments.
|
||||
// Dynamic call of a top level function with too few arguments.
|
||||
try {
|
||||
dynamicFunction();
|
||||
} on NoSuchMethodError catch (error) {
|
||||
|
|
|
@ -250,7 +250,7 @@ window.ExampleJSClass = function ExampleJSClass(x) {
|
|||
|
||||
addEventListener(String name, bool callback(Event e)) => null;
|
||||
|
||||
addFormatterGoldens('Function with functon arguments', addEventListener);
|
||||
addFormatterGoldens('Function with function arguments', addEventListener);
|
||||
|
||||
// Closure
|
||||
addGolden('dart:html method', window.addEventListener);
|
||||
|
|
|
@ -4294,7 +4294,7 @@ Value:
|
|||
]
|
||||
]
|
||||
-----------------------------------
|
||||
Test: Function with functon arguments formatting header
|
||||
Test: Function with function arguments formatting header
|
||||
Value:
|
||||
[
|
||||
"span",
|
||||
|
@ -4304,7 +4304,7 @@ Value:
|
|||
"(String, (Event$) => bool) => Null"
|
||||
]
|
||||
-----------------------------------
|
||||
Test: Function with functon arguments formatting body
|
||||
Test: Function with function arguments formatting body
|
||||
Value:
|
||||
[
|
||||
"ol",
|
||||
|
|
|
@ -51,7 +51,7 @@ void main() {
|
|||
expectStringContains("too few arguments", message);
|
||||
}
|
||||
|
||||
// Dynamic call of a top level funciton with too many arguments.
|
||||
// Dynamic call of a top level function with too many arguments.
|
||||
try {
|
||||
dynamicFunction(1, 2);
|
||||
} on NoSuchMethodError catch (error) {
|
||||
|
@ -60,7 +60,7 @@ void main() {
|
|||
expectStringContains("too many arguments", message);
|
||||
}
|
||||
|
||||
// Dynamic call of a top level funciton with too few arguments.
|
||||
// Dynamic call of a top level function with too few arguments.
|
||||
try {
|
||||
dynamicFunction();
|
||||
} on NoSuchMethodError catch (error) {
|
||||
|
|
|
@ -586,13 +586,13 @@ class FileTest {
|
|||
final tmp = tempDirectory.createTempSync('write_from_offset_test_');
|
||||
try {
|
||||
File f = new File('${tmp.path}/file')..createSync();
|
||||
f.writeAsStringSync('pre-existing content\n', flush: true);
|
||||
f.writeAsStringSync('preexisting content\n', flush: true);
|
||||
final raf = f.openSync(mode: FileMode.append);
|
||||
try {
|
||||
String truth = "Hello world";
|
||||
raf.writeFromSync(utf8.encode('Hello world'), 2, 5);
|
||||
raf.flushSync();
|
||||
Expect.equals(f.readAsStringSync(), 'pre-existing content\nllo');
|
||||
Expect.equals(f.readAsStringSync(), 'preexisting content\nllo');
|
||||
} finally {
|
||||
raf.closeSync();
|
||||
}
|
||||
|
|
|
@ -589,12 +589,12 @@ class FileTest {
|
|||
try {
|
||||
tmp = tempDirectory.createTempSync('write_from_offset_test_');
|
||||
File f = new File('${tmp.path}/file')..createSync();
|
||||
f.writeAsStringSync('pre-existing content\n', flush: true);
|
||||
f.writeAsStringSync('preexisting content\n', flush: true);
|
||||
raf = f.openSync(mode: FileMode.append);
|
||||
String truth = "Hello world";
|
||||
raf.writeFromSync(utf8.encode('Hello world'), 2, 5);
|
||||
raf.flushSync();
|
||||
Expect.equals(f.readAsStringSync(), 'pre-existing content\nllo');
|
||||
Expect.equals(f.readAsStringSync(), 'preexisting content\nllo');
|
||||
} finally {
|
||||
if (raf != null) {
|
||||
raf.closeSync();
|
||||
|
|
|
@ -106,7 +106,7 @@ from the builder name:
|
|||
]
|
||||
```
|
||||
|
||||
A step that uses the script `tools/test.py` either explicitely or by default is
|
||||
A step that uses the script `tools/test.py` either explicitly or by default is
|
||||
called a "test step". Test steps must include the `-n` command line argument to
|
||||
select one of the named configurations defined in the `configurations` section.
|
||||
|
||||
|
|
Loading…
Reference in a new issue