dart-sdk/pkg/vm_service/test
Liam Appelbe 875922a88f [vm]: Rewrite library_filters in source_report
When library_filters were given, we used to prefill the script_table_,
then just assume that any scripts not in the script_table_ must have
been filtered out. We wrote it this way to avoid checking the filters
in every GetScriptIndex call. But in some cases (eg mixins),
lib.LoadedScripts() can miss some scripts, so they'd be incorrectly
omitted from the table.

The new implementation lazy loads the scripts, the same way it works
when there are no library_filters. Skipped scripts are still placed in
the script_table_, but given an index of -1, and omitted from
script_table_entries_.

Bug: https://github.com/dart-lang/sdk/issues/49887
Change-Id: Ide938ddfa9a3750c72c615e296b1a23875e46ab8
TEST=CI (also manually tested that the bug is fixed, but it's a really fiddly setup and I'm not sure how to put it in a unit test. See bug for details)
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260076
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
2022-09-26 23:03:18 +00:00
..
common [vm] Cleanup --lazy-async-stacks VM option 2022-06-10 13:41:24 +00:00
serialization_smoke_tests [ package:vm_service ] Update UriList.uris from List<dynamic> to List<String?> 2022-03-09 21:23:14 +00:00
test_package [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 1) 2021-11-05 17:04:07 +00:00
add_breakpoint_rpc_kernel_test.dart [ Service ] Add line/column information to SourceLocation objects 2022-01-12 02:09:24 +00:00
allocations_test.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 1) 2021-11-05 17:04:07 +00:00
analysis_options.yaml Move pkg/vm_service to package:lints. 2022-04-15 20:15:04 +00:00
async_generator_breakpoint_test.dart Fix pre-existing HintCode.UNNECESSARY_TYPE_CHECK_TRUE in a test. 2021-06-19 18:53:23 +00:00
async_next_regression_18877_test.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 1) 2021-11-05 17:04:07 +00:00
async_next_test.dart [ package:vm_service ] Update tests to be compatible with pub run test 2021-02-12 07:12:54 +00:00
async_scope_test.dart fix sort_directives violations 2021-04-20 22:21:28 +00:00
async_single_step_exception_test.dart [vm] Cleanup --lazy-async-stacks VM option 2022-06-10 13:41:24 +00:00
async_single_step_into_test.dart [vm] Cleanup --lazy-async-stacks VM option 2022-06-10 13:41:24 +00:00
async_single_step_out_test.dart [vm] Cleanup --lazy-async-stacks VM option 2022-06-10 13:41:24 +00:00
async_star_single_step_into_test.dart [vm] Cleanup --lazy-async-stacks VM option 2022-06-10 13:41:24 +00:00
async_star_step_out_test.dart [vm] Cleanup --lazy-async-stacks VM option 2022-06-10 13:41:24 +00:00
async_step_out_test.dart [vm] Cleanup --lazy-async-stacks VM option 2022-06-10 13:41:24 +00:00
awaiter_async_stack_contents_2_test.dart [vm] Cleanup --lazy-async-stacks VM option 2022-06-10 13:41:24 +00:00
awaiter_async_stack_contents_test.dart [vm] Cleanup --lazy-async-stacks VM option 2022-06-10 13:41:24 +00:00
branch_coverage_test.dart [vm] Adding branch coverage RPC to source report 2022-01-12 19:12:04 +00:00
breakpoint_async_break_test.dart [ Service ] Add line/column information to SourceLocation objects 2022-01-12 02:09:24 +00:00
breakpoint_in_enhanced_enums_test.dart Retire the 2.17 language feature experiment flags. 2022-07-11 13:02:22 +00:00
breakpoint_in_package_parts_class_file_uri_test.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 1) 2021-11-05 17:04:07 +00:00
breakpoint_in_package_parts_class_test.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 1) 2021-11-05 17:04:07 +00:00
breakpoint_in_parts_class_part.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 1) 2021-11-05 17:04:07 +00:00
breakpoint_in_parts_class_test.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 1) 2021-11-05 17:04:07 +00:00
breakpoint_non_debuggable_library_test.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 1) 2021-11-05 17:04:07 +00:00
breakpoint_on_if_null_1_test.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 1) 2021-11-05 17:04:07 +00:00
breakpoint_on_if_null_2_test.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 1) 2021-11-05 17:04:07 +00:00
breakpoint_on_if_null_3_test.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 1) 2021-11-05 17:04:07 +00:00
breakpoint_on_if_null_4_test.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 1) 2021-11-05 17:04:07 +00:00
breakpoint_partfile_test.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 1) 2021-11-05 17:04:07 +00:00
breakpoint_two_args_checked_test.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 1) 2021-11-05 17:04:07 +00:00
breakpoints_with_mixin_lib1.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 1) 2021-11-05 17:04:07 +00:00
breakpoints_with_mixin_lib2.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 1) 2021-11-05 17:04:07 +00:00
breakpoints_with_mixin_lib3.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 1) 2021-11-05 17:04:07 +00:00
breakpoints_with_mixin_test.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 1) 2021-11-05 17:04:07 +00:00
capture_stdio_test.dart fix sort_directives violations 2021-04-20 22:21:28 +00:00
causal_async_stack_contents_test.dart [vm] Cleanup --lazy-async-stacks VM option 2022-06-10 13:41:24 +00:00
causal_async_stack_presence_test.dart [vm] Cleanup --lazy-async-stacks VM option 2022-06-10 13:41:24 +00:00
causal_async_star_stack_contents_test.dart [vm] Cleanup --lazy-async-stacks VM option 2022-06-10 13:41:24 +00:00
causal_async_star_stack_presence_test.dart [vm] Cleanup --lazy-async-stacks VM option 2022-06-10 13:41:24 +00:00
code_test.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 2) 2022-02-05 00:12:29 +00:00
column_breakpoint_test.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 2) 2022-02-05 00:12:29 +00:00
contexts_test.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 2) 2022-02-05 00:12:29 +00:00
coverage_async_test.dart [vm] Remove async function deduping in source_report 2022-06-14 23:50:17 +00:00
coverage_const_field_async_closure_test.dart Reland "[vm] Enable new implementation of async/async* in JIT mode" 2022-06-09 15:24:13 +00:00
coverage_leaf_function_test.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 2) 2022-02-05 00:12:29 +00:00
coverage_optimized_function_test.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 2) 2022-02-05 00:12:29 +00:00
cpu_samples_stream_test.dart Remove unnecessary imports in vm_service 2021-09-09 19:03:44 +00:00
debugger_inspect_test.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 2) 2022-02-05 00:12:29 +00:00
debugging_inlined_finally_test.dart Revert "Refactor _Future." 2022-06-09 16:51:55 +00:00
debugging_test.dart Revert "Refactor _Future." 2022-06-09 16:51:55 +00:00
developer_extension_test.dart Remove unneeded ignore comments in vm_service 2022-03-25 23:12:14 +00:00
developer_service_get_isolate_id_test.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 2) 2022-02-05 00:12:29 +00:00
echo_test.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 2) 2022-02-05 00:12:29 +00:00
enhanced_enum_test.dart Retire the 2.17 language feature experiment flags. 2022-07-11 13:02:22 +00:00
eval_internal_class_test.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 2) 2022-02-05 00:12:29 +00:00
eval_issue_49209_test.dart [VM | VMService] Fix expression evaluation when recursive types are used. 2022-06-10 15:03:04 +00:00
eval_named_args_anywhere_test.dart Retire the 2.17 language feature experiment flags. 2022-07-11 13:02:22 +00:00
eval_regression_flutter20255_test.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 2) 2022-02-05 00:12:29 +00:00
eval_skip_breakpoint.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 2) 2022-02-05 00:12:29 +00:00
eval_test.dart [ package:vm_service ] Update tests to be compatible with pub run test 2021-02-12 07:12:54 +00:00
evaluate_activation_in_method_class_other.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 2) 2022-02-05 00:12:29 +00:00
evaluate_activation_in_method_class_test.dart [ package:vm_service ] Migrate Observatory service tests to package:vm_service (Pt 2) 2022-02-05 00:12:29 +00:00
evaluate_with_scope_test.dart fix sort_directives violations 2021-04-20 22:21:28 +00:00
external_compilation_service_script.dart [ package:vm_service ] Add external compilation service tests 2022-04-07 17:39:28 +00:00
external_compilation_service_test.dart [ package:vm_service ] Add external compilation service tests 2022-04-07 17:39:28 +00:00
file_service_test.dart fix sort_directives violations 2021-04-20 22:21:28 +00:00
get_allocation_profile_rpc_test.dart fix sort_directives violations 2021-04-20 22:21:28 +00:00
get_allocation_traces_test.dart [ VM / Service ] Add identityHashCode to @Instance and Instance 2021-03-22 22:45:57 +00:00
get_cpu_samples_rpc_test.dart fix sort_directives violations 2021-04-20 22:21:28 +00:00
get_flag_list_rpc_test.dart [ package:vm_service ] Update tests to be compatible with pub run test 2021-02-12 07:12:54 +00:00
get_http_profile_test.dart Call _profileData.finishRequest after request finalisation 2021-09-09 14:16:21 +00:00
get_isolate_group_memory_usage.dart [ package:vm_service ] Update tests to be compatible with pub run test 2021-02-12 07:12:54 +00:00
get_isolate_rpc_test.dart [ package:vm_service ] Update tests to be compatible with pub run test 2021-02-12 07:12:54 +00:00
get_memory_usage_test.dart [ package:vm_service ] Update tests to be compatible with pub run test 2021-02-12 07:12:54 +00:00
get_stack_test.dart Reland "[vm] More efficient 'await' of not Future and completed _Future" 2022-06-15 15:35:38 +00:00
get_version_rpc_test.dart fix sort_directives violations 2021-04-20 22:21:28 +00:00
heap_snapshot_graph_test.dart fix sort_directives violations 2021-04-20 22:21:28 +00:00
http_enable_timeline_logging_service_test.dart vm_service: remove unnecessary imports 2021-02-18 00:23:46 +00:00
invoke_test.dart [ package:vm_service ] Update tests to be compatible with pub run test 2021-02-12 07:12:54 +00:00
library_dependency_test.dart Remove unnecessary imports 2021-07-15 16:57:21 +00:00
mark_main_isolate_as_system_isolate_test.dart [vm/concurrency] Remove --(no-)enable-isolate-groups flag usage in tests 2021-11-04 18:57:21 +00:00
network_profiling_test.dart vm_service: remove unnecessary imports 2021-02-18 00:23:46 +00:00
object_graph_identity_hash_test.dart fix sort_directives violations 2021-04-20 22:21:28 +00:00
pause_on_exceptions_legacy_test.dart Reland "[ VM / Service ] Add setIsolatePauseMode RPC" 2021-11-17 16:17:24 +00:00
pause_on_exceptions_test.dart Reland "[ VM / Service ] Add setIsolatePauseMode RPC" 2021-11-17 16:17:24 +00:00
process_service_test.dart [deps] remove the dep on package:process 2022-05-20 18:44:12 +00:00
regress_43940_test.dart Move pkg/vm_service to package:lints. 2022-04-15 20:15:04 +00:00
regress_44588_test.dart fix sort_directives violations 2021-04-20 22:21:28 +00:00
regress_44842_test.dart fix sort_directives violations 2021-04-20 22:21:28 +00:00
regress_46559_test.dart [ package:vm_service ] Handle case where no 'type' key-value is included 2021-07-15 20:56:02 +00:00
regress_48279_test.dart [vm] Correct token position for AssertAssignable in implicit field setters 2022-02-08 19:28:36 +00:00
regress_88104_test.dart [ VM ] Ensure TypeArguments register is preserved when regenerating allocation stubs for parameterized classes 2022-05-06 12:57:44 +00:00
rpc_error_test.dart Reland "[vm] Enable new implementation of async/async* in JIT mode" 2022-06-09 15:24:13 +00:00
server_test.dart [ package:vm_service ] Migrate server_test.dart to null safety 2022-06-06 19:59:18 +00:00
set_breakpoint_state_test.dart fix sort_directives violations 2021-04-20 22:21:28 +00:00
should_pause_on_exit_test.dart Reland "[ VM / Service ] Add setIsolatePauseMode RPC" 2021-11-17 16:17:24 +00:00
source_report_package_filters_test.dart [vm]: Rewrite library_filters in source_report 2022-09-26 23:03:18 +00:00
super_constructor_invocation_test.dart Retire the 2.17 language feature experiment flags. 2022-07-11 13:02:22 +00:00
throws_sentinel_test.dart Reland "[vm] Enable new implementation of async/async* in JIT mode" 2022-06-09 15:24:13 +00:00
timeline_default_streams_test.dart [ Service / Timeline ] Enable Compiler, Dart, and GC timeline streams when --observe is provided 2022-08-15 21:02:36 +00:00
uri_mappings_lookup_test.dart [ package:vm_service ] Update UriList.uris from List<dynamic> to List<String?> 2022-03-09 21:23:14 +00:00
user_tag_changed_test.dart [ VM / Service ] Add missing isolate parameter for UserTagChanged events 2021-06-29 22:32:39 +00:00
utils_test.dart Reland "[ VM / Service ] Pulled in vm_service_drivers from its own repo." 2019-07-25 18:46:43 +00:00
verify_http_timeline_test.dart fix sort_directives violations 2021-04-20 22:21:28 +00:00