languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-15 21:50:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ VM / Service ] Add missing isolate parameter for UserTagChanged events

Browse source 
TEST=pkg/vm_service/test/user_tag_changed_test.dart

Change-Id: I962d7d99d6c9d05aefe76baccb30ce0978724ef1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205322
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
This commit is contained in:
Ben Konyi 2021-06-29 22:32:39 +00:00 committed by commit-bot@chromium.org
parent 7ebd051a06
commit 130fa82004
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/vm_service/test/user_tag_changed_test.dart
View file

@ -37,12 +37,14 @@ var tests = <IsolateTest>[
var event = await stream.next;
expect(event.kind, EventKind.kUserTagChanged);
expect(event.isolate, isNotNull);
expect(event.updatedTag, 'Foo');
expect(event.previousTag, 'Default');
expect(await stream.hasNext, true);
event = await stream.next;
expect(event.kind, EventKind.kUserTagChanged);
expect(event.isolate, isNotNull);
expect(event.updatedTag, 'Default');
expect(event.previousTag, 'Foo');
},

2
runtime/vm/object.cc
View file

@ -25729,7 +25729,7 @@ UserTagPtr UserTag::MakeActive() const {
#if !defined(PRODUCT)
// Notify VM service clients that the current UserTag has changed.
if (Service::profiler_stream.enabled()) {
ServiceEvent event(ServiceEvent::kUserTagChanged);
ServiceEvent event(isolate, ServiceEvent::kUserTagChanged);
String& name = String::Handle(old.label());
event.set_previous_tag(name.ToCString());
name ^= label();