Commit graph

7031 commits

Author SHA1 Message Date
Lasse R.H. Nielsen fbedc2b86f Also iprove Future.value(null) and documentation of some Stream related classes.
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1177343004.
2015-06-16 11:38:07 +02:00
Søren Gjesse c05c8c6606 Revert change to Platform.excutable and add Platform.resolvedExecutable
The change to Platform.excutable in
e03ab17437 was a breaking change and it
has been reverted.

A new getter Platform.resolvedExecutable has been added to provide the
the fully qualified path of the executable.

BUG=https://github.com/dart-lang/sdk/issues/16994
R=lrn@google.com, kustermann@google.com, len@google.com

Review URL: https://codereview.chromium.org//1180623006.
2015-06-15 10:13:21 +02:00
Stephen Adams f7263216e4 Better messages for optimized index errors.
Typed list, Array and String indexer methods detect index errors in their own optimized way but now defer to common code to diagnose the error.  This code is shared with the optimized 'ioore' helper, which makes the error message consistent between optimized and unoptimized code.

The main reason for doing this is to ensure that the error messages have as much information as possible to help debug off-line using captured error messages.

BUG=
R=lrn@google.com

Committed: 0d4361fb6d

Reverted: 82215d36f4

Review URL: https://codereview.chromium.org//1180713003.
2015-06-12 18:21:47 -07:00
Stephen Adams 82215d36f4 Revert "Better messages for optimized index errors."
TBR=lrn@google.com

Review URL: https://codereview.chromium.org//1187553005.
2015-06-12 16:53:19 -07:00
Stephen Adams 0d4361fb6d Better messages for optimized index errors.
Typed list, Array and String indexer methods detect index errors in their own optimized way but now defer to common code to diagnose the error.  This code is shared with the optimized 'ioore' helper, which makes the error message consistent between optimized and unoptimized code.

The main reason for doing this is to ensure that the error messages have as much information as possible to help debug off-line using captured error messages.

BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org//1180713003.
2015-06-12 15:33:58 -07:00
Ryan Macnak fd1531b4d8 Fix some markup in the mirrors docs.
BUG=http://dartbug.com/21714
R=gbracha@google.com

Review URL: https://codereview.chromium.org//1184623003.
2015-06-12 14:43:38 -07:00
Seth Ladd 00be3be571 be more explicit about when and how to register for listeners with isolates
BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org//1181043003
2015-06-12 15:02:11 +02:00
Seth Ladd f1b934d816 make the one-liner for the SDK docs an actual one-liner
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//1183623003
2015-06-12 12:21:52 +02:00
Johnni Winther ee1be89b30 Support foreigns as external.
BUG=

Review URL: https://codereview.chromium.org//1169083004.
2015-06-11 15:27:56 +02:00
Regis Crelier 9edc6e5a6d Detect zero receiver of modInverse (may not converge and time out
in that case).

See #23502

Review URL: https://codereview.chromium.org//1177063002.
2015-06-10 16:40:24 -07:00
Regis Crelier 90315a1694 Remove bigint reference in js_number.dart
Review URL: https://codereview.chromium.org//1177873002.
2015-06-10 15:34:43 -07:00
Regis Crelier f6f338ce67 Implement modInverse (bigint version does not support even modulus yet).
Added tests.

See #23502

R=srdjan@google.com

Review URL: https://codereview.chromium.org//1174513004.
2015-06-10 15:01:46 -07:00
Karl Klose 183ae17958 Move IS_INDEXABLE_FIELD to JsGetName.
Also remove the old helper functions and references from js_helper and friends.

R=herhut@google.com

Review URL: https://codereview.chromium.org//1158423005.
2015-06-09 11:29:50 +02:00
Rico Wind f3c6339206 Switch over testing pub seperately from the the normal packages
This will call a new test script that Natalie will fill in the blanks of for pub testing.

This also moves pub from third_party/pkg_tested into third_party/pkg.

The corresponding changes to the buildbot is here:
http://src.chromium.org/viewvc/chrome?revision=295555&view=revision

R=nweiz@google.com, whesse@google.com
BUG=

Review URL: https://codereview.chromium.org//1166093002.
2015-06-09 08:12:51 +02:00
Ryan Macnak cef08e5674 Fix dartdoc for InstanceMirror.delegate and ClosureMirror. Avoid misleading use of the term 'evaluation'.
BUG=http://dartbug.com/15889
BUG=http://dartbug.com/20139
BUG=http://dartbug.com/21992
R=gbracha@google.com

Review URL: https://codereview.chromium.org//1144923012.
2015-06-08 17:41:34 -07:00
Sigmund Cherem 1763aa3467 dart2js: reuse stack trace on rethrow
BUG= dartbug.com/15171
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//1152023004
2015-06-08 12:27:49 -07:00
Stephan Herhut e4255659dd dart2js: Do not emit type metadata for fields declared in non-reflectable classes.
BUG=
R=karlklose@google.com, zarah@google.com

Committed: 67537ffbd7

Reverted: 6cc3bd1124

Committed: a1b630641e

Reverted: 5af9221e1b

Review URL: https://codereview.chromium.org//1169453005
2015-06-08 15:35:25 +02:00
Seth Ladd ac1b0cf8ac Merge pull request #23585 from dart-lang/sethladd-patch-2
Removing Polymer from core SDK API's homepage
2015-06-05 14:20:34 -07:00
Seth Ladd 9326f9d79a update one-line docs for svg, gl, audio
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//1163163004
2015-06-04 16:39:02 -07:00
Seth Ladd 464ffd0fca Removing Polymer from core SDK API's homepage
Also, the "writing API documentation" page was never moved over from the codesite.
2015-06-04 15:20:28 -07:00
pq 2c5e890fc7 Build fixes.
Long tail of fixes related to moving out of `pkg_tested`.

R=paulberry@google.com

Review URL: https://codereview.chromium.org//1162423002
2015-06-03 14:03:15 -07:00
Lasse R.H. Nielsen 5a843ebbf3 Add "checked" parameter to Isolate.spawnUri.
R=iposva@google.com

Review URL: https://codereview.chromium.org//1154673004
2015-06-03 12:32:52 +02:00
Karl Klose 683743c9c5 Change more JS foreign methods to JS_GET_NAME.
R=herhut@google.com

Review URL: https://codereview.chromium.org//1154073004
2015-06-03 11:41:46 +02:00
Anders Johnsen 114c37738d Fix signature of UnmodifiableListMixin.insert to match List.insert.
BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org//1160423002
2015-06-03 09:32:49 +02:00
Lasse R.H. Nielsen 6f2dd2552c Fix typo in ListMixin.insertAll.
Also add test for input iterable being linked to receiver list.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1146163004
2015-06-02 11:58:35 +02:00
Natalie Weizenbaum 3d8c06c4e9 Start pulling pub from its own repo.
Pub now lives in third_party/pkg/pub (it's in pkg to make it possible to import
using "package:" imports).

R=ricow@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org//1165473002
2015-05-29 14:50:18 -07:00
Lasse R.H. Nielsen babcd4e9c0 Revert "Make EfficientLength public, as EfficientLengthIterable."
It's still not a good solution for detecting an Iterable with an efficient
length. It's not inherited by, e.g., a DelegatingIterable wrapper or similar
generic Iterable transformers.

Keep this as an internal optimization for quickly detecting the most common
efficient-length Iterable classes (List, Set, Queue, Map.keys/values), but
don't make it public.

A *real* solution would be adding a hasEfficientLength getter to Iterable, or
adding an efficientLength getter that may return null if it's not efficient.
This would something that a wrapper can attach to.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1154263003
2015-05-29 12:52:45 +02:00
Lasse R.H. Nielsen 542e675fed Fix typo in dart2js typed_data.
Review URL: https://codereview.chromium.org//1163653002
2015-05-29 11:18:01 +02:00
Lasse R.H. Nielsen cf4eaae5a6 Change RangeError instances to use RangeError.range.
This avoids using the (sometimes confusing) "[...)" notation for half-open ranges.
Also change argument tests to simpler interval tests, and move error handling to the end of the functions.

Mostly in VM typed-data libraries.

R=sgjesse@google.com, srdjan@google.com

Committed: 932bcc6901

Review URL: https://codereview.chromium.org//1132603003
2015-05-29 10:50:20 +02:00
Lasse R.H. Nielsen 9e175d27d7 Revert "Change RangeError instances to use RangeError.range."
Method hashes needs to be updated.

Review URL: https://codereview.chromium.org//1160903002
2015-05-28 10:46:15 +02:00
Lasse R.H. Nielsen 932bcc6901 Change RangeError instances to use RangeError.range.
This avoids using the (sometimes confusing) "[...)" notation for half-open ranges.
Also change argument tests to simpler interval tests, and move error handling to the end of the functions.

Mostly in VM typed-data libraries.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1132603003
2015-05-28 10:34:03 +02:00
Ivan Posva 91e71b53e3 - Update expected string in pub test.
BUG=

Review URL: https://codereview.chromium.org//1159983005
2015-05-28 00:32:30 -07:00
Ivan Posva 0358f722ba - Include original, loaded URI in error message.
- Update error string comparison in pub.

BUG=

Review URL: https://codereview.chromium.org//1156983003
2015-05-28 00:14:39 -07:00
Alan Knight ee0a5db6a5 Make sanitizer tests handle IE11, where tagName can't be clobbered
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//1148893004
2015-05-27 12:56:09 -07:00
William Hesse fc1bb66b88 Escape arguments in pub error message command line reproduction.
BUG=dartbug.com/23505
Rebase of https://codereview.chromium.org/1035853003/

R=nweiz@google.com

Review URL: https://codereview.chromium.org//1156663002
2015-05-27 17:21:36 +02:00
Søren Gjesse f05608c49d Fix errors in previous commit
Commit was 897d05b6f0.

TBR=lrn@google.com
BUG=http://dartbug.com/23521

Review URL: https://codereview.chromium.org//1145403004
2015-05-27 11:18:03 +02:00
Lasse R.H. Nielsen 25a16a39b3 In JsonEncoder, test if map has only string keys, and use toEncodable if not.
Currently the encoder assumes that a map will have string keys, and will fail
in ugly ways if it doesn't. With this change, the toEncodable function used on
other un-encodable values is also used on non-String-keyed maps.

BUG= http://dartbug.com/23469
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1153893004
2015-05-27 10:49:21 +02:00
Søren Gjesse 897d05b6f0 Fix argument processing for RandomAccessFile.writeFrom
It is now the same as for RandomAccessFile.writeFromSync

Added some tests.

R=lrn@google.com
BUG=http://dartbug.com/23521

Review URL: https://codereview.chromium.org//1156993003
2015-05-27 10:01:24 +02:00
Stephen Adams 4b2d2379cf dart:js - speed up constructor calls with few arguments.
This eliminates the 5x perf hit reported in http://dartbug.com/23514

R=sigmund@google.com

Review URL: https://codereview.chromium.org//1152673003
2015-05-26 15:02:25 -07:00
Lasse R.H. Nielsen dcf0286f53 Add Iterable.empty constructor.
Convenience constructor giving an easy/quick way to create an empty iterable.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1152483002
2015-05-22 10:39:58 +02:00
Alan Knight 39e5dba8c0 Fix typo in sanitizer
BUG=

Review URL: https://codereview.chromium.org//1151903004
2015-05-21 14:43:02 -07:00
Alan Knight efb738f633 Sanitization should reject elements that we can't examine (e.g. embed/object on FF)
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//1146753004
2015-05-21 13:54:50 -07:00
Natalie Weizenbaum 8298073cbc Always ignore non-public transformers.
This was happening for the most part, but the dependency computer could
get tripped up when a package used a transformer from a dev dependency
on only private files.

R=rnystrom@google.com
BUG= http://dartbug.com/23480

Review URL: https://codereview.chromium.org//1143453006
2015-05-20 17:44:46 -07:00
Søren Gjesse e03ab17437 Make Platform.executable return the fully qualified path of the executable
BUG=http://dartbug.com/16994
R=kustermann@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//1145053002
2015-05-20 13:14:51 +02:00
Florian Loitsch ec51cdcca3 dart2js: Cleanups and renames in runtime code that thouches types.
As a convention we use "rti" in variable names that represent internal type encodings.

R=sra@google.com

Review URL: https://codereview.chromium.org//1135653005
2015-05-19 17:43:01 +02:00
Florian Loitsch de495c6b20 dart2js: remove JS_OBJECT_CLASS_NAME and JS_NULL_CLASS_NAME from foreign
Instead of comparing the constructor's class name to the one of the Dart object class (or Null class), provide a builtin that returns whether a type is _the_ object or null type.

This CL also starts the convention that internal types should have "rti" in their name.

R=sra@google.com

Review URL: https://codereview.chromium.org//1136913006
2015-05-19 17:40:02 +02:00
Kathy Walrath fc4ec71aff Update README.md 2015-05-18 15:44:23 -07:00
John McCutchan f3a74e69c9 Fix typo in Stream documentation.
R=johnmccutchan@google.com, msimprovertechnologies@gmail.com

Review URL: https://codereview.chromium.org//1142683002
2015-05-18 11:32:47 -07:00
John McCutchan 6e42aec4f6 Deprecate 'dart:profiler' and move functionality to 'dart:developer'
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1133713006
2015-05-18 11:31:20 -07:00
Lasse R.H. Nielsen 759b494b10 Remove experimental warning from Isolate methods.
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1140823006
2015-05-18 11:14:14 +02:00