languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 02:17:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

dart2js: reuse stack trace on rethrow

Browse source 
BUG= dartbug.com/15171
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//1152023004
This commit is contained in:
Sigmund Cherem 2015-06-08 12:27:49 -07:00
parent 2c533ac971
commit 1763aa3467
2 changed files with 28 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
sdk/lib/_internal/compiler/js_lib/js_helper.dart
View file

@ -2052,7 +2052,11 @@ StackTrace getTraceFromException(exception) {
if (exception is ExceptionAndStackTrace) {
return exception.stackTrace;
}
return new _StackTrace(exception);
if (exception == null) return new _StackTrace(exception);
_StackTrace trace = JS('_StackTrace|Null', r'#.$cachedTrace', exception);
if (trace != null) return trace;
trace = new _StackTrace(exception);
return JS('_StackTrace', r'#.$cachedTrace = #', exception, trace);
}
class _StackTrace implements StackTrace {

23
tests/compiler/dart2js_extra/identical_trace_test.dart Normal file
View file

@ -0,0 +1,23 @@
// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
import 'package:expect/expect.dart';
main() {
var st1;
try {
try {
throw 'bad';
} catch (e, st) {
st1 = st;
rethrow;
}
Expect.fail('Exception expected');
} catch (e, st2) {
Expect.equals(st1, st2);
Expect.identical(st1, st2);
return;
}
Expect.fail('Exception expected');
}