Commit graph

42898 commits

Author SHA1 Message Date
Kevin Millikin ec84b87ebf Fix some puzzling code in object.cc.
Jens was looking through object.cc and he spotted:

    if (Original()) ...

where it seems like Original returns a RawField* which is never 0, so
it is always true.  It looks like it was intended to be a call to
IsOriginal().

(See https://codereview.chromium.org/1722733002/diff/120001/runtime/vm/object.cc)

BUG=

Review URL: https://codereview.chromium.org/2525633003 .
2016-11-24 09:13:08 +01:00
Siva Annamalai 42e4370818 Adjust status files for some test failures.
TBR

BUG=

Review URL: https://codereview.chromium.org/2530783002 .
2016-11-23 22:54:29 -08:00
Siva Annamalai ae7c951b6b Fix status file.
TBR

BUG=

Review URL: https://codereview.chromium.org/2527613004 .
2016-11-23 16:44:52 -08:00
Siva Annamalai 22ac70a563 Fix status file
- Some DBC tests (regexp, field guards) was turned on inadvertantly
 - Skip cc/Profiler_InliningIntervalBoundry on release builds
  (need to figure how to handle the inlining difference between
   debug/release builds)

BUG=

Review URL: https://codereview.chromium.org/2528793003 .
2016-11-23 16:34:38 -08:00
Brian Wilkerson 5b1236cfe7 Fix the setting of analysis options when there is an embedded SDK
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2523313002 .
2016-11-23 15:48:42 -08:00
Siva Annamalai 501720c644 Retry landing cl for issue with TSAN.
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2525103003 .
2016-11-23 15:40:26 -08:00
Ryan Macnak 12de13d1ae An isolate created with spawn function doesn't necessarily agree with its parent on the library private keys.
(The long-standing issue that spawn function should use snapshots would also fix this.)

Encountered by the analyzer in https://codereview.chromium.org/2492933002/

BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/2509413002 .
2016-11-23 15:36:01 -08:00
Ryan Macnak 2cf2297b4f Print snapshot size in PRODUCT mode as well.
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2525063002 .
2016-11-23 14:30:24 -08:00
Ryan Macnak 1b51889447 Allow binding the vm service to IPv6 addresses.
Change the default bind address to 'localhost', which will be resolved to '127.0.0.1' or '::1' depending on the host's support for IPv6.

Fixes #27841

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2515023002 .
2016-11-23 14:24:52 -08:00
Siva Annamalai 93043a3662 Set the default value for use_corelib_source_files to true on windows as we do not have the source bits baked in.
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2522943004 .
2016-11-23 11:09:25 -08:00
Ryan Macnak 8d57e3d540 Enable SecureSocket on Fuchsia using BoringSSL and compiled-in certificates from dart-sdk/root_certificates.
Implement OS::CurrentTimeMicros in terms of gettimeofday.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2519133005 .
2016-11-23 10:48:18 -08:00
Florian Schneider 6cfce40fab Fix product and Mac build.
BUG=

Review URL: https://codereview.chromium.org/2518063008 .
2016-11-23 10:47:44 -08:00
Florian Schneider 6cd141def5 Dump stack trace on segfault in the VM.
Install a signal handler in the standalone VM that dumps a backtrace
similar to what we already do on assertion failures.

For now only Linux and MacOS are supported.

BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/2514113002 .
2016-11-23 10:29:07 -08:00
Siva Annamalai 7d287b232b Add flag use_corelib_source_files to control how dart_bootstrap and gen_snapshot load core libraries during the boot strap process. If this flag is true then an attempt is made to read the core library sources files and if not present fallsback to the source bits baked in the binary.
By default the flag is false.

BUG=#27860
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2527693002 .
2016-11-23 10:26:06 -08:00
Konstantin Shcheglov e0c5a60f3e Remove accidentally committed 'print'.
TBR

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2523263002 .
2016-11-23 10:00:25 -08:00
Paul Berry 08fa512ff2 Fix MemoryCachingByteStore._evict after an unsuccessful get.
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2524693003 .
2016-11-23 09:47:43 -08:00
Konstantin Shcheglov c5531361ca Remove _LibraryNode altogether.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2525753003 .
2016-11-23 09:39:21 -08:00
Konstantin Shcheglov a50cd75b12 Compute files referencing an externally defined name.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2524733006 .
2016-11-23 09:30:23 -08:00
Siva Annamalai 7bbdbe3541 Skip multiple references to fuchsia test.
Review URL: https://codereview.chromium.org/2519133007 .
2016-11-23 09:09:12 -08:00
Siva Annamalai 373aa1980f Skip Fuchsia test on non VM runtimes.
BUG=#27867

Review URL: https://codereview.chromium.org/2530613002 .
2016-11-23 09:05:30 -08:00
Florian Loitsch 1780f8dbc4 Update links to point to sdk-repo. (#27582)
Some links were still pointing to the old repository.
2016-11-23 16:37:26 +01:00
Alexandre Ardhuin 3f1720069a Add a note on the README of js package (#27701) 2016-11-23 16:36:54 +01:00
Asger Feldthaus d056236180 Enable strong-mode for pkg/kernel and fix some strong-mode warnings.
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org/2523673005 .
2016-11-23 16:16:37 +01:00
Asger Feldthaus 5d310431bd Remove closure_conversion.dart from pkg/kernel.
This file is not strong-mode clean, but since a more recent version
of closure conversion still exists in a branch on the kernel github
repo, there is not much point in fixing this version of it.

BUG=
R=ahe@google.com

Review URL: https://codereview.chromium.org/2526793002 .
2016-11-23 15:34:35 +01:00
Asger Feldthaus f13881ac08 Fix the pubspec and warnings in pkg/kernel.
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org/2530543002 .
2016-11-23 14:36:22 +01:00
Asger Feldthaus b0ffc26dab Fix vm-kernel status file after merging kernel.
The buildbots run tests against the checked-in version of analyzer,
not the one in the pubspec, which is why the tests behave differently.

BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org/2524973002 .
2016-11-23 14:19:34 +01:00
Asger Feldthaus ac21874a21 Disable kernel unit tests.
They are causing issues on dartium and dart2js_jsshell.

BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org/2528623002 .
2016-11-23 14:12:54 +01:00
Asger Feldthaus ce428a1f20 Complete merge of kernel repo into SDK.
This removes third_party/pkg/kernel and changes dependencies to
refer to pkg/kernel instead.

Some status files are updated to reflect new test outcomes.
2016-11-23 12:46:29 +01:00
Asger Feldthaus a45478f271 Merge the kernel repository into the main SDK.
This brings in the kernel repository from github/dart-lang/kernel,
containing the Dart implementation of Kernel, not to be confused with
the SDK fork that contained the VM changes.

Commit messages from the old repository have been preserved and
prefixed with [kernel].

Kernel now lives in pkg/kernel instead of third_party/pkg/kernel.
References to the old location will be updated in the next commit.

Binary files have been stripped from the history, which breaks
some of kernel's unit tests. These tests have been disabled and
will be fixed later.
2016-11-23 12:24:49 +01:00
Erik Ernst 7809d25b92 Remove the ability in dart2js to turn off syntax-only generic methods.
This CL removes all the checks for 'enableGenericMethodSyntax' in the
implementation, which takes away the ability to turn this feature off
and simplifies the code.

As a result, `ParserOptions` is now empty; we may want to remove it,
but this CL does not do that.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2521073003 .
2016-11-23 12:16:30 +01:00
Asger Feldthaus 2eb09d26e3 [kernel] Update and disable some kernel unit tests.
This is in preparation of merging into the SDK repository.
2016-11-23 12:14:59 +01:00
Martin Kustermann 2c9cbb1d2c VM: [Kernel] Go back to previous behavior in loader.cc
Review URL: https://codereview.chromium.org/2523183002 .
2016-11-23 10:55:59 +01:00
William Hesse 4bfe727db6 Update status for Firefox 50
BUG=https://github.com/dart-lang/sdk/issues/27873
BUG=https://github.com/dart-lang/sdk/issues/27872
BUG=https://github.com/dart-lang/sdk/issues/27871
BUG=https://github.com/dart-lang/sdk/issues/27867
R=sortie@google.com

Review URL: https://codereview.chromium.org/2526493004 .
2016-11-23 09:49:01 +01:00
Martin Kustermann 1aff626804 VM: [Kernel] Split kernel API into 3 steps: ([read binary], parse-binary, bootstrap, load program)
This avoids reading and parsing the kernel binary multiple times and avois
having it multiple times in memory (we don't free the 'kernel::Program*' object
ATM).

R=kmillikin@google.com

Review URL: https://codereview.chromium.org/2525623002 .
2016-11-23 09:26:15 +01:00
Martin Kustermann 656be7a7aa Update status file for kernel
Review URL: https://codereview.chromium.org/2525883002 .
2016-11-23 08:58:18 +01:00
Martin Kustermann b1c04f0538 Avoid random stacktraces being printed from tools/test.py during test runs
Previously the testing script was just printing interleaved stack traces with
all the other output. Which means it's not associatable with a single test and
is highly confusing!

This CL associates the stack trace information of tests which time out to the
particular test which timed out.

R=whesse@google.com

Review URL: https://codereview.chromium.org/2524733004 .
2016-11-23 08:39:27 +01:00
Ryan Macnak 171da0489f Fuchsia sockets:
- Remove CheckConnect.
  - Enable NODELAY.
  - Add testSimpleReadWriteClose to hello_fuchsia_test.

Add stub implementation of OS::MaxRSS so Observatory can load without crashing the target VM.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2523133002 .
2016-11-22 16:52:21 -08:00
Paul Berry 05a6045674 Rename AstFactory -> AstTestFactory.
This paves the way for introducing a new AstFactory class that will be
part of the analyzer public API.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2524903002 .
2016-11-22 16:09:51 -08:00
Todd Turnidge 193ddba4db Revert "Implement rewind: drop one or more frames from the debugger."
This reverts commit af1875be91.

BUG=

Review URL: https://codereview.chromium.org/2521413002 .
2016-11-22 16:05:26 -08:00
Todd Turnidge af1875be91 Implement rewind: drop one or more frames from the debugger.
Not yet implemented on dbc.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2523053002 .
2016-11-22 15:26:08 -08:00
Paul Berry e9ebfd4b39 Disable test_import_short_absolute on Windows.
Fixes #27870

R=scheglov@google.com

Review URL: https://codereview.chromium.org/2522113002 .
2016-11-22 15:18:29 -08:00
Konstantin Shcheglov 7ec65fb9ca Fix for exception duirng indexing a reference to MultiplyDefinedElement.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2529433003 .
2016-11-22 15:03:41 -08:00
John McCutchan ea94a5dcb0 Don't pass --print_snapshot_sizes in product mode
BUG=

Review URL: https://codereview.chromium.org/2521323003 .
2016-11-22 14:47:05 -08:00
Stephen Adams 9e80530980 dart2js/kernel: Implement type literal (constant) and JS_INTERCEPTOR_CONSTANT
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2529483002 .
2016-11-22 14:44:30 -08:00
Brian Wilkerson 4e762c8dbf Fix failures caused by earlier CL
R=paulberry@google.com

Review URL: https://codereview.chromium.org/2523853002 .
2016-11-22 13:49:19 -08:00
Brian Wilkerson 1767def635 Respect the rest of the analysis-based options
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2523833002 .
2016-11-22 13:12:32 -08:00
Konstantin Shcheglov f1f036f018 Implement 'displayName' for accessor and varaible elements in linker.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2527523002 .
2016-11-22 12:59:21 -08:00
John McCutchan e3a8b8085f Add RETURN_NULL_ERROR to new apis
BUG=

Review URL: https://codereview.chromium.org/2524853002 .
2016-11-22 12:53:00 -08:00
Ryan Macnak b83fb06741 Fuchsia sockets:
- Enable FDUtils::AvailableBytes.
 - Disable Socket::SetNoDelay.
 - Implement Socket::GetRemotePeer same as Linux.
 - Implement Socket::ParseAddress same as Linux.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2522923002 .
2016-11-22 12:49:01 -08:00
Konstantin Shcheglov 366e727048 Implement search for other local elements.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2529473002 .
2016-11-22 12:48:15 -08:00