languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-03 06:21:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
36817 commits 11 branches 6011 tags 1.4 GiB
Commit graph

7490 commits

Author SHA1 Message Date
Terry L. Lucas b6503c7f74 Added for registerElement checking 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1401703002 .
 2015-10-11 18:57:59 -07:00
Terry L. Lucas 4f9771f4e1 Fixed JS custom elements and temporarily mark polymer test as failing 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1402693002 .
 2015-10-10 16:50:10 -07:00
Terry L. Lucas 888d458e90 Fixed upgrading and data binding 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1403623002 .
 2015-10-09 17:03:53 -07:00
John McCutchan 80dec9493f Add missing patch methods to dart2js implementation of timeline 
BUG=

Review URL: https://codereview.chromium.org/1400893002 .
 2015-10-09 11:47:24 -07:00
Alan Knight 5d615053dd Another attempt at getting NativeUint8 usage in html_common/conversions right 
BUG=

Review URL: https://codereview.chromium.org/1391143003 .
 2015-10-09 11:00:23 -07:00
Alan Knight 1cc65ff26e Missed a spot where NativeUint8ClampedList was used 
BUG=

Review URL: https://codereview.chromium.org/1390913006 .
 2015-10-09 10:38:56 -07:00
John McCutchan 1a0066816d Add support for emitting asynchronous timeline events from Dart code 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1397823002 .
 2015-10-09 10:21:02 -07:00
Alan Knight 2d815d89e7 Remove dependence on internal native_typed_data and malformed type as a result 
BUG=

Review URL: https://codereview.chromium.org/1399063002 .
 2015-10-09 10:02:23 -07:00
Terry L. Lucas 82fdf816b9 Added Alan's CL 1398603003 and augmented with upgrade for HtmlElement and HTMLElement 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1400843002 .
 2015-10-09 09:38:37 -07:00
Sigurd Meldgaard 01d6977030 Revert "Introduce the "Embedded" category." 
This reverts commit 0aef0efb6a.

BUG=

Review URL: https://codereview.chromium.org/1401513002 .
 2015-10-09 13:29:53 +02:00
Sigurd Meldgaard 0aef0efb6a Introduce the "Embedded" category. 
It is not visible from the dart2js command line.

BUG=
R=brianwilkerson@google.com, johnniwinther@google.com

Review URL: https://codereview.chromium.org/1395863002 .
 2015-10-09 13:08:26 +02:00
Terry L. Lucas 2bd3d32181 Updated _blink_dartium.dart needed to prefix a type namespace 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1394363002 .
 2015-10-08 14:20:02 -07:00
Terry L. Lucas 78658b3a88 Hide the accessors for bad custom element upgrade 
TBR=alanknight@google.com,jacobr@google.com

Review URL: https://codereview.chromium.org/1397793002 .
 2015-10-08 10:27:51 -07:00
Søren Gjesse 1f652b320c Fix bug in previous commit 
TBR=lrn@google.com
BUG=

Review URL: https://codereview.chromium.org/1400453004 .
 2015-10-08 19:19:30 +02:00
Søren Gjesse 7c0688a5c6 Ensure ZILB encoder handles all typed data lists correctly 
R=ajohnsen@google.com, lrn@google.com
BUG= https://github.com/dart-lang/sdk/issues/24521

Review URL: https://codereview.chromium.org/1393013002 .
 2015-10-08 18:19:02 +02:00
Terry L. Lucas 0a254bab8d Update to get latest changes to WebKit 
TBR=jacobr@google.com,alanknight@google.com

Review URL: https://codereview.chromium.org/1389163005 .
 2015-10-08 06:46:55 -07:00
Alan Knight c92a2450b4 Switch dart:html objects not to be NativeFieldWrapper subclasses with JsInterop 
BUG=

Review URL: https://codereview.chromium.org/1392723003 .
 2015-10-07 17:42:39 -07:00
Stephen Adams 5265eeebaa Use interceptors for is-checks (version 2). 
Use the $isXXX properties for type tests on raw (non-parameterized) types.

Use special builtin operations for the weird JSArray type hierarchy.

Still TODO:

If the only use of an interceptor is a single 'getInterceptor(value).$isXXX', and XXX is not a supertype of a native type, replace with 'value instanceof XXX'.

R=kmillikin@google.com

Committed: 3b4e12f00b

Reverted: 89b6d8e749

Review URL: https://codereview.chromium.org/1385423002 .
 2015-10-07 17:06:57 -07:00
Sam Rawlins fb7d871428 Formatting comments for mirrors (MirrorSystem, IsolateMirror, DeclarationMirror, and ObjectMirror) 
BUG=https://github.com/dart-lang/sdk/issues/24505
R=lrn@google.com

Review URL: https://codereview.chromium.org/1383403002 .
 2015-10-07 16:48:48 -07:00
Sam Rawlins e928812e27 Format doc comments in mirrors, lines 480 through 1160 
BUG=https://github.com/dart-lang/sdk/issues/24505

Review URL: https://codereview.chromium.org/1390813002 .
 2015-10-07 16:41:58 -07:00
Stephen Adams 89b6d8e749 Revert "Use interceptors for is-checks (version 2)." 
Need to fix some analyzer warnings.

TBR=kmillikin@google.com

Review URL: https://codereview.chromium.org/1396663002 .
 2015-10-07 16:29:11 -07:00
Stephen Adams 3b4e12f00b Use interceptors for is-checks (version 2). 
Use the $isXXX properties for type tests on raw (non-parameterized) types.

Use special builtin operations for the weird JSArray type hierarchy.

Still TODO:

If the only use of an interceptor is a single 'getInterceptor(value).$isXXX', and XXX is not a supertype of a native type, replace with 'value instanceof XXX'.

R=kmillikin@google.com

Review URL: https://codereview.chromium.org/1385423002 .
 2015-10-07 15:47:25 -07:00
Terry L. Lucas c9b553aad1 Fixed upgrade failures to only throw once not on each wrap_jso 
R=alanknight@google.com
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1395723002 .
 2015-10-07 14:37:24 -07:00
Jacob Richman 1f9516ba0b Fix some build breaks. 
Fix test breaks

Roll dep forward to fix windows build.

Dartium typed js interop work dart repo side of the change. Also tries to get

BUG=

Review URL: https://codereview.chromium.org/1390113003 .
 2015-10-07 13:47:12 -07:00
John McCutchan c9334ed61f Fix analyzer warnings in dart:_vmservice 
BUG=

Review URL: https://codereview.chromium.org/1397593002 .
 2015-10-07 13:31:29 -07:00
John McCutchan 4831a1a315 Properly split dart:_vmservice across sdk and runtime 
- This is needed to satisfy the GN build system (mojo, flutter).
- It also makes dart:_vmservice even more regular with othe rlibraries.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1396603002 .
 2015-10-07 13:19:55 -07:00
Jacob Richman 8d793ca758 Dartium typed js interop work dart repo side of the change. Also tries to get 
BUG=

Review URL: https://codereview.chromium.org/1391353002 .
 2015-10-07 11:44:50 -07:00
Matthias Hausner 11965d24e6 Move super initializers to end of list 
Avoid two-phase super constructor call chain in a couple
of library constructors.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1393033002 .
 2015-10-07 11:05:26 -07:00
John McCutchan 51840587fc Remove remaining references to dart:profiler 
BUG=

Review URL: https://codereview.chromium.org/1393833004 .
 2015-10-07 10:27:48 -07:00
John McCutchan 535a9715ac Remove deprecated dart:profiler library 
Fixes #24510

R=turnidge@google.com

Review URL: https://codereview.chromium.org/1398433002 .
 2015-10-07 10:01:33 -07:00
Alan Knight 9ad57e7aa3 Fix Crypto.getRandomValues to modify its argument, fix tests 
BUG=

Review URL: https://codereview.chromium.org/1387273002 .
 2015-10-07 09:11:14 -07:00
Terry L. Lucas ff5d07a4e9 Fixed few more issues with upgrader and custom event identitiy 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1391273002 .
 2015-10-07 08:53:31 -07:00
Harry Terkelsen 2a053a9441 fix typo in dart:core.Map docs 
BUG=
R=skybrian@google.com

Review URL: https://codereview.chromium.org/1393713002 .
 2015-10-06 19:03:24 -07:00
Terry L. Lucas f867fb0218 Fixed element upgrading for polymer 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1382383003 .
 2015-10-06 13:11:23 -07:00
Seth Ladd 7b18bc7e14 clearly mark resource as deprecated 
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org/1385933002 .
 2015-10-06 09:08:11 -07:00
Soren Gjesse 33e2d9cd7e Increase the datagram receive buffer on Windows to 64k 
A datagram can can be up to 64k, and if the buffer is too small the received data is truncated.

This change also correctly handles errors when receiving datagrams on Windows.

BUG= #24426
R=kustermann@google.com, iposva@google.com

Review URL: https://codereview.chromium.org/1381233003.
 2015-10-06 08:42:51 +02:00
Terry L. Lucas ecfad36ac7 Fixed custom elements to work in Polymer 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1389683002 .
 2015-10-05 08:55:52 -07:00
Søren Gjesse 65872873d2 Remove server socket references 
The use of server socket references was deprecated in 1.9 and marked
for removal in 1.10.

R=kustermann@google.com

BUG=http://dartbug.com/22187

Review URL: https://codereview.chromium.org/1072783003 .
 2015-10-05 12:25:20 +02:00
Lasse R.H. Nielsen da8baacae4 Make root-zone handleUncaughtError rethrow with the correct stack. 
Adds _rethrow function which reifies the stack trace of an async
error on the VM. There is no corresponding JS functionality, it still
just throws an AsyncError wrapper.

Fixes issue #24163
BUG= http://dartbug.com/24163
R=iposva@google.com, turnidge@google.com

Review URL: https://codereview.chromium.org//1383983002.
 2015-10-05 08:16:52 +02:00
Ivan Posva a1f0a52c4f - Fix build: Make sure that external methods are patched in dart2js. 
BUG=

Review URL: https://codereview.chromium.org/1389533002 .
 2015-10-03 07:24:38 -07:00
Ivan Posva ba6c0ace3e - Add getters for the current packageRoot or packageMap to the Isolate class. 
- Simplify loading in builtin.dart.

BUG=
R=asiva@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//1334353002 .
 2015-10-03 06:53:13 -07:00
Alan Knight 110b579b8a wrap_jso should wrap JsArray as well, not always call wrap on its contents 
BUG=

Committed: f0e52e4e91

Review URL: https://codereview.chromium.org/1383903002 .
 2015-10-02 12:48:06 -07:00
Alan Knight da7d6379cc Revert "wrap_jso should wrap JsArray as well, not always call wrap on its contents" 
This reverts commit f0e52e4e91.

BUG=

Review URL: https://codereview.chromium.org/1378183003 .
 2015-10-01 17:51:51 -07:00
Alan Knight f0e52e4e91 wrap_jso should wrap JsArray as well, not always call wrap on its contents 
BUG=

Review URL: https://codereview.chromium.org/1383903002 .
 2015-10-01 16:22:17 -07:00
Stephen Adams bd11810f98 Fix bug in dart2js developer_patch.dart 
TBR=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1383883002 .
 2015-10-01 15:17:42 -07:00
Alan Knight eafe9d6b60 Make the dartWrapper access on JsObject private and provide top-level functions for it 
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/1369263004 .
 2015-10-01 15:10:48 -07:00
Alan Knight 07b2ddd401 Preserve identity of Dart wrappers on DOM objects 
BUG=

Review URL: https://codereview.chromium.org/1380963003 .
 2015-10-01 14:04:01 -07:00
John McCutchan 364f6ac601 Fix error caught by analyzer 
BUG=

Review URL: https://codereview.chromium.org/1371353003 .
 2015-10-01 10:50:22 -07:00
John McCutchan 03b41129a2 Add Timeline to dart:developer 
- This CL only adds support for synchronous blocks of time. A follow up CL will add asynchronous blocks of time.
- Reports true thread id to tracing system. This is an improvement over Mojo's tracing helper.
- Dart events are included in individual isolate traces and global traces obtained via the embedders API.
- Dart events are included in the write to disk path (--timeline_dir).

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1377663002 .
 2015-10-01 09:30:47 -07:00
Alan Knight 59bd28d8cf Revert "Preserve identity on wrap_jso hack. Has known failures" 
This reverts commit e65577e4aa.

BUG=

Review URL: https://codereview.chromium.org//1380603004 .
 2015-09-30 17:50:54 -07:00
Alan Knight e65577e4aa Preserve identity on wrap_jso hack. Has known failures 
BUG=

Review URL: https://codereview.chromium.org//1382483003 .
 2015-09-30 13:39:03 -07:00
Seth Ladd ab5af73d75 add JsonCode example 
BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org//1376043002 .
 2015-09-30 11:02:02 -07:00
Alan Knight 8f8d9e7180 Revert "Cache all wrap_jso results so we preserve identity" 
This reverts commit fd52ed572f.

BUG=

Review URL: https://codereview.chromium.org//1374683004 .
 2015-09-29 17:18:03 -07:00
Alan Knight fd52ed572f Cache all wrap_jso results so we preserve identity 
BUG=

Review URL: https://codereview.chromium.org//1376083002 .
 2015-09-29 16:41:38 -07:00
Lasse R.H. Nielsen eb763f941d Fix typos in base64.dart 
Review URL: https://codereview.chromium.org//1377843003.
 2015-09-29 16:34:29 +02:00
Lasse R.H. Nielsen bd4c7a8a07 Add Base64 codec to dart:convert. 
This is a simple converter that only accepts and produces plain base-64 strings
with the default alphabet and no whitespace.

R=floitsch@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//1370073002 .
 2015-09-29 13:49:53 +02:00
Terry L. Lucas 138888e566 Need to handle skipping mixins in a CustomElement 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1368383002 .
 2015-09-28 07:29:14 -07:00
Terry L. Lucas 40fed74848 Fixed checking for more complex inheritance 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1374543002 .
 2015-09-27 21:09:34 -07:00
Terry L. Lucas 3ce007e910 Fixed a bunch of failure cases for custom elements 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1373563004 .
 2015-09-25 15:12:08 -07:00
Alan Knight 1b80b9013e Make sure we short-circuit the second corruption test, it might be crashing firefox 
BUG=

Review URL: https://codereview.chromium.org//1371543002 .
 2015-09-24 16:45:08 -07:00
Alan Knight a4004b6e97 Fix one level of error in postmessage tests, suppress nested list tests 
BUG=

Review URL: https://codereview.chromium.org//1371503002 .
 2015-09-24 14:27:27 -07:00
Terry L. Lucas 54282ccd72 Update to handle expections in custom element's created constructor 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1370513003 .
 2015-09-24 13:17:35 -07:00
Alan Knight 5b6401e900 Move JS calls out of Dartium code 
BUG=

Review URL: https://codereview.chromium.org//1369573004 .
 2015-09-24 12:36:18 -07:00
Alan Knight 8f35656f9b Fix node_validator xss tests for IE and Firefox 
BUG=

Review URL: https://codereview.chromium.org//1365093003 .
 2015-09-24 10:43:08 -07:00
Johnni Winther f794df713b Enqueue superclasses instead of supertypes. 
BUG=
R=herhut@google.com, karlklose@google.com

Committed: a118955a2b

Reverted: b1ecbf10d4

Review URL: https://codereview.chromium.org//1352533002.
 2015-09-24 11:20:23 +02:00
Stephen Adams fdc31a59d3 Redo "dart2js: fix for https://github.com/dart-lang/sdk/issues/24412" 
This time don't try to fix cps_ir try-catch javascript object capture
bug (https://github.com/dart-lang/sdk/issues/24421)

TBR=asgerf@google.com

Review URL: https://codereview.chromium.org//1363183003 .
 2015-09-23 18:16:00 -07:00
Stephen Adams bb1998a825 Revert "dart2js: fix for https://github.com/dart-lang/sdk/issues/24412" 
TBR=asgerf@google.com
BUG=

Review URL: https://codereview.chromium.org//1367783003 .
 2015-09-23 18:07:23 -07:00
Stephen Adams 0bd5cc5f70 dart2js: fix for https://github.com/dart-lang/sdk/issues/24412 
The regression on some benchmarks was caused by
UnknownJavaScriptObject becoming alive.  Changing the test to 'is' reverts the regression.

Also make the cps_ir register UnknownJavaScriptObject when generating try-catch as that might snag a JavaScript error.

BUG= https://github.com/dart-lang/sdk/issues/24412
R=asgerf@google.com

Review URL: https://codereview.chromium.org//1366673003 .
 2015-09-23 17:27:16 -07:00
keertip 18b68f7290 remove docgen remnants from repo, update CHANGELOG 
BUG=
R=alanknight@google.com, whesse@google.com

Review URL: https://codereview.chromium.org//1361163002 .
 2015-09-23 10:27:15 -07:00
Florian Loitsch eb2878c830 dart2js: isExtensible can throw for bad objects. 
Guard the call to Object.isExtensible when trying to set a property on JS objects.

R=sra@google.com

Review URL: https://codereview.chromium.org//1364473002 .
 2015-09-23 11:41:55 +02:00
Lasse R.H. Nielsen 4e94938f7e Fix some cases where Map.containsValue did not accept Object as argument. 
Add tests.
Also remove a left-over check in SplayTreeMap.

BUG= https://github.com/dart-lang/dev_compiler/issues/344
R=wibling@google.com

Review URL: https://codereview.chromium.org//1360053003 .
 2015-09-23 11:26:55 +02:00
keertip c775149a5a remove docgen source and targets from build 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org//1364553002 .
 2015-09-22 15:10:18 -07:00
Stephen Adams 5612c202a0 dart2js runtime: Harden objectTypeName. 
1. Avoid crashing on short minified names.
2. Try to find a better name for external JavaScript classes.
3. Try to find a better name for undistingushed native classes.

BUG= http://dartbug.com/24393

This is related to http://dartbug.com/19137

R=sigmund@google.com

Review URL: https://codereview.chromium.org//1362553002 .
 2015-09-22 14:46:14 -07:00
Alan Knight 0568fa8679 Omit extra argument to createElement/NS if null 
BUG=

Review URL: https://codereview.chromium.org//1345413004 .
 2015-09-22 09:28:38 -07:00
Terry L. Lucas 847847dd95 Fixed typo and test that passes and fails in checked mode 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1350903008 .
 2015-09-22 07:59:37 -07:00
Lasse R.H. Nielsen 232a9d687e Add "environment" parameter to spawnUri for String.fromEnvironment support. 
This completes the parameters corresponding to official command line parameters
for the VM/dart2js.

R=floitsch@google.com, iposva@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//1350053002 .
 2015-09-22 12:29:40 +02:00
keertip 578f3df71c fix comment - add whitespace 
BUG=
R=sethladd@google.com

Review URL: https://codereview.chromium.org//1343173004 .
 2015-09-21 13:03:01 -07:00
Seth Ladd 55fc80e15e specify when a Future completes for IOSink's addStream 
BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org//1342293003 .
 2015-09-21 11:57:27 +02:00
Stephen Adams d0c00d2b61 Throw Error on unreachable code rather than throwing a String. 
Still under a 'flag'.
Enable with:

  DART_VM_OPTIONS=-Dunreachable-throw=true  <compile>

These tests fail with an [empty] input to createRuntimeType.

DART_VM_OPTIONS=-Dunreachable-throw=true  tools/test.py -mrelease -cdart2js -rd8 dart2js_extra/deferred/deferred_mirrors1_test
DART_VM_OPTIONS=-Dunreachable-throw=true  tools/test.py -mrelease -cdart2js -rd8 dart2js_extra/mirrors_used_warning2_test
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1355873003 .
 2015-09-18 16:54:50 -07:00
Alan Knight 1b12c2c89c Operator precedence in isJavaScriptSimpleObject 
BUG=

Review URL: https://codereview.chromium.org//1356653003 .
 2015-09-18 14:30:41 -07:00
Alan Knight 7c6439044b import dart:async in dart2js version of html_common 
BUG=

Review URL: https://codereview.chromium.org//1354173005 .
 2015-09-18 13:50:47 -07:00
Alan Knight a2b606dd54 isJavaScriptPromise needs to handle Promise not being defined (IE) 
BUG=

Review URL: https://codereview.chromium.org//1355913002 .
 2015-09-18 13:45:33 -07:00
Alan Knight aebb870b13 Start using the dart2js type conversions in Dartium as well. 
BUG=

Review URL: https://codereview.chromium.org//1349293006 .
 2015-09-18 12:44:36 -07:00
Terry L. Lucas bcf8dfe1f1 Merge mistake removed annotations for dart2js; re-added. 
TBR=sra@google.com

Review URL: https://codereview.chromium.org//1350063004 .
 2015-09-18 07:25:33 -07:00
Karl Klose bd331519c6 dart2js: clean up setRuntimeType 
We do not call setRuntimeType on the result of factories - only of generative constructors, which do not return null.

R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1354463003 .
 2015-09-18 11:33:17 +02:00
Stephen Adams a2239c2dee dart2js ssa: Inlining heuristics ignore assert() statement size. 
assert() Ast nodes are not counted towards inlinee size in production mode.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//1345413002 .
 2015-09-17 09:44:32 -07:00
Johnni Winther b1ecbf10d4 Revert "Enqueue superclasses instead of supertypes." 
This reverts commit a118955a2b.

BUG=

Review URL: https://codereview.chromium.org//1354603002.
 2015-09-17 14:02:46 +02:00
Johnni Winther a118955a2b Enqueue superclasses instead of supertypes. 
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1352533002.
 2015-09-17 13:28:31 +02:00
Johnni Winther ecb1e33a7f Report hint on unmatched show and hide combinators. 
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1346133002.
 2015-09-17 12:33:17 +02:00
Stephen Adams 0b9e80edbf Add optional message to assert in Dart2js - continued 
This CL takes https://chromiumcodereview.appspot.com/1325843003/ and makes some changes:

 - distinguish enableUserAssertions from enableTypeAssertions
 - better type inference for disabled assertions

R=lrn@google.com

Committed: d5b2b393f3

Review URL: https://codereview.chromium.org//1342213003 .
 2015-09-16 16:47:40 -07:00
Stephen Adams 37be70525b Revert "Add optional message to assert in Dart2js - continued" 
To be re-applied with .status changes.

TBR=sigmund@google.com

Review URL: https://codereview.chromium.org//1346093003 .
 2015-09-16 16:37:10 -07:00
Stephen Adams d5b2b393f3 Add optional message to assert in Dart2js - continued 
This CL takes https://chromiumcodereview.appspot.com/1325843003/ and makes some changes:

 - distinguish enableUserAssertions from enableTypeAssertions
 - better type inference for disabled assertions

R=lrn@google.com

Review URL: https://codereview.chromium.org//1342213003 .
 2015-09-16 15:16:02 -07:00
Terry L. Lucas fc8682ceac Fixed another dart2js code emitting error and enabled tests that now work 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1346203002 .
 2015-09-16 08:19:15 -07:00
Terry L. Lucas 7b322c246c Dartium JS Enabled take 2 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1348173002 .
 2015-09-16 07:13:53 -07:00
Rico Wind b6e48e9617 Use cammelCase for all service extension variables 
R=johnmccutchan@google.com, johnmmccutchan@google.com
BUG=

Review URL: https://codereview.chromium.org//1343033002 .
 2015-09-16 07:27:45 +02:00
Terry L. Lucas 09c804aa78 Revert "Dartium JS Interop enabled." 
This reverts commit 403bd1698d.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1345083002 .
 2015-09-15 19:44:26 -07:00
Terry L. Lucas 403bd1698d Dartium JS Interop enabled. 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1349493003 .
 2015-09-15 17:36:47 -07:00
Rico Wind f3f358e5f3 Change times reported from io resource meta data to be milliseconds since epoch 
Change tests accordingly (and add a few extra tests)

Move the logic to the _IOResource class to only have one datetime and one stopwatch.

R=johnmccutchan@google.com, sgjesse@google.com
BUG=

Review URL: https://codereview.chromium.org//1341733003 .
 2015-09-15 07:42:06 +02:00
Rico Wind 38b579fa78 Add tracking of open processes to the new io resource tracking. 
I plan on refactoring the io_resource_info.dart file a bit in a follow up, but I keept this simple

I also plan on adding some sort of sanity checking when the vm exits, to make sure
all 3 maps are empty (in debug mode)

This fixes issue #24314, before we would hold on to process that failed to start
running in the _processes map.

Closes #24314
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1331033003 .
 2015-09-14 12:54:36 +02:00
Lasse R.H. Nielsen ff65079c47 Add packages parameter to Isolate.spawnUri. 
No implementation supplied, marked as "not implemented everywhere".

BUG= http://dartbug.com/23951
R=iposva@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//1323373002 .
 2015-09-11 13:07:54 +02:00
Lasse R.H. Nielsen 7464947ca0 Make Map constructor external to allow dart2js to specialize it. 
Review URL: https://codereview.chromium.org//1330303002 .
 2015-09-11 13:06:09 +02:00
Lasse R.H. Nielsen d755dd65b9 Update range errors to agree on the numbers. 
Also ensure that typed-data errors are consistent with other lists.

Fixes issue #24295
BUG= http://dartbug.com/24295
R=floitsch@google.com, iposva@google.com, sra@google.com

Review URL: https://codereview.chromium.org//1318943005 .
 2015-09-11 13:05:36 +02:00
Lasse R.H. Nielsen 931e41777e Merge pull request #24236 from a14n/use-const 
use const constructors of Utf8* at several places
 2015-09-11 12:26:27 +02:00
Kevin Millikin 95860326cd Fix a typo in the documentation for HashMap. 
BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org//1337873003 .
 2015-09-11 11:28:10 +02:00
Stephen Adams 1aa97c36b5 dart2js ssa: Open coding of removeLast should use -1 as index 
This makes the error consistent between unoptimized and optimizer code.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//1315523012 .
 2015-09-10 15:38:49 -07:00
Terry L. Lucas 9b0d2582fc Revert "Dartium w/ JsInterop enabled" 
This reverts commit 346af54711.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1330163010 .
 2015-09-09 17:33:24 -07:00
Terry L. Lucas 346af54711 Dartium w/ JsInterop enabled 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1321613005 .
 2015-09-09 17:01:40 -07:00
Johnni Winther 8855bc8161 Support metadata on patches. 
Closes #24291

R=karlklose@google.com

Review URL: https://codereview.chromium.org//1302333006.
 2015-09-09 13:04:51 +02:00
Rico Wind c6918fb126 Refactor the io resource classes 
Move stopwatch so that we will only ever need one instance

Add utility functions for doing reads and writes

The only functional change here is that I say that an except is a read
of one byte, which also updates the readcount. I think this is just as
correct as what we did before.

BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1320023008 .
 2015-09-09 09:18:07 +02:00
Terry L. Lucas 012c998f64 Revert "Patched in Dartium JsInterop" 
This reverts commit 4bb2e617db.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1327083002 .
 2015-09-08 13:35:03 -07:00
Terry L. Lucas 4bb2e617db Patched in Dartium JsInterop 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1310363006 .
 2015-09-08 12:46:41 -07:00
Rico Wind db0d25efd1 Add resource metadata for open files. 
Start tracking the read/write information for files in the new
resource management class.

There is currently no time information, I will refactor the timings so that the
static stopwatch from the socket_patch class is moved into the resource class
instead in a follow up (keeping this simply and only about the file addition).

The testing setup may seem a bit strange, but it is the only way I
seem to be able to guarantee that setup actually finishes and that we
get it cleaned up. John may know of a better way

R=sgjesse@google.com, johnmccutchan@google.com
BUG=

Review URL: https://codereview.chromium.org//1326703004 .
 2015-09-08 11:27:06 +02:00
Søren Gjesse 0124a0542e Revert "Handle addError on a WebSocket" 
This reverts commit 373dd4b33c.

Timeout in tests on Windows and Mac

TBR=ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//1328123002 .
 2015-09-07 09:07:39 +02:00
Søren Gjesse 373dd4b33c Handle addError on a WebSocket 
A call to addError on a WebSocket will now close the connection and add the
error to the associated stream.

Using addError on a WebSocket is not that relevant as normally the close
method is used to close with a possible error condition.

BUG= https://github.com/dart-lang/sdk/issues/24278
R=lrn@google.com

Review URL: https://codereview.chromium.org//1304243005 .
 2015-09-07 08:28:49 +02:00
Stephen Adams cbaae993a1 Make functions that appear to be unreachable throw. 
Functions are unreachable if their parameters have an empty type. We would generate bogus code for the function due to the empty type so we might as well generate a throw. This can prevent spurious inclusion of more code referenced only in the unreachable code.

It is usually a bug if we generate unreachable methods but it can happen for legitimate reasons.  One is that type inference is sometimes more precise than type propagation in the optimizer. Another is that we call a function that has an uninstantiated parameter type. This usually happens due the infeasibility of the path being hidden by a correlation between the type and some variable's value.

There is a tail of bugs that need to be flushed out before we can enable this by default.

Enable with:

  DART_VM_OPTIONS=-Dunreachable-throw=true  <compile>

language/cyclic_default_values_test fails, with foo and foo2 falsely unreachable:

DART_VM_OPTIONS=-Dunreachable-throw=true tools/test.py -mrelease -cdart2js -rd8  language/cyclic_default_values_test

I have added a test for the cause - a type inference bug with default argument values.

DART_VM_OPTIONS=-Dunreachable-throw=true tools/test.py -mrelease dart2js/simple_inferrer_const_closure_default_test
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1320673004 .
 2015-09-04 15:11:08 -07:00
Rico Wind 06ab2bdbdd Extract meta data about open sockets into separate class. 
The current implementation only has information about tcp and udp
sockets, and we explicitly do not track internal and pipe uses of
_NativeSockets.

The testing of this is done through the service layer, which is the end user of
this.

BUG=
R=sgjesse@google.com

Committed: 01eff8ce18

Review URL: https://codereview.chromium.org//1323943003 .
 2015-09-03 19:18:42 +02:00
Rico Wind 665f397bb8 Revert "Extract meta data about open sockets into separate class." 
This reverts commit 01eff8ce18.

Seeing issues on windows and on dart2js

R=sgjesse@google.com
BUG=

Review URL: https://codereview.chromium.org//1323183002 .
 2015-09-02 16:18:52 +02:00
Rico Wind 01eff8ce18 Extract meta data about open sockets into separate class. 
The current implementation only has information about tcp and udp
sockets, and we explicitly do not track internal and pipe uses of
_NativeSockets.

The testing of this is done through the service layer, which is the end user of
this.

BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1323943003 .
 2015-09-02 15:26:35 +02:00
keertip fe5550e934 fix dartdoc.bat 
BUG=

Review URL: https://codereview.chromium.org//1318603006 .
 2015-09-01 10:42:22 -07:00
Paul Berry 3069c86af4 Document the fact that SendPort.send() dispatches messages immediately. 
R=lrn@google.com

Review URL: https://codereview.chromium.org//1320423004 .
 2015-08-31 14:13:18 -07:00
Alexandre Ardhuin 0784fc3134 use const constructors of Utf8* 2015-08-29 22:44:28 +02:00
John McCutchan 69092c741d Another dart2js fix 2015-08-27 11:52:43 -07:00
John McCutchan 23a30a8825 Really fix dart2js 
BUG=

Review URL: https://codereview.chromium.org//1315193008 .
 2015-08-27 11:46:47 -07:00
Natalie Weizenbaum 5778d87dd2 Forward stack traces through stream transformers. 
R=lrn@google.com

Review URL: https://codereview.chromium.org//1302363003 .
 2015-08-27 11:38:27 -07:00
John McCutchan e2d2eed004 Fix old dart2js patch reference in service extensions 
BUG=

Review URL: https://codereview.chromium.org//1311133010 .
 2015-08-27 11:36:59 -07:00
John McCutchan 7052bd6bed Rework service extensions to be safe 
- When scheduling a service extension to be invoked, store the closure in an array held in the isolate.
- At the tail of IsolateMessageHandler::HandleMessage, invoke all pending service extension closures.

R=iposva@google.com, turnidge@google.com

Review URL: https://codereview.chromium.org//1299493007 .
 2015-08-27 11:23:39 -07:00
William Hesse 13bf8ff9f8 Breaking Change: merge BoringSSL branch into master 
This replaces the NSS secure networking library from Mozilla
with the BoringSSL library from Google. This library, based
on OpenSSL, reads certificates from files in PEM format, rather
than storing certificates and keys in a SQLite database, the
way NSS does. There will be a blog post, changelog entries,
and other documentation of the breaking changes.

Review URL: https://codereview.chromium.org//1319703002 .
 2015-08-26 14:42:12 +02:00
Karl Klose 9a3b5614de dart2js: Inline Primitives.identicalImplementation into identical patch. 
This gets rid of one layer of indirection that was not necessary and implements the conditional completely in JavaScript which avoids the potential for recursion when generating the intermediate representation for boolean conversion.

R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1290433002 .
 2015-08-26 11:25:12 +02:00
Kevin Millikin e99fb4fc26 dart2js: Use the NoInline annotation on getInterceptor in the JS runtime. 
This also requires fixing NoInline to work for the JS runtime.
Previously it was ignored.

R=karlklose@google.com
BUG=

Review URL: https://codereview.chromium.org//1315083002 .
 2015-08-26 10:56:14 +02:00
Stan Manilov fe402c50ea sdk/dartanalyzer now detects an available build 
Similar to CL 1276333002; this allows the dartanalyzer script to pick an
available build, rather than failing if ReleaseIA32 is not available.

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//1314893003 .
 2015-08-25 20:48:14 +02:00
Harry Terkelsen bc0deb66d7 dart2js: fetch http Resources 
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1308143002 .
 2015-08-25 10:46:27 -07:00
keertip f07cec063c fix links in readme 
BUG=
R=sethladd@google.com

Review URL: https://codereview.chromium.org//1299873003 .
 2015-08-20 13:17:34 -07:00
Lasse R.H. Nielsen 1d537028f7 Mark resource as experimental 
Fixes issue 24150
BUG= http://dartbug.com/24150
R=sandholm@google.com

Review URL: https://codereview.chromium.org//1284393004 .
 2015-08-20 13:59:01 +02:00
Ryan Macnak 9278cc312b Really update return type of dart2js patch of dart:developer.log. 
Review URL: https://codereview.chromium.org//1296553003 .
 2015-08-19 14:00:40 -07:00
Ryan Macnak 360b40a599 Update return type of dart2js patch of dart:developer.log. 
Review URL: https://codereview.chromium.org//1302823002 .
 2015-08-19 13:42:53 -07:00
Seth Ladd 41e670f913 add void to dart:developer log 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1295803004 .
 2015-08-19 13:01:29 -07:00
keertip 3865dd8748 create dartdoc snapshot, add to dart-sdk. Also add resources needed to run dartdoc from the sdk. 
BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org//1295073003 .
 2015-08-19 08:02:41 -07:00
Lasse R.H. Nielsen f8f06d784a Implement new parameters on Isolate.spawn() for dart2js. 
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1294803003 .
 2015-08-19 13:52:36 +02:00
Asger Feldthaus ff74930f67 dart2js: Mark startRootIsolate as "used" by the backend. 
This fixes a type inference issue where the empty type was inferred for
the parameters to this method.

BUG=
R=herhut@google.com

Review URL: https://codereview.chromium.org//1298173002 .
 2015-08-18 15:55:55 +02:00
Lasse R.H. Nielsen 4b80cfd69e Remove the "not implemented yet" warning for new spawnUri parameters. 
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1293423002 .
 2015-08-18 11:04:38 +02:00
Lasse R.H. Nielsen 6c7093dd19 Fix typo in dart2js code. 
Review URL: https://codereview.chromium.org//1300803002 .
 2015-08-18 10:26:46 +02:00
Lasse R.H. Nielsen 5fa70c4220 Make Dart2js implement the onExit/onError/errorsAreFatal parameters to spawnUri. 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1286193006 .
 2015-08-18 09:56:42 +02:00
Florian Loitsch debf1d6f7c Don't zone-register async callbacks for every await call in the VM. 
This has the nice side-effect that the stack_trace package provides nicer chains.
Fixes issue 23394.

R=hausner@google.com

Committed: 4dae43d637
Reverted: cb4f9fc925

Review URL: https://codereview.chromium.org//1274133002 .
 2015-08-17 19:26:50 +02:00
Florian Loitsch cb4f9fc925 Revert "Don't zone-register async callbacks for every await call in the VM." 
This reverts commit 4dae43d637.

Review URL: https://codereview.chromium.org//1296973002 .
 2015-08-17 16:43:35 +02:00
Florian Loitsch 4dae43d637 Don't zone-register async callbacks for every await call in the VM. 
This has the nice side-effect that the stack_trace package provides nicer chains.
Fixes issue 23394.

R=hausner@google.com

Review URL: https://codereview.chromium.org//1274133002 .
 2015-08-17 15:58:19 +02:00
Florian Loitsch 672df7c087 dart2js: Don't zone-register callbacks in async functions for every await. 
R=johnniwinther@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//1281523003 .
 2015-08-17 15:57:34 +02:00
Florian Loitsch 7e64f3d962 Dart2js async-await. Bind the async-body to the current zone. 
Also ensure the wrapping of js-functions happens only once per
async-call.

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//1163833002 .
 2015-08-17 15:56:53 +02:00
Florian Loitsch 09ac73acd4 Add type to BroadcastSubscriptionWrapper. 
R=lrn@google.com

Review URL: https://codereview.chromium.org//1289203005 .
 2015-08-17 14:45:21 +02:00
Florian Loitsch 410b181e13 The return-value of 'asFuture' isn't necessarily related to the Stream's type. 
R=lrn@google.com

Review URL: https://codereview.chromium.org//1295843002 .
 2015-08-17 14:44:31 +02:00
Lasse R.H. Nielsen 1b8f3fba14 Make List constructor give better error messages for non-int arguments 
BUG= http://dartbug.com/15986
R=herhut@google.com, iposva@google.com, sra@google.com

Committed: 33c7663826

Review URL: https://codereview.chromium.org//1214723009 .
 2015-08-17 13:01:13 +02:00
Florian Loitsch b161b5ab9a Reenable types that were disabled because of a bug in dart2js. 
R=lrn@google.com

Review URL: https://codereview.chromium.org//1294713003 .
 2015-08-17 12:50:48 +02:00
Florian Loitsch 00aaf1708d Accept a computation that returns a Future for Future.delayed. 
R=lrn@google.com

Review URL: https://codereview.chromium.org//1296623004 .
 2015-08-17 11:34:43 +02:00
Alan Knight 89b99e60bf Remove dart2js-specific annotations from childNodes 
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1290263002 .
 2015-08-14 09:32:45 -07:00
Lasse R.H. Nielsen 51fa195f16 Revert "Make List constructor give better error messages for non-int arguments" 
There are VM-only tests that assume exact text of failure.

BUG=

Review URL: https://codereview.chromium.org//1294483003 .
 2015-08-14 15:05:17 +02:00
Lasse R.H. Nielsen 33c7663826 Make List constructor give better error messages for non-int arguments 
BUG= http://dartbug.com/15986
R=herhut@google.com, iposva@google.com, sra@google.com

Review URL: https://codereview.chromium.org//1214723009 .
 2015-08-14 13:44:19 +02:00
Sigmund Cherem e3fbf44643 dart2js: add function coverage tracking in dart2js output, dumpinfo, and 
coverage recording server

R=sra@google.com

Review URL: https://codereview.chromium.org//1288593002 .
 2015-08-13 16:47:58 -07:00
Florian Loitsch ad38b75bb2 Forward cancel subscription in stream pipes. 
R=lrn@google.com

Review URL: https://codereview.chromium.org//1284223005 .
 2015-08-13 12:57:35 +02:00
Stan Manilov ac8a228d0b sdk/dart now detects an available build 
The shell scripts in sdk/sdk are using ReleaseIA32 as the default build
configuration in the case one is not provided as an environment
variable. This is arbitrary so a check of the available builds is
performed and if ReleaseIA32 is available it is selected. Otherwise, an
arbitrary configuration is selected (currently the last one
lexicographically). In the case where there are no subfolders in the
"out" folder, ReleaseIA32 is selected, in order to produce the same
error that used to be produced before (this can be changed to a custom
message for user-friendliness).

Currently only the "dart" shell script is changed and if the change is
accepted, the others will be changed too.

R=floitsch@google.com, zerny@google.com

Review URL: https://codereview.chromium.org//1276333002 .
 2015-08-12 15:19:23 +02:00
Lasse R.H. Nielsen edff0face7 Make String.allMatches lazy. 
R=floitsch@google.com, iposva@google.com

Review URL: https://codereview.chromium.org//1273713003 .
 2015-08-12 11:01:21 +02:00
Seth Ladd b30a7a1750 change param name to match docs 
BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org//1287453002 .
 2015-08-11 10:55:16 -07:00
John McCutchan 590557dfd0 When no service response is requested, send null back to the service isolate so it can cleanup 
BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org//1285673003 .
 2015-08-11 07:13:09 -07:00
Asger Feldthaus 136ec727ee dart2js: Do not use JSDouble for native behavior return types. 
Previously, a JS('double', ...) expression would be seen as having
the exact JSDouble class as return type. This is problematic since that
class is reserved for non-integer doubles, and the result is generally
not known to be non-integer.

For example, the sqrt function returns 'double' but sqrt(0) == 0 which
is an integer.

BUG=
R=floitsch@google.com

Committed: b0905eadce

Review URL: https://codereview.chromium.org//1276353006.
 2015-08-11 15:14:50 +02:00
Florian Loitsch 0370922ca4 Improve documentation for Pattern.allMatches. 
R=lrn@google.com

Review URL: https://codereview.chromium.org//1272743004 .
 2015-08-11 13:26:07 +02:00
Lasse R.H. Nielsen e9f48a37e8 Add getters for callbacks on StreamController. 
R=floitsch@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//1278873008 .
 2015-08-11 10:55:48 +02:00
John McCutchan 5f02eb3c62 Move service extension handler execution to a timer 
R=iposva@google.com

Review URL: https://codereview.chromium.org//1282883003 .
 2015-08-10 14:56:43 -07:00
Seth Ladd d71110f31f Fix comment formatting 2015-08-10 08:50:37 -07:00
Lasse R.H. Nielsen 90643a7ef7 Make HttpClient not send fragments as part of request. 
Make HttpServer ignore fragments sent in requests (which are invalid HTTP request syntax).

Add `removeFragment` method to Uri.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1281973004 .
 2015-08-10 12:18:12 +02:00
John McCutchan 0f13b9c931 Allow Dart code to register service protocol handlers 
- Add 'registerExtension' to dart:developer
- A service protocol handler must implement ServiceExtensionHandler
- Service extensions can report result OR error code / message

R=turnidge@google.com

Review URL: https://codereview.chromium.org//1270103002 .
 2015-08-06 16:20:56 -07:00
Ryan Macnak b6c979f20b Hoist InstanceMirror.delegate to ObjectMirror. 
BUG=http://dartbug.com/14827
R=gbracha@google.com

Review URL: https://codereview.chromium.org//1273983002 .
 2015-08-05 17:09:59 -07:00
Lasse R.H. Nielsen 0a35f7be3b Update Changelog. 
Fix various typos and style nits.

BUG=23961
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1272593002 .
 2015-08-05 12:58:30 +02:00
Søren Gjesse 2ca0bc6d5a Echo the WebSocket close reason as well as the close code 
When receiving a close frame with a code and reason both the code
and the reason are now added to the close frame send as response.
Before only the code was added

BUG=https://github.com/dart-lang/sdk/issues/23964
R=kustermann@google.com

Review URL: https://codereview.chromium.org//1273663002 .
 2015-08-05 11:53:32 +02:00
Sigurd 58c18aaa9b Fix typos in doc-string. 
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//371523006 .
 2015-08-05 11:15:39 +02:00
Srdjan Mitrovic caa3cce77e Fix some TODOs 
BUG=
R=regis@google.com

Review URL: https://codereview.chromium.org//1263963003 .
 2015-08-04 17:13:22 -07:00
John McCutchan a2757141b0 Make dart:developer log more user friendly 
- Make required arguments required.
- Validate required arguments in Dart before calling native.
- timestamp is now a DateTime.
- level has a default (ALL).
- sequence number is last + 1 if not provided.

R=lrn@google.com

Review URL: https://codereview.chromium.org//1266053003 .
 2015-08-04 07:12:39 -07:00
John McCutchan 7640cf4b85 Fix test failure 
patch from issue 1271693003 at patchset 20001 (http://crrev.com/1271693003#ps20001)

Review URL: https://codereview.chromium.org//1270953003 .
 2015-08-04 07:05:34 -07:00
William Hesse bdda0eff52 Revert "Change msg to message in debugger function." 
This reverts commit 2ae214316c.

BUG=

Review URL: https://codereview.chromium.org//1261203005 .
 2015-08-04 15:22:47 +02:00
Lasse R.H. Nielsen 2ae214316c Change msg to message in debugger function. 
BUG=23949
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1271693003 .
 2015-08-04 14:58:13 +02:00
Florian Loitsch e9b91c7c92 Default values for static functions are now inside closures. (in the startup emitter). 
Since static closures are const values, they can reference each other in the default values:

foo([x = bar]) => null;
bar([x = foo]) => null;

Therefore, we must not reference the default values during tear-off installation (as was the case until now).

The corresponding test has been uploaded in https://chromiumcodereview.appspot.com/1255083008/

R=sigmund@google.com

Review URL: https://codereview.chromium.org//1266903004 .
 2015-08-04 13:56:28 +02:00
Florian Loitsch 0231f6ba39 dart2js: fix named arguments with Function.apply in the startup emitter. 
This includes a full rewrite of the Function.apply in the runtime.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//1252533003 .
 2015-08-03 18:06:31 +02:00
Florian Loitsch f6b142c5f4 dart2js: Support const symbols in the startup emitter. 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1253443003 .
 2015-08-03 17:56:34 +02:00
Florian Loitsch 8d6063d806 dart2js: support isolates in the startup-emitter. 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1249023002 .
 2015-08-03 17:48:43 +02:00
Florian Loitsch 62b49eadc6 dart2js: support tear-offs in the startup emitter. 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1229923005 .
 2015-08-03 17:02:31 +02:00
Lasse R.H. Nielsen ac33dfe194 Fix missing generic type parameters on streams. 
Add test.

BUG= 23859
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1250373007 .
 2015-08-03 14:21:17 +02:00
Florian Loitsch ffb72ee817 Make sure '_globalState' is set before calling computeThisScript. 
As first line of running `_globalState = new _Manager()` we invoked `_nativeDetectEnvironment()`. However, that one could ending up calling the getter `IsolateNatives.thisScript` which, in turn could need `_globalState`. Since the state wasn't set yet, this yielded a NPE.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//1264543004 .
 2015-08-03 10:37:41 +02:00
Johnni Winther 783ed933ff Fix boolean conversion bug in dart2js + update JSRegExp accordingly. 
BUG=
R=herhut@google.com

Review URL: https://codereview.chromium.org//1259473005.
 2015-07-27 14:19:26 +02:00
John McCutchan bfd2d4ed2a Refactor dart:developer log to use named parameters 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1247803002 .
 2015-07-21 10:01:37 -07:00
John McCutchan f818f9dc0f Support piping log data over the service protocol 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1241683005 .
 2015-07-21 07:54:46 -07:00
Florian Loitsch fb4633a1c5 dart2js: Use JS_GET_NAME instead of magic constant for catch-all function. 
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1245573002 .
 2015-07-20 14:53:59 +02:00
Alan Knight cd8c569632 Make sure NodeValidator uriAttributes aren't passed as attributes 
WIP

BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1236413002 .
 2015-07-17 14:12:44 -07:00
Alan Knight 8d0ceaad7b Another try at placating the type checking for FilteredElementList 
BUG=

Review URL: https://codereview.chromium.org//1230313008 .
 2015-07-17 12:41:17 -07:00
Alan Knight de3ce04f0a Fix type problem with FilteredElementList._iterable 
BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org//1236793006 .
 2015-07-17 10:53:19 -07:00
Lasse R.H. Nielsen 848f6c978c Do "path normalization" when creating a URI. 
Path normaliztion removes '.' and '..' segments from a URI. Such relative references are only intended for URI References, and Uri References are only intended for resolving against a full URI.

We do path normalization on all URIs that have a scheme, authority or an absolute path, and partial normalization on what are really just relative paths. The partial normalization can leave ".." at the start of the path.

The URI reference resolution algorithm doesn't work as expected for a URI ending in "..". Resolving "./foo" wrt. a base of "/a/.." results in  "/a/foo" - this is avoided when the base is path normalized before it's used.

This also fixes the "normalizePath" function which currently removes leading '..' segments, contrary to its documentation. It also makes the function redundant since all URI paths are normalized automatically.

See discussion on http://dartbug.com/23688

Also fix bug in the removeDotSegments function.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//1224263009.
 2015-07-17 17:08:36 +02:00
Terry L. Lucas 206ffe343b Revert "- Update _blink library using dart:js instead of native keyword" 
This reverts commit 8ecb64d6b0.

TBR=vsm@google.com

Review URL: https://codereview.chromium.org//1237263005 .
 2015-07-17 07:45:12 -07:00
Terry L. Lucas 8ecb64d6b0 - Update _blink library using dart:js instead of native keyword 
- Fixed dart:js event wrapping
- Fixed dart2js gen when --gen-interop used
- Cleanup and enabled static window() for JS interop
- Enabled --gen-interop
- Added --gen-interop switch

R=vsm@google.com,alanknight@google.com

Review URL: https://codereview.chromium.org//1234273003 .
 2015-07-17 07:37:18 -07:00
Lasse R.H. Nielsen 4a8a844c34 Add setters for callbacks on StreamController. 
This allows you to create a stream controller at one point and
add or change the callbacks later. This can be useful if you
want to store a stream controller in a final instance field and
also want the controller to call instance methods as callbacks.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//1242023007.
 2015-07-17 12:03:00 +02:00
Alan Knight d5599eb63b Restore workaround for old Chrome bug that also affects Safari and in some cases Firefox, fix test suppressions 
BUG=

Review URL: https://codereview.chromium.org//1242063002 .
 2015-07-16 13:20:26 -07:00
Alan Knight 4e790fef3d appendHtml, when sanitizing, should create document fragment in the right context 
BUG=
R=terry@google.com

Committed: 560f12bb21

Committed: 930a40daa5

Review URL: https://codereview.chromium.org//1221043003 .
 2015-07-16 10:30:51 -07:00
Lasse R.H. Nielsen e4881c55d0 Add errorsAreFatal, onExit and onError parameters to the spawn functions. 
R=floitsch@google.com

Review URL: https://codereview.chromium.org//1240743003.
 2015-07-16 16:52:43 +02:00
Florian Loitsch 547a0c4c04 dart2js: More documentation for embedded globals and shared property names. 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1236033006 .
 2015-07-16 14:57:30 +02:00
Natalie Weizenbaum bdd5803006 Fix a WebSocket crash. 
Previously, a WebSocket would crash if it was closed after its
StreamSubscription was canceled. Now, it tracks whether the subscription
was canceled by canceling and nulling out its own internal subscription.

Fixes #23845

R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//1234163002 .
 2015-07-15 13:30:06 -07:00
Lasse R.H. Nielsen 4ee6246556 Add split function to LineSplitter class in dart:convert. 
The split function returns a lazy iterable of the lines, unlike the convert
function which returns a list.
This makes the function usable on large strings where not all of the lines
are needed.

Closes https://github.com/dart-lang/sdk/issues/23837

R=kevmoo@google.com

Review URL: https://codereview.chromium.org//1240623002 .
 2015-07-15 12:26:24 +02:00
Cristian Almstrand 3b125d3bc9 Please refer to https://code.google.com/p/dart/issues/detail?id=23418 for the bug reportincluding a WebStorm project which demonstrates the problem. 
This proposal includes a fix to ensure that indices passed to the public functions defined in class FilteredElementList of the dart:html package consistently refer to element indices (not element indices sometimes, and node indices other times). Without this change, it is not possible to reliably insert elements relative to other elements. This can be problematic as the order of HTML elements must be guaranteed to ensure elements appear where expected in a normal page flow.

This proposal also address the TODO in file sdk/lib/html/html_common/filtered_element_list.dart to avoid excessively creating/allocating a filtered list of elements from nodes whenever calling [], every, any, length, etc. The implementation is less concise but should result in much reduced memory allocation and speed improvements.

R=alanknight@google.com

Review URL: https://codereview.chromium.org//1129333002 .

Patch from Cristian Almstrand <cristian.almstrand@gmail.com>.
 2015-07-14 14:50:42 -07:00
Terry L. Lucas cec5812335 Fixed Dictionary and Event hookup w/o --gen-interop 
TBR=vsm@google.com

Review URL: https://codereview.chromium.org//1233083004 .
 2015-07-14 14:18:48 -07:00
Terry L. Lucas 1fa61ee114 Fixed a few more things to make Dartium build w/o --gen-interop 
TBR=vsm@google.com

Review URL: https://codereview.chromium.org//1239653003 .
 2015-07-14 07:17:59 -07:00
Terry L. Lucas 82fbd3382a Remove blink_jsObject when --gen-interop is not used. 
TBR=vsm@google.com

Review URL: https://codereview.chromium.org//1236933003 .
 2015-07-14 05:49:27 -07:00
Alan Knight 610edadff2 Revert "appendHtml, when sanitizing, should create document fragment in the right context" 
This reverts commit 930a40daa5.

BUG=

Review URL: https://codereview.chromium.org//1230203005 .
 2015-07-13 15:32:17 -07:00
Terry L. Lucas 045d9698d3 Revert "Turn on JS interop usage for DOM Dart libraries" 
This reverts commit 7f6fc7eed2.
 2015-07-13 13:40:42 -07:00
Terry L. Lucas 7f6fc7eed2 Turn on JS interop usage for DOM Dart libraries 
Review URL: https://codereview.chromium.org//1235903003 .
 2015-07-13 13:38:45 -07:00
Terry L. Lucas 48af868f47 Fixed compilation error 
Review URL: https://codereview.chromium.org//1233923003 .
 2015-07-13 13:24:08 -07:00
Alan Knight 930a40daa5 appendHtml, when sanitizing, should create document fragment in the right context 
BUG=
R=terry@google.com

Committed: 560f12bb21

Review URL: https://codereview.chromium.org//1221043003 .
 2015-07-13 12:50:49 -07:00
Terry L. Lucas 4947e570d4 Changed to use JSInterop 
Review URL: https://codereview.chromium.org//1173403004 .
 2015-07-13 12:38:16 -07:00
Florian Loitsch ec398a7385 dart2js: Rename "current isolate" to "static state (holder)". 
R=herhut@google.com

Review URL: https://codereview.chromium.org//1232463007 .
 2015-07-10 19:08:11 +02:00
Seth Ladd d69cd1dcfd one-liners for typed data 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1231903007 .
 2015-07-09 16:47:41 -07:00
Seth Ladd 4bc681814b make one-line docs for math 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1231933007 .
 2015-07-09 16:28:22 -07:00
Seth Ladd 4c685b6e84 add docs for indexed_db 
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//1233513002 .
 2015-07-09 16:20:03 -07:00
Seth Ladd 41ed922e4f add one-liner docs to dart:developer 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1229173002 .
 2015-07-09 15:35:04 -07:00
Lasse R.H. Nielsen 8450179afe Update documentation of Uri.parse. 
It currently says that parse tries to escape invalid characters.
That's not true (at least not in most cases, though I think a few might
still work).
This just removes that part of the documentation.

BUG= http://dartbug.com/23688
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1213713006 .
 2015-07-09 12:24:26 +02:00
Alan Knight 1e8a275a20 Revert "appendHtml, when sanitizing, should create document fragment in the right context" 
This reverts commit 560f12bb21.

	modified:   sdk/lib/html/dart2js/html_dart2js.dart
	modified:   sdk/lib/html/dartium/html_dartium.dart
	modified:   tests/html/element_add_test.dart
	modified:   tools/dom/templates/html/impl/impl_Element.darttemplate

BUG=

Review URL: https://codereview.chromium.org//1230553003 .
 2015-07-08 12:19:30 -07:00
Alan Knight 560f12bb21 appendHtml, when sanitizing, should create document fragment in the right context 
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1221043003 .
 2015-07-08 10:16:37 -07:00
Devon Carew 9e8c08320d Merge pull request #23689 from dart-lang/devoncarew_sdk_readme 
fix links in the sdk readme doc
 2015-07-07 13:27:14 -07:00
Florian Loitsch 908865c47e dart2js: Rename emitters. 
The "old" and "new" name was not helpful.

R=herhut@google.com

Review URL: https://codereview.chromium.org//1220333003 .
 2015-07-07 14:47:33 +02:00
Stephan Herhut e21d8dbf93 dart2js: Implement serialization of Capability for isolates. 
R=karlklose@google.com, floitsch@google.com
BUG=

Review URL: https://codereview.chromium.org//1217763004.
 2015-07-07 10:27:30 +02:00
Lasse R.H. Nielsen 3c976019cc Make int.gcd accept zero as an operand, including both operands being zero. 
R=floitsch@google.com, regis@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//1211473002.
 2015-07-07 09:51:13 +02:00
Lasse R.H. Nielsen 03f92623b2 Revert usage of delegating generative constructor, still not supported by VM. 
Also update test expectation for d8/jsshell now that test doesn't use non-zero timer any more.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1221033008.
 2015-07-03 14:53:29 +02:00
Lasse R.H. Nielsen e0a61ceeb4 Fix comparison of StreamIterator with Iterable - should be Iterator. 
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1220233004.
 2015-07-03 13:30:37 +02:00
Lasse R.H. Nielsen f529055c1b Update documentation of StreamIterator, improve tests. 
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1216123004.
 2015-07-03 13:23:39 +02:00
Florian Loitsch 24fbfa7f78 Revert "Fix runtimeType.toString for tear-offs." 
This reverts commit 87a7ca0720.

Review URL: https://codereview.chromium.org//1220793012.
 2015-07-02 13:57:07 +02:00
Florian Loitsch 87a7ca0720 Fix runtimeType.toString for tear-offs. 
Tear-offs are constructed by building a fresh constructor on the fly. However, that constructor is unnamed and didn't have the 'builtin$cls' property set. As such, the runtime-type system was unable to extract a good name and wasn't able to provide a good 'toString' for it. With this CL the constructor has a good 'name' set.

Also removes the 'builtin$cls' property that was a duplicate of 'name'. Whenever we defined a new Dart class, we added a 'builtin$cls' property on the constructor which was a duplicate of the name. This was necessary, because IE doesn't store the function name on the constructor. However, there we can just assign the 'name' field, and don't need to introduce a new field-name ('builtin$cls'). As such, we can always use the 'name' property.

R=sra@google.com

Review URL: https://codereview.chromium.org//1213033002.
 2015-07-02 10:59:31 +02:00
Sigmund Cherem 4ec3db6947 keep old location of libraries.dart in the generated SDK (fixes 23755) 
R=kevmoo@google.com

Review URL: https://codereview.chromium.org//1216313002.
 2015-06-30 17:08:21 -07:00
Lasse R.H. Nielsen ede6cb71a5 Make modInv throw Exception on incompatible operands. 
Also update errors to be more descriptive accross the integer methods.

I'm still considering whether a more precise "NotCoPrimeException" would be better.

R=regis@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//1209523002.
 2015-06-30 14:46:14 +02:00
Jacob Richman ae72b6a701 Enhance dart:js interop in a backwards compatible manner. 
BUG=

Review URL: https://codereview.chromium.org//1213873004.
 2015-06-29 11:20:11 -07:00
Sigmund Cherem b18c5a3e7c sdk files reorganization to make dart2js a proper package 
BUG=
R=brianwilkerson@google.com, floitsch@google.com, whesse@google.com

Review URL: https://codereview.chromium.org//1212513002.
 2015-06-29 10:21:14 -07:00
Jacob Richman 7e9e4d89d3 Revert "Enhance dart:js interop in a backwards compatible manner." 
This reverts commit ac32e37ab1300cb1ce1cd081f050ff1d04e54cbe.

BUG=

Review URL: https://codereview.chromium.org//1209093005.
 2015-06-26 10:29:25 -07:00
Jacob Richman 3fdeb669ee Enhance dart:js interop in a backwards compatible manner. List objects can now be passed back and forth to Dartium without requiring jsify 
BUG=
R=terry@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//1194643002.
 2015-06-26 10:06:45 -07:00
Lasse R.H. Nielsen f8ce36df55 Add Resource class. Currently unimplemented. 
R=herhut@google.com, iposva@google.com

Committed: 2890a7a2a9

Review URL: https://codereview.chromium.org//1181663002.
 2015-06-26 11:42:02 +02:00
Stephan Herhut dd41983945 dart2js: Use an abstract Name class for names in the generated JavaScript ast. 
BUG=
R=asgerf@google.com, floitsch@google.com, sigurdm@google.com, sra@google.com

Review URL: https://codereview.chromium.org//1198293002.
 2015-06-25 09:39:57 +02:00
Harry Terkelsen a684edf08b Don't use ES6 map if browser has no Map 
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1199343006.
 2015-06-24 16:51:18 -07:00
Harry Terkelsen 46fdfd1c7d Use an ES6 map for a linked identity hash map. 
BUG=
R=floitsch@google.com

Committed: 008b41dc33

Review URL: https://codereview.chromium.org//1188713005.
 2015-06-24 15:16:47 -07:00
Stephen Adams 9425621eac JSInvocationMirror - return unmodifiable list or map 
R=floitsch@google.com

Committed: ec9ecdd3ff

Reverted.

Review URL: https://codereview.chromium.org//1200403003.
 2015-06-24 11:00:31 -07:00
Stephen Adams 52740cbcf4 Revert "JSInvocationMirror - return unmodifiable list or map" 
Will re-land with .status updates for tests that started working.

TBR=floitsch@google.com
BUG=

Review URL: https://codereview.chromium.org//1207723003.
 2015-06-24 08:19:00 -07:00
Stephen Adams ec9ecdd3ff JSInvocationMirror - return unmodifiable list or map 
R=floitsch@google.com

Review URL: https://codereview.chromium.org//1200403003.
 2015-06-24 07:45:55 -07:00
Lasse R.H. Nielsen 3300a005f2 Change documentation of modInverse to not specify error thrown. 
R=ricow@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//1204993002.
 2015-06-24 11:04:27 +02:00
Soren Gjesse 0415d9271d Improve the encoding/decoding to/from system encoding on Windows 
On Windows the dart:io SYSTEM_ENCODING is now also working with strings
which have null characters in them. Previously the string would be
terminated at the null character.

BUG=https://github.com/dart-lang/sdk/issues/23295
R=kustermann@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//1194883002.
 2015-06-24 10:36:05 +02:00
Stephen Adams afe5b32e48 Fix for issue 23432. 
Get the correct receiver in noSuchMethod stubs.

noSuchMethod stubs for selectors with Interceptor calling convention should pass the receiver to noSuchMethod (not 'this').  The actual receiver is selected by Object.noSuchMethod and Interceptor.noSuchMethod.

R=floitsch@google.com

Committed: c8d7cd8ef4

Reverted: 21a322fd99

Review URL: https://codereview.chromium.org//1181063005.
 2015-06-22 17:02:21 -07:00
Stephen Adams 21a322fd99 Revert "Fix for issue 23432." 
Reverted while investigating failed tests.

TBR=sigmund@google.com

Review URL: https://codereview.chromium.org//1203523003.
 2015-06-22 13:46:29 -07:00
Stephen Adams c8d7cd8ef4 Fix for issue 23432. 
Get the correct receiver in noSuchMethod stubs.

noSuchMethod stubs for selectors with Interceptor calling convention should pass the receiver to noSuchMethod (not 'this').  The actual receiver is selected by Object.noSuchMethod and Interceptor.noSuchMethod.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//1181063005.
 2015-06-22 13:16:05 -07:00
Alan Knight 1d5b657427 Make it easier and more efficient to use trusted HTML text 
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//1154423009.
 2015-06-22 09:41:01 -07:00
Lasse R.H. Nielsen 78a3db3128 Revert "Add Resource class. Currently unimplemented." 
This reverts commit 2890a7a2a9.

Causes a dart2js test error and a significant amount of analyzer
warnings.

Review URL: https://codereview.chromium.org//1193273003.
 2015-06-22 16:43:44 +02:00
Lasse R.H. Nielsen 2890a7a2a9 Add Resource class. Currently unimplemented. 
R=herhut@google.com, iposva@google.com

Review URL: https://codereview.chromium.org//1181663002.
 2015-06-22 15:05:14 +02:00
Devon Carew 5635fbfb4c fix links in the sdk readme doc 2015-06-21 08:57:17 -07:00