languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-18 21:41:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "appendHtml, when sanitizing, should create document fragment in the right context"

Browse source 
This reverts commit 560f12bb21.

	modified:   sdk/lib/html/dart2js/html_dart2js.dart
	modified:   sdk/lib/html/dartium/html_dartium.dart
	modified:   tests/html/element_add_test.dart
	modified:   tools/dom/templates/html/impl/impl_Element.darttemplate

BUG=

Review URL: https://codereview.chromium.org//1230553003 .
This commit is contained in:
Alan Knight 2015-07-08 12:19:30 -07:00
parent 12b1b4f6a4
commit 1e8a275a20
4 changed files with 3 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sdk/lib/html/dart2js/html_dart2js.dart
View file

@ -12898,7 +12898,7 @@ abstract class Element extends Node implements GlobalEventHandlers, ParentNode,
if (treeSanitizer is _TrustedHtmlTreeSanitizer) {
_insertAdjacentHtml(where, html);
} else {
_insertAdjacentNode(where, createFragment(html,
_insertAdjacentNode(where, new DocumentFragment.html(html,
validator: validator, treeSanitizer: treeSanitizer));
}
}

2
sdk/lib/html/dartium/html_dartium.dart
View file

@ -12426,7 +12426,7 @@ abstract class Element extends Node implements GlobalEventHandlers, ParentNode,
if (treeSanitizer is _TrustedHtmlTreeSanitizer) {
_insertAdjacentHtml(where, html);
} else {
_insertAdjacentNode(where, createFragment(html,
_insertAdjacentNode(where, new DocumentFragment.html(html,
validator: validator, treeSanitizer: treeSanitizer));
}
}

13
tests/html/element_add_test.dart
View file

@ -62,19 +62,6 @@ main() {
expect(fragment.children.length, equals(1));
expect(fragment.children[0], isSpanElement);
});
test('html interpreted in correct context', () {
var el = new TableElement();
el.appendHtml('<tr><td>foo</td></tr>');
expect(el.children.length, 1);
var section = el.children.first;
expect(section is TableSectionElement, isTrue);
var row = section.children.first;
expect(row is TableRowElement, isTrue);
var item = row.children.first;
expect(item is TableCellElement, isTrue);
expect(item.innerHtml, 'foo');
});
});
group('appendText', () {

2
tools/dom/templates/html/impl/impl_Element.darttemplate
View file

@ -1017,7 +1017,7 @@ $endif
if (treeSanitizer is _TrustedHtmlTreeSanitizer) {
_insertAdjacentHtml(where, html);
} else {
_insertAdjacentNode(where, createFragment(html,
_insertAdjacentNode(where, new DocumentFragment.html(html,
validator: validator, treeSanitizer: treeSanitizer));
}
}