John McCutchan
e7358d1e51
Fix clang build error
...
BUG=
Review URL: https://codereview.chromium.org/1531863003 .
2015-12-16 12:42:36 -08:00
John McCutchan
cc0f297703
Compress Observatory assets
...
- Gzip the Observatory assets tar file before encoding into the C++ source file.
Shrinks observatory_assets.cc from ~21MB to ~4MB.
Fixes #25276
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/1534523002 .
2015-12-16 12:35:58 -08:00
Brian Slesinsky
4fad247dc6
remove obsolete cache size parameter
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1530103002 .
2015-12-16 12:35:20 -08:00
Paul Berry
98e8b0a118
Fix resynthesis of operator[]= from summary.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1533563003 .
2015-12-16 11:29:54 -08:00
Paul Berry
5ef4929ae2
Replace uses of setModifier with ElementImpl setters.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1524303004 .
2015-12-16 11:28:24 -08:00
Konstantin Shcheglov
c19e958822
Don't produce [references] in GitHub-like code blocks in comments.
...
Mostly for the cases when we would like to demonstrate use or
lists or maps: `a[i] == b[i]`.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1527393002 .
2015-12-16 10:32:10 -08:00
Ryan Macnak
a0e0ac78cb
Observatory: Include profiler samples in the timeline view.
...
- Add pre-isolate service RPC that emits profiler samples in about:tracing format.
- Make timeline UI automatically merge the event timeline with the sample timelines.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/1525913002 .
2015-12-16 10:11:44 -08:00
Brian Wilkerson
fa73d7e552
Restore auto-processing of plugins
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1523343004 .
2015-12-16 09:19:16 -08:00
Dan Rubel
f13460e235
rename InheritedContributor to OverrideContributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1523163004 .
2015-12-16 12:15:34 -05:00
Dan Rubel
4cd376143f
move functional argument check into manager
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1531473006 .
2015-12-16 12:11:36 -05:00
Konstantin Shcheglov
ea922ef7f4
Fix for recording static elements of a prefixed comment reference.
...
I notied during reading idl.dart that I'd like to see highlighting and
search for type names in comment references like [PrelinkedLibrary.dependencies].
With this change we get highlighting, search and refactoring for both.
Navigation also works (*).
(*) does not work in IntelliJ - it does not parse Dart comments for reference expressions.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1531613002 .
2015-12-16 09:03:25 -08:00
Paul Berry
ea7e6b29ed
Introduce code to resynthesize element models from summaries.
...
A lot of work remains to do (see TODO comments), but the basic
infrastructure is now in place.
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1526243002 .
2015-12-16 08:39:56 -08:00
Brian Wilkerson
66e07636f4
Moved the tests for the element model into locations corresponding to the implementation
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1529923003 .
2015-12-16 07:49:15 -08:00
John McCutchan
7003c9686a
Fix --print-metrics
...
Fixes #25037
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/1531553002 .
2015-12-16 07:31:29 -08:00
John McCutchan
9f7440cde5
Bump observatory pub packages DEPS
...
Fixes #25262
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/1524333003 .
2015-12-16 07:30:25 -08:00
Florian Schneider
61f190eebe
Temporary workaround to make VM bots greener.
...
The reason are data races at isolate creation/shutdown. Further investigation
to fix the root cause needed.
TBR=johnmccutchan@google.com ,
BUG=
Review URL: https://codereview.chromium.org/1531763002 .
2015-12-16 15:30:29 +01:00
Johnni Winther
5d53b30151
Handle malformed elements in onElementResolved.
...
R=sigurdm@google.com
Review URL: https://codereview.chromium.org/1525423002 .
2015-12-16 15:04:25 +01:00
William Hesse
58ea2fbce6
Remove third_party/pkg/petitparser and third_party/pkg/intl
...
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//1332963002 .
2015-12-16 14:48:19 +01:00
Lasse R.H. Nielsen
ba675bddf2
Update documentation on Stream.map
...
Fixes issue #25273
BUG= http://dartbug.com/25273
R=floitsch@google.com
Review URL: https://codereview.chromium.org/1528363002 .
2015-12-16 14:46:35 +01:00
William Hesse
d6fe4122ec
Remove third_party/font-awesome and its use in site/try.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org/1528893002 .
2015-12-16 14:43:23 +01:00
William Hesse
a74f54faf0
Remove fake_async from third_party/pkg.
...
BUG=
R=nweiz@google.com
Review URL: https://codereview.chromium.org//1330363002 .
2015-12-16 14:16:33 +01:00
Asger Feldthaus
488ffd8aac
dart2js cps: Use oneshot interceptors and 'instanceof' expressions.
...
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org/1525163002 .
2015-12-16 14:13:51 +01:00
Florian Schneider
4a037f0ccb
VM: Use read-only handle Object::dynamic_type() where possible.
...
BUG=
R=asiva@google.com
Review URL: https://codereview.chromium.org/1528873002 .
2015-12-16 11:31:53 +01:00
Srdjan Mitrovic
3a46cc28b7
Polymorphic calls in precompilation invoke megamorphic calls when tests fail (instead of deoptimizing). Move the megamorphic call into a slow path stub. Cleanups.
...
Allow truning off speculative inlining if --max_speculative_inlining_attempts <=0
BUG=
R=fschneider@google.com
Review URL: https://codereview.chromium.org/1513883002 .
2015-12-15 12:34:55 -08:00
Paul Berry
b22d7d532f
Merge the prefix and references tables.
...
This makes the UnlinkedLibrary type go away, which means that we no
longer have any unlinked summary data which is spread across the
compilation units constituting a library. That in turn means that we
should be able to safely re-link summaries even in the (pathological)
case where a change to URI resolution affects the relationship between a
library and its parts.
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1528113002 .
2015-12-15 12:33:25 -08:00
Stephen Adams
f264e5291c
analyzer declaration_resolver_test is slow on dart2js
...
It is hovering around 55s, so times out too often.
TBR=sigmund@google.com
Review URL: https://codereview.chromium.org/1528133002 .
2015-12-15 12:27:10 -08:00
Konstantin Shcheglov
70cd905c4d
Issue 25253. Improve collecting names that may conflict with the extracted local variable.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25253
Review URL: https://codereview.chromium.org/1528013004 .
2015-12-15 12:26:11 -08:00
Paul Berry
ceecfe862b
Reserve element 0 in the references table for dynamic
.
...
In addition to simplifying some serialization/deserialization code, this
paves the way for merging the references table with the prefixes table
by allowing the zeroth entry in both tables to act as a sentinel value.
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1528083002 .
2015-12-15 11:25:11 -08:00
John McCutchan
fb33d9deff
Fix get_vm_timeline_rpc_test
...
BUG=
Review URL: https://codereview.chromium.org/1530703002 .
2015-12-15 11:17:45 -08:00
Paul Berry
518ae623d6
Move summary references into UnlinkedUnit and PrelinkedUnit.
...
This is a follow up to commit
f85684604b
, which reorganized the
declarations by compilation unit to pave the way for allowing
summaries to be "re-linked" if the relationship between part files
changes. Organizing references by compilation unit is another
necessary step to make that possible.
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1523093003 .
2015-12-15 10:55:45 -08:00
Ivan Posva
f5f035407f
- Temporarily allow running with dart_bootstrap during the
...
Observatory build.
BUG=
Review URL: https://codereview.chromium.org/1526133002 .
2015-12-15 10:51:55 -08:00
Stephen Adams
c5e9ab890f
Constant-fold fields of constant objects.
...
SSA catch-up item.
R=asgerf@google.com
Review URL: https://codereview.chromium.org/1528673002 .
2015-12-15 10:44:02 -08:00
Stephen Adams
620257ffc0
cps_ir: Add JS checks, use argument nullability
...
- Add JS checks for wrong number or captured placeholders.
- Add list of nullability bits to allow generation of non-null placeholder expressions in place.
R=asgerf@google.com
Review URL: https://codereview.chromium.org/1526623004 .
2015-12-15 10:38:39 -08:00
John McCutchan
2ff1c28978
Emit Timeline events for most Dart_API calls
...
- Remove --trace-api and related macros.
- Emit Timeline events on the API stream for Dart_API calls.
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/1526463005 .
2015-12-15 10:27:22 -08:00
Florian Schneider
fbdce6a59e
VM: Const-correctness fixes.
...
Three types of fixes:
1. Remove redundant const_cast
2. Remove const_cast by adding const when appropiate.
3. Remove const_cast by removing const (e.g. places where we call free with it)
For now I only fixed places where the fix is local enough - i.e. does not require
changed a large amount of code.
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/1526123002 .
2015-12-15 19:24:40 +01:00
Todd Turnidge
3a28a1297e
Fix line number reporting for unresolved breakpoints.
...
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/1524263002 .
2015-12-15 10:08:30 -08:00
danrubel
62f8832770
cleanup LocalLibraryContributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1527613008 .
2015-12-15 13:03:41 -05:00
Konstantin Shcheglov
f71ae984a9
Issue 25252. Stop collecting covering expressions at void invocations.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25252
Review URL: https://codereview.chromium.org/1528023002 .
2015-12-15 09:55:48 -08:00
Konstantin Shcheglov
db1bf5fecf
Couple comment tweaks for summaries IDL.
...
R=paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org/1521963003 .
2015-12-15 09:52:45 -08:00
John McCutchan
27d05fc98a
Add more compiler timeline durations
...
All phases of unoptimized and optimized compilation are now on the timeline.
R=fschneider@google.com , rmacnak@google.com
Review URL: https://codereview.chromium.org/1523833003 .
2015-12-15 09:51:47 -08:00
Asger Feldthaus
c6e2af11db
dart2js cps: Replace GetLazyStatic with GetStatic.
...
Also fixes a bug in GVN that made it unable to GVN GetLazyStatic.
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org/1521553003 .
2015-12-15 11:45:59 +01:00
Johnni Winther
c5235fde7f
Add token invariant to DiagnosticReporter
...
Closes #3675
R=sigmund@google.com
Review URL: https://codereview.chromium.org/1520293002 .
2015-12-15 11:35:55 +01:00
Johnni Winther
212ba4afbe
Support optional package name arguments to --show-package-warnings
...
In response to dartbug.com/18661 and dartbug.com/21651.
Dart2js doesn't know pubspec.yaml or the directory structure but pub does. Next step is to pass arguments from pub.
BUG=
R=sigmund@google.com
Review URL: https://codereview.chromium.org/1513263002 .
2015-12-15 10:52:19 +01:00
Johnni Winther
6bb8cd8943
Introduce benign errors.
...
Closes #25204
R=sigmund@google.com
Review URL: https://codereview.chromium.org/1525593002 .
2015-12-15 10:17:00 +01:00
Brian Wilkerson
56fe38f0ab
Clean up imports in analysis_server and analyzer_cli (and one missed in analyzer)
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1527793003 .
2015-12-14 19:31:46 -08:00
danrubel
6464160147
move LocalDeclarationVisitor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1529653003 .
2015-12-14 20:36:57 -05:00
danrubel
5ff1ebe935
extract LocalLibraryContributor from imported reference contributor
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1525753003 .
2015-12-14 20:31:50 -05:00
Siva Annamalai
956d02f22d
Make no_handle_scope_depth_ an int32_t field as that is what the accessor returns and there is check to ensure it;s value is < INT_MAX.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/1530543002 .
2015-12-14 17:28:03 -08:00
Paul Berry
f85684604b
Organize summary declarations by unit rather than by library.
...
In the initial implementation of summaries, all declarations for a
given library were thrown together into a single bucket, regardless of
the compilation unit in which they appeared. This was done on the
grounds that semantically, the compilation unit in which a declaration
appears is irrelevant.
However, it turns out that this conflicts with one of the design goals
of summaries, which is to allow summaries to be quickly "re-linked"
when URI resolution changes. Since "part" declarations use URIs to
refer to part files, this means that URI resolution may affect the
relationship among compilation units within a library; thus, the
declarations for each compilation unit need to be in their own data
structure.
A side benefit of this reorganization is to make the structure of the
summary more similar to the structure of the element model; this
should in turn make it simpler (and possibly more performant) to
convert between element models and summaries.
This CL reorganizes the declarations themselves; future CLs will
reorganize the dependency and resolution information to match.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1530503002 .
2015-12-14 16:30:15 -08:00
danrubel
8a99902b94
suppress all dart contributor suggestions in comments
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1522003003 .
2015-12-14 18:50:18 -05:00