Commit graph

140 commits

Author SHA1 Message Date
Paul Berry e2f77056a5 Eliminate dependencies on pkg/front_end.
The API for pkg/front_end is still in flux so we want to avoid having
any packages depend directly on it (other than analyzer and
back-ends).

This CL re-exports some of the critical pieces of front_end needed by
analyzer clients so that those clients can access them via analyzer,
without having to directly depend on front_end.  It also updates
pkg/analyzer_plugin to make use of those re-exports.

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2993123002 .
2017-08-07 09:46:30 -07:00
Brian Wilkerson 4e1644f12a Add more documentation for plugins
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2992843002 .
2017-08-02 07:45:45 -07:00
Brian Wilkerson adb482002b Prevent exception with isolate failed to start
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2986123002 .
2017-07-28 08:26:31 -07:00
Brian Wilkerson 9a6b134d33 Improve name generation for indexed expressions
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2990793002 .
2017-07-27 07:58:34 -07:00
Brian Wilkerson cc7b83f4da Mark refactoring support for plugins as experimental
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2990573003 .
2017-07-26 07:43:55 -07:00
Brian Wilkerson 8bbf373a5e Remove the analysus.reanalyze request from the plugin API
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2988743002 .
2017-07-25 12:10:52 -07:00
Brian Wilkerson 1e0e351406 Fix a typo in the docs
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2988683002 .
2017-07-24 09:54:23 -07:00
Brian Wilkerson 8a275e6df8 Add utility method to SubscriptionManager
R=mfairhurst@google.com

Review-Url: https://codereview.chromium.org/2983913002 .
2017-07-21 07:24:55 -07:00
Konstantin Shcheglov 00d5012906 Format analyzer, analysis_server, analyzer_plugin, front_end and kernel with the latest dartfmt.
...instead of mixing formatting with actual changes in many CLs.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/2975253002 .
2017-07-13 16:28:18 -07:00
Brian Wilkerson 0c775ae412 Guard against an AST node with no end token (issue 30089)
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2974533002 .
2017-07-06 12:51:23 -07:00
Konstantin Shcheglov 19265a82b4 Move findElementsByName() into shared analyzer/element_search.dart file.
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2965133003 .
2017-07-06 11:51:17 -07:00
Brian Wilkerson 0484f28335 Initial documentation for the plugin package
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2973753003 .
2017-07-06 11:37:52 -07:00
Konstantin Shcheglov 6323bedc58 Stop depending on LabelElement(s) to be reported in visitChildren().
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2973093002 .
2017-07-06 11:28:06 -07:00
danrubel 8cca317118 fix completion test expectation for fasta scanner
Review-Url: https://codereview.chromium.org/2972063002 .
2017-07-06 14:07:49 -04:00
Brian Wilkerson 75504c2b25 Remove references to AnalysisDriver from the plugin mixin classes
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2970203002 .
2017-07-06 09:07:10 -07:00
Brian Wilkerson 6a7b9f441b Convert DartChangeBuilder to use AnalysisSession
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2969833002 .
2017-07-03 08:41:40 -07:00
Brian Wilkerson aadafd1bd5 Use DartEditBuilder to write types and remove dead code
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2972463003 .
2017-07-01 12:03:44 -07:00
Brian Wilkerson 6f4420562c Clean up some code in plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2967683002 .
2017-06-30 10:39:20 -07:00
Brian Wilkerson 6248df44a6 Add the tests of the spec generator to the unit tests
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2966623003 .
2017-06-30 10:08:51 -07:00
Brian Wilkerson 4749014b06 Remove an unused request and the associated type
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2964113003 .
2017-06-30 09:44:59 -07:00
Brian Wilkerson 99cc563718 Update the spec to deprecate fileStamp
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2964653002 .
2017-06-30 08:21:47 -07:00
Brian Wilkerson 47244b4215 Stop creating unnecessary Source
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2969543003 .
2017-06-30 08:20:51 -07:00
Brian Wilkerson d1bb233f52 Remove timeStamp from the ChangeBuilder API
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2962223002 .
2017-06-29 13:48:46 -07:00
Brian Wilkerson 84dd01904d Missed change to conform to other APIs
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2965453002 .
2017-06-29 06:15:38 -07:00
Brian Wilkerson 7bd9e6c443 Add a mixin for assists similar to that for fixes
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2956353002 .
2017-06-28 11:44:22 -07:00
Brian Wilkerson 6248e7cab2 Add support code to make fixes easier in plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2962903002 .
2017-06-28 10:52:06 -07:00
Brian Wilkerson 9ddb832e10 Generate constants in server as we do in plugin
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2960073002 .
2017-06-28 08:21:33 -07:00
Brian Wilkerson 0ea6b89770 Fix a lint
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2955113002 .
2017-06-27 08:36:59 -07:00
Konstantin Shcheglov 9775892109 Attempt to fix DartEditBuilderImplTest on Windows.
TBR

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2958803003 .
2017-06-26 14:39:41 -07:00
Konstantin Shcheglov a2f18fdb73 Fixes and tests for adding library imports.
R=brianwilkerson@google.com, pquitslund@google.com
BUG= https://github.com/flutter/flutter-intellij/issues/1119

Review-Url: https://codereview.chromium.org/2955913002 .
2017-06-26 13:16:19 -07:00
Brian Wilkerson 4a10003924 Update the plugin API
R=maxkim@google.com, mfairhurst@google.com

Review-Url: https://codereview.chromium.org/2953093002 .
2017-06-23 12:31:00 -07:00
Brian Wilkerson 8cd2a4924d Disable a not-yet-defined lint
R=pquitslund@google.com

Review-Url: https://codereview.chromium.org/2955583002 .
2017-06-23 09:37:34 -07:00
Brian Wilkerson e28064f405 Restore partial analysis of analysis options files
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2946313003 .
2017-06-22 08:00:50 -07:00
Brian Wilkerson 24996fbfe7 Add support to pass the location of the analysis options file to plugins
R=mfairhurst@google.com

Review-Url: https://codereview.chromium.org/2947743002 .
2017-06-20 07:41:03 -07:00
Brian Wilkerson 5976c78a79 Handle unresolved constructor (issue 29925)
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2944083002 .
2017-06-20 06:16:23 -07:00
Brian Wilkerson eafc070479 Remove ReplacementRange
R=danrubel@google.com, maxkim@google.com

Review-Url: https://codereview.chromium.org/2946573003 .
2017-06-19 10:15:36 -07:00
Max Kim 382ddb21c3 Refactor: Removed ReplacementRange from test and ReplacementRange from src/. Copied contents of test into lib/utilities and modified test path.
This is needed to expose ReplacementRange outside of test folder for external plugin users to utilize. Reason discussed further in ticket: https://codereview.chromium.org/2934133002/

BUG=
R=brianwilkerson@google.com, danrubel@google.com

Review-Url: https://codereview.chromium.org/2937093002 .
2017-06-16 11:19:27 -07:00
Max Kim e57d9b608f Change to accommade Angular plugin and finalize removal of dependency to analysis_server
BUG=
R=brianwilkerson@google.com, mfairhurst@google.com

Review-Url: https://codereview.chromium.org/2934133002 .
2017-06-13 16:31:39 -07:00
Brian Wilkerson 1e9ae646ff Clean up some hints
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2939723002 .
2017-06-13 09:24:50 -07:00
Brian Wilkerson d824acbf71 Update AssistProcessor to use ChangeBuilder
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2928313002 .
2017-06-12 07:28:02 -07:00
Brian Wilkerson b928683560 Add a couple of lints to the options files
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2933713002 .
2017-06-11 09:12:48 -07:00
pq b502bb6956 Prioritize required name param completions (flutter-intellij#1049).
R=danrubel@google.com

Fixes: https://github.com/flutter/flutter-intellij/issues/1049
Review-Url: https://codereview.chromium.org/2927343002 .
2017-06-09 10:20:16 -07:00
Brian Wilkerson 0e6586492d Make common tests consistent
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2925273003 .
2017-06-09 08:40:16 -07:00
Brian Wilkerson 624f4d8b3d Add tests for recently added mixins and improve plugin tests
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2932553004 .
2017-06-09 07:27:16 -07:00
Brian Wilkerson 38e2bf5897 Remove invalid imports of analysis_server
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2927923003 .
2017-06-08 10:41:25 -07:00
Brian Wilkerson 6d8b7c8806 Finish refactoring FixProcessor to use ChangeBuilder
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2930793002 .
2017-06-08 07:56:08 -07:00
Brian Wilkerson 91b8b495b3 Add support for fixes
R=maxkim@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2923283002 .
2017-06-08 07:53:06 -07:00
Brian Wilkerson b9529da60e More test fixed (TBR)
Review-Url: https://codereview.chromium.org/2925163002 .
2017-06-07 14:04:29 -07:00
Brian Wilkerson 0d315af354 Try again to fix the bots (TBR)
Review-Url: https://codereview.chromium.org/2926173002 .
2017-06-07 13:15:40 -07:00
Brian Wilkerson 9b0a98fd42 Port a missed piece to remove invalid reference to analysis_server
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2930723002 .
2017-06-07 10:06:33 -07:00