Add a couple of lints to the options files

R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2933713002 .

pkg/analysis_server/analysis_options.yaml

@@ -2,5 +2,7 @@ analyzer:
   strong-mode: true
 linter:
   rules:
-    - unnecessary_brace_in_string_interp
     - empty_constructor_bodies
+    - empty_statements
+    - unnecessary_brace_in_string_interp
+    - valid_regexps

pkg/analysis_server/test/services/dependencies/library_dependencies_test.dart

@@ -49,6 +49,6 @@ class LibraryDependenciesTest extends AbstractContextTest {
   }
 
   void _performAnalysis() {
-    while (context.performAnalysisTask().hasMoreWork);
+    while (context.performAnalysisTask().hasMoreWork) {}
   }
 }

pkg/analysis_server/tool/instrumentation/page/stats_page.dart

@@ -258,7 +258,6 @@ class StatsPage extends PageWriter {
           sink.write(method);
           sink.writeln('</td></tr>');
         }
-        ;
         sink.writeln('</table>');
       });
     }

pkg/analyzer/analysis_options.yaml

@@ -2,7 +2,7 @@ analyzer:
   strong-mode: true
 linter:
   rules:
-    # TODO(pq): re-enable once we have a bulk edit tool
-    # - annotate_overrides
     - empty_constructor_bodies
+    - empty_statements
     - unnecessary_brace_in_string_interp
+    - valid_regexps

pkg/analyzer/test/src/task/strong/strong_test_helper.dart

@@ -44,7 +44,7 @@ SourceSpanWithContext _createSpanHelper(
   int lineEnd = endLoc.offset;
   int lineNum = lineInfo.getLocation(lineEnd).lineNumber;
   while (lineEnd < content.length &&
-      lineInfo.getLocation(++lineEnd).lineNumber == lineNum);
+      lineInfo.getLocation(++lineEnd).lineNumber == lineNum) {}
 
   if (end == null) {
     end = lineEnd;

pkg/analyzer_cli/analysis_options.yaml

@@ -2,3 +2,9 @@ analyzer:
   strong-mode: true
   exclude:
     - 'test/data'
+linter:
+  rules:
+    - empty_constructor_bodies
+    - empty_statements
+    - unnecessary_brace_in_string_interp
+    - valid_regexps

pkg/analyzer_plugin/analysis_options.yaml

@@ -4,4 +4,8 @@ linter:
   rules:
     - annotate_overrides
     - empty_constructor_bodies
+    - empty_statements
+    - prefer_single_quotes
+    - unawaited_futures
     - unnecessary_brace_in_string_interp
+    - valid_regexps