Commit graph

13629 commits

Author SHA1 Message Date
Vyacheslav Egorov
eb8c24e133 Reland "Merge more Kernel infrastructure from kernel_sdk SDK fork."
R=zra@google.com
BUG=

Review URL: https://codereview.chromium.org/2451623006 .
2016-10-27 10:09:22 +02:00
Vyacheslav Egorov
12968edb9c Revert "Reland "Merge more Kernel infrastructure from kernel_sdk SDK fork.""
This reverts commit 4e7a31262e.

Windows bots are broken now.

R=zra@google.com
BUG=

Review URL: https://codereview.chromium.org/2451893004 .
2016-10-26 17:07:18 +02:00
Vyacheslav Egorov
4e7a31262e Reland "Merge more Kernel infrastructure from kernel_sdk SDK fork."
This relands commit 2fed1c3905 with fixes to ensure that analyzer summaries are correctly created and XARM build does not try to use target binaries on the host.

R=zra@google.com
BUG=

Review URL: https://codereview.chromium.org/2453773002 .
2016-10-26 16:48:28 +02:00
Lasse R.H. Nielsen
22a57bbe2c Adapt analyzer to new warnings around switch-case fallthrough.
Fixes issue #27664.
BUG= http://dartbug.com/27664
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2446093003 .

Committed: 1322877f5b
Committed: 1f7d8924c6
Committed: 9c2306c7dc
2016-10-26 14:03:14 +02:00
Vyacheslav Egorov
cf7ff42e60 Revert "Merge more Kernel infrastructure from kernel_sdk SDK fork."
This reverts commit 2fed1c3905.

SDK builds are failing

TBR=zra@google.com

Review URL: https://codereview.chromium.org/2455593002 .
2016-10-26 13:06:27 +02:00
Vyacheslav Egorov
2fed1c3905 Merge more Kernel infrastructure from kernel_sdk SDK fork.
- bring patched SDK generation scripts and VM patch tweaks that allow VM patch files to be parsed by analyzer front-end;
  Patched SDK is an SDK with all VM patches spliced into it. Kernel compiler is based on the analyzer front-end which does
  not have any patch files support/model so for it to produce Kernel files that match VM we need to generate a such patched SDKs.

- bring test script modifications that allow to test Kernel pipeline

BUG=
R=asiva@google.com, kmillikin@google.com, whesse@google.com, zra@google.com

Review URL: https://codereview.chromium.org/2434123003 .
2016-10-26 13:02:54 +02:00
Lasse R.H. Nielsen
9c2306c7dc Adapt analyzer to new warnings around switch-case fallthrough.
Fixes issue #27664.
BUG= http://dartbug.com/27664
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2446093003 .

Committed: 1322877f5b
Committed: 1f7d8924c6
2016-10-26 12:56:54 +02:00
Lasse R.H. Nielsen
1322877f5b Adapt analyzer to new warnings around switch-case fallthrough.
Fixes issue #27664.
BUG= http://dartbug.com/27664
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2446093003 .
2016-10-26 10:51:50 +02:00
Lasse R.H. Nielsen
1d4657f3d4 Add test for warning-conditions around switch cases.
Only tested on analyzer.

R=eernst@google.com

Review URL: https://codereview.chromium.org/2446923003 .
2016-10-26 09:02:58 +02:00
Regis Crelier
3342380ff8 Avoid parsing formal type parameters a second time from inside an async body,
as default values may not be resolved correctly and may conflict with already
parsed formal parameters (fixes #27659).
Added regression test.

R=hausner@google.com

Review URL: https://codereview.chromium.org/2452623002 .
2016-10-25 08:11:37 -07:00
Florian Loitsch
6bc6ea34b5 Use different bug-number for skipped test.
BUG=

Review URL: https://codereview.chromium.org/2442203003 .
2016-10-24 10:56:24 +02:00
Florian Schneider
ba04d1d627 Skip flaky isolate test temporarily.
This test still fails on some architectures (simmips, windows)

TBR=floitsch@google.com,

BUG=

Review URL: https://codereview.chromium.org/2435603008 .
2016-10-21 14:01:17 -07:00
Ryan Macnak
1627c70035 Fix http_server_response_test.dart not to use snapshots as its data.
Fixes #27633

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2441073002 .
2016-10-21 13:56:52 -07:00
Florian Schneider
a74262c0e9 Enable now-passing tests for Android precompilation
Remove other obsolete entries.

Fixes #26373.
Fixes #27378.

R=rmacnak@google.com, whesse@google.com

Review URL: https://codereview.chromium.org/2431163007 .
2016-10-21 12:16:47 -07:00
Ryan Macnak
d274e8adf8 Skip http_server_response_test on AOT and app snapshots.
Issue #27633

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2432923005 .
2016-10-20 13:55:55 -07:00
Florian Schneider
c3fb2b5d89 Fix two io tests for precompilation, update status
BUG=#26376
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2441743002 .
2016-10-20 13:14:12 -07:00
Florian Loitsch
6beb1fdd11 Change Set.difference API to accept Set<Object>.
Fixes #27573
BUG= http://dartbug.com/27573
R=lrn@google.com

Review URL: https://codereview.chromium.org/2413233002 .
2016-10-20 14:37:15 +02:00
Siva Annamalai
af4d246ef1 Cleanup options for use of application snapshots
- unified kAppAfterRun and kAppJITAfterRun to kAppJIT
 - adjusted the test configuration to make dart2app and dart2appjit to mean
   the same
 - delete GenerateFullSnapshot function as it is not used anymore

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2429023002 .
2016-10-19 17:42:01 -07:00
Florian Schneider
b85f900cb7 test.dart: Push all required files to Android device when running AOT tests
Some tests have resources in sub-directories (e.g. certificates/)

Remove status file lines for tests that are now passing.

Fixes #26376,#26377.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2434123002 .
2016-10-19 16:50:23 -07:00
Matthias Hausner
f73ea62c99 Add check for constness in constructor redirection
Const constructor can only redirect to another const constructor.

BUG=#27617
R=regis@google.com

Review URL: https://codereview.chromium.org/2439593003 .
2016-10-19 15:15:02 -07:00
William Hesse
cdfe272b37 Update status for chrome on macos co19 tests.
BUG=

Review URL: https://codereview.chromium.org/2434773002 .
2016-10-19 14:27:27 +02:00
Sigmund Cherem
3cdcaeda96 Fix browser test status.
This is to match the state of the bots, it appears that chrome was recently upgraded.

BUG=

Review URL: https://chromiumcodereview-hr.appspot.com/2426093002 .

Committed: 940e498e17
2016-10-18 12:50:58 -07:00
Sigmund Cherem
2200ee77f7 Revert "Fix browser test status."
This reverts commit 940e498e17.
2016-10-18 12:48:15 -07:00
Sigmund Cherem
940e498e17 Fix browser test status.
This is to match the state of the bots, it appears that chrome was recently upgraded.

BUG=

Review URL: https://chromiumcodereview-hr.appspot.com/2426093002 .
2016-10-18 12:38:45 -07:00
Johnni Winther
b262be749e Optimize needNoSuchMethodHandling computation
This greatly improves the number of lookups needed to establish the relation.
For the two most prolific tests we have:

html/element_test: 44939 -> 6557
html/mirrors_js_typed_interop_test (mirrors+jsinterop!): 1638455 -> 171326

R=sigmund@google.com

Committed: a8b2bfb5eb

Review URL: https://codereview.chromium.org/2428543002 .

Reverted: 5397c5427e
2016-10-18 16:06:03 +02:00
Johnni Winther
37afcd5197 Change TypeInference to handle super calls as direct invocations.
This also makes calls of known target registered as static uses and thus
removes the need for misusing type masks to select super methods.

Closes #25716

R=sigmund@google.com

Committed: 70159b7418

Review URL: https://codereview.chromium.org/2423953002 .

Reverted: 5397c5427e
2016-10-18 14:02:55 +02:00
Erik Ernst
b5d2b38aa3 Relaxes treatment of method type parameter in as expressions.
This CL changes the semantics of `dart2js --generic-method-syntax`
generated code for `e as T` where `T` is a method type parameter.

The old behavior was to raise a `TypeError` at runtime when such an
expression was evaluated. The new behavior is to consider `T` as an
alias for `dynamic`, i.e., `e as T` will then always succeed.

Addresses part of issue 27460, omits a part that is not yet agreed upon.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/2388843002 .
2016-10-18 11:11:44 +02:00
Johnni Winther
5397c5427e Revert "Change TypeInference to handle super calls as direct invocations." and "Optimize needNoSuchMethodHandling computation"
This reverts commit 70159b7418.
This reverts commit a8b2bfb5eb.

Review URL: https://codereview.chromium.org/2425933002 .
2016-10-18 11:00:42 +02:00
Johnni Winther
a8b2bfb5eb Optimize needNoSuchMethodHandling computation
This greatly improves the number of lookups needed to establish the relation.
For the two most prolific tests we have:

html/element_test: 44939 -> 6557
html/mirrors_js_typed_interop_test (mirrors+jsinterop!): 1638455 -> 171326

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2428543002 .
2016-10-18 10:52:12 +02:00
Johnni Winther
70159b7418 Change TypeInference to handle super calls as direct invocations.
This also makes calls of known target registered as static uses and thus
removes the need for misusing type masks to select super methods.

Closes #25716

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2423953002 .
2016-10-18 09:46:28 +02:00
Johnni Winther
74b74a13f7 Decouple TypeMask from ClassElement
- by typing FlatTypeMask.base with Entity
- moving needsNoSuchMethodHandling to ClosedWorld
- and testing needsNoSuchMethodHandling

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2420073002 .
2016-10-17 09:47:20 +02:00
Sigmund Cherem
997581ccec Fix custom elements in startup emitter
R=sra@google.com

Review URL: https://codereview.chromium.org/2424553002 .
2016-10-14 16:58:47 -07:00
Ryan Macnak
fe04737a77 Add test directive to include other files used by a test in its compiled output directory.
Fixes #27591

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2423593002 .
2016-10-14 16:11:25 -07:00
Sigmund Cherem
ee42a0a0aa Add js-interop support to the fast-startup emitter
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2420173002 .
2016-10-14 14:22:11 -07:00
Ryan Macnak
0d99435f0c Mark tests failing with app snapshots that expect a resource relative to script.
Issue #27591

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2418193002 .
2016-10-14 11:10:19 -07:00
Florian Loitsch
136e476c87 Check for the type of the the spawned function.
In general we avoid explicit type-checks, but in this case the error would be only detected in the new isolate making error handling much harder.

Fixes #27185
BUG= http://dartbug.com/27185.
R=lrn@google.com

Review URL: https://codereview.chromium.org/2414173003 .
2016-10-14 13:27:11 +02:00
Lasse R.H. Nielsen
523da59d56 Add reference to invalid typedef so dart2js will detect it.
R=floitsch@google.com

Review URL: https://codereview.chromium.org/2417223002 .
2016-10-14 12:56:40 +02:00
Lasse R.H. Nielsen
efb9a12811 Add = as default-value separator for named parameters.
Fixes issue #27559.

BUG= http://dartbug.com/27559
R=asiva@google.com, eernst@google.com, floitsch@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org/2411633002 .
2016-10-14 11:25:25 +02:00
Florian Schneider
1ebde18da6 Fix and dedup entries in language.status.
Correct mistakes from my previous CL and simplifications.

TBR=rmacnak@google.com,
BUG=

Review URL: https://codereview.chromium.org/2412323004 .
2016-10-13 14:49:27 -07:00
Florian Schneider
701b91eb31 VM: Save one bool when serializing library prefixes.
When loading a snapshot all library prefixes should be considered not
loaded. This makes code running from a JIT snapshot throw the correct
error when using a deferred prefix before it is loaded.

Also, update test status and avoid skipping tests.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2416963003 .
2016-10-13 13:36:19 -07:00
Siva Annamalai
d8276c4ef9 Skip env_test for dartium as it uses command line options which are not supported for dartium.
R=terry@google.com

Review URL: https://codereview.chromium.org/2413093003 .
2016-10-13 12:40:40 -07:00
Florian Schneider
6d66f3dea8 VM: Make optimized try-catch work in DBC.
The catch entry block has all locals in fixed locations
(Rj) where j = kNumberOfRegisters - i for parameter i.

This means we reserve a range of DBC registers at the top-end of the frame.
Those registers are blocked for general allocation to avoid any overlap
with the rest of the registers that are allocated from the bottom.

Each optimized frame with a try-catch will be kNumberOfRegisters wide.

BUG=
R=vegorov@google.com

Review URL: https://codereview.chromium.org/2388093003 .
2016-10-13 11:36:23 -07:00
Florian Schneider
d9b1bc93af Fix product mode noSuchMethod with library prefix.
Update analyzer status of test that has a static warning expected.

BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/2413033003 .
2016-10-12 19:10:27 -07:00
Siva Annamalai
aae051e4c3 Fix for issue 27567 (inconsistent handling of invalid -D options
BUG=#27567
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2409263004 .
2016-10-12 18:42:30 -07:00
Florian Schneider
d99229026e Fix issues with argument evaluation order and noSuchMethod errors.
Fix tests to conform to spec bahavior.

Update dart2js test status.

BUG=#27572
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2416513003 .
2016-10-12 17:04:55 -07:00
Nicholas Shahan
2a51e46153 Copy new JS Interop test from dev_compiler test suite.
The test was added in the issue #2394103002.

R=vsm@google.com

Review URL: https://codereview.chromium.org/2402163002 .
2016-10-12 10:15:34 -07:00
John McCutchan
7fd9df4d91 Improvements to NoSuchMethodError.toString
This makes the following improvements:

* Always show the call that was made, with arguments.
* ...and show the actual arguments in more cases.
* Be less confusing in the case of a call on the null receiver.
* Be less redundant in the output.
* Report when a constructor is called with the wrong number of arguments.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2405353002 .
2016-10-12 09:52:51 -07:00
Florian Schneider
e25461c151 VM Propagate receiver type from calls to unique selectors in AOT compilation.
If there is no override of noSuchMethod in any class, we can
propagate the receiver type downwards from calls that call a unique
selector.

This speeds up dart2js by around 3%, a particle simulation benchmark by around 10%.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2412653002 .
2016-10-11 13:17:47 -07:00
William Hesse
980e2097e8 Update status of LibTest/isolate/Isolate/spawn_A04_t04
BUG=https://github.com/dart-lang/sdk/issues/27558
R=floitsch@google.com

Review URL: https://codereview.chromium.org/2402393002 .
2016-10-11 00:34:27 +02:00
William Hesse
25e3b30560 Update status for failing tests
BUG=https://github.com/dart-lang/sdk/issues/27557
R=floitsch@google.com

Review URL: https://codereview.chromium.org/2405843002 .
2016-10-10 16:26:55 +02:00